- 13 Aug, 2020 18 commits
-
-
Chris Lu authored
This new method will be used to determine if the user is likely using Chrome as the default Browser for metrics logging and when to present default browser promotional UI. Bug: 1107489 Change-Id: I642a7de704f84c7564aea08d90a512cf08a1078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348207Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#797499}
-
Xianzhu Wang authored
This is to evaluate the performance improvement of the optimization in 1 or 2 canary builds. Will revert after that. This disables the optimization for composited scrolling added in crrev.com/771292 (based on the LCD-text on opaque optimization added in crrev.com/768555). Bug: 1113269 Change-Id: I20250169241d8f6d99e9bd917974aaf3fd0f675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351400 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797498}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/61ca10cb63d0..7369107c7819 2020-08-12 tsepez@chromium.org Rename XFA_ThemeGetOuterWidget() to GetOutmostFFWidget(). 2020-08-12 tsepez@chromium.org Remove CFWL_WidgetMgr::SetParent(). 2020-08-12 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetTime() API 2020-08-12 zhouhan@google.com Add an experimental API to surface a page's additional action. 2020-08-11 tsepez@chromium.org Allow setting v8 flags from pdfium_test command line. 2020-08-11 tsepez@chromium.org Catch more exceptions from reentrant V8 conversions. 2020-08-11 tsepez@chromium.org Base CFWL_WidgetMgr::Item on TreeNode<> 2020-08-11 tsepez@chromium.org Remove CFWL_WidgetProperties::m_pParent. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112206 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3d31eb899643970f9d512bed9d76ad6b456d3ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797497}
-
rbpotter authored
Add warnings in chrome://settings/printing and chrome://settings/cloudPrinters for Google Cloud Print deprecation. Redirect "Manage cloud devices" link to the cloud print printers page, instead of chrome://devices, which is being removed. Bug: 1114189 Change-Id: I3d4dcdcad1d85afa07082cf1b2d3713f3b50d801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347320 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797496}
-
Ted Meyer authored
This still defaults to staying disabled, and further work to enable the vaapi video decoder will come in later CLs. gLinux machines will have new enough hardware to play h264 and vp8 using hardware acceleration. Bug: 1066176 Change-Id: Ie917d64e987507d160009eb7df0121c73bfeb716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208531Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797495}
-
Jonathan Freed authored
Change-Id: If4d19d6ba2367f7770c4e77c8f885767171bebe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350148 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797494}
-
Avi Drissman authored
This reverts e35a8ac4 and provides the capability of putting [New] tags into Cocoa context menus. Bug: 1114257 Change-Id: I411335701f61af47a515e498f7f09c5467fd60e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344944 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#797493}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ee70c3aabba0..c4f3b713800f 2020-08-12 sugoi@google.com Fix copying cubemap textures out of bounds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1115345 Tbr: swiftshader-team+autoroll@google.com Change-Id: Id2a219619671d4a3c084b304ed68cb34f15de89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797492}
-
Tommy Li authored
This CL adds an enabled-by-default flag that causes on-focus gestures to trigger ZeroSuggest on the Contextual Web page classification (OTHER). We add this flag so we can disable it in some experiments, where we want to use on-clobber instead. It also adds a test to make sure this flag doesn't affect other page classifications such as the NTP. Bug: 1106096 Change-Id: I32d4b9fc396874f836c60ae347ac3894818cf1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350309 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#797491}
-
Harry Cutts authored
This has been enabled by default for a while now, we haven't had any complaints, and the flag's expired, so we can remove it. Bug: 888172 Test: the wheel very slowly to check high-res scrolling remains on Change-Id: I5a8d345271562b76eafbaa8f82acc3870e3a96d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353021Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#797490}
-
Xing Liu authored
This CL adds a few more test cases for download later dialog. Also fixed a minor bug that the button text is certain scenario should be "Next" instead of "Download". Bug: 1115241 Change-Id: I957b7e1efc726b133c746e75f4c148511be43dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350192Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797489}
-
Peter Kasting authored
Also makes one or two functions const. Bug: none Change-Id: I9a67f5f5839aef92468342c0dfcba36da864d4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348195 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#797488}
-
Sophie Chang authored
Bug: 1115698 Change-Id: I03e7514d22c7a4f8592793de1e69202b0356565a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352038Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797487}
-
Nate Fischer authored
No change to logic. This moves GpuSwitches to a "gpu/config" subfolder, to match the Java package name. I overlooked this in the last patchset of https://crrev.com/c/2343776. Bug: 1112006 Test: autoninja -C out/Default system_webview_apk Change-Id: If970753ab1f984ca7377bc6b097877a7b5cf0889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351121 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797486}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fac64cf60aa2..dbee93ac203d 2020-08-12 fmayer@google.com Merge changes If131e346,I204c0777 2020-08-12 lalitm@google.com Merge "tp: fix SelectRows when working with trunacted bitvectors" 2020-08-12 treehugger-gerrit@google.com Merge "Rename StackProfileTracker -> SequenceStackProfileTracker." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id41a0c9f1a6e9be5ff8f55941306c9e727b1cacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353469 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797485}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5697d3550bc8..dfa133b7b48c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9606b3950fe3ab596bece0737337b80a7c0a8846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797484}
-
Kai Ninomiya authored
Bug: 1115412 Change-Id: I65d01c7fad045e11ef45180e882079ef398fe59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353368Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797483}
-
Michael Thiessen authored
EditUrlSuggestionUnitTest was leaking native clipboard state that was causing other clipboard tests to fail. Test grouping on M vs R revealed this dependency locally, but not on the bots. Change-Id: I98bed04aae3fa69dc82bb7a74856c37d75b6106a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353389Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#797482}
-
- 12 Aug, 2020 22 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c95b589112f3..652124c372e5 2020-08-12 bsalomon@google.com sk_gpu_test::MakeTextureProxyFromData -> MakeTextureProxyViewFromData 2020-08-12 johnstiles@google.com Add `GrProcessor::onDumpInfo` for subclass info dumps. 2020-08-12 johnstiles@google.com Reland "Guard dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." 2020-08-12 brianosman@google.com Unit tests for runtime effect SkSL errors found later in compilation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ia182b56ff61c3eb0852134c7207253979662835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797481}
-
Nick Diego Yamane authored
R=sky@chromium.org Bug: None Change-Id: Ie3ce9e126def94576b078c27063048917948b299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353111 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797480}
-
Peter Boström authored
This is more readable to me (after using it twice) and you don't need to remember how to spell ui::DIALOG_BUTTON_CANCEL. It also removes Set{Accept,Cancel}Callback by making these callbacks part of Add{Ok,Cancel}Button(). Bug: 1106422 Change-Id: I208b80c041616ac506e4b77913a7bb6150c200dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351370 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797479}
-
Joe DeBlasio authored
This CL updates the illustrations for the lookalike safety tip on Desktop. It now looks like this: https://drive.google.com/file/d/1IPugu1WucRKymM3lCGvCW0SU83joNFxu/view Fixed: 1111358 Change-Id: I90dcba0bb6cecc1d9fb08de0cce1377e5972a69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353060 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#797478}
-
Vasiliy Telezhnikov authored
Both with SurfaceTexture and AImageReader we get only one FrameAvailable callback before we call UpdateTexImage. This causes the problem when we released buffer to codec in early rendering, but dropped the frame later. In this case we did not called UpdateTexImage for that frame and will not received OnFrameAvailable for next one causing WaitForFrameAvailable to timeout. This CL adds UpdateTexImage call after WaitForFrameAvailable in RenderToTextureOwnerBackBuffer in case we're already waiting for frame. Bug: 1113203 Change-Id: I32e703d07df94f7170795077773a30b4578c1a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339495 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#797477}
-
Yusuf Sengul authored
Adds the logic that handshakes with the service control manager and runs the process as a service. Bug: 1101590 Change-Id: Id0825d3ea5bbfccb17147740eda26bff04367037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329045Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#797476}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..fac64cf60aa2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45e6b6bccc3c0082bbbc16aa19c827d9d1ac5091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797475}
-
Carlos IL authored
IDNs triggered a DCHECK when elision experiments were enables, due to a search in GetSimplifiedDomainBounds trying to search for the punycode version of the URL in a string containing the unicode version. This fix is a pre-requirement for fixing elision for RTL URLs. Bug: 1114286, 1101472 Change-Id: I433bc4cac2e31b6056e154025f0c5b8c5c0726a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350022Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#797474}
-
Dan Harrington authored
Bug: 1044139 Change-Id: If241abe46b91d8fa63706d0262a8c7c3f1b56a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353027 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797473}
-
Rachel Carpenter authored
This means on the first 3 launcher opens, the suggestion chip for whats new will be seen. It previously only showed up once. Bug: b/161755085 Change-Id: Ie9b475a57b1571873b98b1e80f329831eee71b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351344Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797472}
-
Yuly Novikov authored
Bug: 1115721 Change-Id: I2293535744d9f7894865bd32b9ed9fb4a84a33f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353551Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797471}
-
zhaoyangli authored
Since some beta version of Xcode 12, XCTest result can report XCTest runner app crash as a failed test in log. In this CL, log parser reports this failure as "BUILD_INTERRUPTED" which fits into the existing logic to handle test process crash in test runner scripts. Bug: 1115232 Change-Id: Icebdb5456005b2473e5ed8af683487ac532cda3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350442Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797470}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5276639d2789..cc958e0e8703 2020-08-12 jmadill@chromium.org Remove D3D9 configs from perf tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ia3e7842e94c866c1c6f299ac32a1cbc7dcd3fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797469}
-
Nektarios Paisios authored
Every AXObject in Blink has not only a pointer to each one of its children, but also a pointer to its parent. Under some circomstances the pointer to the object's parent was not set. One case of this was when inline text boxes were forcefully loaded by calling the AXObject::LoadInlineTextBoxes method. Another case was when continuations were involved. The former was done for testing. Unit tests were added for both of the above situations which ensure that a large number of the public tree walking methods on AXObject work correctly. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I375a10552d8cd91f8d54a9d35e75b0c9f8278059 Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344468 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797468}
-
Jun Kokatsu authored
This change modifies tests in a way that test won't be blocked by Trusted Types mitigation on WebUI. Also disabled Trusted Types mitigations in some WebUI pages due to usage of Polymer. Bug: 41905 Change-Id: I85c60066672e896032599d674b7bac35e38ccb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341800 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797467}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5192b234de64..409802afddc8 2020-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I27c03bf22b9ba5add61b61bba25bfbe2182fa1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797466}
-
Anne Lim authored
Change-Id: Ida6f0d6babda680d3618e9ba226eda154020126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352624Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#797465}
-
Robert Ogden authored
This fails because the ScopedFeature list was being destroyed before the test was fully done. Bug: 1078965 Change-Id: I57d4c01bc4bcc10a8377e4abac5f5b65f9ea9859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351168Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#797464}
-
My Nguyen authored
Adding the first bit of the input page according to design at http://go/cros-lang-settings-ux slide 23. Current view: http://screen/K4xO3C4FXaz Bug: 1113439 Change-Id: Ic2c5e3d1e095e5080bc2409a1c3aafe89a147fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345933 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797463}
-
Garrett Beaty authored
Change-Id: I5587dff4225c4341ed80fa107cedf71b10f73e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353331 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#797462}
-
Claude van der Merwe authored
removeWebUIListener expects a WebUIListener argument, but strings were being passed. This CL 1. Adds variables to keep track of created WebUIListener types so they can be removed with removeWebUIListener in cups_printers_entry_manager.js 2. Uses addWebUIListener from WebUIListenerBehavior for automatic WebUIListener removal in cups_printers.js Change-Id: I86da8dda6bf03e3ce83c38a3e63825ff4335f1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350335 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797461}
-
Claude van der Merwe authored
Bug: 1045266 Change-Id: I0217bf03b82683b1f4d0a08e0342f8c9b2de43eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340408 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797460}
-