- 08 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9eaf5ce5d81..7e3252b4439a 2020-09-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domDebuggerManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.isolateManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domModelUndoStack If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b15f2d77180d4f5e3d8cee30eac275e4bcda2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804942}
-
Miriam Zimmerman authored
BUG=chromium:1125007 TEST=CQ Fixed: chromium:1125007 Change-Id: Ie0317463f0e0b4b5bb602a64229f5ce3486df459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398960 Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#804941}
-
Bruce Dawson authored
tools\win\setenv.bat is a mostly unknown but sometimes useful batch file that adds the VS tools to the path. It respects the value of DEPOT_TOOLS_WIN_TOOLCHAIN and the current toolchain hash. This change updates it to add support for VS 2019, and remove support for VS 2015. It also takes away support for selecting 32-bit versus 64-bit target toolchains because this feature was never used and was too much work to support (since the packaged toolchain and vcvarsall.bat flags are different). This change also fixes a bug where the name of the batch file would be retained in the command-prompt title after this script exits. Using the "call" command fixes that. The retained title is ultimately a Windows command prompt bug which is not going to get fixed. Adding the call command then requires quoting the command path in the Python script. Change-Id: I2b4943dc1e391d9fb4a9e76dd8b592223dc31fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392013 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#804940}
-
Sreeja Kamishetty authored
After enabling H264 which run WPT,the failing blink web_tests should be working with BackForwardCache enabled. Bug: 1103214 Change-Id: I5059bf682f0aa441fd9d5a8237e90057213796d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395236Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#804939}
-
Hiroki Nakagawa authored
This is a follow-up CL for the previous review comment: https://chromium-review.googlesource.com/c/chromium/src/+/2389380/comment/65b648df_f6299bcf/ Bug: 1112515 Change-Id: Ia7ba8b79cb0b60567616773c8240c4c5b446e8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397992Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#804938}
-
Laís Minchillo authored
Remove logging of Android.WebView.onReceivedSslError.ErrorCode and mark the enum and histogram as obsolete. Fixed: 1066115 Test: None Change-Id: Ia060aa6c07fad809085c15b037762278d380a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398718 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804937}
-
Mohamed Adel authored
This flag will be used to determine which notification API to run on macOS devices during the introduction of the new API. Bug: None Change-Id: Iddadbec08cea46d99a46cf425466420cdc38347d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396076Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#804936}
-
Matt Jones authored
This is a reland of 3c8430ae This patch adds a check for the currently running animation. Animations on Android M seem to continue for a few updates after cancellation. Original change's description: > Batch BottomSheetControllerTests > > This patch batches all the tests in BottomSheetControllerTest. > Consequently, some new methods to reset the sheet's state were added > to the test support classes and BlankCTATabInitialState was updated to > support any subclass of ChromeActivity. > > Bug: 1122163 > Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803156} Bug: 1122163 Change-Id: I2b562243eb50b7990fa82bd9d353c8d1f16589cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387433Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804935}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I6b8b702b1e4e335786b365ce4ca00c29195ae191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375285 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#804934}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I397656c55fe211615ae3d1d4cbc167cc2c1feee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396616Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804933}
-
Owen Min authored
Based on the flake-portal, the test SavePageBrowserTest.SaveHTMLOnlyTabDestroy is also flaky on Windows and Linux's release bot. Disable the test on those platforms. Bug: 580766 TBR: qinmin@chromium.org Change-Id: I813fb92b70358da9acee5a88007bb399a3d5e1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397240 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804932}
-
Owen Min authored
The test BackForwardCacheBrowserTest.NavigateBackForwardRepeatedly is flaky on Mac, Linux and ChromeOS. Disable the test on those platforms. Bug: 1099395 TBR: altimin@chromium.org Change-Id: Ib4adf13ffe75fce14b42e9b93b7a2383d60b8a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398899 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804931}
-
Yngve N. Pettersen authored
chrome_public_apk_or_module_tmpl template instantiation for an Android target Additionally, add default values for lint_suppressions_file and lint_baseline_file inside the chrome_public_common_apk_or_module_tmpl template definition when linting is enabled. Change-Id: I2feb9c0b26c133588495c523284b4ef7e9df5120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391077 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804930}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iee4d506b6b2bc47ec552759e29b282e8af663c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804929}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor| to produce |NGInlineItem| with |ShapeResult| having same start and end offset for valid text painting. Before this patch, we see wrong painting, e.g. "AxXX" instead of "AxVX" when insert "x" before "X" of "AVX". This is cause by kerning between "A" and "V". Bug: 1121885, 1124805 Change-Id: If51bd6ed688e909911b55324515cb1ac23d2cb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397989 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd54c8385c31..2b3b35f8381b 2020-09-08 brianosman@google.com Handle function reference expressions in the inliner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ib233327cfda1a531156d2b6ddf2ef502535d21a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804927}
-
manukh authored
- Images in the omnibox dropdown are decoded in isolated processes created when needed. Especially on windows, this contributes significant delay in displaying them. - Images are cached making the delay most noticeable when first displaying particular entities. - Image fetching and decoding begins as soon as the search response is parsed, before AC completes. Therefore, the time to fetch & decode images is longer than the delay between showing suggestions and showing their images. - Both answer (e.g. weather) and entity suggestions have images. - Decoders are shut down after 5s of idling. This CL reduces this delay by sharing a single decoder among all omnibox suggestion images. Additionally, the shared decoder is woken on user input to reduce the startup delay if they've been unused for at least 5s. Before, with isolated decoders, a sample timeline could look like the below, resulting in a 270 ms (450-180) image latency. AC start search response AC done image fetched image decoded 0 ms 160 180 190 450 With this CL, With a shared decoder, a sample timeline could look like the below, resulting in a 30 ms (210-180) image latency. AC start search response AC done image fetched image decoded 0 ms 160 180 190 210 In addition, this CL adds 4 histograms - BitmapFetcher.Fetch: to help breakdown sources of image latency - BitmapFetcher.Decode: to help breakdown sources of image latency - Omnibox.BitmapFetch: to measure the latency experienced by the user (delay between suggestions displaying and their images displaying) - Omnibox.SuggestRequest.Success.PrefetchImagesCount: to measure the number of images included per search response. Additionally, the existing histogram Omnibox.SuggestRequest.Success.GoogleResponseTime is relevant. Change-Id: Ia8ed2ead9fda6b3893715c3757165d3ebe0ae1f3 Bug: 1115108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348328 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#804926}
-
Robbie Gibson authored
The test is causing the builders to fail. Bug: 1124655 Change-Id: Id808248e6b63c69da8d10a9fe351a8573cf7d588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398681 Commit-Queue: Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804925}
-
Alex Gaynor authored
Previous commits have been at my Mozilla address, but I've also been involved in Chromium in my personal capacity. Change-Id: I1ef97b84bbf947b7e5e957249c8cc01e8410a41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394675Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804924}
-
Richard Knoll authored
We've deprecated an enum value which might still be set in some profiles. This will make sure we're ignoring these invalid enum values instead of hitting a DCHECK further down in sync code. Bug: 1114108 Change-Id: I3fa0800052a0c7d84cdb30ceb3a1486bc7468264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395616Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804923}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c107c7e93630..6b0afc48ae3d 2020-09-08 hjd@google.com Merge "ui: Allow open in catapult from permalinks" 2020-09-08 hjd@google.com Merge "Use const references where possible" 2020-09-08 treehugger-gerrit@google.com Merge "Deobfuscation support for the ui / pprof layers" 2020-09-08 treehugger-gerrit@google.com Merge "Remove unmapped_java_symbols" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia98873ba29363a103ec1acd271d07e6a73d894fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398798Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804922}
-
Alice Wang authored
This CL removes all ChromeActivity usage in AccountPickerDelegate. Bug: 1125068 Change-Id: Ib2afc7f5d8ab1ebe8138e96aff41cdd1c1c8dea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398129Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804921}
-
Peter Boström authored
This removes ButtonListener from BubbleDialogModelHost and adds Button::PressedCallback versions of MdTextButton and LabelButton constructors to support it. Bug: 772945, 1106422 Change-Id: I5a6fc50a714e6ac6701af588d5a428ea291bd008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398321 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804920}
-
Ella Ge authored
When switch on/off dark theme, WebApk splash screen is shown again since browser is initialized again and SplashController#onPreInflationStartup is called. The splash screen is not hidden because the web page is not reloaded. This CL makes the splash screen also hide when the Tab's re-attached to window (intractability state to True), and is not loading. It only hides when TabCreationMode is RESTORED so the real splash screen on webapk launch won't be affected. Bug: 1111880 Change-Id: I4df9490d3dccc375db03ef9b639e8fee74d952e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391387 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804919}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. This is reland of original commit. There are two changes to fix revert resones: 1. Size of ShapeResult is increased => reduce bit size of |num_glyphs_|[1] 2. Newly added member is not initialized in copy constructor[2] [1] http://crrev.com/c/2390615 [2] http://crrev.com/c/2392577 Bug: 1124446, 1124740 Change-Id: Ifef96781528b03944be752303b1ce1edca5ff92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397105 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804918}
-
Julian Pastarmov authored
The current logic simply returned UNKNOWN for all cases that were not a dm disk or we had trouble learning what is the uuid of that disk. With this change anything that is not a dm disk will return that encryption is disabled. It also now checks the result of the stat command and returns UNKNOWN if it fails as this prevents us from doing the further interrogation. BUG=1125634 TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo Change-Id: I83e3b825f1033e14c3819d5adbe35fc0ee1be1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396377 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804917}
-
Kushagra Sinha authored
|GoogleServiceAuthError::State::USER_NOT_SIGNED_UP| is now thrown iff |OAuth2AccessTokenManager::Delegate::HasRefreshToken| is |false|. Update the documentation for |GoogleServiceAuthError::State::USER_NOT_SIGNED_UP| to reflect this. Change-Id: I5f5f4ea9d6706254092074f0ec48b9c4fdde6c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386798Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#804916}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7e4614b548c..e9eaf5ce5d81 2020-09-08 tvanderlippe@chromium.org [globals] self.UI.dockController 2020-09-08 alexrudenko@chromium.org Move inspector_overlay to the top level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320,chromium:1100925 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80d0b9d3d0da2dacf031ca6c0760fe157fe852a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804915}
-
Maksim Sisov authored
This is a reland of 7138b785 WaylandPopup didn't allow empty bounds. Fixed by https://crrev.com/c/2397695 Original change's description: > ozone/wayland: Fix drop down menus for touch events. > > In case of touch events, we may not find currently focused windows > as menu windows might be created on touch up events. Thus, > GetCurrentFocusedWindow returns nullptr. > > To fix that, use a concept of a currently active window. That is, > Wayland sets a window to "active" state if it has had a focus. > There can be only one focused window at a time. > > Thus, if there is no a focused window, use currently active window > as a parent. That's the best effort one could make to find a parent > window for a newly created non-toplevel window. At some point, > it might be worth reconsidering the design and make aura always pass > parent widgets for new windows if applicable. > > Bug: 1123521 > Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#804674} Bug: 1123521 Change-Id: I62c6b254bc2e931bc93ac4609290518138aa19b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397715 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#804914}
-
Maksim Sisov authored
After https://crrev.com/c/2385279 landed, the factory stopped creating WaylandToplevelWindow instead of WaylandPopup for requests that asked for kPopup windows (which is correct). However, some tests may pass bounds with the size parameter set to 0, 0. That resulted in closing of WaylandPopups and tests crashed. Thus, to fix this problem, readjust bounds when shell popup is created. Bug: 1125924 Change-Id: Icd7179e8f5ab1d9c2e96fee3dbb167e67b9e753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397695 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804913}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dc1b9762731e..6a6e311d81dd 2020-09-08 johnkslang@users.noreply.github.com Merge pull request #2388 from Tobski/rq-initialization-error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I1a5248157bd441f1bdc5dbf4fab9f723cec5d5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804912}
-
Jose Dapena Paz authored
Fix this build error using libstdc++: ../../printing/print_settings_conversion.h:24:22: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type 24 | PRINTING_EXPORT std::unique_ptr<PrintSettings> PrintSettingsFromJobSettings( | ^~~~~~~~~~ ../../printing/print_settings_conversion.h:9:1: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’? Bug: 957519 Change-Id: I3d23fb277ba5c600109c115e5de48a08c6e401be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394163Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#804911}
-
Owen Min authored
This reverts commit 85ae69b0. Reason for revert: crbug.com/1126038 Compile error on Linux Chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/15196 Original change's description: > Add new class ColorTrackingIconView to deduplicate subclasses. > > Upon investigating the associated bug, I noticed that there are a few > subclasses of ImageView that exist solely to override OnThemeChanged. > Since I also needed a subclass like this to fix the bug, I decided to > make a utility class to eliminate this ad-hoc subclassing, in the style > of ColorTrackingVectorImageButton (in image_button_factory.cc). > > Bug: 1125510 > Change-Id: I975a9b6a4676bb6b2a454172f211f406934d7869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397737 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804901} TBR=tapted@chromium.org,bsep@chromium.org Change-Id: I958b5f7c04434b680f58fb0d0e0e46a8529a6abb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1125510, 1126038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398778Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f29c57c715c..c107c7e93630 2020-09-08 andrewbb@google.com Ran tools/run_ftrace_proto_gen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I21c279a29065aaa34c6ccd350c33ebae9fa96742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804909}
-
Owen Min authored
Using 'future_on' instead of 'future' flag for the following policies: CrostiniArcAdbSideloadingAllowed CrostiniExportImportUIAllowed DeviceCrostiniArcAdbSideloadingAllowed Except the DeviceCrostiniArcAdbSideloadingAllowed, all policies will be filtered out in Beta and Stable. The follwing policies are actually launched, removing the future flag for them. CrostiniAnsiblePlaybook FloatingAccessibilityMenuEnabled VirtualKeyboardFeatures PluginVmDataCollectionAllowed BYPASS_POLICY_COMPATIBILITY_CHECK=Four policies are launched few milestones ago without removing the future flag. Bug: 1117637 Change-Id: I89304cc1b613a10fba1853267d6d31ed674597ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391615Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804908}
-
Frédéric Wang authored
This CL adds a web platform test to check that MathML content inside a content-editable div is still correctly laid out. It is inspired from the similar tests mathml/relations/html5-tree/integration-point-4.html and mathml/relations/css-styling/multi-column-layout.html for SVG embedding and fragmentation respectively. Currently, this test passes with EditingNG enabled. Bug: 6606, 1125133, 707656 Change-Id: I1bac091ca02608891e2d36e34c0a8190c40506be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398481 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804907}
-
Paula Vidas authored
This CL makes DeviceInfoSyncService an observer for FCM token and interested data types, so that it can send updated device info when they change. Bug: 1102336 Change-Id: I3fe00cbef6eb57fd7ccff35c047fa74053e4fcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397578 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804906}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51932f610c36..0485634fe3f9 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 25d277579d1e to ccab4cc42372 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic8124b58b79e82dfab4b23795182ac1a60a7d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804905}
-
cfredric authored
Change-Id: I1ad064b9da87821b578d9f183a7a78ba8da5929a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393056 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804904}
-
Wez authored
Flakes are observed under Fuchsia, Linux ASAN, Linux MSAN and ChromeOS bots, so disable the tests for Fuchsia & ChromeOS, and all ASAN and MSAN configurations. TBR=sunnyps Bug: 1045521 Change-Id: Ib8d1f33d433e6be6d3be1183af0e5ecd3edb5fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398678Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#804903}
-