GitLab

quic_protocol.h clean of chromium only code.

BUG=

Review-Url: https://codereview.chromium.org/2028803002
Cr-Commit-Position: refs/heads/master@{#396939}

Currently, the External Estimate Provider (EEP) may get
called multiple times per connection change. This CL ensures
that EEP is called exactly once per connection change.

This CL also updates the callback to UpdatedEstimateDelegate.
The callback now contains the updated estimates. This means
that the delegate does not have to query for those estimates
on receiving the callback. It makes the logic easier to
understand.

BUG=604417

Review-Url: https://codereview.chromium.org/2010003002
Cr-Commit-Position: refs/heads/master@{#396938}

BUG=606985

Review-Url: https://codereview.chromium.org/2026793002
Cr-Commit-Position: refs/heads/master@{#396937}

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Review-Url: https://codereview.chromium.org/2018223002
Cr-Commit-Position: refs/heads/master@{#396936}

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2025893003
Cr-Commit-Position: refs/heads/master@{#396935}

This CL completes ScreenWin's migration to be multiple DPI capable. Scaling
functions now attempt to resolve the DPI context based off of the HWND or
argument location if the HWND is unavailable.

An example of this is in ScreenWin's unittests. All calls that could change the
global default device scale factor have been removed.

The last remaining step is to hook up the monitor DPI specific info to ScreenWin
once multiple DPI mode is enabled.

The visual behavior of Chrome should not change with this CL.

BUG=426656,501259

Review-Url: https://codereview.chromium.org/2012083002
Cr-Commit-Position: refs/heads/master@{#396934}

Plumb unmodified HTTP/2 stream weight value through SPDY framing code
(SpdyHeadersIR and SpdyFramerVisitorInterface::OnHeaders()).

This CL lands server changes 116592396 by mpw and 123319972 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2018513002
Cr-Commit-Position: refs/heads/master@{#396933}

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see
https://crrev.com/2010173002

Also re-adding LayoutTest
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Review-Url: https://codereview.chromium.org/2018183002
Cr-Commit-Position: refs/heads/master@{#396932}

Otherwise, the same techniques can be applied to it as with
other kinds of injected URLs.

Review-Url: https://codereview.chromium.org/1998743002
Cr-Commit-Position: refs/heads/master@{#396931}

It is no longer necessary now that crbug.com/494442 is fixed.

BUG=494442,615538
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2023073002
Cr-Commit-Position: refs/heads/master@{#396930}

The cache deletion was previously not tested in BrowsingDataRemover,
presumably because the helper class StoragePartitionHttpCacheDataRemover
instantiates a number of services that are difficult / not possible to
mock in the unittest.

Therefore, we will test this in the browsertest. The test added in this
CL only verifies two things:
1. That the cache deletion completes successfuly without crashing.
2. That the size of the cache decreases after deletion.

Whether the correct cache entries would be deleted is already tested
in the browsertest of ConditionalCacheDeletionHelper, which is the helper
class used by BrowsingDataRemover for partial cache deletion.

The added test uncovers two bugs in the conditional cache deletion (which
is currently not live) and fixes them.
1. Missing return value assignment in StoragePartitionHttpCacheDataRemover.
2. It is not possible to partially clear cookies for origin, and therefore
   the creation of CookieMatcherFunction from an OriginFilterBuilder DCHECKs.
   However, it should be possible to delete cache for an origin. When doing
   so, we unnecessarily try to also instantiate CookieMatcherFunction, which
   hits the mentioned DCHECK.

Finally, we replace URLRequestMockHTTPJob with an EmbeddedTestServer in the
browsertest. This is because to populate the cache, we need to make an actual
resource fetch.

BUG=113967

Review-Url: https://codereview.chromium.org/2008323002
Cr-Commit-Position: refs/heads/master@{#396929}

BUG=

Review-Url: https://codereview.chromium.org/2022093002
Cr-Commit-Position: refs/heads/master@{#396928}

This CL makes following changes:
1. Adds a BACKGROUND mode in the dump triggers in trace config.
1. Periodic dumps can be disabled on passing 0 as interval.
2. On BACKGROUND mode only whitelisted dump providers are invoked.
3. Clean up periodic dump timer set up.
4. MemoryDumpSessionState is initialized with config in the renderer
   also.

BUG=613198

Review-Url: https://codereview.chromium.org/1995573003
Cr-Commit-Position: refs/heads/master@{#396927}

BUG=534814
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2025483002
Cr-Commit-Position: refs/heads/master@{#396926}

Now that the Android build is migrated to GN, remove documentation instructing
developers to update GYP files for JNI.

Review-Url: https://codereview.chromium.org/2022283002
Cr-Commit-Position: refs/heads/master@{#396925}

BUG=340339
TEST=WindowCycleControllerTest.TabKeyNotLeaked

Review-Url: https://codereview.chromium.org/1083093006
Cr-Commit-Position: refs/heads/master@{#396924}

BUG=

Review-Url: https://codereview.chromium.org/2024923002
Cr-Commit-Position: refs/heads/master@{#396923}

Revert of [Android Client] Move session-scoped native interface into JniClient (patchset #3 id:60001 of https://codereview.chromium.org/2007403002/ )

Reason for revert:
Revert this patch so that a fix for random crashes can land on M52 without conflicts.

Original issue's description:
> [Android Client] Move session-scoped native interface into JniClient
>
> This finishes up the refactorization of the JNI interface. Scheduled tasks
> inside a session will not be lingering after the session ends.
>
> BUG=526336
>
> Committed: https://crrev.com/800991e54ced74fc425843070a1941827af5b787
> Cr-Commit-Position: refs/heads/master@{#396036}

TBR=lambroslambrou@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=526336

Review-Url: https://codereview.chromium.org/2027783002
Cr-Commit-Position: refs/heads/master@{#396922}

https://chromium.googlesource.com/chromium/src/+/e9818faaa

BUG=490511
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/2027623003 .

Cr-Commit-Position: refs/heads/master@{#396921}

Description of the new form-targets-cross-site-frame.html test.
===============================================================

The test verifies that a form with target="crossSiteFrame" works fine
(especially in presence of out-of-process-iframes, aka OOPIFs, aka
blink::RemoteFrames which are present in --site-per-process mode).

The test finishes successfully, if form-target.pl ends up calling
testRunner.notifyDone() after main frame calls testRuner.waitUntilDone
and submits the form.  Expected test output helps verify that the
correct HTTP method was used and that test field's value from the form
was propagated correctly.

Required test harness fix (under components/test_runner)
========================================================

Context
-------

Before https://crrev.com/1852603002 (which I landed about a month ago):

- Cancellation of TestRunner's callbacks was using WebTaskList, instead
  of reusing base::WeakPtr to cancel callbacks.

- TestRunner::NotifyDone would cancel pending callbacks, before completing
  notifyDone processing.

After https://crrev.com/1852603002:

- WebTaskList was removed and replaced with using base::WeakPtr (yay!)

- TestRunner::NotifyDone was modified to call
  weak_factory_.InvalidateWeakPtrs()
  instead of task_list_.RevokeAll().
  This has led to the problem below.

Problem
-------

Calling weak_factory_.InvalidateWeakPtrs() from TestRunner::NotifyDone
would cancel pending callbacks (as before), but invalidated weak
pointers are also used for other things - i.e. as a link between
TestRunnerBindings and TestRunner instance.  This meant that
https://crrev.com/1852603002 accidentally changed the semantics of
testRunner.notifyDone().

Before https://crrev.com/1852603002 TestRunnerBindings would continue to
work after a call to testRunner.notifyDone().  Keeping these bindings
working is important, because testRunner.notifyDone() might *not* finish
the test when 1) testRunner.waitUntilDone() was not called yet, or
2) there are pending work items in TestRunner::WorkQueue or 3) we are
still tracking and waiting to finish loading of
TestRunner::top_loading_frame_.  In particular, the first notifyDone()
call in the new form-targets-cross-site-frame.html test would not finish
the test, because of (1).

Fix
---

It turns out that we can simply remove the call to InvalidateWeakPtrs
from TestRunner::NotifyDone.  This is okay because:

- InvalidateWeakPtrs will still be called in TestRunner::Reset (which is
  called between tests), so we still will insulate one test from another.

- Calling InvalidateWeakPtrs from TestRunner::NotifyDone cancels *pending*
  callbacks, but new callbacks created between TestRunner::NotifyDone and
  TestRunner::Reset would still be allowed to run.  Therefore the call to
  InvalidateWeakPtrs doesn't robustly accomplish its original purpose.

Since after the fix TestRunner::NotifyDone simply forwards the call
to TestRunner::CompleteNotifyDone, these 2 methods can be merged
together.

BUG=585284

Review-Url: https://codereview.chromium.org/1989103007
Cr-Commit-Position: refs/heads/master@{#396920}

Pointer::SetCursor() is now required to be called in response to
focus change events. This provides more seamless cursor changes
as the cursor will remain the same until it has been re-defined.

Simply clients that never define the cursor will now get the
default cursor instead of no cursor at all. Clients that draw
their own cursor now have a chance to provide a new frame before
the cursor is changed.

BUG=549781

Review-Url: https://codereview.chromium.org/2028443002
Cr-Commit-Position: refs/heads/master@{#396919}

BUG=614504
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2025673003
Cr-Commit-Position: refs/heads/master@{#396918}

This fixes find-in-page, sad-tab etc. in chrome --mash.

BUG=612820

Review-Url: https://codereview.chromium.org/2018333002
Cr-Commit-Position: refs/heads/master@{#396917}

Also disabling "Change channel" button according to whether
the user is allowed to change release channels.

BUG=546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2011703002
Cr-Commit-Position: refs/heads/master@{#396916}

I plan on moving this code into RootWindowControllerCommon next, but
am doing it in two phases to make it easier to see what changed.

BUG=none
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2024993002
Cr-Commit-Position: refs/heads/master@{#396915}

If policy defaults (or other defaults) overrule exceptions, changing UI
to show the exceptions texts in strike-through style.
- Adding policy icons that display text bubble on click.
- Fixing existing text misalignment in "Behavior" column for
  Policy or Extension Exceptions.

This replaces the earlier (buggy) attempt http://crrev.com/1855393006/

BUG=568031
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1963203002
Cr-Commit-Position: refs/heads/master@{#396914}

This CL fixes the incorrect implementation in https://crrev.com/1926473003.
In addition to the state WaitingToCancelOnCompositorButNewScroll introduced
previously, it adds a new state RunningOnCompositorButNeedsAdjustment when
an ongoing animation needs to be adjusted. We need the former to fix
issue 599876.

When an adjustment needs to be made, ScrollAnchor calls into ScrollAnimator
which adjusts the curve. When the animation is running on MT, this is enough,
but if the animation is running on CC, we abort the old animation and
push a new one with the adjusted initial and target positions (hence the new
state).

This CL also cleans up ::updateCompositorAnimations.

Added a new test case for testing MT animation and an animation running on CC
is tested by the layout test added in the initial patch.
(fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html)

BUG=594456

Review-Url: https://codereview.chromium.org/2015113003
Cr-Commit-Position: refs/heads/master@{#396913}

BUG=612245,509886

Review-Url: https://codereview.chromium.org/2021913002
Cr-Commit-Position: refs/heads/master@{#396912}

The initialization code in GLSurfaceOSMesaX11 needs to be used from
//ui/gl/init and as such can't be in anonymous namespace. Expose the
class similar to other GLSurface implementations.

BUG=611142

Review-Url: https://codereview.chromium.org/2022103002
Cr-Commit-Position: refs/heads/master@{#396911}

In 903e2b85, GN stopped recursing into bundles
to collect target dependencies. But any explicit data_deps on a bundle should be
included in the runtime_deps output.

BUG=611414
R=brettw@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2010173004
Cr-Commit-Position: refs/heads/master@{#396910}

Brotli compression as applied to the about credits HTML file in
https://codereview.chromium.org/1951363002/, but not decompressed in the
iOS about credits WebUI code.

BUG=614859

Review-Url: https://codereview.chromium.org/2015133003
Cr-Commit-Position: refs/heads/master@{#396909}

https://chromium.googlesource.com/skia.git/+log/0ee622021c92..18c4943e90db

$ git log 0ee622021..18c4943e9 --date=short --no-merges --format='%ad %ae %s'
2016-05-31 herb Use special case for 0x00 and 0xFF alpha to go faster. Base          Exp           Ratio           Name 3916010   3077544   0.785888  top25desk_amazon_com.skp_1 3462512   2776580   0.801898  top25desk_google_com_calendar_.skp_1 3446330   3134187   0.909427  top25desk_ebay_com.skp_1 590474    546375    0.925316  top25desk_techcrunch_com.skp_1 3804991   3544162   0.931451  top25desk_google_com__hl_en_q_b.skp_1 996037    939960    0.9437    top25desk_blogger.skp_1 973264    922677    0.948023  top25desk_wikipedia__1_tab_.skp_1 4514050   4295660   0.95162   top25desk_docs___1_open_documen.skp_1 4255383   4110057   0.965849  top25desk_linkedin.skp_1 8408717   8191843   0.974208  top25desk_booking_com.skp_1 2878529   2806501   0.974977  top25desk_plus_google_com_11003.skp_1 11509894  11254486  0.97781   top25desk_pinterest.skp_1 9132514   9010635   0.986654  top25desk_weather_com.skp_1 6504720   6419592   0.986913  top25desk_sports_yahoo_com_.skp_1 9136774   9033870   0.988737  top25desk_answers_yahoo_com.skp_1 4836199   4799784   0.99247   top25desk_news_yahoo_com.skp_1 1393650   1384065   0.993122  top25desk_games_yahoo_com.skp_1 6779678   6735278   0.993451  top25desk_youtube_com.skp_1 10926943  10882308  0.995915  top25desk_espn.skp_1 4259514   4245489   0.996707  top25desk_facebook.skp_1 10955293  10947657  0.999303  top25desk_google_com_search_q_c.skp_1 9153575   9207386   1.00588   top25desk_twitter.skp_1 3865942   3906345   1.01045   top25desk_wordpress.skp_1 4180009   4305530   1.03003   top25desk_mail_google_com_mail_.skp_1
2016-05-31 cblume Add mip support to *DeferredTextureImageData functions.
2016-05-31 lsalzman Filter out degenerate contours in GrConvexPolyEffect
2016-05-31 jvanverth Add missing files for GL unix viewer. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023943004
2016-05-31 msarett Fix integer overflow in SkColorSpace

BUG=578304

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2025023002
Cr-Commit-Position: refs/heads/master@{#396908}

This is a speculative fix since unable to repro with local Android ASan build.

BUG=588352

Review-Url: https://codereview.chromium.org/2022873003
Cr-Commit-Position: refs/heads/master@{#396907}

BUG=615104

Review-Url: https://codereview.chromium.org/2013113002
Cr-Commit-Position: refs/heads/master@{#396906}

BUG=613419

Review-Url: https://codereview.chromium.org/1994403002
Cr-Commit-Position: refs/heads/master@{#396905}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1254fd14d97f..1fe25d215145

$ git log 1254fd14d..1fe25d215 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2024183003
Cr-Commit-Position: refs/heads/master@{#396904}

BUG=None

Review-Url: https://codereview.chromium.org/2025053002
Cr-Commit-Position: refs/heads/master@{#396903}

EndConnection reasons were being passed to net::ErrorToString, which in
debug builds will DCHECK if the error is not recognized.

BUG=599711

Review-Url: https://codereview.chromium.org/2023623002
Cr-Commit-Position: refs/heads/master@{#396902}

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2018263002
Cr-Commit-Position: refs/heads/master@{#396901}

It is unnecessary; for USS the DTC's are generic and we can just use the
UIModelTypeController.

BUG=

Review-Url: https://codereview.chromium.org/2017963002
Cr-Commit-Position: refs/heads/master@{#396900}