- 27 Feb, 2020 40 commits
-
-
Darwin Huang authored
Bug: 1052575, 1056154 Change-Id: Ic54bb72742ee3e8b8b94f63e5468319e289a8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076539 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745177}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4467316..bfa4dadb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e9722345ce60aff3e10b9383631754d07b0ce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745176}
-
Rohit Rao authored
The pref values are transferred over eDO as JSON representations of base::Value and deserialized back into the appropriate types in the test process. BUG=None Change-Id: Ibcdd487160791d4d163bd3123d2244933406436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075480 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#745175}
-
Geoff Lang authored
These objects are not used when the passthrough command decoder is in use. This saves several GPU memory allocations in TextureManager for default and black textures. Saves ~2 MB per context. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2028291 TBR=sandersd@chromium.org BUG=1046613 BUG=1030835 Change-Id: Iae138dd860023d3b16e958fed290ad78188b31bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072358 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745174}
-
Michael Lippautz authored
This sets up a directory for a C++ garbage collection library. The library will use the core of Oilpan (currently sitting in third_party/blink/renderer/heap) without depending on WTF or Blink internals. Design doc: http://bit.ly/oilpan-library-proposal "Would you tell me, please, which way I ought to go from here?" "That depends a good deal on where you want to get to," said the Cat. "I don't much care where--" said Alice. "Then it doesn't matter which way you go," said the Cat. "--so long as I get SOMEWHERE," Alice added as an explanation. "Oh, you're sure to do that," said the Cat, "if you only walk long enough." -- Lewis Carroll Bug: 1056170 Change-Id: I231f596783d742800b53730af6dcb84b11ffe389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077992 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745173}
-
Joshua Pawlicki authored
This allows extensions to serve from locations that require HTTP auth. Bug: 1031500 Fixed: 1031500 Change-Id: Ied62b0f685f43bbac450147f16518db293fbaea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071044 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#745172}
-
Toni Barzic authored
When the user successfully performs home to overview gesture, record the even in contextual nudges prefs for home to overview gesture. The goal is to stop showing the contextual nudge for the gesture if it's reasonable to assume the user already knows how to use it. BUG=1008963 Change-Id: Ie031320e6c8033fcee9aea26a1c5b01685d3c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076265Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745171}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb3f302bdf69..11efa18eca9f git log fb3f302bdf69..11efa18eca9f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com impl load32 2020-02-27 brianosman@google.com Revert "Add most important intrinsics to the interpreter" 2020-02-27 mtklein@google.com initialize fEE = nullptr 2020-02-27 borenet@google.com [recipes] Move app_name into flavor.setup() 2020-02-27 westont@google.com Revert "Update Go Deps" 2020-02-27 mtklein@google.com convert to phi nodes Created with: gclient setdep -r src/third_party/skia@11efa18eca9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id7257d7a182704017a0b7174a865e256d2a08c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745170}
-
Nico Weber authored
We had a bunch of workarounds to get link.exe not use /incremental for very large binaries. Since we no longer use link.exe, remove those workarounds, and since this removes all reference to a bunch of configs, remove the configs as well. Inline all that remains into default_incremental_linking. (There's more that can be simplified here, but one thing at a time.) Bug: 1053958 Change-Id: I4cb123ef1a45fdbcd16d09211e55715095744a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079088 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745169}
-
Ben Joyce authored
Bug: 1005891,1054152 Change-Id: I28da67e1d4d1b92a4953a8ae72f9565055cc2afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064823Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#745168}
-
Kurt Horimoto authored
The OverlayPresenter passed as an argument for the OverlayPresentationContext API was not used by the implementation. This CL decouples the presentation context interface from OverlayPresenter. Bug: none Change-Id: Iefa20303f6b38d22240fb9f29f0c3ec6675cb55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069257 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745167}
-
Greg Kerr authored
This adds the scheduler-configuration-default flag to the flags that are allow listed in guest mode. BUG=b:147685035 Change-Id: Ic2ef8d84ea71857953a3e223e8a0be140f50c035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079252 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745166}
-
Kyle Milka authored
If STTS is not available (sync not enabled or no target devices available) display a prompt to educated users to sign in. Bug: 1009124 Change-Id: I357763f51fafcfded316fb8ecfb954470ea527e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067798 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#745165}
-
Akihiro Ota authored
This change is composed of the following menu panel improvements: 1. Change menu title "Search menu" to "Search" 2. Change the hint text of the search bar to "Search the menus" 3. Change instances of "ChromeVox" and "Cvox" to "Search" 4. Use ", then " instead of " > " for layered commands. 5. Change menu title "Forms" to "Form controls" Bug: 1049396 Change-Id: Ic622ec6949af2d7b2a1f3c6b5d73dc6048b89847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032007 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#745164}
-
Domenic Denicola authored
filter() results are not subscriptable in Python 3, so we need to use next() to retrieve the first element instead. Bug: 1056747, 941669 Change-Id: I003eda9a8044d18bf7a2aae82086693aa0386c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079191Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745163}
-
Martin Kreichgauer authored
The existing WebAuthentication.CableV1Event metric recorded information about the caBLEv1 authenticator discovery process up until the point before Chrome starts scanning for BLE advertisements. Most of the current issues with caBLE however occur in between starting the BLE scan and having a fully connected authenticator (e.g. during advertisement registration, establishing a GATT connection or reading FIDO Characteristics). This change replaces the existing metric with one that's recorded at the FidoCableDiscovery (WebAuthentication.CableV1DiscoveryEvent) which allows us to record more fine-grained events. The events recorded by the new metric are an almost-superset of the old metric's events. The only exception is the "Success (7)" event. However, we should still be able to count the number of successful caBLE v1 assertions from the WebAuthentication.GetAssertionResponseTransport metric. Bug: 1055029 Change-Id: I784e0ca94f2b0b1d97bef3efa9af19c8e9ea133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069022 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#745162}
-
kylechar authored
This is a reland of 985a1f41. Also fix an issue where SoftwareOutputDeviceWinProxy was crashing if we draw the root RenderPass but never call SwapBuffers() as the |swap_ack_callback_| wasn't set. Original change's description: > Don't disable draw during resize > > https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to > also block draw instead of just swap. This had the side of effect of > blocking draw when the browser window is minimized, which means we stop > casting tab/window contents. Switch DisableSwapUntilResize() back to > just block swap instead of draw+swap. > > Bug: 1054239, b/149923568 > Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744018} Bug: 1054239, b/149923568 Change-Id: I4f96bcb9547f4c4b24c020ffff728e4fa08d0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078840Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745161}
-
Daniel Rubery authored
Real time URL lookups may be running multiple token fetches at once, and needs to manage these requests in parallel. This CL moves that functionality into the SafeBrowsingTokenFetcher. Bug: 1051679, 1041912 Change-Id: I6a667ac86422e5c31c14107d45bf495cc0de4e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072911Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#745160}
-
Ted Meyer authored
We've decided after much deliberation that MediaError wasnt a very good name for a return type that could also denote success, so we've changed it to |Status| instead. Bug: 1043289 Change-Id: I1265f6aa6dc501298fa80b8df027205c70d64e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068307Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745159}
-
Ana Salazar authored
Overview mode blurs the background, so we don't need the hotseat to blur the background a second time. Bug: 1022157 Change-Id: I7c1ee1f609db32163c629205c4bada0785b2b582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076085 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#745158}
-
John Lee authored
As requested by UX. Change-Id: I95847f267f74b199789f16ba1b5e2bc80e304747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076529 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745157}
-
Xing Liu authored
This reverts commit bfb35d53. Reason for revert: Triggers a bug in the old code. see crbug/1056107. Original change's description: > Download notification: Simplify foreground notification events. > > Currently we use DownloadForegroundServiceObservers to broadcast > download foreground service events. It uses reflection to cache the > class name and then persist to android shared preference. > > DownloadNotificationServiceObserver implements > DownloadForegroundServiceObservers.Observer, and then call methods of > the singleton object of DownloadNotificationService. > > Also, onForegroundServiceRestarted() is not getting called, which make > the following calls dead code. > > This is extremely weird, we can just call the one line singleton > method. > > Bug: 922929 > Change-Id: I28ff5552fd7fc0fd5a111cd4971d6bf4514bb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063853 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743368} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922929 Change-Id: I467b19ba958a380a08e464339e735d5e30e376c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076977Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745156}
-
Xinghui Lu authored
If RTLookupResponse is empty, it can be either the URL is safe or there is an error during the network request. We should fall back to hash based check if an error happens. Bug: 1050859 Change-Id: Ib499ac35bf0ca4e01c211361975958e2cc88f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068893 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#745155}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I921c72bddfe6c716bad2756a524670efbb991958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745154}
-
Sophie Chang authored
This is a reland of 04f3c8a3 TBR=tbansal@chromium.org for chrome/browser/predictors/... (he also said it was ok over chat) Original change's description: > Reland "Reland "Add support for loading predictor to use hints from optimization guide"" > > This is a reland of 9a31f5ab > > Original change's description: > > Reland "Add support for loading predictor to use hints from optimization guide" > > > > This is a reland of eed7024d > > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > > > Original change's description: > > > Add support for loading predictor to use hints from optimization guide > > > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > > metrics since the support is all behind a feature flag. > > > > > > Bug: 1050101 > > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#743767} > > > > Bug: 1050101 > > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744088} > > Bug: 1050101 > Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744839} Bug: 1050101 Change-Id: I3a2f925fc8d1d69ef25584848002cc158f2028a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078836Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745153}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eed48b86ed9c..c93595b4b916 git log eed48b86ed9c..c93595b4b916 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 perkj@webrtc.org Allow REMB messages to be sent immediately in RtcpTransceiver Created with: gclient setdep -r src/third_party/webrtc@c93595b4b916 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I674e68120b0fc63fa1296edb055d9a1130255b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745152}
-
Yue Li authored
Portrait and smaller screen treatment for 2 columns layout: https://spec.googleplex.com/crosux-spec/feature-specs/oobe-templates.html#oobe-templates-2-columns Also fix an error that the lottie animation is not found in the timeout method. Bug: 1033273, 1033268 Test: Manual Test Change-Id: I8cbe121b0514a8ff41bab6affecf00a576aad72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076665Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#745151}
-
Jerome Jiang authored
BUG=chromium:1055917 Change-Id: I7105ed49b94960bec3e267ffcee7aa4d74efff4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072364Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#745150}
-
Evan Stade authored
This matches Chrome behavior. When a window.alert is triggered on a bg tab, it will be deferred until that tab becomes foregrounded. This logic is implemented in TabModalDialogManager, so there are minimal changes required to WebLayer. Note that other js dialogs are simply ignored on backgrounded tabs, with a console message logged. Bug: 1025256 Change-Id: I05bce9195198db3685c814246e73721269a4b979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075053 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745149}
-
Chris Blume authored
This reverts commit ee82ef83. Originally reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1924632 Bug: 1055899 Change-Id: I5d210a6df3d90ad6e96a6f6d7955845a38721f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076531Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#745148}
-
Nina Satragno authored
Add `isUserConsenting` to the content shell testdriver API. This lets us run the timeout WPTs. Fixed: 1054810, 1054655 Change-Id: Id90567818a1fcda44794294fc3527790df056870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078833Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#745147}
-
Katie Dektar authored
This reverts commit 18fd0f78. Reason for revert: Breaks compile, closes the tree Original change's description: > Reland "Reland "Make tab strip auto scroll to position of the selected tab"" > > This reverts commit 6f50bdff. > > Reason for revert: Try to fix the compile failure. > > Original change's description: > > Revert "Reland "Make tab strip auto scroll to position of the selected tab"" > > > > This reverts commit 1d7cbd22. > > > > Reason for revert: This is still causing a compile failure: > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol > > CachedFeatureFlags.setForTesting(ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID, true); > > > > Original change's description: > > > Reland "Make tab strip auto scroll to position of the selected tab" > > > > > > This reverts commit e3a03f83. > > > > > > Reason for revert: Try to fix the compile failure. > > > > > > Original change's description: > > > > Revert "Make tab strip auto scroll to position of the selected tab" > > > > > > > > This reverts commit 7767aa96. > > > > > > > > Reason for revert: suspect causing compile failure on android-archive-rel > > > > > > > > Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648 > > > > > > > > Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw > > > > ---- > > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol > > > > CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true); > > > > ^ > > > > symbol: method setGridTabSwitcherEnabledForTesting(boolean) > > > > location: class CachedFeatureFlags > > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol > > > > CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true); > > > > ^ > > > > symbol: method setTabGroupsAndroidEnabledForTesting(boolean) > > > > location: class CachedFeatureFlags > > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol > > > > CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null); > > > > ^ > > > > symbol: method setGridTabSwitcherEnabledForTesting(<null>) > > > > location: class CachedFeatureFlags > > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol > > > > CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null); > > > > ^ > > > > symbol: method setTabGroupsAndroidEnabledForTesting(<null>) > > > > location: class CachedFeatureFlags > > > > 4 errors > > > > ---- > > > > > > > > Original change's description: > > > > > Make tab strip auto scroll to position of the selected tab > > > > > > > > > > Currently, when a tab in group is selected or a new tab is created > > > > > within group, the tab strip doesn't scroll to the position of the > > > > > currently selected tab. This could lead to a state where user needs to > > > > > scroll by themselves to find their selected tab in strip. This CL fixes > > > > > this issue by making following changes: > > > > > * Always scroll the strip to the last position when new tab is added > > > > > in group. > > > > > * When selected a tab in group (through tab grid dialog etc), try to > > > > > scroll to a state where the selected tab is in the middle of the > > > > > strip, if possible, > > > > > > > > > > Bug: 1054079 > > > > > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888 > > > > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > > > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#744892} > > > > > > > > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > > > > > > > Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 1054079 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219 > > > > Reviewed-by: Takashi Sakamoto <tasak@google.com> > > > > Commit-Queue: Takashi Sakamoto <tasak@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#744908} > > > > > > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > > > > > Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1054079 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415 > > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#745086} > > > > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > > > Change-Id: I8bfddb25a503e743d790d0ddc59c4a45e0c91665 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1054079 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079137 > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Commit-Queue: Patrick Noland <pnoland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#745123} > > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,pnoland@chromium.org,yuezhanggg@chromium.org > > Change-Id: I88bc2d374066bf52fc056214ed9d4634a999647f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1054079 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078843 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745129} TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,pnoland@chromium.org,yuezhanggg@chromium.org Change-Id: I2483422df9d9bcfb282155ded95a3a52270ba81a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079332Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745146}
-
chrome://settings/paymentsChristos Froussios authored
The new payment type is being added to the existing credit_card_list, which is renamed to payments_list. Functions to get the data from WebData were added to autofill_private.idl AutofillTable, AutofillWebData, PersonalDataManager etc Bug: 986289 Change-Id: Ie7897c5497864c944e696f8fed2bf9ee20282f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022769 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#745145}
-
Alan Cutter authored
Bug: 1007786 Change-Id: I7b3ce7e78c7b15407e8e8f5826d94baae4f946d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076858Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745144}
-
Olivier Li authored
When the feature is activated HangWatcher will monitor the IOThread instead of ThreadWatcher. The individual MessageLoop implementations are instrumented to cover all platforms for the handling of events and ThreadControllerWithMessagePumpImpl is instrumented to cover the task execution. Shutdown hang watching is still covered by ShutdownWatcherHelper. Bug: 1034046 Change-Id: Ie797a1d1c4ce3b438878ad18e91347ccd02daccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046404Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@google.com> Cr-Commit-Position: refs/heads/master@{#745143}
-
Wanchang Ryu authored
When renderer process is created, BackgroundTracingManagerImpl creates closure for constructing of BackgroundTracingAgentClientImpl and creates its instance lazily only when any agent observers are registered. But it never releases if none of agent observer exists so it remained as leaked memory. To release pending constructor, BackgroundTracingAgentClientImpl registers a disconnect handler to BackgroundTracingAgentProvider then it releases when it is disconnected. BackgroundTracingAgentProvider would be disconnected when the process is gone. Change-Id: I880c31caa7731dd3429c089ff523da5f846af00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065195 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745142}
-
Ted Meyer authored
There were no checks in the StructTraits static getter methods, which was causing DCHECK's when used. Bug: 1043289 Change-Id: Ic139687493bb1e03b369dda2f30301ee78aa8330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067949Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745141}
-
Ian Kilpatrick authored
This adds a test for the progression caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1869012 Which corrected the clip state for paint descendants. Bug: 1049976 Change-Id: I1c53cd800fa9ac342c025703e6d05359b582da56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076534Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745140}
-
Shimi Zhang authored
Samsung devices may have a "Glove Mode", which is determined by Samsung only API "android.util.GeneralUtil#isSupportedGloveModeInternal". This method violates StrictMode disk read. So we need to ask extra permission for Samsung devices. Bug: 1056368 Test: Install WebView shell on Samsung J7 device (see the linked bug for Test: ro.build.fingerprint), click the 3-dot menu, no crash observed. Change-Id: I685e06ed30b3ba1654a4cabb7e2efede7480b8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076528Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#745139}
-
Raymond Toy authored
Rebase test results that have changed because of changes in audit.js. The output basically just has some new output lines and some changed line numbers. Bug: 1027300 Change-Id: I4a055a8e136e25139b1cf7e6bf24fbfbc2914796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076536Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745138}
-