GitLab

Note that for NaCl bundles nspr files will be used anyway, since NaCl toolchain doesn't looks for libraries in system directories.

BUG=none

Review URL: https://codereview.chromium.org/11685002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175539 0039d316-1c4b-4281-b951-d872f2087c98

Lots of tests fail with seemingly random failures if the screen turns off. Add an explicit test for this so it's obvious why tests are failing.

BUG=167141

Review URL: https://chromiumcodereview.appspot.com/11642050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168615


Review URL: https://chromiumcodereview.appspot.com/11784028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175537 0039d316-1c4b-4281-b951-d872f2087c98

Correctly clean up resources when we're finished with the Surface
by invoking release().

Android only change and android bots are green.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11791027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175536 0039d316-1c4b-4281-b951-d872f2087c98

This was added with the intention of using Size as a vector, replacing use of
IntSize. Since we have Vector2d now, negative sizes should not exist, so clamp
them in set_width/set_height and the constructor.

Not covered by tests, as we can't test DCHECKs.

TBR=sky
BUG=160158
Relanding: https://codereview.chromium.org/11365160/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167255

Review URL: https://chromiumcodereview.appspot.com/11410024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175535 0039d316-1c4b-4281-b951-d872f2087c98

This Cl ensures that if the current user's session cannot be locked,
"lock on idle suspend" triggers a logout instead.

BUG=168151
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/11737015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175534 0039d316-1c4b-4281-b951-d872f2087c98

A callback object is passed along with the mailbox name to the layer. This callback is triggered with a sync point to signal when the mailbox is no longer in use by the compositor.

TextureLayerImpl packages a mailbox up as a resource on willDraw
and releases it when a new mailbox is ready for consumption or when the layer is destroyed.

BUG=123444

Review URL: https://chromiumcodereview.appspot.com/11638028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175529 0039d316-1c4b-4281-b951-d872f2087c98

the "runtime" namespace rather than "extension" in docs and samples.

R=asargent@chromium.org
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/11745015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137591

Review URL: https://codereview.chromium.org/11761005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175526 0039d316-1c4b-4281-b951-d872f2087c98

These seemed to make the graph-plotter frontend not work.

BUG=NONE

Review URL: https://codereview.chromium.org/11779042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161536


Review URL: https://chromiumcodereview.appspot.com/11669012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175524 0039d316-1c4b-4281-b951-d872f2087c98

In drive_scheduler_unittest.cc, contents of account meatadata
do not matter, so we can just return empty metadata.

BUG=166572
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11787035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175523 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11782027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175522 0039d316-1c4b-4281-b951-d872f2087c98

content::GeolocationPermissionContext derives RefCountedThreadSafe, so
we can't mix a RefcountedProfileKeyedService into
ChromeGeolocationPermissionContextFactory. Instead, create a separate
ProfileKeyedService to hold the
scoped_refptr<GeolocationPermissionContext>.

Ground work for https://codereview.chromium.org/11590002/

TEST=Existing
BUG=155029

Review URL: https://chromiumcodereview.appspot.com/11587003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175521 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175520 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11794035/
Review URL: https://codereview.chromium.org/11801026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143337
TEST=unit_tests:FrameNavigationStateTest.SrcDoc, browser_tests:WebNavigationApiTest.SrcDoc
R=marja@chromium.org,creis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11791018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175518 0039d316-1c4b-4281-b951-d872f2087c98

 This also adds an option in flags page in case this caused the crash in the field.

This requres https://codereview.chromium.org/11684002/.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11673010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164772
R=pkasting@chromium.org,sail@chromium.org
TBR=ben@chromium.org # for file additions to gyp files

Review URL: https://codereview.chromium.org/11773025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175516 0039d316-1c4b-4281-b951-d872f2087c98

When running on a fresh install, there's no preferences available.
Rather than throwing an exception, start the browser and wait for the file to become available.

BUG=166176
TEST=tools/perf/run_multipage_benchmarks --browser=android-chrome --show-stdout sunspider tools/perf/page_sets/sunspider.json -vvv

Review URL: https://chromiumcodereview.appspot.com/11574039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175515 0039d316-1c4b-4281-b951-d872f2087c98

Removed translateable="false" option for these messages.
Currently a few messages who have translation data are translated and others are kept as-is.

BUG=168490
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11788027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175514 0039d316-1c4b-4281-b951-d872f2087c98

Remove IDR_INFO_BUBBLE_CLOSE and various unused/unreferenced PNGs.

Change the (x) close button image for ConfirmBubbleViews.
(the new image matches the new dialog style specification)
(the button currently doesn't use hover/pressed state images)
(see before/after pictures at http://crrev.com/166075#c6)

Note: To test the only use of ConfirmBubbleViews, open a webpage textfield context menu (right-click) and select "Spell-checker options" -> "Ask Google for suggestions". Observe the dialog's close button.

BUG=166075
TEST=Spelling bubble has better (x) image; no build breaks.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11779030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175510 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175509 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141842
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10782030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163860


Review URL: https://chromiumcodereview.appspot.com/11663025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175505 0039d316-1c4b-4281-b951-d872f2087c98

This CL is preparation for server path injection, especially for testing.
It Extracts URL constructing logic from GetURL methods of the classes in
drive_api_operations.{h,cc}, and puts them into a new class
DriveApiUrlGenerator.
DriveApiUrlGenerator is given via operation classes' constructors from their
client (DriveApiService).
The concept of this CL is very similar to the following CLs:
https://codereview.chromium.org/11411086
https://codereview.chromium.org/11418084
https://codereview.chromium.org/11417108
https://codereview.chromium.org/11417109

BUG=162155
TEST=ran unit_tests and chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/11799003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran test locally.
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11648013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35811
TEST=drag the [Next] image from http://www-sul.stanford.edu/tools/tutorials/html2.0/img.html and drop it on the desktop; the resulting file should be named "nextbtn.gif", not "tables.gif"


Review URL: https://chromiumcodereview.appspot.com/11790003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175502 0039d316-1c4b-4281-b951-d872f2087c98

Without this, e.g. a navigation to about:srcdoc looks like a navigation to
about:blank during the provisional phase, and suddendly the internal
about:srcdoc URL is leaked to the embedder.

BUG=168611
TEST=WebContentsImplTest.FilterURLs
R=creis@chromium.org

Review URL: https://codereview.chromium.org/11801011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167135


Review URL: https://chromiumcodereview.appspot.com/11776033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175500 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175499 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11747020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175498 0039d316-1c4b-4281-b951-d872f2087c98

These 5 tests:
DragDropControllerTest.DragDropInSingleViewTest
DragDropControllerTest.DragDropInMultipleViewsSingleWidgetTest
DragDropControllerTest.DragDropInMultipleViewsMultipleWidgetsTest
DragDropControllerTest.ViewRemovedWhileInDragDropTest
DragDropControllerTest.PressingEscapeCancelsDragDrop

pass locally but fail on the buildbot.

BUG=154081
TBR=ben
Review URL: https://codereview.chromium.org/11783026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167680

Review URL: https://chromiumcodereview.appspot.com/11617006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175496 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11791020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154081
Review URL: https://codereview.chromium.org/11787005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175494 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175493 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=139010&stop_rev=138895&verbose=on

TBR=dglazkov

BUG=

Review URL: https://codereview.chromium.org/11813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175492 0039d316-1c4b-4281-b951-d872f2087c98

[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:62: cannot find symbol
[javac] symbol  : method onEvaluateJavaScriptResult(int,java.lang.String)
[javac] location: class org.chromium.content.browser.test.util.TestContentViewClient
[javac]         super.onEvaluateJavaScriptResult(id, jsonResult);
[javac]              ^
[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:63: cannot find symbol
[javac] symbol  : method onEvaluateJavaScriptResult(int,java.lang.String)
[javac] location: class org.chromium.content.browser.ContentViewClient
[javac]         mWrappedClient.onEvaluateJavaScriptResult(id, jsonResult);
[javac]                       ^
[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:60: method does not override or implement a method from a supertype
[javac]     @Override
[javac]     ^
[javac] 3 errors

> Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.
> 
> BUG=168169
> TEST=should all pass
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11788005

TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/11778034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Compiles and test chrome://histograms/Tabs.SadTab


Review URL: https://chromiumcodereview.appspot.com/11775012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175490 0039d316-1c4b-4281-b951-d872f2087c98