GitLab

This CL makes it so that all locales are used during resource_packaging
for bundle builds.

It is a reland of: https://crrev.com/c/2024159 which included the new
locales on APK builds and was reverted.

Before this change all language splits for the 27 + 9 new languages
recently added to Clank were about half the size as older languages in
monochrome_public_bundle.apks

After this change the new languages and old languages are about the same
size in monochrome_public_bundle.apks.

Example Before (af,as, az, be, bn, and bs are new languages):

   158921  2001-01-01 00:00   splits/base-af.apk
   424765  2001-01-01 00:00   splits/base-am.apk
   432527  2001-01-01 00:00   splits/base-ar.apk
   226815  2001-01-01 00:00   splits/base-as.apk
   165763  2001-01-01 00:00   splits/base-az.apk
   203683  2001-01-01 00:00   splits/base-be.apk
   473236  2001-01-01 00:00   splits/base-bg.apk
   234710  2001-01-01 00:00   splits/base-bn.apk
   163986  2001-01-01 00:00   splits/base-bs.apk

Example After:

   305787  2001-01-01 00:00   splits/base-af.apk
   424765  2001-01-01 00:00   splits/base-am.apk
   432527  2001-01-01 00:00   splits/base-ar.apk
   569512  2001-01-01 00:00   splits/base-as.apk
   325961  2001-01-01 00:00   splits/base-az.apk
   468522  2001-01-01 00:00   splits/base-be.apk
   473236  2001-01-01 00:00   splits/base-bg.apk
   577862  2001-01-01 00:00   splits/base-bn.apk
   324504  2001-01-01 00:00   splits/base-bs.apk

Bug: 1035665 1046654
Change-Id: I4928e62ac29b35bf6c19508a70834149eabaaa82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029232Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736773}

Change the signature of the callback of FindRegistration methods to
remove ServiceWorkerRegistration dependency from ServiceWorkerStorage.
ServiceWorkerRegistration instantiation has been moved to
ServiceWorkerRegistry.

As a side effect ServiceWorkerDatabase::RegistrationData and
ResourceList are allocated on heap instead of stack when
FindRegistration methods are called. However this wouldn't have
performance impacts because we only allocate them only when we
look up database.

Bug: 1039200
Change-Id: Ic7b543b50e59b37f861f3d37d074839186616643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015863
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736772}

Reimplement GetPrimaryAccountId/HasPrimaryAccount in
IdentityManager.java as helpers on top of GetPrimaryAccountInfo instead
of standalone methods that are routed through JNI separately. This makes
the code more concise, facilitates mocking and simplifies future changes
to these methods.

Bug: 1046746
Change-Id: I8bfb715cb562b957849ca6e272a1731c17d98194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026573
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736771}

With this CL, the password_autofill_manager will push updates to the
popup once the "unlock passwords" button is clicked.
First, the clicked button will disappear (later: show a throbber).
Second, the popup will show all passwords once they arrive (later:
an empty state message if no additional passwords were found).

To do that, the manager will pin the popup view so that it waits for
updates and remove the unlock button.

Bug: 1043963
Change-Id: I8a8db6a1bdc6d25b6c097202ab2a93914cddd9cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020966Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736770}

https://skia.googlesource.com/skia.git/+log/25bcd6a6215e..f1c330bde24f

git log 25bcd6a6215e..f1c330bde24f --date=short --first-parent --format='%ad %ae %s'
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@f1c330bde24f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I7bb15e642baac6eae9d46fe426a7bd108d7cf4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030031Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736769}

The upcoming source map asyncification turns {addBinding} and
{removeBinding} into async functions. This CL adds some {await}s in
two web tests where they are needed.

R=sigurds@chromium.org

Bug: chromium:1032016
Change-Id: I9975c545af8746efd0d580339a4e6ca9573dd053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027468
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736768}

In order to prevent a runnable |mDetachRefreshLayoutRunnable| from
being invoked after |SwipeRefreshLayout| is set to zero, this CL adds
a missing null check.

Bug: 1045952
Change-Id: I48bf09831a42dccda3f38b1101184a27caf0218c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028870
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736767}

Previously, when the root node in ARC gets focus from ChromeVox,
ChromeVox reads the entire window content.

This CL prevents it by assigning the window title to the root node.

Bug: None (preparation of b:148356674)
Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*"
Change-Id: I884e2c19188468c48f6c26a4d4cb3eb72dc31144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024635
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736766}

Initial layout, sizes, colors, font and icons for file list header. It
still needs a few touches in the colors and hover/ripple effects.

Remove fill color from arrow up/down SVG icons so it's controlled by
CSS. These 2 files weren't used before this CL.

Bug: 992821
Change-Id: I51ed93ff93506592612d7da8cc1b5cd9a6f2f934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018564Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736765}

The explicit destructor is pessimising performance by preventing the move constructor from being generated.

Change-Id: Ia595d72a631decd522e22189fe42ec235fd7e381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029402
Commit-Queue: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736764}

We used to have a root element color value based on an internal UA sheet
value, but this is not according to spec since it affects the initial
value for the color property, hence setting the color value to 'initial'
should result in a used value that depends on the color-scheme for that
element.

Initial value for the color property is canvastext, but we do not yet
ship color-scheme aware system colors, so instead we implement this as a
method on ComputedStyle which is color-scheme aware and currently return
black for light and white for dark.

The devtools test changes are basically a revert of the necessary
changes done when we introduced -internal-root-color.

Bug: 939811
Change-Id: I63477751e1fe4aa3ce8292e8a3fc2cdb1dd3afbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027469
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736763}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/885b3febcc17..0ac28472d073

$ git log 885b3febc..0ac28472d --date=short --no-merges --format='%ad %ae %s'
2020-01-29 tikuta client: do not use isolated in win7
2020-01-28 tikuta [client] use go isolated client other than win7 32bit bots
2020-01-24 tikuta [swarming] use go isolated when cipd is enabled on windows10
2020-01-23 tikuta Revert "[swarming] use go isolated when cipd is enabled on windows"
2020-01-22 tikuta [swarming] use go isolated when cipd is enabled on windows
2020-01-22 tikuta [client] update isolated
2020-01-22 tikuta [client] roll infra_libs
2020-01-21 tikuta [client] followup for crrev.com/c/2009949
2020-01-20 tikuta [client] make dir after clobbering cache directory
2020-01-20 tikuta [client] update lru version
2020-01-20 tikuta [client] show GiB for large size
2020-01-20 tikuta [client] fix total_size
2020-01-17 tikuta Revert "[client] do not apply clean for isolate_cache"
2020-01-17 tikuta Revert "Reland "Reland "[swarming] use go isolated when cipd is enabled by default"""
2020-01-17 tikuta Reland "Reland "[swarming] use go isolated when cipd is enabled by default""
2020-01-17 tikuta [client] fix lru_test.LRUDictTest
2020-01-16 jojwang Add Google API protobufs
2020-01-16 tikuta [client] update isolated
2020-01-16 tikuta Revert "Reland "[swarming] use go isolated when cipd is enabled by default""
2020-01-15 tikuta Reland "[swarming] use go isolated when cipd is enabled by default"
2020-01-15 tikuta [client] do not apply clean for isolate_cache
2020-01-14 tikuta Revert "[swarming] use go isolated when cipd is enabled by default"
2020-01-14 tikuta [client] include more info in ValueError
2020-01-14 tikuta [swarming] use go isolated when cipd is enabled by default
2020-01-14 tikuta [client] do not use data.isolate_cache when go isolated is used
2020-01-10 tikuta [client] pass cache parameter explicitly for go isolated
2020-01-08 tikuta Revert "run_isolated: fallback to python if go failed"
2020-01-08 tikuta [client] remove --go-cache-dir
2020-01-08 tikuta [client] update isolated
2020-01-08 tikuta [swarming] log content of path when we see UnicodeDecodeError
2019-12-17 agable Fix test_fix_url for python 3.8.1
2019-12-13 tikuta client: clobber cache when failed to load state file
2019-12-13 tikuta Revert "swarming: rename isolated_cache to isolated_cache_python"
2019-12-13 tikuta Revert "4th Reland "task_runner: enable go isolated client""
2019-12-12 tikuta swarming: rename isolated_cache to isolated_cache_python
2019-12-12 tikuta 4th Reland "task_runner: enable go isolated client"
2019-12-11 tikuta run_isolated: fallback to python if go failed
2019-12-11 tikuta Revert "Reland "Reland "Reland "task_runner: enable go isolated client""""
2019-12-10 tikuta Reland "Reland "Reland "task_runner: enable go isolated client"""
2019-12-09 tikuta Revert "Reland "Reland "task_runner: enable go isolated client"""
2019-12-09 tikuta run_isolated: remove --use-symlink flag
2019-12-06 tikuta Reland "Reland "task_runner: enable go isolated client""
2019-12-05 tikuta run_isolated: update isolated client
2019-12-04 jwata [luci-py] fix jwata address in owners files
2019-12-03 tikuta run_isolated: update isolated client
2019-12-03 tikuta run_isolated: add --go-cache-dir flag
2019-12-03 tikuta run_isolated: update isolated client revision
2019-12-03 tikuta run_isolated: change type to str in args
2019-12-02 tikuta Revert "subprocess42: accept non-str arg"
2019-12-02 jwata [swarming] remove test_seq.py
(...)
2019-10-29 tikuta client: replace ' unicode(' with ' six.text_type('
2019-10-29 tikuta Handle sys.platform difference between Python2 and Python3
2019-10-29 tikuta client: change shebang of zip_package_test.py
2019-10-29 tikuta Reland "client: make zip_package_test.py run on Python3"
2019-10-29 tikuta Revert "client: make zip_package_test.py run on Python3"
2019-10-29 tikuta client: make zip_package_test.py run on Python3
2019-10-28 tikuta replace logging.warn with logging.warning
2019-10-28 tikuta client: make logging_utils_test.py run on Python3
2019-10-28 jwata [swarming] skip tests failing on mac
2019-10-28 tikuta client: fix indent in isolate_format.py
2019-10-28 tikuta client: use str string for python2 instead of unicode for extend/trim
2019-10-28 tikuta client: use extend in fs.readlink
2019-10-25 tikuta client: make isolated_format_test.py run on Python3
2019-10-25 tikuta client: use six.moves for some renamed modules in Python3
2019-10-25 jwata [swarming] remove test_support symlink from client and bot
2019-10-25 tikuta client: add missing encode in isolate_format.py
2019-10-25 tikuta make: isolate_format_test.py run on Python3
2019-10-25 tikuta client: update shebang for fs_test.py
2019-10-24 tikuta client: fix syntax warning in isolate_format.py
2019-10-24 tikuta client: tools_test.py can run in python3
2019-10-24 tikuta client: make fs_test.py run on Python3
2019-10-24 tikuta client: make auth_server_test.py run on Python3
2019-10-24 tikuta client: make file_path_test.py python3 compatible
2019-10-24 tikuta client: fix SyntaxWarning
2019-10-24 tikuta client: make _monkey_patch_oauth2client_locked_file run on Py2/3
2019-10-23 tikuta client: make extend/trim in fs for POSIX nop
2019-10-23 tikuta client: auth_test.py runs on python3
2019-10-23 tikuta client: make net_test.py run on Python3
2019-10-23 tikuta client: apply futurize stage1 under client/tests/
2019-10-23 tikuta client: make large_test.py python3 compatible
2019-10-23 tikuta client: make lru_test.py python3 compatible
2019-10-21 jwata [luci-py] move failing tests to test_seq.py
2019-10-21 tikuta client: make luci_context_test.py run on python3
2019-10-21 jwata [swarming] delete old blacklist file pattern
2019-10-21 jwata [luci-py] Setup test runner for client, components, auth_service, config_service
2019-10-20 tikuta client: make test_env.py python3 compatible
2019-10-18 tikuta swarming: replace unicde with six.text_type
2019-10-18 tikuta roll depot_tools to 989bc351863dd6cbb7e645a027a3c5e04104e44f
2019-10-17 tikuta add jwata@google.com as OWNERS for swarming and client
2019-10-16 tikuta Specify vpython in shebang for test
2019-10-10 maruel Migrate print to python3 format.
2019-10-10 maruel Migrate remaining use of urllib to six.moves
2019-10-10 maruel Use six.moves to import urlparse to be python3 compatible
2019-10-10 maruel [client] Allow packages in utils/ to be imported at interactive prompt
2019-10-10 maruel Get rid of xrange
2019-10-09 maruel Update dict usage to be python3 compatible
2019-10-03 tikuta Revert "client: increase the number of io worker threads"
2019-09-30 tikuta client: fix typo
2019-09-26 tikuta client: fix comment posisition
2019-09-23 tikuta client: improve error message for too long command line args

Created with:
  roll-dep src/tools/swarming_client

Bug: 984869
Change-Id: Id6edf75d02fc4db3def3a428b3131cbb755d3d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026514
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736762}

No-Try: true
Bug: 955013
Change-Id: Id0c8835aa3af57b770d501d5010c9f456318fefa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029398
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Cr-Commit-Position: refs/heads/master@{#736761}

If an IDL dictionary that is directly derived from DictionaryBase and
has no inherited class, its Trace can be non-virtual.
However, to make it consistent, this CL makes DictionaryBase's Trace
virtual and make generated dictionaries override it.


Bug: 839389
Change-Id: I3e897b4dbdd9ba944ae3eeb1bf3c9011718decd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026629Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736760}

Reland the CL with following fixes:
* We still use DIRECT_DRAW as the copy method used when the
source effective internal format's corresponding type is UNSIGNED_SHORT
and it's unmatched with that of the dest. Since the spec doesn't require
implementations to support this conversion. And failure of conversion is
seen on Android Nvidia shield tablet devices.
* Suppress ext-texture-norm16 test failure on win intel.
* Add some copy texture format combinations in gl_tests. Skip RGBA16 to
  RGB10_A2 on Mac and Linux Intel.

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1907195

Bug: 1000354, 1042252, 1042239, 1042246, 1046873
Change-Id: I96fe001fe261ceff4cf8bc82e548544456cb11e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003080Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#736759}

This CL finishes the refactor of views::DesktopDragDropClientAuraX11.

R=thomasanderson@chromium.org

Bug: 1014860
Change-Id: I8b7761873818224c091661467f43b992954ed6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020965
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736758}

https://crrev.com/c/1388124 introduced ContainerInfo.
It is pessimising performance by preventing the move constructors from
being generated and forcing additional copies in its constructor.

Change-Id: Ib973d689ae5a3dde1521a75e45b00c09e7510935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029401
Commit-Queue: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736757}

The delete confirm dialog needs to be instantiated from within Quick
View's <dialog> and requires the style to be injected from common.css.

Add a helper function deleteSelectedEntry_ to bring up the delete
confirm dialog to confirm deleting the currently selected entry.

No change in behavior, no new tests.

Bug: 803259
Change-Id: I5c86a2844b73cac146d34e59a2dab07000ce30b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026631Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Rachel Sugrono <rsugrono@google.com>
Cr-Commit-Position: refs/heads/master@{#736756}

Test: ArcAccessibilityHelperBridgeTest.FilterTypeChange
Bug: b/145316954
Change-Id: Iefee81eed63c0a1e5b39c07a875b6f1b5f2a5a62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952557Reviewed-by: Sara Kato <sarakato@chromium.org>
Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736755}

https://dawn.googlesource.com/dawn.git/+log/7d56022a6445..48e7da791f14

git log 7d56022a6445..48e7da791f14 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 rnk@google.com Use dict.items() instead of dict.iteritems() for py3 compat

Created with:
  gclient setdep -r src/third_party/dawn@48e7da791f14

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:941669
Tbr: cwallez@google.com
Change-Id: I38f6368b2a00765b253eb39b7fb7eabbab25127c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030029Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736754}

Currently, the generated classes for each event are created under the
//tools/metrics/structured target. I don't think this is the intended
use of the tools directory, because chrome targets explicitely can't
depend on it, and so can't access the generated events.

This CL moves the codegen targets to //components/metrics/structured,
which is accessible from chrome (and just makes more sense).

Bug: 1016655
Change-Id: I6a295486a3dad094b44db67d70408c8629728bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029531
Commit-Queue: Tony Yeoman <tby@chromium.org>
Auto-Submit: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736753}

This CL moves the dropped tab group to the end of the target
tab strip as a temporary solution.

Bug: 1005560, 1027373
Change-Id: I16207bfd0dd1f8e563c6c4d2cdd01abd45f9e15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025933
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736752}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e827b0f7ec9d..29e5a1af6c1d

git log e827b0f7ec9d..29e5a1af6c1d --date=short --first-parent --format='%ad %ae %s'
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@29e5a1af6c1d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I94ccb0ec08897321d22842c99fa174e2a57816ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030030Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736751}

The CL retrieves highlight color information from PDFium and passes it
from plugin to mimehandler. The color information is added to the
accessibility tree.

Bug: 1008775
Change-Id: I1faf7e1e7808a19ddbc234705dedcd546670de9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018568
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736750}

This change removes CopyToString from base::BasicStringPiece's API.
Similarly to the recently removed clear() and set() these APIs are
not present on std::basic_string_view, and thus would block us from
adopting string_view once we support C++17.

Existing usages of `piece.CopyToString(&str)` are replaced by either
`str = std::string(piece)` or `str.assign(piece.data(), piece.size())`
depending on whether move assigning a temporary would result in an
additional malloc or not.

TBR=dcheng

Bug: 752720
Change-Id: Ib70a183671d61bbbbf08c2c4a1c7eef573c3c446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027408
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736749}

To make debugging and analysis easier, I am extending the lifetime of
some statistics related to video capture related to frame handling.

Bug: 1043514
Change-Id: I60378651dfdc0ee29cd8a7ecbe94b90d41f72ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026969Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736748}

https://skia.googlesource.com/skia.git/+log/4328e928ef4d..25bcd6a6215e

git log 4328e928ef4d..25bcd6a6215e --date=short --first-parent --format='%ad %ae %s'
2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 243744c2..fbfe7df1 (481 commits)
2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c3dc3581eaf..430def835f9f (7 commits)
2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2bc9cc12f0b0..ee07cb317579 (18 commits)

Created with:
  gclient setdep -r src/third_party/skia@25bcd6a6215e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I9c1af36bb55acc641aaed4c0159b05b681b1fa66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030028Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736747}

The purpose of this change is to reduce
ServiceWorkerStorage::NewVersionId() as much as possible so that
we can make it async easily. See the planning doc [1] for the
context.

[1] https://docs.google.com/document/d/1j0WP5wsenJISViJzhngSJG3hKcIf39KbfRgCbzgWt5A/edit?usp=sharing

Bug: 1046335
Change-Id: Id013cdbe3dd88a51fc3002466581c8224a4e22e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026528
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736746}

This patch fixes invalidations for first-line, by copying
the logic from |NGPaintFragment|.

Fixes 5 tests.

Bug: 982194
Change-Id: I164fa59f2dfa080ec64fc0afe24ba83ba950ecf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943080
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736745}

This CL adds more scrollbar invalidation tests.

Bug: 1045808
Change-Id: I2a841fda4e8ebe584753fcdb70475ed28cf7f1e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027209
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736744}

Before this CL, FindRegistrationForId() worked like the below:
1. Check if storage is initialized/disabled.
   * if not initialized, perform lazy initialization then go back
   step 1.
   * if disabled, abort registration lookup.
2. Check if there are stored registrations for the given origin.
   * if NOT exists, only checks installing registrations.
3. Check if there is a live registration for the given registration id.
   * if exists, return the found registration.
4. Check database.

This ordering doesn't fit well for the Storage Service migration
because step 1, 2 and 4 should be performed in the storage service
(in the future) but step 3 should remain in content/. Keeping this
ordering will require an additional IPC round-trip which is undesirable.

This CL changes the above steps like the below so that we won't need
extra IPC:
0. Introduce a new field in ServiceWorkerRegistration which tells that
   if the registration is stored in persistent storage.
1. Check if storage is disabled. If disabled, abort registration
   lookup.
2. Check if there is a live registration for the given registration id.
   * if exists and the registration is stored on storage or in
     installing state, return the found registration.
3. Initialize storage if needed.
4. Check if there are stored registrations for the given origin.
   * This is the same as the step 2 of the previous behavior.
5. Check database.

The new behavior should be almost the same as long as we maintain the
field which indicates if a registration is stored accordingly. This CL
makes sure the condition by updating the field when a registration is
created from ServiceWorkerDatabase::RegistrationData or
ServiceWorkerRegistry::DidStoreRegistration() is called.

Bug: 1039200
Change-Id: I9e351c04a2eaa516a75274757778f604eadf951a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021783
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736743}

There are two problems which prevent features from being counted during
navigation commit:
- Document::Loader() does not return committing DocumentLoader during commit.
  This leads to use counters being immediately dropped. The fix is to expose
  committing DocumentLoader explicitly through DocumentInit::GetUseCounter.
- UseCounterHelper::DidCommitLoad() is called before DispatchDidCommitLoad().
  This leads to use counters being not reported to browser process. The fix
  is to call UseCounterHelper::DidCommitLoad() slightly later during commit.

Bug: 1043018
Change-Id: I16b1d248aad194d4ada3aeb841cddae924510596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022348Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736742}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adc8d4cb9876..916bee6fe15b


Created with:
  gclient setdep -r src-internal@916bee6fe15b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1041701,chromium:1044158
Tbr: jbudorick@google.com
Change-Id: Ifb1b6ace0a1cbbb95a9a15f0240527c6ca69daf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029463Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736741}

Since source mapping will be async in the future, this test is changed
to not race events, but instead print the single expected binding
upon receiving the "BindingCreated" event.

R=mathias@chromium.org

Bug: chromium:1032016
Change-Id: I676cd279f7f606dacc94b6a6d82814c7187e677a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026974Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736740}

Bug: 1036490
Change-Id: Ibad8cdb5f84b2a3fbb1c85499b9c327cd8f2cb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029230Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736739}

This function isn't used.

This CL also moves WriteToDiskCacheWithCustomResponseInfoAsync()
to anonymous namespace in service_worker_test_utils.cc because it
is only used from service_worker_test_utils.cc

Bug: 1046335
Change-Id: I733b8332191293f75cebde317e51996e896e860c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029552Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736738}

The delete from Quick View feature allows user to delete files via the
Quick View, which means the number of selected entries can change, and
onFileSelectionChanged_ will advise Quick View of that.

That includes having no selected entries at all.  And if there are no
selected entries, Quick View should be closed if it is open.

Otherwise, we need to ensure this.currentSelection_ is bounded by the
selected entries length (to avoid out-of-bounds entries_ access).

Bug: 803259
Change-Id: I8702b9422b0ea5b1ffc956aa8f2f999568fd82de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027008
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736737}

This reverts commit c1f6f104.

Reason for revert: Caused build breakage as crbug.com/1047073

Original change's description:
> bind-gen: Build generated IDL enumeration in prod
>
> Builds the bindings of IDL enumeration generated with the new
> bindings generator in prod, despite that the bindings is not
> yet used.  This patch makes it available for real use.
>
> Bug: 839389
> Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736356}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org

Change-Id: If378fb06497f5782dd18a3c637c7f61df745fa5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839389, 1047073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029556Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736736}

PositionIterator should have identical behavior for <input>, <select>,
and <textarea>.
We should remove kSelectTag branches later.

This CL has no behavior changes.

Bug: 697283
Change-Id: I5209d4ee59acf835310f8218b5c99305fef2573d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028868Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736735}

Bug: 1034355
Change-Id: Id433020409786ba93822d03606b64f21a4d40953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026335
Auto-Submit: Darren Shen <shend@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736734}