- 04 Oct, 2018 40 commits
-
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/extensions. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 809610 Change-Id: I6946ce73781d65738ac93e0b32868cd69087ac20 Reviewed-on: https://chromium-review.googlesource.com/c/1258921 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596599}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/desktop_ios_promotion. This CL was uploaded by git cl split. R=justincohen@chromium.org Bug: 809610 Change-Id: I5a51b5d4ada1e22557b10645166aaaa44b721bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1258915 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596598}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/mdns. This CL was uploaded by git cl split. R=gene@chromium.org Bug: 809610 Change-Id: If3c540d1d4a21995f64f4774615a27fc374c2762 Reviewed-on: https://chromium-review.googlesource.com/c/1258910 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Cr-Commit-Position: refs/heads/master@{#596597}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/omnibox. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: Id899615e5de24f082ed88441d255c57f73d17b34 Reviewed-on: https://chromium-review.googlesource.com/c/1258359 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#596596}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 809610 Change-Id: Id2dce79aff71ae34ea51f32f7f5c631cda602997 Reviewed-on: https://chromium-review.googlesource.com/c/1259015 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596595}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ssl. This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 809610 Change-Id: I27af4c0d03bd13ab7d7d9ed3941b7afea0de2302 Reviewed-on: https://chromium-review.googlesource.com/c/1258984 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596594}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/feedback_private. This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 809610 Change-Id: I41eb7e5f4a7b0286c0e3338e1b1792f38c7fdfdb Reviewed-on: https://chromium-review.googlesource.com/c/1259017 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596593}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/sockets_tcp. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 809610 Change-Id: I158ac6df6d0cf950da4c516bfa7595f3a5dcc148 Reviewed-on: https://chromium-review.googlesource.com/c/1258172 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/cocoa/test/cocoa_profile_test.mm. This CL was uploaded by git cl split. R=mark@chromium.org Bug: 809610 Change-Id: Id64f53e6b6a58c032f41c4461693d6d69116f406 Reviewed-on: https://chromium-review.googlesource.com/c/1259016 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#596591}
-
Mihai Sardarescu authored
This CL is a partial revert of chromium-review.googlesource.com/c/chromium/src/+/1254210 as a short-term fix for login issues. Only the ChromeOS changes are reverted, the behavior is not reverted on other platforms. The issue on ChromeOS originates from the fact that LoadCredentials is called with an empty primary account: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc?rcl=72758d92461e238aa314c1ffb6219eab17daf5ae&l=190) For the revert of changes in file chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc: TBR= tengs@chromium.org Bug: 891818 Change-Id: I4a3cebf635ec529225ba9427e04783621aeb2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1261002Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#596590}
-
Mirko Bonadei authored
This macro is needed to allow RTC_EXPORT to mark symbols as visible by a shared library. The WebRTC task queue will be marked as visible in https://webrtc-review.googlesource.com/c/src/+/103740 but the implementation used by Chromium lives here and must be marked as "WebRTC implementation". Bug: webrtc:9419 Change-Id: I1803538fa45d64f1b7e4a4c0f5afdee69ffcae7f Reviewed-on: https://chromium-review.googlesource.com/c/1261122Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#596589}
-
Egor Pasko authored
Sometimes AsyncInitializationActivity.onCreate() sits idle for 600+ ms with CPU being idle. Add a few more startup trace events to get a more detailed breakdown where the time is spent. These days finding an example trace where the event spikes (on perf bots) is a matter of a couple of clicks from chromeperf dashboard (win). The plan is to look at the details when it spikes next. Bug: 891797 Change-Id: I41a77a660b166f5013f61ae339596a6745af4686 Reviewed-on: https://chromium-review.googlesource.com/c/1258988Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596588}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: Ia7e7b275a75c4e841b330b6bebae44204dee381a Reviewed-on: https://chromium-review.googlesource.com/c/1258666Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#596587}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a817f0a559a..3fbdcc7add70 Created with: gclient setdep -r src-internal@3fbdcc7add70 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1463af52e4991f6bc7c38f8a77cf8f9c9bda0c7 Reviewed-on: https://chromium-review.googlesource.com/c/1260269Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596586}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/storage. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 809610 Change-Id: I3230efd3d9d26eff70a220d471ea5c06c88df502 Reviewed-on: https://chromium-review.googlesource.com/c/1258178 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/extension_gcm_app_handler_unittest.cc. This CL was uploaded by git cl split. R=peter@chromium.org Bug: 809610 Change-Id: I4210652a5584af1dfb3a069f73bfed156ef65b55 Reviewed-on: https://chromium-review.googlesource.com/c/1258006 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596584}
-
Sylvain Defresne authored
TestingFactory is a base::Callback<> while TestingFactoryFunction is a function pointer. Convert GCMProfileServiceFactory to the callback based type. Bug: 809610 Change-Id: I8a031fa5eef35d5a4f669d931594ba14b926c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/1245776 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596583}
-
tzik authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/bea85b5273..fb462224c0 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/bea85b5273..fb462224c0 Bug: 881453 Change-Id: Ib979bc7de0a354d9f865c6d778db0d91ac3b762b Reviewed-on: https://chromium-review.googlesource.com/c/1215368 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#596582}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72758d92. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25792 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Id7eca3852ec010a1c60b0f2df1b56468664b8d09 Reviewed-on: https://chromium-review.googlesource.com/c/1260925 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596581}
-
Kouhei Ueno authored
Bug: 890180 Change-Id: Iadafef53faba0cf2968b8c60da9503b28b116301 Reviewed-on: https://chromium-review.googlesource.com/c/1253314Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#596580}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/notifications. This CL was uploaded by git cl split. R=dewittj@chromium.org Bug: 809610 Change-Id: Iab5158d08029f4755cb4a2c60628cdc7e34148a7 Reviewed-on: https://chromium-review.googlesource.com/c/1258357 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596579}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/autofill. This CL was uploaded by git cl split. R=estade@chromium.org Bug: 809610 Change-Id: I9120558e0313fcc16cfeef3f9f01d032346abd52 Reviewed-on: https://chromium-review.googlesource.com/c/1257936 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596578}
-
Vadym Doroshenko authored
Saving credentials with NewPasswordFormManager was implemented in https://crrev.com/c/1180220. However, (the old) PasswordFormManager is still used for detecting login success. This CL enables using NewPasswordFormManager for success detection by switching from using the provisional_saved_manager_ (which has type PasswordFormManager) to using the result of GetSubmittedManager() (of type PasswordFormManagerInterface, the common base to both *PasswordFormManager types). This CL completes the infrastructure needed to replace PasswordFormManager with NewPasswordFormManager. So, it also introduces an option for tests to stop using PasswordFormManager in PasswordManager at all. (Production code still runs both versions in parallel and chooses the result based on the active base::Features.) Bug: 831123 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id30b1a5b87e64a6ae8f9bc80b4cbf22922e17a2d Reviewed-on: https://chromium-review.googlesource.com/c/1254065 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596577}
-
Morten Stenshorne authored
In LayoutInline::GenerateLineBoxRects(), when collecting rectangles, for each rectangle, we need to flip its block axis offset, to make it relative to the block-start of the container, because this is what's expected by the callback. GenerateLineBoxRects() is used to implement Element.getClientRects() (among other things). Added a test that used to fail with LayoutNG, since this obviously lacked test coverage. Also had to fix LayoutText::AbsoluteQuadsForRange(), or fast/writing-mode/flipped-blocks-text-map-local-to-container.html would regress. It used to pass because getClientRects for a text node and getClientRects for an inline (separate code paths) had the same bug. Also had to update NGPhysicalBoxFragment::AddSelfOutlineRects(). Now that GenerateLineBoxRects() (called from LayoutInline::AddOutlineRects()) behaves consistently and always produces rectangles with the block offset relative to the block-start of the container (rather than physical top or left for NG), we need to flip vertical-rl rects to become purely physical on our own. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6a5d6ab6012c20b3a2fd943cb9cd3c6ee53bf052 Reviewed-on: https://chromium-review.googlesource.com/c/1257917 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#596576}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 809610 Change-Id: I646b188142ae4695eb7810f8f78bc50fa19417a0 Reviewed-on: https://chromium-review.googlesource.com/c/1259005 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#596575}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b222f495a95b..7f6417f480e7 git log b222f495a95b..7f6417f480e7 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 minyue@webrtc.org Restricting NetEq postpone decoding after expand. Created with: gclient setdep -r src/third_party/webrtc@7f6417f480e7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I13c9b03a83dbd8bcfd5d3633070ccdfbd50ff2a3 Reviewed-on: https://chromium-review.googlesource.com/c/1260311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596574}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/tabs. This CL was uploaded by git cl split. R=erikchen@chromium.org Bug: 809610 Change-Id: Ieba941ac2a7331b9628a1040d641b4c8791c778d Reviewed-on: https://chromium-review.googlesource.com/c/1259003 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596573}
-
Daniel Bratell authored
The new extensions_internals_source.cc code used the same constants as extension_basic_info.cc, and since in some jumbo builds those files compile in the same translation unit, those clashed. This is a quick rename to give the clashing variables unique names to make builds happy again. An alternative solution would be to reuse the variables if they have the same value (the linker will (probably?) merge them anyway so probably no wasted binary size). TBR=dbertoni@chromium.org,rdevlin.cronin@chromium.org Bug: 891788 Change-Id: Ia7342f249c9bb0cdb6697e8be00413879b26d284 Reviewed-on: https://chromium-review.googlesource.com/c/1261104 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#596572}
-
Daniel Bratell authored
Jumbo Mac fyi builder broke when a kStopIcon was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1239010 because the OSX API has a kStopIcon in .../MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Dialogs.h This renames it to kGenericStopIcon to make the builds go again. TBR=jrw@chromium.org,estade@chromium.org Bug: 877702 Change-Id: Id6c675b539f8e3161ef322bf008174ec2911d4be Reviewed-on: https://chromium-review.googlesource.com/c/1261042Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/safe_browsing_private. This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 809610 Change-Id: Ic8dc08fdd58fa73d17afc920df3b1d54d6e88a70 Reviewed-on: https://chromium-review.googlesource.com/c/1257840 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#596570}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/storage. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 809610 Change-Id: I009d132b82772e6139b6728400b5faba101a69ad Reviewed-on: https://chromium-review.googlesource.com/c/1258009Reviewed-by:
-
David Davidović authored
Instead of using base::TimeTicks::Now() to return the current monotonic clock value, use a TickClock instance which can be changed. Create a fake tick clock that advances every time its NowTicks() method is called. Inject this clock to Nigori instances during testing when applicable. Use this for testing whether the key derivation duration metrics (for both PBKDF2 and Scrypt) record exactly the correct duration. Change-Id: Ic3c2d9dafceb53cdc07afe56a69be428abab9a12 Reviewed-on: https://chromium-review.googlesource.com/c/1245725 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596568}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/developer_private. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 809610 Change-Id: Ib6c0e16bf224508f7b7e6a4eae78879766cdae32 Reviewed-on: https://chromium-review.googlesource.com/c/1258983 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
The sync revision is just after merge. The next roll should come just after this CL. BUG=874735 TEST=Build. Change-Id: I4fe902ca404d8dccd6409efb19c5d73104293ef9 Reviewed-on: https://chromium-review.googlesource.com/c/1260422Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596566}
-
Tanja Gornak authored
The InstanceID, provided by GCM will be used in order to identify the Sync commit data to server. The ID is needed for reflection blocking. On the serverside the ID isn't stored, but thrown away once the pipeline identifies where to send the invalidation. BUG=801985, 866453 Change-Id: If13432c30ba6284d5ff685a6ac86d5c399244c74 Reviewed-on: https://chromium-review.googlesource.com/c/939824 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#596565}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/android/signin. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 809610 Change-Id: I6f1d6fcc1e311286e193d7be174fc5cf6687c309 Reviewed-on: https://chromium-review.googlesource.com/c/1258360 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/translate. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 809610 Change-Id: Iad4ab19844ec672459312067de78681b70684765 Reviewed-on: https://chromium-review.googlesource.com/c/1258356 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
This CL allows us to set the cursor positing to inside of the composing text. We need it to implement InputConnection.SetComposingRegion(). It allows an IME to put the cursor position to arbitrary position after setting composing region. Bug: 845079 Test: unit_tests Change-Id: Ib70a67f3b4d78c753205efe6465084f1e69c938b Reviewed-on: https://chromium-review.googlesource.com/c/1258809 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596562}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components/sync. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 890902 Change-Id: I4a816ae8d6a4f164bb11dfe1b8f81e6354cad70d Reviewed-on: https://chromium-review.googlesource.com/c/1257849Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596561}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/login. This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 809610 Change-Id: I5630118ead9379c1dd5cb9ba8aeedcffa8a2e8d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257836 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#596560}
-
