- 10 Aug, 2018 40 commits
-
-
kristipark authored
Pressing enter in the edit link dialog will no longer delete the link. The current event handler was not being called. Bug: 864357 Change-Id: Idbba0cf0a3f9f0afa7dbcf91b49ec45de5c9e144 Reviewed-on: https://chromium-review.googlesource.com/1169763 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582020}
-
akaba authored
This CL updates SurfaceManager::GetLatestInFlightSurface to consider presistent references while computing the latest surface. In addition, it allow GetLatestInFlightSurface to return something other than the fallback in case the FrameSinkIds of the range differ. Bug: 871964 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9f0de1cbb6bbdd10a69f70305a499123b34d7912 Reviewed-on: https://chromium-review.googlesource.com/1166163 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582019}
-
Scott Haseley authored
The emum labels had a mix of "visible" and "active". The page lifecycle state is "active", not "visible". Change-Id: I580f6037464e5a54810170ceddb71ce586901ef5 Reviewed-on: https://chromium-review.googlesource.com/1170177Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#582018}
-
Oystein Eftevaag authored
This enables it for a limited subset of tests to catch any regressions before enabling it for all perf tests, and will only have an effect on Mac/Windows/Android platforms currently. Bug: 839084 Change-Id: Ifcfcaefbbb3be177f9a5941031e48ead60f1fc77 Reviewed-on: https://chromium-review.googlesource.com/1169768 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582017}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/644d8e7175ae..bc6f9c9a8c6b git log 644d8e7175ae..bc6f9c9a8c6b --date=short --no-merges --format='%ad %ae %s' 2018-08-09 herb@google.com Remove GrTextUtil::Paint 2018-08-09 fmalita@chromium.org [skottie] Avoid UB while parsing 1-based indices 2018-08-09 mtklein@google.com in MS land, -include is /FI 2018-08-09 timliang@google.com Reland "implemented GrMtlSampler for metal gpu backend" 2018-08-09 enne@chromium.org Add max_fragment_uniform_vectors_32 workaround 2018-08-09 mtklein@google.com turn on alignment sanitizer 2018-08-09 ethannicholas@google.com fixed early return breaking things in .fp files 2018-08-09 brianosman@google.com Allow any color space when making a picture backed image 2018-08-09 fmalita@chromium.org [skottie] Optimize color filter layerization 2018-08-09 bungeman@google.com Viewer to resize Samples with window resize. 2018-08-09 herb@google.com Remove RunPaint 2018-08-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c43cdad25851..468484201532 (1 commits) Created with: gclient setdep -r src/third_party/skia@bc6f9c9a8c6b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:864564,chromium: 829614 TBR=djsollen@chromium.org Change-Id: I71da299909970ffe5f2ac7fde0bb6d761e7d1abe Reviewed-on: https://chromium-review.googlesource.com/1169667Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#582016}
-
Ned Nguyen authored
NOTRY=true TBR=sadrul@chromium.org, vmiura@chromium.org Bug: 873014 Change-Id: Ie2e2161a36445df755f3414ca484cbfc44e14bf7 Reviewed-on: https://chromium-review.googlesource.com/1170386Reviewed-by:
-
Andrey Kosyakov authored
We accidentally used a CORS fetch() to a resource that dit not allow CORS access in the test, expecting Network.loadingFinished to happen after the resource is loaded. However, with per-message dispatch tasks (https://chromium-review.googlesource.com/c/chromium/src/+/1145692), the request is cancelled before we receive loadingFinished, so we now get loadingFailed with net::ERR_ABORTED instead. Bug: 872081 Change-Id: I9cfd6c8ebc49f1e835916fb87f4d6cea0e4262b1 Reviewed-on: https://chromium-review.googlesource.com/1168185 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582014}
-
Jennifer Apacible authored
This updates the scrim, or the background layer of the controls, based on UX feedback. Bug: 872806 Change-Id: Ieb036815599057b6e0869bf61dee0b811cc42333 Reviewed-on: https://chromium-review.googlesource.com/1168735 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#582013}
-
Dirk Pranke authored
This reverts commit 7e545610. Reason for revert: Speculative revert for crbug.com/872714 Original change's description: > android/asan: Don't depend on llvm version number at test time. > > Instead, copy the runtime to the build dir at build time and find it there > at test time. > > Matches how things work on other platforms with the asan runtime in a shared > library (mac/ios/win). > > This also makes things do the right thing with a custom clang_base_path. > > Bug: 872278 > Change-Id: I930bd88206f973c10eb47bfd2f132e70167235f4 > Reviewed-on: https://chromium-review.googlesource.com/1167465 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581682} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872278 Change-Id: Ie2903e4f2a65dc44abe698f3a26c6d370afd1e89 Reviewed-on: https://chromium-review.googlesource.com/1169933Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582012}
-
Jinsuk Kim authored
There is a timing-related bug in Find in page menu on NTP, which happens when the web contents was already switched to one for NTP but the menu for the action remained available. The actual find toolbar is designed not to appear by checking if the current web contents is for NTP or not. Previously, null check against |tab.getContentViewCore| was enough but after https://crrev.com/c/989515, |tab.isNativePage| should be called as well as |tab.getWebContents|. This CL adds the missing check. Bug: 872650 Change-Id: Ibef4d335cf2dc2a4ceab5b507eb9f08c47e5e946 Reviewed-on: https://chromium-review.googlesource.com/1170142Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#582011}
-
Jennifer Apacible authored
For ChromeOS, ash (window manager), will handle adjusting the window size to adhere to the specified aspect ratio. This change adds a new aura constant to keep track of the window's aspect ratio, if any. This is used in WindowResizer to determine the new window bounds. Bug: 853276 Change-Id: I4c7eaa6252e26ffccf3ac10a4dafd635a3b556d1 Reviewed-on: https://chromium-review.googlesource.com/1164483 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
For now, IDL parser allows to put extended attributes on enum values, that is syntactically invalid in Web IDL spec [1]. In Blink, other IDL compiler parts ignore them, and no IDL files have them. In order to avoid misleading developers, this CL makes IDL parser to disallow extended attributes on enum values. [1] https://heycam.github.io/webidl/#idl-enums Bug: 871867 Change-Id: Ic57406ce3ff94a0c1a4cf38da12b217c05667eb0 Reviewed-on: https://chromium-review.googlesource.com/1169482Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#582009}
-
Ned Nguyen authored
Bug:873013 NOTRY=true TBR=sadrul@chromium.org, vmiura@chromium.org Change-Id: I191cc697f66945c327c2c8a4bdf5ecb1029e041b Reviewed-on: https://chromium-review.googlesource.com/1170359Reviewed-by:
-
Raymes Khoury authored
With Permission Delegation enabled, GetPermissionStatusForFrame should always be used to determine the permission status for an embedded origin. GetPermissionStatus should only be used when there is no frame available (e.g. for UI or in the case of service workers, etc.). Bug: 802945 Change-Id: I45867eb3c3e98be57b48e8c2c3cade6287e9a8fd Reviewed-on: https://chromium-review.googlesource.com/942504 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#582007}
-
David Black authored
Fixes a crash caused by using Assistant before our service side references are fully initialized. Bug: b:112427263 Change-Id: If2845ae4365b005c029d73e113a1989f0f210ef8 Reviewed-on: https://chromium-review.googlesource.com/1169911 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582006}
-
file://static_top_25/yahoonews.htmlNed Nguyen authored
NOTRY=true TBR=vmpstr@chromium.org Bug: 873011 Change-Id: I96ef9604433cd5b03c8a0e51dd124e7d5d0e7999 Reviewed-on: https://chromium-review.googlesource.com/1170357Reviewed-by:
-
Jordy Greenblatt authored
This Behavior will be used by the multidevice settings UI so it should live in a common area. Note that because some files in the folder are used by iOS9 which does not support newer js features, the convention is to use older syntax (such as var instead of let of const). Change-Id: I1bf8a8c99c20322fb43e4c0afe54caf853e5c37e Reviewed-on: https://chromium-review.googlesource.com/1170091Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#582004}
-
Peter Collingbourne authored
This will allow ShellMainDelegate and TestShellMainDelegate to share an implementation of the browser subprocess later. Bug: 855193 Change-Id: Id4ef662bd96b606f19b4ecedda15a8a1bbed979b Reviewed-on: https://chromium-review.googlesource.com/1168647Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582003}
-
Ned Nguyen authored
Bug:872931 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If55c6c7a688e3bc83ebbed972b4c046c1bdb3604 NOTRY=true # CQ flake Change-Id: If55c6c7a688e3bc83ebbed972b4c046c1bdb3604 Reviewed-on: https://chromium-review.googlesource.com/1170088 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#582002}
-
Ted Choc authored
The issue was that when transitioning from a LTR URL to an empty textview the call to ApiCompatibilityUtils.isLayoutRtl(this) would return false in the initial scroll calculation and then true in the subsequent one. To work around this, we need to track the RTL-ness of the previous scroll to ensure it remains the same before we reuse the previous scroll offset. BUG=871147 Change-Id: I2440ffdd56c4ec9f95b01194e2e4f81f2f8bb572 Reviewed-on: https://chromium-review.googlesource.com/1169526Reviewed-by:
-
Becca Hughes authored
Update sound settings string from muted to mute as per spec. BUG=865548 Change-Id: Ib4a349627966995fc8abca36d10937d194f145ae Reviewed-on: https://chromium-review.googlesource.com/1156990Reviewed-by:
-
Khushal authored
Canvas2d uses cc's ImageDecodeCache in at-raster mode, which means the cache internally locks and unlocks images after every draw. If an image should be locked for the duration of a draw, it needs to be managed external to the cache. Avoiding the continous ref/un-ref churn was particularly important with GPU discardable. For this reason, canvas2d keeps images locked uptill a particular budget. The tracking for whether the budget has been exceeded is in the image cache and the information is passed to the CanvasImageProvider in DecodedDrawImage. This was resulting in the issue where for images which can directly be used in raster (bitmaps in sw case), the cache would always indicate them as budgeted so these images were not being released until the end of a canvas frame, causing OOM in certain cases. To fix the above, we could indicate these cases as unbudgeted from the cache but in that canvas the CanvasImageProvider drops all current decodes. The correct fix here would be to kill this locking of images in CanvasImageProvider and instead have the cc cache internally lock images uptill a budget for this use-case. But as a bandaid fix, this change makes it so we never hit the cache for these cases, and the CanvasImageProvider never locks these images if the ScopedDecodedDrawImage doesn't need to be unlocked. Bug: 872117 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I48089d6aa3d1523a3c4d45821c7e307c6ee43c8c Reviewed-on: https://chromium-review.googlesource.com/1169902Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#581999}
-
Wez authored
We previously attempted to include only the SOs listed in the primary executable's ELF headers as NEEDED. This causes SOs needed by other executables in the package to be missed, as well as any libraries used by the executable, but loaded via dlopen() rather than at load-time. Bug: 861931 Change-Id: If72d8007ca7d18674dd28eb310a0a5aa76519516 Reviewed-on: https://chromium-review.googlesource.com/1170179Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581998}
-
Reilly Grant authored
This is a reland of daa348fa Original change's description: > Attach UsbContext to libusb_device(_handle) pointers > > This change modifies ScopedLibusbDeviceRef and adds a new class > ScopedLibusbDeviceHandle. This now explicitly own a reference to the > UsbContext object (which reference counts a libusb_context) in addition > to the libusb_device or libusb_device_handle they are wrapping. > > This resolves potential use-after-frees possible when posting tasks > with a ScopedLibusbDeviceRef since the UsbService the task is being > posted to could be destroyed before the task is executed. The > libusb_device would then be released after its libusb_context has been > destroyed. > > This is based on https://crrev.com/c/1131949 after I realized there > where additional issues that needed to be addressed. > > Bug: 838947 > Change-Id: Idee02828bf615bd477033e585fffe03cf4d20595 > Reviewed-on: https://chromium-review.googlesource.com/1145910 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577329} Bug: 838947 Change-Id: Ibb916b6dea86f05f0b6d2fdfa2d3b71f8c1e8c66 Reviewed-on: https://chromium-review.googlesource.com/1158770 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#581997}
-
David Tseng authored
Bug: 842874,869576 Change-Id: I2cf585a3763a5685c39d30d7f7b35b232e2ed9bf Reviewed-on: https://chromium-review.googlesource.com/1162930 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#581996}
-
Sammie Quon authored
When we reach one third of work area, stop shrinking the overview bounds and instead start sliding it out off screen. Test: added test Bug: 872141 Change-Id: I4d42e5943485c9a4d96205d1a1870823305b49e9 Reviewed-on: https://chromium-review.googlesource.com/1169974 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change unifies the HID input report handling on Windows with the existing logic on Linux and macOS where input reports are continuously read from the device and queued until a request is made to read them. This is necessary on Windows as well because the OS driver maintains a limited ring buffer of input reports and so if they are not read in a timely manner they will be discarded. This is a problem for protocols such as CTAP2 which break a larger message into multiple reports. Bug: 862207 Change-Id: I222e1cb2df8633e0bec77d9a64a9cf91760ba417 Reviewed-on: https://chromium-review.googlesource.com/1168153 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Scott Violet authored
BUG=none TEST=none Change-Id: I5c4566dff3707174b9d5193650e25bee1948631c Reviewed-on: https://chromium-review.googlesource.com/1170167Reviewed-by:
-
Weilun Shi authored
By setting the user select to none, when user double click the collection tile, the tile title will not highlighted. Bug: 869086 Change-Id: Ic3d567c47ad37b442805974fac0097d1f04f5539 Reviewed-on: https://chromium-review.googlesource.com/1170101 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581992}
-
Ned Nguyen authored
A big portion of perf data uploading latency is due to I/O operation (uploading), hence maximize the number of parallel processes to improve the wall-time. Bug:857283 Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 TBR=simonhatch@chromium.org Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 NOTRY=true # android_arm64_dbg_recipe flake Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0 Reviewed-on: https://chromium-review.googlesource.com/1170083 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#581991}
-
Mark Pearson authored
Bug: 871476 Change-Id: I2af8257c540c5b985b2f469f5c473427e6b51329 Reviewed-on: https://chromium-review.googlesource.com/1169947Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#581990}
-
Steven Holte authored
Change-Id: I4475bc903028b12fdf5fec9b47878136bb8c879c Reviewed-on: https://chromium-review.googlesource.com/1159688 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#581989}
-
Hitoshi Yoshida authored
We could not have IDL callback functions in IDL dictionary. This CL makes it possible. Bug: 867875 Change-Id: I156407fcf3e18b6e3a7ca507771fd3f168809c8f Reviewed-on: https://chromium-review.googlesource.com/1152336 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
Switching to Unified Desktop Mode removes all current displays (including primary display) and replaces them with the unified display. The display manager notifies observers of display removals before display additions. At this point if an observer tries to get the primary display, it could lead to a crash because all displays have been removed. This CL fixes this by checking for this condition and returning a fake display with default parameters. BUG=866714 TEST=Manually and added new test that crashes without the fix. Change-Id: Id124884098c66e33136d480b2cb7d3f86d2ff4c1 Reviewed-on: https://chromium-review.googlesource.com/1168598 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581987}
-
Sunny Sachanandani authored
Add "DirectCompositionPreferNV12Overlays" feature flag to use NV12 for creating overlay swap chains when NV12 hardware overlays are supported. Bug: 869677 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I50ad546e1f0e3cdc27a1c3dad74f52d91f6555e6 Reviewed-on: https://chromium-review.googlesource.com/1159838Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#581986}
-
Yuki Shiino authored
Renames existing old Function to CallbackFunctionTreatedAsScriptValue in *.idl so that we can introduce new Function type that is type of |any ()|. Function type is now defined in core/dom/common_definitions.idl, and v8_function.{h,cc} are now code-generated (not yet used though). Bug: chromium:871208 Change-Id: I395c49e5d664cec14ad3b29653b10c4bb000f4fe Reviewed-on: https://chromium-review.googlesource.com/1166931Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#581985}
-
Peter Boström authored
This function is being removed and currently always returns true. While this mode was enabled, the bubble alignment was effectively ALIGN_EDGE_TO_ANCHOR_EDGE and paint type was PAINT_NONE. This change reflects that and cleans up a ton of code to paint and place the arrows that are no longer visible. Since images were only used when paint type was not PAINT_NONE related arrow and shadow images are also removed. Bug: chromium:867557 Change-Id: I22f9abcf55867bebb00d857324fdf6d7aeaccbc3 Reviewed-on: https://chromium-review.googlesource.com/1168108 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Tommy C. Li authored
This is a reland of af3a6bdc31c29746d749ba0ab9e7181c49c11642 Original change's description: > Omnibox Refresh UI: Hide placeholder text when keyword is selected > > Previously, when a keyword was selected, i.e. "Search Yahoo", we would > still show the placeholder text in the Omnibox when unfocused, like: > "Search Google or enter a URL". > > That is plainly not applicable to the selected keyword case. We don't > need to show placeholder text at all when there is a selected keyword, > since the selected keyword label itself gives ample instruction to the > user. > > Bug: 872327 > Change-Id: I84fd06964808554e5c606d2f2f371bea9c44b465 > Reviewed-on: https://chromium-review.googlesource.com/1168506 > Reviewed-by: Kevin Bailey <krb@chromium.org> TBR=krb@chromium.org Bug: 872327 Change-Id: I978f264d1d37b883e6e75b460b923573b01ada61 Reviewed-on: https://chromium-review.googlesource.com/1169931 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581983}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I47c41909035edd1b5424fe8314914692249eca81 Reviewed-on: https://chromium-review.googlesource.com/1170302Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#581982}
-
Miguel Casas authored
This is just a reland of crrev.com/c/1167474; it got reverted due to infra issues (Gerit outage), see crbug.com/872722 and/or https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/YnUEOtzCrzs TBR=fserb@chromium.org Original CL description ------------------------------------------------ This CL simplifies OffscreenCanvasResourceProvider: - Removes the unused member variables |width_|, |height_| and |frame_provider_|. - Removes superfluous method Reshape(). - Forward declares a few data types ISO including files. - Uses early return for easier indenting. This is inspired by junov@'s crrev.com/c/1103011 (in the follow up CL crrev.com/c/1167907 I'll fold OffscreenCanvasResourceProvider into CanvasResourceDispatcher, but it's easier to review in two steps). Bug: 839970 Change-Id: Ic4d3a6002cec32c01e8914a11d3c392981dae8b5 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1167474Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1169829Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#581981}
-
