- 19 Oct, 2020 40 commits
-
-
Christian Biesinger authored
Because flexbox passes in LayoutUnit::Max(), ng_length_utils used that as the minimum block size, so effectively we ignored the aspect ratio. The test was incorrect. See also https://github.com/w3c/csswg-drafts/issues/5406 R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010, 1045668 Change-Id: I2ed30cb6d9539ea82ac5c22b34c45770fa9a60a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479802 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818452}
-
Andrew Grieve authored
Build rules in //build should not reference things outside of //build. java_strings_grd() was breaking this rule, and so I'm fixing it here by moving it to live alongside the other grit() templates. Bug: 1136507 Change-Id: I575c8e6636a86602b8c3eee557ce990e7fa00eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477093Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818451}
-
Andrew Grieve authored
Noticed this when doing binary size review. Bug: None Change-Id: Ic98d5dce26c2574340e86763518099b2cf85c825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484047 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#818450}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..7411aeba4d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie13dae9eb2147b5035f26d913345f6e03a6451f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818449}
-
Ian Kilpatrick authored
Previously we had special logic within ng_absolute_utils.cc which simply checked if we had an element with display:table for some table specific logic. This was incorrect, and should have been checking for the LayoutObject type instead. This caused some incorrect layout of replaced elements when OOF. This patch uses the NGBlockNode::IsTable instead to apply this logic. Bug: 1138851 Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#818448}
-
Monica Basta authored
Bug: 1063856 Change-Id: I718631d454bcd8df2dda8f2d8e55533cb59f2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480566 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818447}
-
Andrew Grieve authored
Likely pretty innocuous, but it's possible a GC could happen between the two weakRef.get() calls. Bug: None Change-Id: I345fac7f72a70cef8aed80a834b47f3514d7f51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477048 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#818446}
-
Illia Klimov authored
Track permission auto-revocation event. Track whether all blocking lists data is loaded before an abusive origin verification started. Track blocking lists data version. UKM review doc: https://docs.google.com/document/d/1TVSMLfnyNusIn6kaAbHL8oBgUnQRj5TYEYa-ikjvTa4/edit Bug: 1134233 Change-Id: I864b224a4098b7fbdf1a2b708b2b15ad61fcd99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443290Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#818445}
-
Titouan Rigoudy authored
These tests might not live very long, depending on the outcome of the related issue: https://github.com/web-platform-tests/wpt/issues/26166. In the meantime, they serve to document the existing spec intent, and hopefully undergird discussions around address space inheritance. Bug: chromium:1138905, chromium:1138906, chromium:1134601 Change-Id: I7d8d0e7cf8e70cfdf3bdc044e748ee384f3418dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475875 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#818444}
-
sandromaggi authored
Bug: none Change-Id: I3e17122036375f5738afdeeee7944bb12b2648c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484599 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#818443}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5118dae088e4..7b572a466a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I34813afdf55a749eac02094a45fc41e13de57f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483916Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818442}
-
Monica Basta authored
Bug: 1089332 Change-Id: I6c699b26f1bb92126552e401f39993441e6d8283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478986Reviewed-by:
-
Viktor Semeniuk authored
Since new Passwords Details screen is used test should no longer fail. Bug: 1109644 Change-Id: I391ed31618ef69b5913e50b449dee50e5da1ad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476275Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#818440}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/efd1e44d0df7..16b862bdf547 2020-10-19 aerotwist@chromium.org TypeScriptify LighthouseStatusView 2020-10-19 alexrudenko@chromium.org Enable TypeScript for NetworkPriorities.js 2020-10-19 sigurds@chromium.org Display isolation status in FrameDetailsView 2020-10-19 pfaffe@chromium.org TypeScriptify PresentationConsoleMessageHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43622e2f4573b0d26c86c337bb4f685faa03d78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483917Reviewed-by:
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484717 R=sigurds@chromium.org Bug: 1011811 Change-Id: Ibbd4a5a822d4f06fca89cbdf9376127a6ce30327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484702 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818438}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e706198..94e1f5b2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cbf5ba9dfa4de01f5f563957271b57991fa78e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484283Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818437}
-
Andrew Shulaev authored
Change-Id: I23657194899a2258e39596056b03a53b2082aa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403484 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818436}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f7eab68c0ce..1253aea08e5f 2020-10-19 mbonadei@webrtc.org Revert "Reland "Remove placeholder Obj-C headers and use angle-bracketed headers."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c116a8e936e7fb25942e47a133f3b7d2de672d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484310Reviewed-by:
-
Antia Puentes authored
This CL migrates the legacy IPC message out of view_messages.h to {Local,Remote}MainFrameHost mojo interfaces from Blink. The ViewHostMsg_Focus IPC method has been migrated both into the LocalMainFrameHost and RemoteMainFrameHost interfaces, and Blink will route the message through the correct channel depending on whether the renderer's main frame is a LocalFrame or a RemoteFrame. ChromeClient calls to WebView to send the message, previously this went through the RenderView. Method TakeFocus has been added to the WebView and methods Focus{Next/Previous} were removed from the RenderView and WebViewClient. Bug: 1135180 Change-Id: I6ac1ac344b9863ad685abca369ad14997b27be0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475116Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/master@{#818434}
-
Kushagra Sinha authored
EduAccountLoginHandler currently uses |signin::ConsentLevel::kSync| for fetching the account to be used for initiating the parental reauth in EDU co-existence flow. Since this account is guaranteed and must be the Device Account, we should use that regardless of Sync consent status. Fix this by supplying |signin::ConsentLevel::kNotRequired| while fetching the access token for the Device Account in EduAccountLoginHandler. Bug: 1123844 Change-Id: I002f20b754dc63378a4b1b086efbf8cd6b7b3485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484698Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2320bb8402d66f17f78b5edf68118efe29ca1abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484313Reviewed-by:
-
Fabian Sommer authored
Add two policies that govern behavior for users that authenticate with a security token (e.g., smart card) and remove it while in session. One policy determines what happens then (nothing/logout/lock), the other determines if and how long a notification of this appears. Add SecurityTokenSessionController that monitors those two policies. Actual behavior (such as displaing the notification or locking a session) will be implemented in follow-up CLs. Bug: 1131450 Change-Id: Ibb7827010b1d6af4127406afe61b261e234b7326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426044 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818431}
-
Julie Jeongeun Kim authored
As blink::mojom::ResourceType is deprecated[1], this CL replaces |resource_type_| with |request_destination_| in AppCacheRequestHandler. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I83c4ab2b35c84aad06aab2d79afb6ff83f5d8005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476696 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#818430}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c69ef8bf34ca..e2e37e74709f 2020-10-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7e36b15b to 7501f245 (405 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id5e229b50896b53d4f52488f4b485130697441e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484733Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69e28b68cab8..efd1e44d0df7 2020-10-19 tvanderlippe@chromium.org Remove unstable native heap sampling experiment 2020-10-19 pfaffe@chromium.org TypeScriptify StylesSourceMapping 2020-10-19 pfaffe@chromium.org TypeScriptify DefaultScriptMapping 2020-10-19 tvanderlippe@chromium.org Move remaining legacy files to GN 2020-10-19 alexrudenko@chromium.org Enable TypeScript for TimelineProfileTree.js 2020-10-19 pfaffe@chromium.org TypeScriptify NetworkProject 2020-10-19 alexrudenko@chromium.org Partially revert 'Fix snippet saving and search' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1043121,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icacc1f1a877e687fb027489c5a19c476f6fefa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484731Reviewed-by:
-
vitaliii authored
This was not obvious on the server and led to a confusion. Happy to provide more details in a private discussion. Change-Id: I7214daf5ae0daa7e5213a921846cde0c5c49bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484693 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818427}
-
Omid Tourzan authored
Removing on_removable_device check from validation in the private API as it's not a reliable check. The removable attribute is read from device by inquiry command [1] and it is false for some devices like removable hdd disks, while they are removable. Also on_boot_device removed as cros-disks server filter out boot devices when populating the list of allowed disks. The new validation still complies with the checks in the cros-disks server (isDeviceAllowed). [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/kernel/upstream/drivers/scsi/scsi_scan.c;drc=c5a9707672fe22865d90fc04ac2fbc4f812666f3;l=813 Bug: 1138076 Change-Id: I66546c26bff766610458e58f7d6dfcda422d2d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483983 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#818426}
-
Denis Kuznetsov authored
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#comment-style Bug: None Change-Id: I50a61322104233b1ef358e5fff90be4262ccbc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484792 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818425}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2475720 R=sigurds@chromium.org Bug: 1011811 Change-Id: I8e17d4863f17398f153d39d4b72e4e7d434098eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484692 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Roberto Moura authored
Move kBVCHeightTabGrid (height of the BVC that remains visible when the tab grid is visible) to the grid constants file. Correct the Thumb Strip Layout top section inset value that was wrong. Increase the Grid Layout bottom section inset to account for the BVC on the bottom of the screen. Correct the Tab Grid's bottom content inset by increasing it by the same amount that the top content inset was decreased. Bug: 1127604 Change-Id: I843d74f7ade7272f032211162a0bca9054602dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479467 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8216043b1fc4..5118dae088e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I0ea95372bd71531840810b95557b7d00f00408e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484331Reviewed-by:
-
Peter E Conn authored
TBR=wychen@chromium.org Change-Id: I8aa9ab8128a2f5b3144bd1a0fc48f90ea4fc5389 Bug: 1139807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484443Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#818421}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I13e054fb89896cf33aa7be5c043a0f6a9418938c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463616Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818420}
-
Wolfgang Beyer authored
frontend CL: https://crrev.com/c/2475716 re-enable tests CL: https://crrev.com/c/2478991 Bug: chromium:1011811, chromium:1138492 Change-Id: I8caa074b87593e4f7538bd9aef0133f7467e416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479366Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818419}
-
Morten Stenshorne authored
This is a continuation of tkent's work in https://chromium-review.googlesource.com/c/chromium/src/+/2397378 The sub-directories of Blink core depend on each other, and we don't intend to make independent libraries for each of them. We want a single library containing everything. Currently we have build targets in each of them, and it's very difficult to declare their dependencies correctly in BUILD.gn due to the massive amount of circular dependencies. The new approach which this CL introduces: * A core sub-directory doesn't need BUILD.gn in most cases. * It should have build.gni instead, and build.gni should define source lists. * core/BUILD.gn refers to the lists. All dependencies will also be declared here, since there's no way to determine if a sub-directory has successfully declared all necessary dependencies (since it's part of one big target now). * Some of core sub-directories apply optimization flags different from others. core/BUILD.gn has 'core_hot' target for them. There are still a handful of sub-directories under renderer/core/ that have a BUILD.gn file, because they have special build flags or special targets. We might want to get rid of those eventually as well. typed_arrays/BUILD.gn is kept because it has no difficult dependencies, so it deserves to be a target on its own. Bug: 800764 Change-Id: I92cd5bac949fe4c541f21131309cfc66743edb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463919Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818418}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForEndOfLine()| to use first or last item in line instead of hit-testing at inline end offset[1] of line box to handle hanging spaces[2] and position:relative[2], numerical saturation in line box size, e.g. width:1e10, correctly. [1] inline end offset: right-bottom offset for horizontal writing mode with left-to-right direction. [2] hanging space: Spaces at end of line not counted for line size https://drafts.csswg.org/css-text-3/#spaces [3] position:relative items can be outsize of line box or any point in line to place first item at last item. Bug: 1136740 Change-Id: I32e46d88617a870944b56f72796902968b216583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467046Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818417}
-
Frédéric Wang authored
When a service worker intercepts a page that is later registered as a handler for a custom scheme via navigator.registerProtocolHandler, and if one clicks a link with this custom scheme, then the service worker is only able to intercept the page after reload. This CL fixes that bug by allowing the service worker to intercept the page after registering the custom scheme. A new browser unit test is added to verify this fix. This also makes the following manual WPT tests pass (*): protocol-handler-fragment-manual.https.html protocol-handler-path-manual.https.html protocol-handler-query-manual.https.html (*) https://w3c-test.org/html/webappapis/system-state-and-capabilities/the-navigator-object/ Bug: 522370 Change-Id: I95eda9025885838665e9735ac9f47a3d65d89aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379672 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818416}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd534e877e72..502e98295625 2020-10-16 afdx@google.com spirv-fuzz: Fix to TransformationInlineFunction (#3913) 2020-10-16 afdx@google.com spirv-fuzz: Wrap early terminators before merging returns (#3925) 2020-10-16 jaebaek@google.com Add DebugValue for function param regardless of scope (#3923) 2020-10-16 afdx@google.com Temporary fix to make GoogleTest compile. (#3922) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I5dd3fb19e37d70be1c87c20f73ae61fb38cd9f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484327Reviewed-by:
-
chrome://cryptohomeYi Chou authored
BUG=b:155063317 TEST=Build ok. TEST=open chrome://cryptohome and check the permission Cq-Depend: chromium:2460975 Change-Id: I81aa0ba7a899d63a62528a7d0592132d9e2d8908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461977Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#818414}
-
Reda Tawfik authored
This CL allows keyboard accessory icons to be always shown on username fields if AllPasswordsBottomSheet is enabled. Bug: 1133351, 1104132 Change-Id: I835481caa89d8fc0823f7e00f11375d7729485c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438396 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818413}
-
