GitLab

There's some speculation that MainThreadFreezeDetector is catching too
many hangs that eventually recover, especially on change from foreground
to background.  If a hang report is generated, but the app recovers,
return early before |reportGenerated| can be set.


Change-Id: Ib4a4f9b1db44eeb42ce15da7f312f4df0033e401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536386
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833884}

Bug: 1150634
Change-Id: I84ad38c9eb8af368c0c34ba56305da0088d121ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568364
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833883}

The tasks on shutdown are not scheduled if not mark as "BLOCK_SHUTDOWN".
This behavior leads FileTraceDataEndpoint object into an inconsistant
state since its assumes tasks are executed to close the endpoint.

The following stackframe shows the problem:

[26692:22732:1204/131653.908:ERROR:tracing_controller_impl_data_endpoint.cc(68)] FileTraceDataEndpoint: c:\src\chromium\startup.json
[26692:21808:1204/131719.958:ERROR:tracing_controller_impl_data_endpoint.cc(102)] OpenFileIfNeededOnBlockingThread!
[26692:22732:1204/131735.498:FATAL:tracing_controller_impl_data_endpoint.cc(86)] Check failed: file_ == nullptr.
Backtrace:
        base::debug::CollectStackTrace [0x00007FF87DAE24B2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:303)
        base::debug::StackTrace::StackTrace [0x00007FF87D9D6AE2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:195)
        logging::LogMessage::~LogMessage [0x00007FF87D9F2C94+148] (C:\src\chromium\src\base\logging.cc:566)
        logging::LogMessage::~LogMessage [0x00007FF87D9F3B80+16] (C:\src\chromium\src\base\logging.cc:559)
        content::`anonymous namespace'::FileTraceDataEndpoint::~FileTraceDataEndpoint [0x00007FF8603C5A50+96] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl_data_endpoint.cc:86)
        content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C1B88+114] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206)
        content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C3F20+16] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206)
        content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD41EA7+295] (C:\src\chromium\src\content\browser\browser_main_loop.cc:549)
        content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD46480+16] (C:\src\chromium\src\content\browser\browser_main_loop.cc:545)
        content::BrowserMainRunnerImpl::Shutdown [0x00007FF85FD476B8+312] (C:\src\chromium\src\content\browser\browser_main_runner_impl.cc:193)
        content::BrowserMain [0x00007FF85FD41935+213] (C:\src\chromium\src\content\browser\browser_main.cc:52)
        content::RunBrowserProcessMain [0x00007FF8609437C8+104] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:520)
        content::ContentMainRunnerImpl::RunBrowser [0x00007FF86094469D+1005] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:1008)
        content::ContentMainRunnerImpl::Run [0x00007FF860944289+457] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:888)
        content::RunContentProcess [0x00007FF860943295+1573] (C:\src\chromium\src\content\app\content_main.cc:372)
        content::ContentMain [0x00007FF86094338D+61] (C:\src\chromium\src\content\app\content_main.cc:398)
        ChromeMain [0x00007FF84BD11225+389] (C:\src\chromium\src\chrome\app\chrome_main.cc:133)
        MainDllLoader::Launch [0x00007FF749A926B5+391] (C:\src\chromium\src\chrome\app\main_dll_loader_win.cc:169)
        wWinMain [0x00007FF749A91ADF+2783] (C:\src\chromium\src\chrome\app\chrome_exe_main_win.cc:345)
        __scrt_common_main_seh [0x00007FF749B89926+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
        BaseThreadInitThunk [0x00007FF8BF304034+20]
        RtlUserThreadStart [0x00007FF8C0913691+33]

R=gab@chromium.org, eseckler@chromium.org, fdoray@chromium.org

Bug: 1082916
Change-Id: I715d13e47de44c974a80ee80bec0f44639691786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575257Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833882}

Dead code will be removed in follow-up CL.
https://chromium-review.googlesource.com/c/chromium/src/+/2567093

BUG=b:174506130

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I60505ad3ceb2bec51486b28271bcf96811c1c3e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567255Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Rachel Wong <wrong@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833881}

https://skia.googlesource.com/skia.git/+log/db873dd600c3..bc3c41b8742a

2020-12-04 johnstiles@google.com Enforce that layout(binding=...) is set on interface blocks in Metal.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: westont@google.com
Change-Id: Id4c5b1d11db9c94b116c86b6dcea09241394e7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575109Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833880}

No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and
BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in
/android_webview.

The methods themselves will be removed in a follow-up CL once all call
sites have been removed.

This CL was uploaded by git cl split.

R=boliu@chromium.org

Bug: 1106920
Test: autoninja -C out/Default monochrome_public_apk
Change-Id: I7c772186e1d54f5e4e6e2b36aaa08ca350124bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575326
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833879}

Recent changes made it so these fixture methods must be called, even
from derived test fixtures. This adds logic that ensures they are called
and fixes the various derived test fixtures that weren't calling the
superclass methods.

Change-Id: If85d104427b86087c13111a08fcce8578512138b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563701
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833878}

This change extends support for running a PWA at OS login to linux.
ChromeOS is not supported with this change.

The change adds Linux to the support about:flags page, allowing users
to control at both installation time, and from chrome://apps page if
an application can run at login.

To run an app at login, a '.desktop' file needs to be created
in the autostart folder. This change extends the existing code to
support the 'ShortcutLocations.in_startup' field.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md
I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ

Bug: 897302
Change-Id: I7e82c4971018a2fb9d92210f96273bc43282ccc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524536Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#833877}

This reverts commit 9b53f52e.

Reason for revert: Causing server pipeline breakage

Original change's description:
> Migrate U-Z histograms to patterned histogram syntax
>
> This is part of a migration that replaces the old
> <histogram-suffixes> syntax that was used to denote groups
> of histogram to the new patterned histogram syntax.
>
> Bug: 758782
> Change-Id: I6cde5e15fb8d43b58006569ca01cab5765fb79e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552631
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: Karthika Pai <karthikapai@google.com>
> Cr-Commit-Position: refs/heads/master@{#832494}

TBR=isherman@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,karthikapai@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 758782
Change-Id: I1e6f202496d6bf30f18828ddb8a1ba2647f2eec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574779Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833876}

The View destructor ends up in an impossible state which means that
execution must have branched to the middle of it, but it is not clear
how this could happen. This change adds an array of line numbers that is
filled in as the destructor runs to leave us some bread crumbs. It also
records the vtable of the about-to-be-deleted child object so that we
can investigate if this is a type-related bug.

Bug: 1152152
Change-Id: I386507974a8b6ccd1914e0ec62151456411f0c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572793
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833875}

Pointer Lock Options are launching in 88. The flag should stay for many
more cycles to allow users and developers to turn it off for any reason.

Bug: 982379
Change-Id: I6751b3a400a723540d773e682436890986596e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575052
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833874}

This change fix the Linux build crash caused by a DCHECK in
MetricsRecorder::OnConnectionStatusChanged()

Bug: 1106937
Change-Id: Id8b1f7f5c0bd414fa55b44234994e9c815e77750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574622Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833873}

This test broke on mac-arm64 between  r833059 and r833159. It will be
re-enabled as part of fixing the linked bug.

Bug: 1154345
Change-Id: I17ffe033b1e1541a62b0ba5d0b4c5ae4670522e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572998Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833872}

Change-Id: I65a4017b1b810d9deb0594e6fc63fdf3d89d30fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575050Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833871}

1. Refactoring `NGGridLayoutAlgorithmTrackCollection::SetIterator` to
   allow callers access to the iterator from a const reference/pointer
   to the collection; this change improves the `NGGridLayoutAlgorithm`
   implementation since previously we were not able to pass const
   references to an algorithm track collection as an input parameter
   (because of the non-const restriction imposed by `SetIterator`).

2. Refactoring use of `GridTrackSizingDirection` into track collections;
   several methods in `NGGridLayoutAlgorithm` received both, track
   collection and its respective direction, as parameters. Since the
   direction is already tied to the specified collection, this change
   moves the `GridTrackSizingDirection` into the collection class.

Bug: 1045599
Change-Id: Ibbc7d2d93c5947106b0fe627d67dce2fb24916f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573889Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#833870}

Bug: 1154655
Change-Id: I1ef25adf8a1211599ff856444af43e2a22683db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566944Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833869}

This reverts commit becee7ed.

Reason for revert: Spike on M88 - most likely caused by https://crbug.com/1151008 and https://crbug.com/1151438

Original change's description:
> Enable |request_initiator_site_lock| enforcement on Android.
>
> The "RequestInitiatorSiteLockEnfocement" feature is enabled on desktop
> platforms in M87, because we want to be more careful on Android, since a
> mojo::ReportBadMessage might lead there to renderer kills (if
> NetworkService is hosted in the Browser process, something that never
> happens on desktop platforms).
>
> Since the M87 data so far looks good so far [1], this CL enables the
> enforcement on all platforms for M88.
>
> [1] https://docs.google.com/document/d/132ZPqDZdH-rcvBvHEAd-m86P2udVCi07ccnI0DXmJgE/edit#
>
> Bug: 920634
> Change-Id: I5f27d9402b3e60668305312aa437252554890bc8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465803
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816410}

TBR=yhirano@chromium.org,lukasza@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 920634, 1151008, 1151438
Change-Id: I7b2157914d8a091d21ce55bfc108c3029a4ff4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575358
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833868}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d21a8fb4dbe..d5886280043b

2020-12-04 kimanh@chromium.org [LMI] Add keyboard navigation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1110202
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0ff8b952e24706d02013581a642f57b258db7b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575439Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833867}

metadata from OWNERS files in the next repos:
//components/cast...
//components/certificate..
//components/chrome_cleaner
//components/client...

Bug: 1113033
Change-Id: I67561c5b8a8796ca6307fd088855d24ac089e317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564389
Auto-Submit: Norman Rosas <normando@google.com>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#833866}

Open Screen does not end the Cast Streaming session on MessagePort
disconnect. This change ends the session on the receiver end when the
Cast Streaming MessagePort disconnects.
This is a necessary change to unit test the Cast Streaming Receiver.

Bug: 1110490
Change-Id: I272da7bad03c5f7efa31d3a8eb30f3ebdfe49f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572167
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833865}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I4fd38346d19724d48a07aa5e9f87749f775bc4c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575576Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833864}

When the VaapiVideoDecoder was released, if it was using the CdmContext
it would have a callback associated with the CDM. Upon destruction of
the decoder, that callback would be destroyed automatically which makes
a call into the CDM.  The CDM is being destructed on another thread, so
there was a race and this could cause a crash.

The fix is to maintain a CdmContextRef in the decoder which keeps the
CDM alive until the decoder is destroyed.

BUG=b:153111783
TEST=Page refresh 10 times in a row w/ CDM did not crash

Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833863}

This CL fixes issues I missed while reviewing
https://crrev.com/c/2467899.

* Use base::SequenceChecker instead of making thread-hostile checks. The
  quota client doesn't need to run on the IO thread, it just needs to
  run on the same sequence as NativeIOContext.

* Replace the deprecated DISALLOW_COPY_AND_ASSIGN() macro with deleted
  copy constructor and assignment operator.

* Remove qualifier (storage::QuotaClient::) from QuotaClient callback
  types. This reduces churn when QuotaClient becomes a mojo interface.

* Remove unused GetClientTypeFromOwner() declaration.

* Remove self-#include in header.

No functional changes are introduced.

Bug: 1137788, 1016065
Change-Id: I34f59e128e877358d16f197bc6e6f0ac79de5df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570318
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833862}

Interstitial pages no longer work as overlays, they are just regular
error pages. This makes the PAGE_TYPE_INTERSTITIAL value in PageType
obsolete, therefore this CL removes it from the codebase.

Bug: 1077074
Change-Id: I9487bc97018b0f832f6d5b70cda04ea217bc8031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570126Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833861}

https://pdfium.googlesource.com/pdfium.git/+log/46df5d14ee80..30f45a6f043f

2020-12-04 vmiklos@collabora.co.uk Add FPDFAnnot_GetLine() API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I61ab716e018bcbe36948826e03a1f6596e575e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575219Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833860}

This change is the beginning of the implementation of the
integration test system for the desktop PWA system.

Design doc:
https://docs.google.com/document/u/1/d/1Gd14fjwA4VKoRzL2TAvi9paXwyh36ehlS4gbpUmUeeI/edit#

Bug: 1145240
Change-Id: Iaa6f7620e40d137ab8e771446bcead23ad7f93ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536138Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Auto-Submit: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833859}

This CL changes the last_mod parameter to use base::Time and renames
it to be last_modified.

It also updates all the callsites, with no functional change, just a
cleanup.

Bug: 1022775
Change-Id: I8c82d11727c20bfddff42342500f905149a468a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575043
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833858}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d5148db386ce..bbb828223e9c

$ git log d5148db38..bbb828223 --date=short --no-merges --format='%ad %ae %s'
2020-11-25 jonathan.wright Update libjpeg-turbo to v2.0.90 (2.1 beta1)

Created with:
  roll-dep src/third_party/libjpeg_turbo

This CL also updates our expected test results to reflect the
modified block-smoothing algorithm in the libjpeg API library,
introduced in libjpeg-turbo 2.0.90 (2.1 beta1.)

Bug: 922430
Bug: b/135180511
Bug: 919548, 1145581
Change-Id: I156c67564f783362634d02551336c5e1cd9e47b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564483
Commit-Queue: Jonathan Wright <jonathan.wright@arm.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Cr-Commit-Position: refs/heads/master@{#833857}

It's failing with "not supplied via -var or -varsfile" errors, which
are a KI when running tast tests on Chrome bots.

This disables the test while we work on supporting these types of tests.

No-try'ing to speed up LKGM updates.

No-try: True
Bug: 1115622
Change-Id: Ia6d7e42ee9f8321bda920bf958feac1de758f029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575372
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833856}

This is the list of directories excluded from presubmit checks
for base::Bind, base::Closure, and base::Callback.

Bug: 1007788
Change-Id: Iea98671c4fcaeab39697429fd7526cae0ad2da5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575196Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833855}

and  removed duplicated metadata from OWNERS files

Bug: 1113033
Change-Id: I2e78b4bef26a6448cffb9d0bb0c9aec8c6ef1574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573129Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#833854}

This CL adds all possible Android locales and those in l10n_util to the
CL3DLanguageCode enum values.

Bug: 1133736
Change-Id: Ie7a2f4a0d8ffe52c8fe88157e8df41020afa2bb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569853
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833853}

 - cpu_profiler_->StartProfiling() now returns a status enum, of either kStarted, kAlreadyStarted, or kErrorTooManyProfilers.
This change throws an exception and returns a nullptr when either kAlreadyStarted or kErrorTooManyProfilers is returned

R=acomminos@fb.com, npm@chromium.org, petermarshall@chromium.org, ulan@chromium.org

Change-Id: Ie9c6df3c836119064c30fffc54ee7f21f34d9eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549465Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Nicolas Dubus <nicodubus@fb.com>
Cr-Commit-Position: refs/heads/master@{#833852}

Bug: None
Change-Id: I3473e5798ea1b790a22adecd033777637aca023b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574829
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833851}

In PaymentUiService, the way to get the selected payment app is through
mPaymentMethodsSection, in spite of the fact that
getSelectedPaymentApp() is available. This CL is to replace these
mPaymentMethodsSection usages with getSelectedPaymentApp(). This will
help moving the payment app management logic out of PaymentUiService.

Bug: 1155614
Change-Id: I870d9b24f3cc78e007817c7b67bf9ca0639ccf34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574598
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833850}

TBR=govind@chromium.org

Change-Id: Ibd5feccf0a802824695a4165252d501b43d2feaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575338Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833849}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome/browser/extensions.

Bug: 1113033
Change-Id: I7bbea659093e20086f9ac7eca7419cd50129b061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572786
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833848}

This CL adds PaymentUiService#showShippingAddressError() to encapsulate
the UI logic so as to simplify the boundary between the UI and the
business logic.

Bug: 1155582
Change-Id: I144785eb833da259a6752f2f20d193f5f61c2e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572909
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833847}

Bottom controls UI was enabled only on tabbed chrome UI but
a bug in https://crrev.com/c/2567077 caused it to run for
other UI modes as well. This CL partially reverts the changes
in the CL and let the root ui coordinator for tabbed mode
handle the initialization again.

Bug: 1154485, 1142286, 1154582
Change-Id: I834958fd6d3e620d928064a800c2499bb0deba6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569435Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833846}

This change updates the field_group of all the internal forced colors
properties to "*" to ensure that they are all stored in a rare data
structure.

Bug: 970285
Change-Id: Ibfdac0b40980824e79eab51f9f42e807d94eda97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566691Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#833845}