GitLab

Re-introduce screen manager

BUG=231331
R=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/539483002

Cr-Commit-Position: refs/heads/master@{#293507}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/546743002

Cr-Commit-Position: refs/heads/master@{#293506}

While working on issue 410276, in particular in
https://codereview.chromium.org/542733002/ , I had to update the
tracing cache backend. Why? Does anyone use it?

Let's remove it instead.

R=pasko@chromium.org,clamy@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/544923002

Cr-Commit-Position: refs/heads/master@{#293505}

BUG=400684

Review URL: https://codereview.chromium.org/451633007

Cr-Commit-Position: refs/heads/master@{#293504}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=408985,409110,409138

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan

Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#293503}

This should hopefully fix
BUG=410839
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/540313002

Cr-Commit-Position: refs/heads/master@{#293502}

These attributes are gone:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container

Blink: https://codereview.chromium.org/541943003/

BUG=404982
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/544023002

Cr-Commit-Position: refs/heads/master@{#293501}

This is required for CL, https://codereview.chromium.org/456413002, to run webkit_unit_tests on android.
In subsequenct CL from blink side, https://codereview.chromium.org/542003002, we should extend the android.py to start sending this file to the
device under test.

R=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/544903003

Cr-Commit-Position: refs/heads/master@{#293500}

The name is used to retrieve a service from a ServiceProvider.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/540913003

Cr-Commit-Position: refs/heads/master@{#293499}

This change completes the removal of package_name from
build/java_apk.gyp and removes it from all the places
which still refer to it.

'package_name' used to be how you specified the intermediate
directory when building an APK. Now we use the target name and
includers no longer need to set the intermediate directory
explicitly. However one use in java_apk for setting additional
resources files seems to have crept through the refactoring.

BUG=405963

Review URL: https://codereview.chromium.org/487223003

Cr-Commit-Position: refs/heads/master@{#293498}

When the last profile is deleted, a new one is created automatically.

BUG=410008

Review URL: https://codereview.chromium.org/532963004

Cr-Commit-Position: refs/heads/master@{#293497}

My idea was that the histogram could show if we do a very large number of short
calls and how the length of the streams are related to the length of
AudioTracks. If so, we might have issues in WebRTC clients or in how we
create/destroy the input streams.

BUG=405449
TEST=Manual testing using WebRTC clients.

Review URL: https://codereview.chromium.org/537573002

Cr-Commit-Position: refs/heads/master@{#293496}

Move the include of the Mac TargetConditionals.h file to after we've
checked if we're building for Android. Apparently this file doesn't
exist on all macs used to build android and the rest of android builds
fine without it, so including it there causes the build to fail. It
appears to only be used to test TARGET_OS_IPHONE which will never be
true on android.

BUG=

Review URL: https://codereview.chromium.org/538563002

Cr-Commit-Position: refs/heads/master@{#293495}

The method will be called from FileSystemURLRequestJob class to redirect requests for the drive hosted documents.

BUG=367027
TEST=manually; Add the method call to FileSystemURLRequestJob and open FileSystemURL in browser tab.

Review URL: https://codereview.chromium.org/527773003

Cr-Commit-Position: refs/heads/master@{#293494}

Move content_settings_pattern and content_settings_pattern_parser to the content_settings component.

BUG=387079
TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/518803009

Cr-Commit-Position: refs/heads/master@{#293493}

BUG=404012,410798

Review URL: https://codereview.chromium.org/545433003

Cr-Commit-Position: refs/heads/master@{#293492}

https://skia.googlesource.com/skia/+log/26abcf10a4994a0bb13a074d79baa85cd8d67b2c..7675fb23a0448448662567bf1d100e39bf7b5e65

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/542093002

Cr-Commit-Position: refs/heads/master@{#293491}

If the request is a force refresh (shift+refresh) the request should not be handled by the ServiceWorker.
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-controller

Currently we are checking LOAD_BYPASS_CACHE flag of net::URLRequest in ServiceWorkerControlleeRequestHandler::MaybeCreateJob().
But this flag is set not only when shift+refresh but also when devtool's "Disable cache" is checked.

To distinguish them, I added skipServiceWorker flag to blink::WebURLRequest and blink::ResourceRequest in https://codereview.chromium.org/527703002/.

This cl changes the follwings
- Introduce skip_service_worker flag to content::RequestExtraData and ResourceHostMsg_Request.
- Remove the check of LOAD_BYPASS_CACHE in ServiceWorkerControlleeRequestHandler::MaybeCreateJob().
- Check skip_service_worker flag in ServiceWorkerRequestHandler::InitializeHandler() and call provider_host->SetDocumentUrl() when the request is main resource request.

TEST=none
BUG=402093

Review URL: https://codereview.chromium.org/527713002

Cr-Commit-Position: refs/heads/master@{#293490}

They are |display_name|, |avatar_url| and |federation_url|.

BUG=400674
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/520583003

Cr-Commit-Position: refs/heads/master@{#293489}

https://chromium.googlesource.com/chromium/blink/+log/9a051c526402aedfa6bc73e6699838c777b679cf..e76e0d3c27477b816754225fcdbcae5c79f6940f
TBR=arv@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/547573002

Cr-Commit-Position: refs/heads/master@{#293488}

Event::flags() contains all the buttons that are being held down during the event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the event (and this is what we really are interested in).

This fixes the issue with LMB being pressed while RMB is being held down. Without the fix, we always get blink::WebMouseEvent::ButtonRight in blink::WebMouseEvent::button.

Review URL: https://codereview.chromium.org/302593002

Cr-Commit-Position: refs/heads/master@{#293487}

Instantiation of OwnerKeyUtil is delegated to OwnerSettingsServiceFactory, as we're going to move as much as possible from OwnerSettingsService to components/ownership/* and because OwnerSettingsServiceFactory should do all platform-specific business.

BUG=398856
TEST=existing browser_tests and unit_tests

Review URL: https://codereview.chromium.org/516243002

Cr-Commit-Position: refs/heads/master@{#293486}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/526303003

Cr-Commit-Position: refs/heads/master@{#293485}

Allows navigation requests to be canceled before they are committed when they become stale.

BUG=397998

Review URL: https://codereview.chromium.org/475783002

Cr-Commit-Position: refs/heads/master@{#293484}

BUG=410824

Review URL: https://codereview.chromium.org/537993002

Cr-Commit-Position: refs/heads/master@{#293483}

BUG=408431

Review URL: https://codereview.chromium.org/537123002

Cr-Commit-Position: refs/heads/master@{#293482}

Autocomplete: Fix a typo that flipped the extension keyword provider check for enabling in incognito mode.

This is deliberately kept small for easy merging.

BUG=409705

Review URL: https://codereview.chromium.org/537283002

Cr-Commit-Position: refs/heads/master@{#293481}

BUG=402800

Review URL: https://codereview.chromium.org/519643002

Cr-Commit-Position: refs/heads/master@{#293480}

Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui, and webkit.

TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/529273002

Cr-Commit-Position: refs/heads/master@{#293479}

BUG=399186

Review URL: https://codereview.chromium.org/491263002

Cr-Commit-Position: refs/heads/master@{#293478}

BUG=409490
TEST=manually

Review URL: https://codereview.chromium.org/528263002

Cr-Commit-Position: refs/heads/master@{#293477}

This patch conveys more information about frame timings to Blink.
Specifically it adds the current deadline by which work should be
finished as well as the expected interval between frames. The
Blink scheduler will use this information to schedule lower priority
work.

We also notify Blink when a committed frame actually got composited,
which means the current frame is done and lower priority work can be
started immediately (i.e., before the scheduled deadline).

BUG=391005

Review URL: https://codereview.chromium.org/521613002

Cr-Commit-Position: refs/heads/master@{#293476}

The embedder was initialized in the constructor of CoreImpl. This is not
correct, because when it will be used in Chromium, the embedder is
initialized by the native code.

This remove the initialization from CoreImpl. Instead, for tests,
initialize it when loading the native library.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/544603002

Cr-Commit-Position: refs/heads/master@{#293475}

 * Don't count demoted dirty tracker as pending.
 * Notify observer of service state update when the initialization is completed.

BUG=410675

Review URL: https://codereview.chromium.org/537883002

Cr-Commit-Position: refs/heads/master@{#293474}

properly  with invalid server's originator_cache_guid and
originator_client_item_id.
It checks UpdateBookmarkPositioning works fine.

BUG=
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/533113002

Cr-Commit-Position: refs/heads/master@{#293473}

The progress bar of sync status in Desktop Notification is not updated
due to issue 400636.

BUG=408931
TEST=manually
1. Copy local file to Drive
2. Start sync
3. Close Files.app
4. Observe the Notification

Review URL: https://codereview.chromium.org/543973003

Cr-Commit-Position: refs/heads/master@{#293472}

Condition variables should be signaled inside the critical section.
cf) http://www.chromium.org/developers/lock-and-condition-variable#inside

BUG=None
TEST=Ran trybots.

Review URL: https://codereview.chromium.org/533823003

Cr-Commit-Position: refs/heads/master@{#293471}

Remove noamsml@ from all OWNERS files.

NOTRY=true

Review URL: https://codereview.chromium.org/541943002

Cr-Commit-Position: refs/heads/master@{#293470}

BUG=

Review URL: https://codereview.chromium.org/537843002

Cr-Commit-Position: refs/heads/master@{#293469}

We have a plan in progress to upgrade the 'important' field to a combination
of two fields 'primary' and 'improvement_direction'. This will be a two-sided
patch that will require reworking the dashboard's handling of chart JSON. Since
the dashboard has been modified to accept chart JSON with 'important' values,
we want to update Telemetry to continue serializing values with this field for
now.

R=nednguyen

Review URL: https://codereview.chromium.org/541253002

Cr-Commit-Position: refs/heads/master@{#293468}