GitLab

Data is from https://chromium-build-logs.appspot.com/flakiness_dashboard?master=tryserver.chromium

BUG=386891,378061,394032,327719,395152,396318,396320,394592,396326,395152,396328,314905,396334,396336,396342,396344,396347,391894,315299,396352,396353,313205,248437,389084,396360,396363,396364,396347,367665,327719,120484,167158,396371,396373
R=viettrungluu@chromium.org
TBR=kalman

Review URL: https://codereview.chromium.org/410043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284970 0039d316-1c4b-4281-b951-d872f2087c98

On Mac the profile directory may contain a socket "App Shim Socket", which we don't want to copy to the generated profile.
The original fix for this no longer works on the bots for an unknown reason, attempt an alternate fix.

BUG=396106

Review URL: https://codereview.chromium.org/404413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284965 0039d316-1c4b-4281-b951-d872f2087c98

This is applied to:
- open to the search result
- click on app icon

I am not sure this is the right approach. We may want to introduce
an ActivityObserver or something, and minimize the home card
by itself. However, activity may be created for various reason
but minimizing should work upon the user's action on the
home card, so this approach isn't bad.

BUG=None
R=oshima@chromium.org, sadrul@chromium.org
TBR=sky@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/408623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284962 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284684

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284961 0039d316-1c4b-4281-b951-d872f2087c98

This patch strips out usage of specific threads defined in content/.

- Replaces FILE thread in BackgroundDownloaderWin with a SingleThreadTaskRunner backed by the FILE thread.
- Replaces a bunch of DCHECK(UI thread) with use of base::ThreadChecker (which just checks that it's all on the constructor thread).
- Replaces Posts to the UI thread with a post to the current message loop used in the constructor.

BUG=371463

Review URL: https://codereview.chromium.org/385013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284960 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/399273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393149

Review URL: https://codereview.chromium.org/387923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/dynamorio/issues/detail?id=1443
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/417593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284956 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the following changes:

  - Add support for the new "Characteristics" and "Descriptors" properties
    exposed under org.bluez.GattService1 and org.bluez.GattCharacteristic1,
    respectively.

  - Add device::BluetoothGattService::Observer::GattDiscoveryCompleteForService
    event, which gets called after the first PropertiesChanged signal is
    received for the "Characteristics" property of a service.

  - Change BluetoothLowEnergyEventRouter, so that it sends the "onServiceAdded"
    event not in GattServiceAdded but in GattDiscoveryCompleteForService.

BUG=394537
TEST=browser_tests:BluetoothLowEnergyApiTest,
device_unittests:BluetoothGattChromeOSTest

Review URL: https://codereview.chromium.org/402303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284955 0039d316-1c4b-4281-b951-d872f2087c98

CWS search has turned on 100% since 2013/9 and CWS server side has no
problem handling the traffic. So get rid of the field trial.

BUG=262192

Review URL: https://codereview.chromium.org/412583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284954 0039d316-1c4b-4281-b951-d872f2087c98

Script crashes with "TypeError: int() argument must be a string or a number, not 'NoneType'" message.
The fix is to use 'raise ValueError' instead of returning None.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/408253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284953 0039d316-1c4b-4281-b951-d872f2087c98

This means if you have an existing ViewManager connection you can just use that to ask the WM to embed a new node for you.

Also fix the issue where only one call to EmbedRoot() could be made to the init service prior to the window tree host being ready.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/405163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284952 0039d316-1c4b-4281-b951-d872f2087c98

This CL replaces gfx based geometry objects with ones from mojo::.

TEST=none
R=beng@chromium.org, viettrungluu@chromium.org
BUG=330467

Review URL: https://codereview.chromium.org/409263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396658
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/417573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284950 0039d316-1c4b-4281-b951-d872f2087c98

When the calculated shadow border exceeds layer bounds we should make
the layer invisible instead of clamping the shadow border like we
previously did. This matches the behavior of ui::wm::ImageGrid
where we set patches as invisible.

BUG=395949
TEST=verify that the bug is fixed with this patch.
NOTRY=TRUE

Review URL: https://codereview.chromium.org/412643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284949 0039d316-1c4b-4281-b951-d872f2087c98

Previously this rule had a lot of custom stuff to work around the fact that the grit rule couldn't run at GN time to get the inputs and outputs. Now that the inputs are lazy, we can use the template.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/414623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284948 0039d316-1c4b-4281-b951-d872f2087c98

This finishes the rest of the Grit outputs that was started in a previous pass, and removes the ability to optionally deduce outputs at GN-time (which is slow so we don't want to do it).

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/411543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394028
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/409223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284946 0039d316-1c4b-4281-b951-d872f2087c98

Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.mac.

BUG=386891,53586
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/415453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284945 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rouslan@chromium.org
BUG=395169

Review URL: https://codereview.chromium.org/417563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284942 0039d316-1c4b-4281-b951-d872f2087c98

This IPC is used by the renderer to notify the browser when
a GPU memory buffer instance is deleted. This allows the browser
to maintain proper lifetime management of GPU memory buffers for
which ownership can't be passed with IPC.

This also renames the GpuCommandBufferMsg_DestroyGpuMemoryBuffer
IPC to GpuCommandBufferMsg_UnregisterGpuMemoryBuffer to not
be confused with real GPU memory buffer destruction, which
doesn't necessarily happen at when the GLImage is destroyed.

BUG=

Review URL: https://codereview.chromium.org/409723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284941 0039d316-1c4b-4281-b951-d872f2087c98

Rename the CloudPrintPrinterListTest.Parsing test to PrivetConfirmApiFlowTest.Params to match the other test in that file as there's already another CloudPrintPrinterListTest.Parsing.

One of them is flaking 33% of the time according to http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win but I can't tell which one it is.

TBR=vitalybuka@chromium.org
BUG=386891

Review URL: https://codereview.chromium.org/409163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284940 0039d316-1c4b-4281-b951-d872f2087c98

Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.chromiumos.

BUG=386891,396494,396496,396497,396499,396501,396502,396504,396505,393208,223888,396506,387045,396507,396509,396510
R=viettrungluu@chromium.org
TBR=sky, stevenjb

Review URL: https://codereview.chromium.org/407073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396645
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/413743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284935 0039d316-1c4b-4281-b951-d872f2087c98

Probably, we should also do something (assert/DCHECK) in the bindings
code too, but I'll do that separately.

R=darin@chromium.org
BUG=389666

Review URL: https://codereview.chromium.org/407643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284934 0039d316-1c4b-4281-b951-d872f2087c98

This is a cleanup, as discussed in the comments of https://codereview.chromium.org/287103004/

This turned out to require extending gfx::TruncateString with an extra BreakType parameter; it now supports breaking within words as well as at word boundaries. All call sites have been updated accordingly.

BUG=none

Review URL: https://codereview.chromium.org/381953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284933 0039d316-1c4b-4281-b951-d872f2087c98

Broke Mac ASan Builder gclient runhooks step:

Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium returned non-zero exit status 1 in /Volumes/data/b/build/slave/Mac_ASan_Builder/build
Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
gyp: Found /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/third_party/libc++/libc++.gyp:libcxx_proxy#target in dependencies! of /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/base/base.gyp:sanitizer_options#target, but not in dependencies
builder -> 'ninja'
gyp_defines -> {'asan': '1', 'gomadir': '/Volumes/data/b/build/goma', 'use_goma': '1', 'component': 'static_library', 'release_extra_cflags': '-gline-tables-only'}
IsWindows -> False
IsLinux -> False
platform -> 'mac'
Running build/landmines.py...
Hook '/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium' took 51.21 secs

> Use libc++ for all non-Windows ASan builds.
> 
> BUG=318770
> TBR=earthdok@chromium.org
> 
> Review URL: https://codereview.chromium.org/414703002

TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/410213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284932 0039d316-1c4b-4281-b951-d872f2087c98

The test creates multiple-displays, and multi-display tests do not work reliably
on Windows.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/410943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/414703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284930 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=396639
NOTRY=true

Review URL: https://codereview.chromium.org/410193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284929 0039d316-1c4b-4281-b951-d872f2087c98

Previously touch operations are handled by SwipeOverlay class. Overlay is a
common way to obtain mouse/touch events in Gallery, but it does not support
touch specific capability (e.g. multi fingers). The CL newly adds TouchHandlers
class to the SlideMode class and let it call the zoom/scroll feature of the
slide mode depending on user's touch gestures.

BUG=245926
TEST=on link

Review URL: https://codereview.chromium.org/411853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284926 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/400973002/

BUG=387614
TBR=zelidrag@chromium.org,derat@chromium.org,stevenjb@chromium.org

Review URL: https://codereview.chromium.org/398753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284925 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::targetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/409593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=202947

Review URL: https://codereview.chromium.org/391783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284921 0039d316-1c4b-4281-b951-d872f2087c98

The shared timer must be deleted on the same thread that it was executing on. When the WebThread is being destroyed, it is done from a different thread, so the shared timer must be deleted prior to that. This gives an API for the thread cleanup code to do so.

BUG=301515
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/416453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284920 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut (https://codereview.chromium.org/379773003/)

Reason for revert:
I am reverting this CL because it causes regressions like crbug.com/395985. This CL is in the right direction, but I need to make the capture code for tab dragging less crazy first. See comment #3 in crbug.com/395985 for more details

Original issue's description:
> Simplify the logic in DesktopWindowTreeHostX11 for FocusOut
> 
> We should have the same handling regardless of whether the 'mode' member is
> NotifyGrab or NotifyUngrab. According to
> http://tronche.com/gui/x/xlib/events/input-focus/grab.html, whether the mode
> field is NotifyGrab or NotifyUngrab depends on whether there is a new
> capturer for the keyboard. The X window has lost keyboard capture in both cases.
> 
> BUG=392480
> TEST=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283823

TBR=erg@chromium.org,erg@google.com,sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392480

Review URL: https://codereview.chromium.org/409223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284919 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284918 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/409363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284917 0039d316-1c4b-4281-b951-d872f2087c98

Based on experimentation, it appears that calling setNeedsDisplay or
displayIfNeeded on a CAOpenGLLayer which has the isAsynchronous
property set, will result in the animation getting screwed up. In
particular, calls to canDrawInCGLContext stop occurring.

This was working in M35 and M36 because, entirely accidentally, we
were calling setAsynchronous:NO before most instances of
setNeedsDisplay and displayIfNeeded. In r272469, these calls were
removed, and resulting in the janky animation.

Add calls to setAsynchronous:NO before all instances of calling
displayIfNeeded, and almost all instances of calling setNeedsDisplay.

BUG=395827
TEST=manual, automated tests in progress

Review URL: https://codereview.chromium.org/408153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284916 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=344769

Review URL: https://codereview.chromium.org/410083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284915 0039d316-1c4b-4281-b951-d872f2087c98