GitLab

This change includes multiple fixes for various cases where
SourceBufferStream requires notification of a new coded frame group when
buffering by PTS (currently available via kMseBufferByPts feature) even
if there is no MSE coded frame processing algorithm DTS discontinuity
detected. This additional granularity allows for SourceBufferStream to
understand that the next buffers appended to it may overlap recently
appended buffers, and also allows for handling cases where the next
keyframe (continuous in DTS) jumps significantly forward in PTS but
still needs to remain continuous with the current append sequence.

On every keyframe, when buffering by PTS, FrameProcessor now considers
doing the extra signalling if DTS is continuous and buffering ByPts,
and:
a) keyframe PTS jumps significantly into the future relative to the
   highest PTS emitted already in the current coded frame group (in
   which case the highest PTS emitted already in the current CFG is used
   as the signalled PTS value), or
b) keyframe PTS is before the highest PTS emitted already in the current
   coded frame group (in which case the keyframe PTS is used as the
   signalled PTS value and tracking of the highest PTS emitted is reset
   to enable correct detection and signalling of both (a) and (b) cases
   for future keyframes in the continuous DTS append sequence.)

This change also includes a fix to SourceBufferStream when buffering
ByPts to appropriately split a range that is being overlap-appended.

A benign DCHECK is also removed from SBS::UpdateLastAppendStateForRemove
which could fail for a SAP Type 2 GOP at the beginning of a range (the
last appended buffer in that range might indeed be a non-keyframe with a
PTS prior to the range start time, which could be as late as the PTS of
the keyframe of that non-keyframe's GOP.)

New and updated unit tests are included. I locally confirmed this fixes
bugs 773115 and 788344, and appears to fix nest.com and twitch.com
renderer crashes with dcheck_always_on=true.

Pre-existing bug 791095 is demonstrated, but not yet fixed, by new
unit tests:
  BufferingByPts_ContinuousDts_SapType2_and_PtsJumpForward
  BufferingByPts_ContinuousDts_NewSap2GopEndOverlapsLastGop_1

Pre-existing bug 763620 is demonstrated, but not yet fixed, by new
unit tests:
  BufferingByPts_ContinuousDts_NewGopEndOverlapsLastGop_2
  BufferingByPts_ContinuousDts_NewSap2GopEndOverlapsLastGop_2
  BufferingByPts_ContinuousDts_GopKeyframePtsOrder_2_1_3

BUG=773115,788344,791095,763620

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6f95cf85e1d1fa5b5f74ed1d99a3853ec6ccf686
Reviewed-on: https://chromium-review.googlesource.com/777778Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521961}

This test is newly-introduced but doesn't work on Fuchsia.

Bug: 792300
Change-Id: Ice4288e9c5e199ff49e323c0d79470883da0e659
Reviewed-on: https://chromium-review.googlesource.com/809838
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521960}

Bug: b/66944165
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia22b2b815bbaa6e26a30044fc06a58cf9a142807
Reviewed-on: https://chromium-review.googlesource.com/807363Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521959}

Previously the new tab desktop in-product help promo bubble was too
close to the new tab button. Thus, I had to move the the promo bubble
further from the anchor_view of the button. I also removed the shadow
from the new tab promo bubble. Note that new tab promo bubbles are
inactive.

Bug: 734132
Change-Id: I5ba93f841413d3985ff810fbb0f009b8627289bb
Reviewed-on: https://chromium-review.googlesource.com/797920
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521958}

If test output is over kOutputSnippetBytesLimit, which is 300kb, then
TestLauncher::OnTestFinished() trunactes the string to the last 5000
bytes. It looks like this a mix up of kOutputSnippetBytesLimit and
kOutputSnippetLinesLimit.

Bug: 788739
Change-Id: I4aacc4b62f51f764143060bdaeef00031053d1b5
Reviewed-on: https://chromium-review.googlesource.com/809085Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521957}

Worklet requires a valid Frame object, but GetFrame() from the window
can be nullptr. This CL blocks out such case.

Bug: 792108
Change-Id: Ie3fe64c707447956fcfeac687d4df9f5bf7b26d1
Reviewed-on: https://chromium-review.googlesource.com/809299Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521956}

When we specify CSS variables in a property value (e.g. color: var(--A))
we need to return a CSSUnparsedValue. This patch implements this
by first trying to parse the property value according to the property's
grammar. If it fails, we then check if it has var references and parse
it as a variable reference. The code for converting a variable reference
to a CSSUnparsedValue was already in the codebase so we just hook into
that.

Bug: 788570
Change-Id: I65b32d29e80918c61e1731e7a0424b72e7d9b1d7
Reviewed-on: https://chromium-review.googlesource.com/804980
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521955}

1- Updates WKSystemCookieStore so it can use wkcookiestore only from
   the main thread.
2- Update the CookieCreationTimeManager to only be used on IO thread
   (aside from creation on Main thread)

Bug: 779106,759229
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifa0f9e5bb2d2c33c488759467dc8a25403f6e0ed
Reviewed-on: https://chromium-review.googlesource.com/809531
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521954}

Bug: 778051
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5aea1c4412721a7b1bc549a3d14f52bd3de73bb
Reviewed-on: https://chromium-review.googlesource.com/809783Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521953}

- Remove ProduceTextureCHROMIUM from GLES2Interface.  Change all call sites
  to use ProduceTextureDirectCHROMIUM.
- Remove <target> from ProduceTextureDirectCHROMIUM.
- Remove <target> from CreateAndConsumeTextureCHROMIUM.

BUG=757607

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic50059a0db3edfaeb51690645bce096f4f64228e
Reviewed-on: https://chromium-review.googlesource.com/780807
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521952}

If the fetch of the warmup URL (aka probe URL) fails, the
corresponding proxy is disabled, and the config is reloaded.

A future CL will add retries -- If the fetch of the probe URL
due to network flakiness fails, then the probe will be retried
(up to 3 times) on the same proxy.

Bug: 760294
Change-Id: Ib255f8178ef106f5e2882ad3dc32bde143c40a90
Reviewed-on: https://chromium-review.googlesource.com/807592Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521951}

I had the locations wrong. The root is reset to the local, not the
local to the root. Not sure why some tests passed with the other way.

BUG=792214
TEST=none

Change-Id: I9a0a29c0c412d9c097d1c7df64312e1693328998
Reviewed-on: https://chromium-review.googlesource.com/810009Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521950}

Ensure that the Incognito Bubble presentation is deferred until after
the feature engagement tracker is initialized, just as the New Tab
Bubble is deferred.

Bug: 778395
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33c86953665211a7cfafc8e27349892d01e43b80
Reviewed-on: https://chromium-review.googlesource.com/809848Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521949}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/873be6fd45b7..9c02a833e207

$ git log 873be6fd4..9c02a833e --date=short --no-merges --format='%ad %ae %s'
2017-12-05 iannucci [led] Update led to the latest version

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I17e83345022764597a95370ce248e63d210d34fa
Reviewed-on: https://chromium-review.googlesource.com/809960Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521948}

The CGIs were previously the only way to test Unicode filenames in
file uploads, but introduced noticeable test slowdowns, especially
on Win32.

This also removes the test bifurcation previously added to avoid
occasional Win32 timeouts due to Win32 CGI slowness:
https://chromium.googlesource.com/chromium/src/+/78383443fce02079cbbec26f911abea2ca70dc5b

TBR=

Bug: 661819
Change-Id: Iab3295f665bdfe4c51688f4fa42162505f36a929
Reviewed-on: https://chromium-review.googlesource.com/802554
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521947}

The method does not need access to a PrivetURLFetcher pointer.

Change-Id: I94d42334cdfab47131bc29e8de5b090a0634f120
Reviewed-on: https://chromium-review.googlesource.com/804670
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521946}

This reverts commit 15a3e07e.

Reason for revert: Still failing on bots.

Original change's description:
> Reenable testBadgedReadingListFeatureShouldShow.
> 
> Reenable this test since flake seems to have been fixed on FYI bots.
> 
> Bug: 789943
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I184607d3fc25206409c0786d81583c49a9f8471a
> Reviewed-on: https://chromium-review.googlesource.com/807166
> Reviewed-by: edchin <edchin@chromium.org>
> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521764}

TBR=edchin@chromium.org,gchatz@chromium.org

Change-Id: Ia4838fc7a683aaeb54eebbf1c4432f0baeb55b09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/809857Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521945}

removes rescaler, auto-filter (-af) support and makes WebPPictureCopy,
WebPPictureIsView, WebPPictureView, WebPPictureCrop, and
WebPPictureRescale noops.

Bug: 789665
Change-Id: I222feb7dce9b41093acebf1d3381dcedf9922e7d
Reviewed-on: https://chromium-review.googlesource.com/797771Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#521944}

This metric is no longer needed as we have detailed
metrics for tracking main thread scrolling.

Bug: 
Change-Id: Idcb10e071c121d192148c2a05075c52c87d3b32e
Reviewed-on: https://chromium-review.googlesource.com/809087Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521943}

https://chromium.googlesource.com/catapult.git/+log/09fc536c66c6..a9cf2fa54a33

$ git log 09fc536c6..a9cf2fa54 --date=short --no-merges --format='%ad %ae %s'
2017-12-05 martiniss Emit artifacts from story runner

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia2fee95f0bb00fa9117da6c2ed8058bce41eab14
Reviewed-on: https://chromium-review.googlesource.com/809957
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521942}

This doesn't change any content of the file. To create this patch, I:
1. Used a script to generate markdown from the HTML
2. Cleaned up differences by hand
3. Formatted and wrapped to 80 chars
4. Added 'DO' and 'DONT' in front of code blocks where the red/green
   colouring was lost (and the difference is important)

Change-Id: Ib16c404ce5cf8f4e0d434e35886037dafbcc63a5
Reviewed-on: https://chromium-review.googlesource.com/802843
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521941}

Bug: 754889
Change-Id: I7dd1233e282fab6a3e00c40526e5c69b54637726
Reviewed-on: https://chromium-review.googlesource.com/806925
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521940}

Tracing can generate large output files (over 50M) especially if system
tracing is enabled, and are very compressible. Add an option to compress
them using the same machinery that chrome://tracing uses.

This also uses less /tmp space to store the stream. Storing large files
in /tmp was causing problems for chromecast, as space is /tmp is very
limited.

BUG=791708

Change-Id: Icbaac91cccb825a305431569bf6f42011d3cfbea
Reviewed-on: https://chromium-review.googlesource.com/807384
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521939}

This logic is currently implemented in ResourceDisaptcherHostDelegate,
which doesn't work with network service.
This CL moves the logic to ContentBrowserClient,
so the function can be invoked by both legacy and network service path.
A new DownloadTest is added to test this.

BUG=715630

Change-Id: I488858e16ef7d54e82405432b0d4efc9c2ca31eb
Reviewed-on: https://chromium-review.googlesource.com/806737
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521938}

Add the ability to share and delete items through a new three dot menu
on all download items in download home.

Bug: 777630
Change-Id: Icd8f19e2d4630ab4e96d21e7c02021fa30690046
Reviewed-on: https://chromium-review.googlesource.com/802138
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521937}

The new spec made attributes of CSSVariableReferenceValue mutable.
This also allows us to simplify the test helper to create
CSSVariableReferenceValues.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue

Bug: 545318
Change-Id: I9f7571e7b50b646423e4a6dc44cfb6c95c3fc5dd
Reviewed-on: https://chromium-review.googlesource.com/802664
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521936}

IFrames can have border-radius applying to the contents.
Now generate InnerBorderRadiusClip property node for such IFrames.

Bug: 765985
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I42587e4c046728e15a19097c25466e229b6c6da8
Reviewed-on: https://chromium-review.googlesource.com/807335
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521935}

This allows the Relying Party to request that a token's attestation
certificate be replaced with a randomly-generated certificate.

The default behavior is unchanged.

BUG=780299

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98d6a94399ac1896b6893c8c080f874d66b818b3
Reviewed-on: https://chromium-review.googlesource.com/804978Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Matt Braithwaite <mab@google.com>
Cr-Commit-Position: refs/heads/master@{#521934}

Like single-process mode, chrome uses x11 from multiple threads in
--mus mode too (the window-server thread, and the viz thread). So
always initialize ozone-x11 in multi-thread mode. It would be possible
to introduce a new flag in InitParams for this mode, but considering
this is only used for development purposes on developer workstation,
just init multi-thread mode unconditionally.

BUG=786453, 791619

Change-Id: I930fc325ef1a52f531a419f660d31f55af03d1c6
Reviewed-on: https://chromium-review.googlesource.com/809943Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521933}

TBR: scheib@chromium.org
Change-Id: I467adbf5ff9304eea15f8c597565ce84384fbc18
Reviewed-on: https://chromium-review.googlesource.com/810058Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521932}

Also label related methods and some others as "ForTest".

Change-Id: Ibbe204423d9da05ae244993168c12166b1a0568a
Reviewed-on: https://chromium-review.googlesource.com/804669
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521931}

https://pdfium.googlesource.com/pdfium.git/+log/c45271e053c8..6eda94d78313

$ git log c45271e05..6eda94d78 --date=short --no-merges --format='%ad %ae %s'
2017-12-05 thestig Replace uses of bsearch().
2017-12-05 thestig Replace bsearch() in FPDFAPI_CIDFromCharCode().

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I75e1ad25efe8734a0e96b73dccfa3268f765962e
Reviewed-on: https://chromium-review.googlesource.com/809768
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521930}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7af7216b..ee13fe4b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0f22175c61de70e41f207fa63454f373ef78ea4d
Reviewed-on: https://chromium-review.googlesource.com/809911Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521929}

This reverts commit a9783e12.

Reason for revert: Broke webkit_unit_tests

All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/1
All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/0
All/SnapCoordinatorTest.EndAlignmentCalculation/1
All/SnapCoordinatorTest.CenterAlignmentCalculation/0
All/SnapCoordinatorTest.CenterAlignmentCalculation/1
All/SnapCoordinatorTest.EndAlignmentCalculation/0
All/SnapCoordinatorTest.StartAlignmentCalculation/0
All/SnapCoordinatorTest.StartAlignmentCalculation/1
All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/1
All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/0
All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/1
All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/0

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/72004

Original change's description:
> Snap at GestureScrollEnd on main thread.
> 
> As the first step of ScrollSnapPoints, this patch implements it on main
> thread at GestureScrollEnd. It introduces necessary data structures:
> SnapAreaData and SnapContainerData, updates the data after style change
> and layout, implements a naive algorithm to select snap points at
> intended-end-position, adds unit-tests for logic and adds sim-tests for
> behavior.
> 
> Bug: 778257
> Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47
> Reviewed-on: https://chromium-review.googlesource.com/756887
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Darren Shen <shend@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521840}

TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,shend@chromium.org

Change-Id: I172b350063d66006a3974919f67c7d4f4f0a980d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778257
Reviewed-on: https://chromium-review.googlesource.com/809313Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521928}

Bug: 791906,791902
Change-Id: I4a4ccb4afd70b4888a14455f56eea3ba739add77
Reviewed-on: https://chromium-review.googlesource.com/809810Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521927}

- It is better to do nothing when context document/frame is null.
- Preparation for removing ExecuteScriptResult.
  kShouldFireNone is no longer used, and will be removed in
  https://chromium-review.googlesource.com/791473.

Bug: 788828, 686281
Change-Id: I2327e9065c9a07da0ea3658bb1d31765cbcb537f
Reviewed-on: https://chromium-review.googlesource.com/791450
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521926}

Bug: 775577
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I99dc244ceb3905fd55c948398a7991a5a019e669
Reviewed-on: https://chromium-review.googlesource.com/806734Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521925}

Moves ability to create the //device/bluetooth/public/interfaces Adapter
to chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.cc
instead of chrome/browser/chrome_content_browser_client.cc

//chrome/browser/ui/webui/bluetooth_internals target created to allow visibility
of //device/bluetooth/public/interfaces:deprecated_experimental_interfaces
to be restricted precisely to the single allowed client.

Numerous build files adjusted as needed to enforce that visibility restriction
and clearly document that the interfaces are only intended to be used by
bluetooth-internals.

Bug: 746132
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idcaa51d1ed4fb818bd3d8ae617e41a28eabfcb44
Reviewed-on: https://chromium-review.googlesource.com/775782Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521924}

Extracts code that deals with calling powerd SetBacklightsForcedOff
method from PowerButtonDisplayController to a separate class that can
handle multiple concurrent requests to set backlights off (by keeping
track of the active set backlights forced off requests).

While currently only PowerButtonDisplayController uses
SetBackligthsForcedOff, it's planned to add similar ability to lock
screen note launching code in a follow-up (the idea is to force
backlights off if the lock screen app is launched while the display is
turned off, until the app launch is done).
Goal of BacklightsForcedOffSetter is to prevent these two classes from
conflicting with each other - it will ensure backlights are forced off
as long as at least one backlights forced off request is active.

Backlights can be forced off using
BacklightsForcedOffSetter::ForceBacklightsOff, which returns
ScopedBacklightsForcedOff unique ptr - to stop backlights forced off
request, callers should just reset the returned unique ptr.

BUG=767711
TEST=Press power button, verify display is turned off. Press power
     button again - display is turned on.

Change-Id: Ie47f546edb51659bb82ba4618b069569a2d188c6
Reviewed-on: https://chromium-review.googlesource.com/758963
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521923}

This change makes it possible to return RemoteDevice objects
synchronously instead of requiring an IPC call to create them. This
change is needed to support [1], since that CL requires that a
BluetoothDevice object be used immediately (i.e., synchronously),
requiring that a RemoteDevice object is also available synchronously.

This CL also moves ownership of TetherHostFetcher from TetherComponent
to TetherService, ensuring that RemoteDevice objects necessary for
TetherComponent are generated before the component is started up.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/738467

Bug: 777610, 672263
Change-Id: I3c74af3cb8964d32e3bd30298849af1e2477c77a
Reviewed-on: https://chromium-review.googlesource.com/804395
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521922}