GitLab

When calling ShowLineTreeForThis() on RootInlineBox and children-
inline LayoutBlockFlow, the existing code searches for inline
structures in a wrong LayoutBlock, which is the block container of
the inline formatting context instead of the inline formatting
context itself.

This patch fixes the issue.

Bug: 821289
Change-Id: Icba7ee2b036649df5caba75050b4267188a8dbda
Reviewed-on: https://chromium-review.googlesource.com/961797Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543022}

When GMB copies fall behind we would previously also slow down the
Decode() calls, after GMBDecoderWrapper was introduced we would
return the DecodeCB while the copy was pending, letting DecodeStream
think it could schedule another Decode. If decoding rate is higher
than the copy rate, this will generate absurd amounts of decode
results waiting for copying.

This patch changes the behavior to be based on GetMaxDecodeRequests();
e.g., when GetMaxDecodeRequests() == 1, this allows another decode if
there is at most 1 copy outstanding. When GMDR() == 2, this allows
another decode if there are at most 2 copies outstanding.

BUG=801245, 820167
TEST=new test and existing tests modified to enforce this.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I06415feda36643eb65aac69b17125737e12254c0
Reviewed-on: https://chromium-review.googlesource.com/959149Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543021}

The script that traffic annotations FYI bot runs is changed to a new one
that specifically checks network traffic annotation auditor's health.

Bug: 690323
Change-Id: Iaa97d5ce27b2b9f9d2c523deae7fda803ffb5079
Reviewed-on: https://chromium-review.googlesource.com/955688Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543020}

With java WebContentsUserData in place, ContentViewCore doesn't
have to rely on native to retrieve its java object. This CL refactors
ContentViewCore so that it is backed by WebContentsUserData.

Bug: 789000
Change-Id: Icf4b6b0e90e78cd8cfd4d7d74f1d14196736d2b5
Reviewed-on: https://chromium-review.googlesource.com/945035
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543019}

We cannot use the content size (intrinsic block size) as min-height or
max-height (min-width or max-width, if writing mode is vertical).
Doing so would cause min-height to incorrectly override any specified
height or max-height that is less than the intrinsic block size, and
max-height to override any specified height that's greater than the
intrinsic block size. Do what the spec says [1] instead: max-height
to become 'none', and min-height to become 0.

This fixes the final rendering problem with Acid2 (this was about the
min-height issue). It now renders correctly with LayoutNG!

Since no other tests than Acid2 started to pass with this change, I wrote
a couple.

[1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights

     XXXXXX
   XX      XX
  X          X
 X   O    O   X
 X            X
X      /\      X
X      \/      X
X              X
 X X        X X
 X  XXXXXXXX  X
  X          X
   XX      XX
     XXXXXX

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351
Reviewed-on: https://chromium-review.googlesource.com/960085Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543018}

There could be multiple providers. So, each must create allocator dumps
with distinct names. Refer notes on GetOrCreateAllocatorDump.
Group autocomplete and in_memory_url_index dumps under different child
dumps for easier collection of metrics.

BUG=803822
TBR=mpearson@chromium.org

Change-Id: I872491bb1496572600fc6b6f87d9198a76eea8c7
Reviewed-on: https://chromium-review.googlesource.com/961263
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543017}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I5e7f5a43bbf36e9e4cc5c81a31611fea17d95019
Reviewed-on: https://chromium-review.googlesource.com/961392
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543016}

This is a retry of https://chromium-review.googlesource.com/c/chromium/src/+/908371,
with fixing the DCHECK (NOTREACHED) error. We were not sure when the
NOTREACHED is reached before the fix, but now this case becomes
deterministic (see the discussion at crbug.com/816533)

Note that this might still cause Telemetry regressions reported at
crbug.com/753071 before, but this is expected.

A document is leaked because AutofillAgent hold a lastly used element
even after navigation happens, and the document of the element remains
until a new (input) element is focused. This CL fixes this issue by
resetting the element in AutofillAgent when navigation happens.

Bug: 734427, 755489, 816533
Change-Id: I7eb2f9fb879d826297247c4c66e366ec0b73067c
Reviewed-on: https://chromium-review.googlesource.com/939224Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543015}

The previous comment was added at [1], saying the code is suspicious, however,
the code is correct.

To avoid a confusion, update the comments.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/755855

Change-Id: I9c30c53b6cd24e14160fa18b8fc0c3dc7aff2dc0
Reviewed-on: https://chromium-review.googlesource.com/959947
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543014}

pixels per mouse_scroll_wheel_tick was being set wrong (should have
been wheel_scroll_factor but was the value divided by dip_scale
was set), hence decreased the scroll rate and caused the regression.
This CL fixes the issue. Now WindowAndroid stores wheel_scroll_factor
(instead of tick multiplier) which is accessed much more often, for
efficiency's sake.

Bug: 821101
Change-Id: I99e81fdfc21ec101a99092c50555be4f429d7a20
Reviewed-on: https://chromium-review.googlesource.com/961503Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543013}

Before this CL, SignedExchangeSignatureVerifier didn't verify
date and expires values on the "Signature" HTTP header.
This CL introduces SignedExchangeSignatureVerifier::VerifyTimestamps
to verify those.

The original CL http://crrev.com/c/923468 was created by kouhei@.

Bug: 803774
Change-Id: I21a2db04c9bf80787226631696e1e334219bf893
Reviewed-on: https://chromium-review.googlesource.com/958368Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543012}

https://chromium.googlesource.com/angle/angle.git/+log/690c8eb7f2d2..fccebffe63cf

$ git log 690c8eb7f..fccebffe6 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 jiawei.shao ES31: Support adjacency draw modes for geometry shader

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I4e61a9ad93a380b0f5ec8a392f95a154ce812590
Reviewed-on: https://chromium-review.googlesource.com/961813
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543011}

This CL has no behavior changes.

Bug: 770603
Change-Id: Ieaeec84b67a6a4dbb0063e43478def41b909448f
Reviewed-on: https://chromium-review.googlesource.com/961183
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543010}

Reference: https://docs.google.com/spreadsheets/d/1HKl-gMSzjI-ygRkYTvqpJRwSW0ZI-xj-0aoiNdTum2g/edit#gid=939250318

Change-Id: I160fcaaa9aca29ab5c78eda66a78be2c5775720f
Reviewed-on: https://chromium-review.googlesource.com/956829Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sanjoy Pal <sanjoy.pal@samsung.com>
Commit-Queue: Abhishek Agarwal <abhishek.a21@samsung.com>
Cr-Commit-Position: refs/heads/master@{#543009}

There were three problems:
1. We didn't multiply the number of vertices by the number of instances.
2. We didn't account for vertices written by previous draw calls.
3. We didn't round the vertex count down to the nearest number of whole
   primitives.

Fixes the WebGL 2 conformance test added here:
https://github.com/KhronosGroup/WebGL/pull/2604

Bug: 820639
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9566ad14aa6671eca127a1b7f68b73e6408acd10
Reviewed-on: https://chromium-review.googlesource.com/957743
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543008}

Following bot results are included.
4201 4203 4207 4211 4215 4216

1 lines were removed and 3 lines were deflaked by consecutive
results since 4166.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2885e853016e26861f8776a57aab36990ce8993c
Reviewed-on: https://chromium-review.googlesource.com/960541
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543007}

Bug: 803774
Change-Id: Id7c04828f3a78401ff0e809bccfdcfd036473a6f
Reviewed-on: https://chromium-review.googlesource.com/958945
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543006}

This updates the Media Router integration tests so they run in the
Chromium waterfall with the open source Media Router component
extension and its mock (test) Media Route Provider.

Additional changes:

- Removes extension from top level BUILD.gn as it is only used for
  browser tests at the moment.
- Splits the targets for Media Router browser tests into integration tests
  (part of main browser_tests suite), e2e tests (which require the
  external component extension), perf tests, and shared support code.
- Renames the "test" extension to the "telemetry" extension used for perf
  tests to avoid confusion.
- Updates README files
- One test is not compatible with the Chromium component and need
  to be fixed.  Bugs 818767 filed for follow-up.

Bug: 698796
Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722
Reviewed-on: https://chromium-review.googlesource.com/917214
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543005}

This patch adds support for scroll-margin-* and adds relevant tests.

Spec: https://drafts.csswg.org/css-scroll-snap-1/#margin-longhands-physical

Bug: 820299
Change-Id: I46f8482c88c237de2a9d263b3a334ac9c03f4fca
Reviewed-on: https://chromium-review.googlesource.com/958755Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543004}

Change-Id: Ibae84f3215ae29e2154df538f4ff7e86f72118b5
Reviewed-on: https://chromium-review.googlesource.com/959750
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543003}

This CL has no behavior changes.

Bug: 770603
Change-Id: I7229bd5cb53d468c054d323a458fb78ca0803535
Reviewed-on: https://chromium-review.googlesource.com/961164
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543002}

Bug: none
Change-Id: I4bf6dc8b898a5c0af1516888e40e290e5bf91d95
Reviewed-on: https://chromium-review.googlesource.com/960982Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543001}

Bug: 803774
Change-Id: I0cc2bbcdb34ef09f4f0fbcfeefe2d667bfec1cd8
Reviewed-on: https://chromium-review.googlesource.com/930645Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543000}

Now we got only a handful of references to ContentViewCore object
left in RenderWidgetHostViewAndroid.

All but 3 are all null checks trying to see if content_view_core_
is set to null or not, which is equivalent to checking if the native
view (ViewAndroid) of ContentViewCore and its own native view form
a view tree or not. This can be replaced simply by a boolean flag.

The only 3 are significant (i.e. invoking methods of CVC)

ContentViewCore::GetViewAndroid() - RWHVA may not have an access
    to the parent native view. It should be passed to RWHVA instead.

ContentViewCore::RequestDisallowInterceptTouchEvent() - It goes up
    to Java container view to invoke
    android.view.View.requestDisallowInterceptTouchEvent.
    One more move from CVC to ViewAndroidDelegate...

ContentViewCore::GetWindowAndroid() : same WindowAndroid (or null
    if not attached to view tree) can be obtained via
    ViewAndroid::GetWindowAndroid().

Bug: 626765
Change-Id: I80088c6a9ca2ca0047184ac77f84f08f64ff0acb
Reviewed-on: https://chromium-review.googlesource.com/958646
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542999}

This CL has no behavior changes.

Bug: 770603
Change-Id: I3d8a6c2813b360ca5497f9d8bc31e8e6e2c6caf0
Reviewed-on: https://chromium-review.googlesource.com/961166
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542998}

Split GCType into MarkingType and SweepingType so we can track if the gc was incremental marking or not.

Change-Id: I2264badba6b0e7dbdbd41e2bb4958ca3fb37cb0d
Reviewed-on: https://chromium-review.googlesource.com/958898Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542997}

This CL has no behavior changes.

Bug: 770603
Change-Id: I0c1872dc6942c3cccf706b4c60869402bbe47f59
Reviewed-on: https://chromium-review.googlesource.com/961561
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542996}

Bug: 820348
Change-Id: Id9c8ff9878f6595f99d4630a18aa023b55cc8467
Reviewed-on: https://chromium-review.googlesource.com/956297Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542995}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I63fded1b83f7f2fd51ca455f2b1f5eefee8f76d4
Reviewed-on: https://chromium-review.googlesource.com/961809Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542994}

This CL has no behavior changes.

Bug: 770603
Change-Id: I2084d2a10cf69f2815c147769d46d8a5f0cba7ff
Reviewed-on: https://chromium-review.googlesource.com/961621
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542993}

Bug: 809119
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1aa568846bf0a71ebb509c5e55ae3fce9163a78e
Reviewed-on: https://chromium-review.googlesource.com/958307Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542992}

WebContents of contextual search panel can be created
after the device gets rotated. The content size to be
used for WebContents should have been updated to pick
up the right size after the rotation happens. This CL
fixes that.

Bug: 820940
Change-Id: I811d52db9d175adf100c0e13c0bfc35ac5d00d5a
Reviewed-on: https://chromium-review.googlesource.com/959408Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542991}

Screenshot: https://crbug.com/803774#c41
Bug: 803774

Change-Id: I3cffd4258de124df22f4bc7560e0e9dbc91ca442
Reviewed-on: https://chromium-review.googlesource.com/956654
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542990}

R=jbudorick@chromium.org

Bug: 811974
Change-Id: I50908b28ce18fabf62f033563669f194b68fb9a4
Reviewed-on: https://chromium-review.googlesource.com/961531Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542989}

This is causing ninja to treat WebKit as dirty on every compile, for
certain build configurations. Follow-up to https://crrev.com/c/957264.

Bug: 818691
Change-Id: Idd32f722b8d4efe82388a06e2acc0d638cd9eb4e
Reviewed-on: https://chromium-review.googlesource.com/961784Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542988}

The comment on the disabled tests was wrong.

Bug: 820464, 821551
Change-Id: Icad7c41fdb814eea44be2fa4c16528404a816176
Reviewed-on: https://chromium-review.googlesource.com/961487Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542987}

https://skia.googlesource.com/skia.git/+log/6fccc50a4a6f..cefa808f3f23

$ git log 6fccc50a4..cefa808f3 --date=short --no-merges --format='%ad %ae %s'
2018-03-13 benjaminwagner Update clang_win to yesterday's build (from Chromium).
2018-03-13 fmalita [sksg] Use SkTrimPathEffect for path trimming

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I6b9d264fc911f25428788a77cb1e577d92e6fe74
Reviewed-on: https://chromium-review.googlesource.com/961725
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542986}

Pretty standard test apart from font-size can't be negative.

Bug: 774887
Change-Id: Ieae05dc71c68b5f777d6078e4c9daec0b6eebee4
Reviewed-on: https://chromium-review.googlesource.com/936961
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542985}

Phantom window and overlay have other meanings for other uses.

Phantom windows -> preview area as it is a highlight which gives a preview
of the bounds of a snapped window.
Overlay -> drag indicators. The class handles displaying various indications
for entering split view.

Test: ash_unittests SplitViewWindowSelectorTest.*
Bug: 808283
Change-Id: If8bb36792daa7d89c8dac96cc5baf841bee3bdee
Reviewed-on: https://chromium-review.googlesource.com/946887
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542984}

This CL applies //tools/clang/base_bind_rewriters to
//chrome/browser/extensions.
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

This reduces the number of 'base::Bind' in //chromecast from from 186 to 121
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: If50b2191fe374860cd17455f9bd0e0e549fbefc0
Reviewed-on: https://chromium-review.googlesource.com/960402Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542983}