- 10 Oct, 2019 40 commits
-
-
dpapad authored
- Fix newly found JSC_HIDDEN_INTERFACE_PROPERTY_MISMATCH, as a result of the interface checking overhaul at [1] - Fix/suppress newly found JSC_CONSTANT_PROPERTY_REASSIGNED_VALUE errors. This is in preparation of rolling a newer compiler version at a later CL. [1] https://github.com/google/closure-compiler/commit/86acbd5e3ec78f08a1804df5f1efbea129d29c0e Bug: 1012840 Change-Id: I8c356c9d2d3df03120f04614eafa555de488c8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850312 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704889}
-
Michael Liao authored
Re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1636250 This is a shared control between Timeline, Network, Memory, JS Profiler and Layers tools 1. This PR adds the ability to use keyboard to navigate sliders in the Overview grid. - Can tab into the sliders - Can use left and right arrow keys to navigate the grid sliders (step by 2 pixels) - Can use Ctrl + left and right arrow keys to navigate the grid sliders faster (step by 10 pixels) Gif: https://imgur.com/Im7m6su Bug: 963183 Change-Id: I64ec60864165d9cca6e7a76c6849ed1cf1beee61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676677Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704888}
-
Chris Harrelson authored
This is necessary to make sure the values get through to the compositor thread. It regressed accidentally in earlier CLs. Bug: 1013000 Change-Id: Ia6de23a10180abb5e41fc8d48f790359f826c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854218Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704887}
-
siyua authored
Did some manual testings to make sure it is working correctly. Bug: 991037 Change-Id: Icceddefdee99f0ba252f5ce161e4b42813ee1c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848751Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#704886}
-
Haiyang Pan authored
This would help local development with emulator Bug: 922145 Change-Id: Ie107381b80e3c0acae1145cf4078a327e38ffa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849434Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#704885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481902904a9..6a1d77869d77 git log 3481902904a9..6a1d77869d77 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 ehmaldonado@chromium.org gsutil: Bump asn1crypto version to 1.0.1 Created with: gclient setdep -r src/third_party/depot_tools@6a1d77869d77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012612 Change-Id: I965e614a9ae1ddc5dfeab2bef26e7db27ff663bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704884}
-
Brandon Wylie authored
The current histogram that's in place doesn't fit our needs here. Bug: 1001839 Change-Id: Ie1a0e897c86bfa88fbb5eb901fb7f57c7f4b1bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846249Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704883}
-
Zoe Clifford authored
String parking can be fairly expensive in terms of CPU, which makes it undesirable for certain headless use-cases, such as those with many short-lived pages, or where RAM is more plentiful than CPU. The option to disable string parking was removed in [1]. This CL re-adds a similar option so it may be disabled once more. (Google Internal) screenshot of CPU profiling: https://screenshot.googleplex.com/cFXiZq1ydBN [1] https://chromium-review.googlesource.com/c/chromium/src/+/1697649 Change-Id: Ib05e79a009fb70565011bd8aa9ba6238c6a8c617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820023 Commit-Queue: Zoe Clifford <zoeclifford@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704882}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d0704ce5c6a1..d62ac3f0b830 git log d0704ce5c6a1..d62ac3f0b830 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kcwu@google.com Use fake clock for replay fuzzing Created with: gclient setdep -r src/third_party/webrtc@d62ac3f0b830 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:959836,chromium:1009073 Change-Id: Id67092bd1507ca2c61443a8db8bdd8b2ac3a2337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854377Reviewed-by:
-
Dmitry Gozman authored
This moves some logic for previews state from RenderFrameImpl to FrameFetchContext, which already knows about previews state. Bug: none Change-Id: I6cf8febb27d88ab078ccb2101496f83ab613bddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849142 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#704880}
-
gogerald authored
Screenshot https://drive.google.com/file/d/1qg8pxjuJdN_d4YxeIpyssp-xFxbPjV1I/view?usp=sharing Bug: 982018 Change-Id: Id334c4b2b279e130703ce99a9e76f81ef1735920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854461Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#704879}
-
Elly Fong-Jones authored
The Tab menu in the Mac system menu bar has some options that target the foreground tab, like "Mute Site" and such. This change introduces alternates that show up for those items when Option is held which instead target the tab that has keyboard focus. This allows the user to perform those operations on a tab without having to activate it. There are no key equivalents for these new options (yet?), but they are still usable two ways: 1) By focusing a tab, then using Ctrl-F2 to move native focus to the system menu bar and navigating to the Tab menu, 2) By adding a user key equivalent corresponding to these items by name and invoking that at any time The main implementation complexity in this CL is that TabStripModel doesn't know about keyboard focus for tabs, and has no easy way of finding out about it without depending on implementation details of the TabStrip View. As such, this CL directly binds TabStrip (the View class) to BrowserCommandController. This change: 1) Has TabStrip (the Views View of the TabStripModel) observe its Tabs for keyboard focus changes and propagate these into the BrowserCommandController. 2) Adds new menu items to the MainMenu builder as alternates to the existing commands in the Tab menu. 3) Adds implementations of these commands in browser_commands. Bug: 818261 Change-Id: Ia222e412c53e19dde3cb19f38b18a8507f11f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829804 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704878}
-
Antonio Gomes authored
This CL wraps up Onion souping of media_stream_remote_video_source.cc|h that happened in [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1667727 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org hange-Id: I4b184a271b2b894d1b7d34e305a9fdf625404d9a Change-Id: Ic48da9a50cbe8a369850b4eb70a7b5896b0a6b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816795 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Bryan Clark authored
This allows callers to deference the result of CastMediaShlib::GetVideoPlane() without crashing cast_shell. Change-Id: I09b8a761359736195e42bec1708174a4e939a69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854186Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#704876}
-
Emil A Eklund authored
Bug: 1011885 Change-Id: Ibd96773c271a5a7021069cdee3676d9248783c7d Tbr: dgrogan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853287Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704875}
-
Sergey Ulanov authored
Encrypted media streams may contain unencrypted flames. That case wasn't handled correctly in FuchsiaSecureStreamDecryptor. Now it generates input packet with a single subsample entry with encrypted_bytes = 0. fuchsia.media.drm API currently needs key_id even for clear frames, see fxb/38253. To workaround this bug FuchsiaSecureStreamDecryptor now stores a key_id from the last OnNewKey() and then sets that key_id in the FormatDetails for clear frames. Bug: 1012525, b/141148085 Change-Id: I185e3a89086a3613b383b9ef75e59ef5e151cb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846323 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704874}
-
Ken MacKay authored
This allows other processes to directly control the mixer, eg volume control or postprocessor config changes. Bug: internal b/127963522 Change-Id: Ibd2dc3b320ae633c9b7ddc9b51889bff34d7f62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842272Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#704873}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d200a77a22cf..32bee0fd038e git log d200a77a22cf..32bee0fd038e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jmadill@chromium.org Fix debug layers being disabled everywhere. 2019-10-10 sugoi@google.com Correct presubmit error for missing Bug ID 2019-10-10 geofflang@chromium.org Update some implementation limits to match modern drivers. Created with: gclient setdep -r src/third_party/angle@32bee0fd038e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I01fc9d21cc652626146297d5e8593423620d1a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854265Reviewed-by:
-
Dan Beam authored
R=hcarmona@chromium.org Fixed: 1012997 Change-Id: I6b5c1cf5b740777b521034920fd56455f85e4293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851285 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#704871}
-
Geoff Lang authored
Adds these tests to the chromium.gpu.fyi bots only, and not trybots yet, due to lack of capacity. BUG=982294 Change-Id: I3332c981c4102577aaf1d16af29b3cd351637bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839031 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704870}
-
Rob Paveza authored
This change enables keyboard selection and navigation, as well as screen reader, for the Computed Properties pane of the Accessibility tool. Related nodes can now also be navigated-to by pressing the <enter> key while these nodes are selected. This change is a break-out and continuation of CL 1603344. Screencap: https://imgur.com/a/tcipWNX Change-Id: Id7702aa8c2d32cc0afe5215006db7f16b80af195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812105Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704869}
-
Josh Nohle authored
If no devices request the group private key in the SyncMetadata response, do not attempt to share the group private key. Before this CL, an empty map might be sent to CryptAuthGroupPrivateKeySharer::ShareGroupPrivateKey(), which would subsequently crash from a DCHECK requiring the map to be non-empty. Bug: 951969 Change-Id: I0561538ab2bad53b8e065d2e216b92c2e2b25933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851325Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#704868}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/66ae304f501e..7fd7a8aef06c git log 66ae304f501e..7fd7a8aef06c --date=short --no-merges --format='%ad %ae %s' 2019-10-10 egdaniel@google.com Remove uses of GrPixelConfig version of GrBytesPerPixel. Created with: gclient setdep -r src/third_party/skia@7fd7a8aef06c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I17f543676365171e3db36baae18a864b74986b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853582Reviewed-by:
-
Jinsuk Kim authored
Adds myself as an owner of gesturenav/ in javatests Bug: 937946 Change-Id: Ib1cdc2119855355ce8db55ff0e4ecc31bab72cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850682Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704866}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/4ca3339848cc..af60f62955c6 $ git log 4ca333984..af60f6295 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 yakimakha Bring cast/common/mdns up to date with style guidelines 2019-10-08 jophba Use TlsCredentials in TlsConnectionFactoryPosix 2019-10-08 rwkeane Address Comments From After Previous Checkin 2019-10-08 miu Cast Streaming Receiver: Consuming frames, resolving playout delays 2019-10-08 yakimakha mDNS querier. 2019-10-08 rwkeane TlsDataRouter takes Ownership of Listening Sockets 2019-10-08 rwkeane TLS: Add connection options 2019-10-08 rwkeane Unify Networking Thread: Update Existing classes 2019-10-08 rwkeane PlatformClient: API + Posix Impl 2019-10-08 mfoltz [Open Screen] Use RVO for local_address() and remote_address(). 2019-10-08 mfoltz Roll buildtools/ d5c58b84d..cf454b247 (22 commits; 3 trivial rolls) 2019-10-07 mfoltz Fix gcc compilation error. 2019-10-04 rwkeane Unify Networking Thread: Class Definiton 2019-10-04 yakimakha Make IsRunningOnTaskRunner non-abstract to fix upstream break 2019-10-01 btolsch Add CastSocket and implementation 2019-09-27 rwkeane Fix SocketHandleWaiter condition_variable bug 2019-09-26 yakimakha Add unique pointer that's deleted on the provided task runner 2019-09-25 rwkeane Move OSP_DISALLOW_COPY_AND_ASSIGN to public section for networking classes 2019-09-25 miu Fix for indefinite blockage in TaskRunnerImpl. 2019-09-25 rwkeane Rename NetworkWaiter -> SocketHandleWaiter 2019-09-25 miu Follow-up on Max's comments from last TaskRunnerImpl change. 2019-09-25 rwkeane TcpSocket: Integrate With NetworkWaiter 2019-09-25 rwkeane Rename NetworkReaderPosix -> UdpSocketReaderPosix 2019-09-20 jophba Add simple reading to TlsConnection 2019-09-24 miu TaskRunnerImpl stops by posting a "quit task" to itself. 2019-09-23 rwkeane TcpSocket: Impliment TLSConnectionPosix Write 2019-09-23 yakimakha Add notification callbacks to mDNS question tracker. 2019-09-20 miu Rename values of EncodedFrame::Dependency enum to improve readability. 2019-09-23 rwkeane Rename NetworkReader -> NetworkReaderPosix 2019-09-23 rwkeane TcpSocket: TlsNetworkingManagerPosix skeleton 2019-09-20 rwkeane TcpSocket: Fix TlsConnection SocketHandle 2019-09-19 miu Cast Streaming Receiver: Frame queuing and processing of RTP packets. 2019-09-20 rwkeane TcpSocket: Update NetworkWaiter to Subscriber Model 2019-09-20 yakimakha Add a debug-only guard to check if code is running on the task runner 2019-09-20 rwkeane TcpSocket: Add new TlsConnectionPosix constructor 2019-09-19 mfoltz [openscreen] Finish BUILD.gn cleanup 2019-09-18 jophba Add checking to UDP Socket creation 2019-09-18 rwkeane TcpSocket: Add Write Buffer 2019-09-18 mfoltz [Open Screen] Some BUILD.gn cleanups. 2019-09-18 btolsch Add framing for CastMessage 2019-09-18 jophba Fix building with Chromium 2019-09-17 miu Cast Streaming Receiver: Add RTCP processing. 2019-09-17 rwkeane Move files from platform/api to platform/impl 2019-09-16 yakimakha Implement OnRecordUpdated for mDNS question tracker 2019-09-13 yakimakha Update and expiration callbacks for MdnsRecordTracker 2019-09-16 jophba Add noexcept operators to move constructors 2019-09-13 jophba Refactor TlsCredentials to use util/crypto classes 2019-09-10 jophba Delete SslContext class + tests 2019-09-06 jophba Issue 72: Cleanups for ErrorOr 2019-09-16 rwkeane TlsSocket: Implement TlsConnectionFactory::Connect 2019-09-06 jophba Implement TlsCredentials construction 2019-09-11 rwkeane Update UdpSocketPosix to use FileHandle object 2019-09-10 rwkeane TcpSocket: Modify existing code for TcpConnectionWaiter 2019-09-10 yakimakha Rename record_class to dns_class in mDNS code 2019-09-10 yakimakha mDNS record refresh and expiration tracker 2019-09-10 btolsch Add cast channel authentication utilities 2019-09-09 yakimakha Add countof equivalent to sizeof to std utilities 2019-09-09 rwkeane TcpSocket: Refactor StreamSocket 2019-09-06 rwkeane TcpSocket: Remove accessors task_runner() and client() 2019-08-15 jophba Add TLSConnection + TLSConnectionFactory Skeleton 2019-09-04 miu Cast Streaming Follow-up: Receiver code comments and naming tweaks. 2019-09-04 yakimakha mDNS query tracker with continuous querying support 2019-09-04 miu Connect Cast Streaming to UdpSocket. 2019-09-04 rwkeane Adds platform factories for network and task threads 2019-09-04 yakimakha Fix std::move usages of tasks 2019-08-30 miu Cast Streaming: FrameCollector for collecting/assembling from packets. 2019-08-30 yakimakha Roll googletest dependency to pick up the new MOCK_METHOD. 2019-08-30 yakimakha Add CreateMessageId method to produce unique sequential mDNS message IDs. 2019-08-30 rwkeane Rename 'MockUdpSocket' to 'FakeUdpSocket' 2019-08-29 jophba Quick fix for build break 2019-08-29 rwkeane The Build is Broken! 2019-08-29 mfoltz [Open Screen] Random repository housekeeping. 2019-08-29 btolsch Add gcc try bot as experimental 2019-08-29 btolsch Fix gcc 8.2 errors 2019-08-29 rwkeane UdpSocket: Update Reads 2019-08-29 yakimakha Add a class for generating random delays as per mDNS RFC 2019-08-28 miu Cast Streaming: Tracking and computation of RTP arrival stats. 2019-08-28 miu Cast Streaming: Receiver skeleton, demo app, and usage documentation. 2019-08-27 yakimakha Change mDNS record TTL type from uint32_t to std::chrono::seconds 2019-08-27 rwkeane UdpSocket: Update Reads - Remove Deletion Callback 2019-08-27 rwkeane UdpSocket: Update Remaining Configuration Methods 2019-08-15 jophba Implement POSIX stream sockets 2019-08-26 rwkeane UdpSocket: Close socket when an error occurs 2019-08-22 miu Cast Streaming: SenderReportParser::Parse() exposes report ID. 2019-08-23 btolsch Add revocation list support to cast certificate checking 2019-08-23 rwkeane UdpSocket: Update Mock method names 2019-08-23 rwkeane UdpSocket: Update Read - Update cast/* 2019-08-23 rwkeane UdpSocket: Update Bind call 2019-08-23 btolsch Add optional chromium try jobs 2019-08-23 btolsch Update README.md with current bot info 2019-08-22 miu Cast Streaming: Change EncodedFrame API to allow external buffers. 2019-08-21 rwkeane Fix 1 line bug 2019-08-21 rwkeane Udp Socket: Update Writes 2019-08-20 btolsch Remove gcc bots Created with: roll-dep src/third_party/openscreen/src Change-Id: I3506587f58f608477e19d2f5065fbd447dbacc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854264 Commit-Queue: Jordan Bayles <jophba@chromium.org> Auto-Submit: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704865}
-
Henrique Nakashima authored
This a step to make FeatureUtilities easier to maintain. - Move most static variables in FeatureUtilities to a static Map. - Deduplicate code into isFlagEnabledWithDefaultFalse(), isFlagEnabledWithDefaultTrue(), and cacheFlag() - Keep the public API intact for now This is not a final solution, but it highlights the quirks in each usage so they can be clearly refactored out, and makes it easier to migrate to the solution we decide for. Bug: 1012975 Change-Id: Id155ec60dbcb1170ef39bc6e3f1b759ef7b63692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850820 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Always request bluez to stop discovery; do not gate on whether or not discovery is active. The recent refactor crrev.com/c/1699214 in BluetoothAdapter and its children classes resurfaced a buggy implementation of BluetoothAdapterBluez::IsDiscovering() (crbug.com/905374) -- its implementation in bluez can sometimes return an incorrect value. In this particular bug, crbug.com/1013020, when ARC++ spammed BluetoothAdapterBluez with too many Start/Stop scan calls, we entered a racy situation in which ARC++ called StopScan(), and that StopScan() incorrectly early-returned, failing to stop discovery, because BluetoothAdapterBluez::IsDiscovering() incorrectly returned 'false'. the repro steps described in crbug.com/1013020. Bug: 1013020, 822104, 905374 TEST: Manaully verified 5 times on both M78 branch and ToT following Change-Id: Ide80706d77f1659cc07f457c4a524d823141f2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854459 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704863}
-
Daniel Rubery authored
In rare cases, the real time URL lookup response can still arrive after the timeout has triggered in the SafeBrowsingUrlCheckerImpl. This can lead to reading off the end of urls_. Bug: 1012813 Change-Id: I5662f9d3c7dac5c50289e6a571e3e992d092522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853088 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704862}
-
Austin Eng authored
These tests are failing on every run. Bug: chromium:1013295, dawn:208 Change-Id: I4e625753a4b39807e62905bf7aa8cef6297317a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853992Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#704861}
-
Toby Huang authored
Currently, screen readers narrate "Setup parental controls" for the title of the Add Supervision dialog. This phrase is unclear and should be changed to "Setup parental controls dialog" instead to describe the top-level dialog more clearly when in focus. Bug: 1011556 Change-Id: I82707b26c80354dfbe1395d8f3a33517be8231db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842633Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704860}
-
Yutaka Hirano authored
The bug broke extension scripts cancelling WebSocket connections in onBeforeRequest handlers with "extraHeaders" option. Bug: 1011108 Change-Id: I6aec9ff124384b80818955ee66cad05a016579bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844912Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#704859}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51c8a7860a5a..383a4e801d41 git log 51c8a7860a5a..383a4e801d41 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 dproy@chromium.org Add .py extension to update_chrome_reference_binaries Created with: gclient setdep -r src/third_party/catapult@383a4e801d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I47916be7ebb527e672948d533671a5dd053ce9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854359Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5697a837..d372b6c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb355cdaded845b33408854fc568f265bb90ec5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704857}
-
John Emau authored
Problem: When a web audio context change event occurs the "changed to" context is first removed from the context selector list then added back. If the list only contains 1 items then the list contents goes 1 -> 0 -> 1 and the event listener AudioContextSelector._onListItemReplaced will intermediately disable the context menu during the change event when the empty state list is reached. This can cause side-effects and is extra cycles we don't need to spend. Solution: The UI.ListModel.replace method does the same operation without the intermediary empty list state. Change-Id: Ide76e2281c6c7224c22e77f3e7a5766fb2ef0a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823730 Commit-Queue: John Emau <John.Emau@microsoft.com> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704856}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/364848cc9284..f1f2e8606a69 git log 364848cc9284..f1f2e8606a69 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 efoo@chromium.org Add "# COMPONENT" to chromite OWNERS file Created with: gclient setdep -r src/third_party/chromite@f1f2e8606a69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3e5452344b46279175bd06d3c46e2dab38f4d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853999Reviewed-by:
-
David Tseng authored
Bug: 865575 Change-Id: I8d8328a459d7621d6fc0a0d65e0f24f788b9767f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852414 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704854}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60e30b8a1a53..561ba7ee890b git log 60e30b8a1a53..561ba7ee890b --date=short --no-merges --format='%ad %ae %s' 2019-10-10 primiano@google.com Add gen_all --check-only to CI Created with: gclient setdep -r src/third_party/perfetto@561ba7ee890b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:123498112 Change-Id: I341cdf88d08771bde74853e7a02a02302b666a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853996Reviewed-by:
-
Dave Tapuska authored
Add a post dispatch hook so message filters can do work after a dispatch. This will be used for the content layer which sets the debug URL during each message dispatched. Since only one filter is ever used only allow one to be set. BUG=1008432 Change-Id: Ie531e875ea9cbf42347374030d3c5a030fa6290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853129Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#704852}
-
Dan Beam authored
Also annotate other teammates relationships to this code. R=mahmadi@chromium.org BUG=none Change-Id: I3eabc0422737c1ef0184fc554890308850ccb8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854399Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704851}
-
Evan Stade authored
All activity logging is done on the UI thread now, so there's no need for a thread-safe cache of extension whitelists or ActivityLog active state. Bug: 268984 Change-Id: I3c35017cb8413be59a270a96e587f3c401e80b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849419Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#704850}
-
