- 07 May, 2018 14 commits
-
-
Sasha Morrissey authored
Adds a 'Manage in Drive' button to the context menu for entries in the Files app for ChromeOS. Creates a new DriveManageAction which appears enabled only for non-directory entries (for now) in Drive when offline mode is not enabled. Uses getEntryProperties() for the entry to get its 'alternateUrl' (provided by the Drive Sync API) and navigates to this URL in the browser. 'Manage in Drive', ensure the browser window opens and navigates to the file. Test: Right-click on a file in Google Drive in the File Manager, select Bug: 831480 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieaa359b9e825bef166ea25ec23ae1693681d91f7 Reviewed-on: https://chromium-review.googlesource.com/1011465 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#556375}
-
Victor Costan authored
The ServiceWorkerContextCore constructor declaration uses user_data_directory as the name of its base::FilePath argument. However, the definition renames the argument to "path". This less expressive name is then used in ServiceWorkerStorage. This CL replaces "path" with "user_data_directory". This adds clarity to the code and adds consistency between declaration / definition argument names. Change-Id: Ib5dc48d5c935a84e654b8b057858fb18b2be6ee5 Reviewed-on: https://chromium-review.googlesource.com/1045909Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#556374}
-
Matt Falkenhagen authored
According to UMA this doesn't happen since 65. The original bug about a reused/crashed process host was probably fixed when we removed the extra thread hops after allocating a process. Then the remaining bug issue 781313 was fixed in 65, which was causing a process from the wrong storage partition to be allocated. Also simplify SendStartWorker() by removing the return value. Change-Id: I0dddd731c4c512e21b4644b19b074b8bcbdfcd5b Reviewed-on: https://chromium-review.googlesource.com/1037048Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#556373}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia33e986c7be678e90351a0a0dd6e08cd8903137a Reviewed-on: https://chromium-review.googlesource.com/1046004Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556372}
-
Tetsui Ohkubo authored
ChromeOS.SystemTray.TimeToClick metrics for UnifiedSystemTray was recorded in old SystemTray class. Reference from UnifiedSystemTray to SystemTray will be removed in the future, so this is not preferable. This CL adds Delegate to TimeToClickRecorder to fix this. TEST=manual(chrome://histograms) BUG=834462 Change-Id: I249ae40bb471d833bcc24242ade9efc778e295df Reviewed-on: https://chromium-review.googlesource.com/1029565 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556371}
-
Patti authored
Currently, All Site list entries are not reuseable. These will eventually become entries that represent an ETLD+1 site, with a list of origins as its children, so factor out the existing entries into a separate Polymer element. This is needed as they will also in future be used as site-list entries. This patch also fixes the UI in All Sites to have entries on a single line, when previously the icon, origin and arrow displayed were misaligned. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66315496599f8c8d04309048ca897585a3bb431c Reviewed-on: https://chromium-review.googlesource.com/1041628 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556370}
-
Yuri Wiitala authored
When the Audio Service will be running in its standalone process, the worker thread will be used to drive the audio flows for the loopback streams, as well as all the fake streams (including the those used for muting). These things should not become blocked by long-running control tasks on the main thread. Bug: 824019 Change-Id: I6b7fd4cb110842c70a26072161dc91929ed4f19d Reviewed-on: https://chromium-review.googlesource.com/1046153 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556369}
-
Patti authored
Refactor TableView and TableModel so that the size of the icon requested is provided when the TableView is retrieving the icon. This avoids duplicating the icon size in places other than TableView, and fixes one specific issue where the bluetooth connected icon used in the device chooser dialog did not specify any size, triggering a DCHECK. Bug: 838052 Change-Id: I14e7463b086c77615286e38100fe7e0f94d8fd34 Reviewed-on: https://chromium-review.googlesource.com/1036684 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556368}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44700b6e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17090 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6f81262b031ca2d8d4db9c388b1f212b89e930b4 Reviewed-on: https://chromium-review.googlesource.com/1046139 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556367}
-
John Abd-El-Malek authored
Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9a74ae26c42cf2672d382d178da76f22f5758fb2 Reviewed-on: https://chromium-review.googlesource.com/1045555 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Hiroshi Ichikawa authored
Before this change, added script commands were cleared when state restoration (-decodeRestorableStateWithCoder:) happens for a CWVWebView. The script commands are preserved after this change. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I06b3d7ebedc3216930516ecadcef84ab943f5a1f Reviewed-on: https://chromium-review.googlesource.com/1032316 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556365}
-
Sam McNally authored
Bug: 823607 Change-Id: I763d48015011dc4cb59d1e5d15cc78b9cf13f2b7 Reviewed-on: https://chromium-review.googlesource.com/1032271Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
These tests are timing out on Mac: * virtual/layout_ng/fast/inline/inline-empty-block-continuation-remove.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-after-spanner.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-before-spanner.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-between-spanners.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-inline-and-spanner-after-spanner-foreignObject.html TBR=eae@chromium.org Bug: 840208 Change-Id: Ibf439881543b665ac8065c2b0bc2db4148ac2d1e Reviewed-on: https://chromium-review.googlesource.com/1045956Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556363}
-
Noel Gordon authored
Add FileManageBrowserTestBase private helper routines: IsGuestModeTest and IsIncognitoModeTest to return true when the test extension browser test has that GetGuestMode(). Use the helpers everywhere. The "isInGuestMode" command actually wants to know if the test runs in guest or incognito mode, or not. Write that out explicitly in its code and add LOG(INFO) and ASSERT_EQ() for even more explanation. Move "isInGuestMode" command so it's the first, move "getTestCaseName" command so it's third, to match the call order the test extensions use to call them: isInGuestMode, getRootPaths, getTestCaseName [1]. Minor change to getRootPaths: call the variable downloads_root. [1] The test extensions call in this order always and once these three are done, the test extensions start running the test case. Another way to think about it is: these three commands are preliminary set-up that every Files.app browser test case requires. All remaining commands are specific to the current test case. Bug: 833834 Change-Id: Ida01b88e745df6bf4b760aa421d36c5d8e872ecd Reviewed-on: https://chromium-review.googlesource.com/1043672Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556362}
-
- 06 May, 2018 14 commits
-
-
Noel Gordon authored
Bug: 833834 Change-Id: I4eb15bf48c996adad73f72597718b82af1069654 Reviewed-on: https://chromium-review.googlesource.com/1045948 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: Icd0d30ca1665e843d13c9d3521d3038a08a8488b Reviewed-on: https://chromium-review.googlesource.com/1043007 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556360}
-
Kristoffer Erlandsson authored
Does the connection setup in a specific sequence that historically triggered a deadlock (https://crbug.com/736725). The test simply verifies this specific sequence completes without errors. Verified it fails on the deadlock by running the test on the parent commit (2485344d)of the original bug fix. BUG=chromium:818584 Change-Id: I3245de0b8f824a83f26a310d8f12bba45aea0958 Reviewed-on: https://chromium-review.googlesource.com/1044196 Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#556359}
-
Xianzhu Wang authored
- Disable virtual/video-surface-layer/ and virtual/threaded/fast/animationworklet/ because most of the tests under the (virtual) directories fail, to save our time to update expectations for individual tests when new tests are added. - Rebaseline paint/invalidation/table/replace-col.html - Add 3 failures. TBR=trchen@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8740d4451fb77ba4b8c6df1c99cf9aaa72d09603 Reviewed-on: https://chromium-review.googlesource.com/1046149 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556358}
-
Abhishek Arya authored
TBR=mmoroz@chromium.org Bug: 784464, 836663 Change-Id: I09c05445b1a86de19ef41d40e7e6fa72ce361390 Reviewed-on: https://chromium-review.googlesource.com/1046151Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#556357}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32d8f883bd4e..95e2b91d76d6 $ git log 32d8f883b..95e2b91d7 --date=short --no-merges --format='%ad %ae %s' 2018-05-06 egdaniel Revert "Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice" 2018-05-06 egdaniel Revert "Restore old SkBitmapDeviceFilteredSurfaceProps" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ie12bb6049116e432d57c9e7fa3b3d21e8ddcbd1a Reviewed-on: https://chromium-review.googlesource.com/1046147Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556356}
-
Ken Buchanan authored
Select menu dropdowns use LocalFrameView::ContentsToViewport to determine what part of the menu intersects with the window viewport. This doesn't work in OOPIFs because LFV::ContentsToRootFrame only converts coordinates into the local frame root's coordinates, not the main frame. The consequence is that menus in large iframes that have been scrolled into view will falsely report to be out of view. This patch changes the intersection calculation to use LayoutView::MapToVisualRectInAncestorSpace(), which determines the viewport intersection while accounting for OOPIF containers. Bug: 837639 Change-Id: If265e24ad4cbee967fdb97ae85002a81e75033a7 Reviewed-on: https://chromium-review.googlesource.com/1036232Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#556355}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I1884f38a68ea2d32c1c874d9896416455e3ba9ef Reviewed-on: https://chromium-review.googlesource.com/1046148 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556354}
-
Sergey Ulanov authored
The tests are not expected to timeout anymore with TSC clock Bug: 731302 Change-Id: I747383b85fec029b9edfe375ed436b1586a2a544 Reviewed-on: https://chromium-review.googlesource.com/1045620Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556353}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: I89364cc511cbf1ab12f638d0ab31611ea34378f8 Reviewed-on: https://chromium-review.googlesource.com/1046131Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556352}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I07051aa0107be16f466b94841c1f056b6ebfc685 Reviewed-on: https://chromium-review.googlesource.com/1046113 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556351}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70d24bb2..0cb7b82e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I73b2d7e224987fd3505cf6f3e79154be9e2b365f Reviewed-on: https://chromium-review.googlesource.com/1045993Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556350}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Icd09aea13117af1c4bf03846d3a7d61556bafffe Reviewed-on: https://chromium-review.googlesource.com/1046129Reviewed-by:
-
Max Moroz authored
Also write output of llvm-cov export program on the disk (needed for the bot). Plus some refactoring for logs from target programs: - redirect stderr from targets into stdout to be written into a .log - write logs into its own subdir for better output structure Not output folder structure look as follows: $ ls -l out/zreport15/ total 8 drwxr-x--- 5 mmoroz primarygroup 4096 May 4 10:53 linux -rw-r--r-- 1 mmoroz primarygroup 2519 May 4 10:53 style.css $ ls -l out/zreport15/linux/ total 48 drwxr-xr-x 2 mmoroz primarygroup 4096 May 4 10:53 components -rw-r--r-- 1 mmoroz primarygroup 1627 May 4 10:53 component_view_index.html -rw-r--r-- 1 mmoroz primarygroup 4672 May 4 10:53 coverage.profdata -rw-r--r-- 1 mmoroz primarygroup 241 May 4 10:53 directory_view_index.html -rw-r--r-- 1 mmoroz primarygroup 7416 May 4 10:53 file_view_index.html -rw-r--r-- 1 mmoroz primarygroup 200 May 4 10:53 index.html drwxr-xr-x 2 mmoroz primarygroup 4096 May 4 10:53 logs -rw-r--r-- 1 mmoroz primarygroup 7483 May 4 10:53 summary.json drwxr-x--- 3 mmoroz primarygroup 4096 May 4 10:53 usr Bug: 784464, 836663 Change-Id: I3283f16b62cfeb267bb2b3092fa469d5ff39ef14 Reviewed-on: https://chromium-review.googlesource.com/1044652 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
- 05 May, 2018 12 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9be6ec5e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16966 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I384b7df6d0e870e2fdfcaef877cc59f4cbfa93ea Reviewed-on: https://chromium-review.googlesource.com/1045803 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Wez authored
We already DCHECK that |ptr_| is valid in GetWeakPtr(), but this extra check ensures we catch mis-use earlier. Change-Id: Id62dc3cbe6c4e33f08bb1d5c5c2e304aa01c53a8 Reviewed-on: https://chromium-review.googlesource.com/1042485Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556346}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 690f3329. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16965 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I00f8564beca7667e679bbf7124c8ef9b5205e289 Reviewed-on: https://chromium-review.googlesource.com/1045987 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 707f4d3e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 556340 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcwN2Y0ZDNlNzgxZGIwZjUxZjQ5MzBjNTAxOTRkMmNkMWU3YWUyZDYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5528 Sample Failed Step: interactive_ui_tests Original change's description: > Fully integrate the Select-to-Speak tray button with the extension. > > This change lets taps to the tray button control changes in the Select-to-Speak > extension page. It also adds integration tests. > > A large part of this change is adding a mojom test API to allow the ChromeOS > integration test to find and tap the Select-to-Speak button in Ash. > > Bug: 753018 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6 > Reviewed-on: https://chromium-review.googlesource.com/1041210 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556340} Change-Id: I7a62f01228147f07a681275916533cf53d339332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1046026 Cr-Commit-Position: refs/heads/master@{#556344}
-
Chris Harrelson authored
Based on CL 1033824 This patch adds three tests and test the following: - Filtered block establishes a container for fixed and abs pos. - Filtered inline establishes a container for fixed and abs pos. - Filtered <html> does not establish a container for fixed pos. Bug: 795549 Tbr: vmpstr@chromium.org Change-Id: I3fa13cc7f478503583a191bfb434cdab860862ef Reviewed-on: https://chromium-review.googlesource.com/1045727 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556343}
-
Christopher Cameron authored
RecyclableCompositorMac owns a ui::Compositor, but the surface id generation was owned by BrowserCompositorMac. A RecyclableCompositorMac will be recycled by many different BrowserCompositorMac, and as a result, it may have a non-monotonic- increasing surface id. Scope the surface id information to RecyclableCompositorMac, and throw some of the related logic into a helper function. Bug: 772576, 817827 Change-Id: Ic4299afa5670c96b51260917a3fafb2b692b3465 Reviewed-on: https://chromium-review.googlesource.com/1046045Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#556342}
-
Yuri Wiitala authored
This is a simple test utility that will be used in upcoming tests to act as a final consumer of audio in loopback unit tests. It records all the audio samples given to it, and then provides useful utility methods to analyze/interpret the signal. Bug: 824019 Change-Id: I0ef3476b2e8004c77265a85d51f5dd69a3b309b3 Reviewed-on: https://chromium-review.googlesource.com/1041653Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556341}
-
Katie D authored
This change lets taps to the tray button control changes in the Select-to-Speak extension page. It also adds integration tests. A large part of this change is adding a mojom test API to allow the ChromeOS integration test to find and tap the Select-to-Speak button in Ash. Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6 Reviewed-on: https://chromium-review.googlesource.com/1041210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556340}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f3313d8. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16955 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I667e88e5e25093acc6314240ee38bbf574992c48 Reviewed-on: https://chromium-review.googlesource.com/1045802 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Scott Violet authored
This makes it so that if an app requests the WindowService it's launched in Ash. This is only enabled if --mash and --mus is not specified. BUG=837686 TEST=none Change-Id: Ic01879e0aff8828b17c0652bd74078daba628d40 Reviewed-on: https://chromium-review.googlesource.com/1045248 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 5157 5161 5163 5181 5182 5187 5195 5200 5206 5207 5208 5209 108 lines were removed and 21 lines were deflaked by consecutive results since 5129. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7fac4144cc97aaec933727bf2994edd7b0b37e81 Reviewed-on: https://chromium-review.googlesource.com/1042665 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556337}
-
Fady Samuel authored
LocalSurfaceId is plumbed to WebContents for auto-resize but never used. This CL deletes that plumbing. Bug: 672962 Change-Id: I851c17d856fc72405e5893ddbe80e36bc068af49 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1045911Reviewed-by:
-
