GitLab

Bug: 994488
Change-Id: I7d40a2a5faa0e030057c12119c1f0b2762bd091e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761397Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688327}

Implement the gesture fling handler for ScrollableShelfView

Bug: 973481
Change-Id: I1acee6b12cf8beeb55d637ceba1820e3cd088596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758596Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688326}

Bug: None
Change-Id: I632edbdac0f9f40a6d34cf2efd9ffabb8b5a9ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761388
Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688325}

Bug: 993611
Change-Id: Ic55ad673343ace5faf48f7912ac5b615d0043d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751776Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688324}

This reverts commit 9cf67d23.

Reason for revert: Causes a compile failure on linux-chromeos-google-rel

BUG=995590

Original change's description:
> [multi-profile]Speculative fix for crash while loading AppList search
> 
> Either we are attempting to emplace() past the last element of the
> vector, or the index is negative somehow. Fix the first condition and
> check for the second.
> 
> Bug: 992344
> Change-Id: Id3f6a71a9d5ab3ad41079f9ed1fa7067238faae8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761295
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688279}

TBR=newcomer@chromium.org,mmourgos@chromium.org

Change-Id: I245a4b3c01aa86f5ba7178340647963b94a291f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 992344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761345Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688323}

This was added in support of the Telemetry-based GPU tests and I
should be able to review changes to this file and its header.

Bug: 985486, 984780, angleproject:3701
Change-Id: Ib346b273b8e646b43747b081bf14002f3494be3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761159Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688322}

Added tests similar to TestLauncher unittests to run
3 simple content tests and validate the TestLauncher json result file.

Common methods for validating resulting json file were
moved to test_launcher_test_utils.h/cc.

Bug: 936244
Change-Id: I8dee29f80f82ca5981f7343e9ffec4cacc95eeaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743099Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#688321}

This fixes an issue which caused a crash, where a combination of re-creating a node and walking NextOnLine() caused a continuation to be set as the cached parent of an AXObject.

When the actual node parent queried its children, the child for which the continuation was cached as a parent was reported as an "indirect" child, causing the child not to be properly cleaned up when moving in the DOM.

Fixed by never allowing continuations to be non-ignored, or cached as parents.

The test is a little unsatisfying as it's both not *guaranteed* to fail if the bug is present (though in my testing it always did), and it requires a series of reloads. I did spend a lot of time trying to find a better way, and failed.

Bug: 989969
Change-Id: Ie268adb4679052443c4fe6ecea2149918147a1a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753378
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688320}

https://pdfium.googlesource.com/pdfium.git/+log/9bf01811ac13..d41929adaddf

git log 9bf01811ac13..d41929adaddf --date=short --no-merges --format='%ad %ae %s'
2019-08-19 thestig@chromium.org Split CPDF_CMapParser::ParseWord().

Created with:
  gclient setdep -r src/third_party/pdfium@d41929adaddf

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I03430b3fc9cb8786d33088d9bb659b5dfc00af36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761198Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688319}

R=csharrison@chromium.org

base: :LazyInstance is officially deprecated
Change-Id: I94f041f59362c44a9a2af15e05717899a0327dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761347Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688318}

I incorrectly assumed ProfileImpl was also used by incognito profiles, this
fixes that assumption by also returning the correct permission context in
OffTheRecordProfileImpl.

Bug: 992516
Change-Id: Ia3286aa4d6903dc028a3839b36f00dac50cb2204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746837Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688317}

fast/css/forced-colors-mode/forced-colors-mode-12.html was detected as
flaky. This tests animations in forced colors mode. Looking at other
animation tests, it looks like the issue was that I needed to add
"media="screen"" to the style element.

Bug: 994465
Change-Id: I982343bf05e3aa4ac4df2caab0373103f5165cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758706Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688316}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

CR+1 from all parties.

NOPRESUBMIT=true
Set due to folks in OWNERS files lacking permissions to LGTM.

Bug: 977050
Change-Id: I3f82b04e138e65cd808670db46ab82a48dd580b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700855
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688315}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

CR+1 from all parties.

NOPRESUBMIT=true
Set due to folks in OWNERS files lacking permissions to LGTM.

Bug: 977050
Change-Id: I17a6e403810ad7c2e1c011e561e7fce832ee541a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700912Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688314}

This mirror's MenuButton's implementation.

Bug: 995182
Change-Id: I98f64d067980aed77a666fd8491c52b49d234da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760143
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688313}

Fix for a crash that occurs while the AppList is closing. We assume the
layer exists, yet a few optimizations have been implemented which
may result in layers being destroyed when they are no longer needed.

Bug: 994409
Change-Id: I1d99f34c32e18ef70a3784b1e5337c1530cba872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761308
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688312}

https://skia.googlesource.com/skia.git/+log/eb3eb98eb6b8..0d6f77537a4c

git log eb3eb98eb6b8..0d6f77537a4c --date=short --no-merges --format='%ad %ae %s'
2019-08-19 csmartdalton@google.com Add GrvkGpuRTCommandBuffer::appendSampledTexture
2019-08-19 brianosman@google.com Temporary Lua hook to measure impact of conservative convexity
2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@0d6f77537a4c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: Ief5f4886603b66ca5b5bc619fb6218f0dfd00bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761196Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688311}

This was a typo that resulted in empty Milo UI entries:
https://ci.chromium.org/p/chromium/g/chromium.goma.migration/console

R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org

Bug: 950413
Change-Id: I206fa2f090299f563ce62da6e54c1b711ee871c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761342
Auto-Submit: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688310}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d272ed1e68f8..199e517c52c6

git log d272ed1e68f8..199e517c52c6 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 akeshet@chromium.org test_stages: fix temporary hack for moblab boards

Created with:
  gclient setdep -r src/third_party/chromite@199e517c52c6

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I283fbbee90d450c4a1698f8449224f246140e0bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761197Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688309}

The thread ServiceWorkerContextCore lives on (the "core thread") will
move from the IO thread to the UI thread.

This makes service_worker_browsertest.cc core thread-aware instead of
assuming the IO thread. Some tests start to pass when the flag
is enabled locally. After this, the plan is to fix tests that fail.

Bug: 824858
Change-Id: Id7032f875c068e4a5af2ea620d7bdaaa9146e7b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760573
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688308}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ib86df4c2ffa933a36af6abf86437956c418e1818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700913Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688307}

Currently, URLPattern will trim the host piece from whitespace. However,
this doesn't really make sense:
- It doesn't handle whitespace within host components
- It doesn't handle other invalid host characters

Rather than do this, just rely on the host canonicalization (which
is done through net::CanonicalizeHost()).

Note that GURL (and net::CanonicalizeHost()) both allow various host
inputs which would normally be invalid, include spaces (which are
escaped to %20, but '%' is also an invalid character in a host).
However, this is better than arbitrarily treating whitespace
differently.

Bug: None

Change-Id: Ia32c26071e6afdd35386775b345a658937acbe0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749579
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688306}

Allows embedders to handle popup window requests from web content
(e.g. "window.open", navigation to links with target="_blank").

Bug: 888131
Change-Id: I7fef0525b6b043494cd462deb66f854e657af670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548586
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688305}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I81ceb84acc15c073b92c2d24531df7802bd9ba49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699949Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688304}

This reverts commit 3ea87442.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 688173 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlYTg3NDQyYmY1MTk4Mzc1ZWQzODU2MmEwYTZhMTEzOTI0M2QwNjIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/55899

Sample Failed Step: browser_tests

Original change's description:
> Better success detection for pw change
> 
> Only slightly improves success detection at this stage,
> by adding Azure support - Ping and Okta are still pretty
> lacking - but makes room in the code for better success
> detection, and adds a unit test.
> 
> Bug: 930109
> Change-Id: I59a173095301f7c641031f79cb3a6c946c5efc09
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754013
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Lutz Justen <ljusten@chromium.org>
> Commit-Queue: A Olsen <olsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688173}


Change-Id: I2e20b20503381c181ed94b133a4099c70e5104fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761344
Cr-Commit-Position: refs/heads/master@{#688303}

This CL addressed guidou's remark on [1], that
was accidentally left off when splitting the CL into
smaller pieces.

[1] https://crrev.com/c/1757490/4/third_party/blink/renderer/modules/modules_initializer.cc#185

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ie46cc5eeb9963dc54538d122b0c922a5ec5c4e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760407Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#688302}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ie7f2051e4b6c9c4af7880597550949c02162d5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700854Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688301}

This adds code to recognize platform serial ports which aren't on a
particular bus like USB. They are identifiable because they end up in
the /devices/platform namespace.

Bug: 981483
Change-Id: I95613d57fd81a1edd060b140fd9b47f5297037b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760986Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688300}

This reverts commit 5e608df4.

Reason for revert: The problem was a typo ("dEQP" not "eDQP"), not a missing builder

Original change's description:
> infra: Delete eDQP builder Milo entries
> 
> These builders no longer exist. The Milo UI entries are blank:
> https://ci.chromium.org/p/chromium/g/chromium.goma.migration/console
> 
> R=​bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org
> 
> Bug: 950413
> Change-Id: I362d1e4260f949c9ce32f228828ffb6ed0910f8b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761332
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Simon Que <sque@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688292}

TBR=sque@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: Ib5531f38fceaf47211eb8409ea9309198a462474
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 950413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761406Reviewed-by: Simon Que <sque@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688299}

Geoff has nearly single-handedly developed the passthrough command
decoder and is well versed in the code in this directory.

Bug: none
Change-Id: Ic2e87bd485b4274270abbd562a729b84d3637c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758737Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688298}

- Moved IconConverter ownership to IconStore.
- Added MockIconConverter in the unittest for future use.
- Cleaned-up all other legacy icon_converter uses in codebase.

Bug: 963290
Change-Id: I3ae60dcc8df936033d1c72eb806d54f485f0519a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759206
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688297}

This fixes Finch presubmit warning for GroupSuggestionsBySearchVsUrl
experiment.

Bug: 990865
Change-Id: Id294e8de22098e7d5750fb393f6f7ed158ad12c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760459Reviewed-by: Ender <ender@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Ender <ender@google.com>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688296}

Bug: 994293
Change-Id: I2446ed845f08b5173ac25fe836e50b114f58cf45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756545
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688295}

When we get asked to close a tab, actually close the tab before
finishing the Activity for tests that test that a tab actually closes
(and proactively defend against tabs that were closed sticking around
after relaunching).

Bug: 983743
Change-Id: I61771961edd8524b851bffc741a9b37e28e524e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758629
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688294}

Add a test to prevent future regressions.

BUG=991919

Change-Id: I41ebd4f5cee6375f0cb2d510b8d4e91d356a1bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761226Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688293}

These builders no longer exist. The Milo UI entries are blank:
https://ci.chromium.org/p/chromium/g/chromium.goma.migration/console

R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org

Bug: 950413
Change-Id: I362d1e4260f949c9ce32f228828ffb6ed0910f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761332Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688292}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7dcd6b790228..1c3b93db4826


Created with:
  gclient setdep -r src-internal@1c3b93db4826

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Id327494c09eae96e9c3ba79cb5621538f88f2747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761195Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688291}

BUG=992838

Change-Id: Idc6ab38c6f40224188312f9f6804857fcf48828f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757299
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#688290}

- chrome_content_browser_client.cc: Include the --disk-cache-dir switch
  value when computing GetNetworkContextsParentDirectory().
- network_quality_estimator_prefs_browsertest.cc: Create the network
  state file in the profile directory, rather than a temp directory,
  since the network service sandbox does not permit accessing the
  latter.
- service_process_control_browsertest.cc: Only override the child
  process path when launching the service process, so that the path
  override does not affect other child process types.
- shell_browser_main_parts_mac.mm: Expand the sandbox for the //net
  test certificates when running the shell outside of browser tests.
- shell_content_browser_client.cc: Implement
  GetNetworkContextsParentDirectory() for Content Shell's profile.

Bug: 915910
Change-Id: Ifbe481abdfed9d00c694865282ba316033749867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756153Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688289}

For
https://chromium-review.googlesource.com/c/chromium/src/+/1755125

Bug: 876922
Change-Id: I944eb771d41b4aa93db271a58eff025139d64aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757956
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688288}