- 24 Apr, 2019 40 commits
-
-
Lan Wei authored
When we have keyboard events and mouse events send together, we should set key modifies in mouse events. This test first presses some keys then send some mouse events. This test only works on Chrome. Bug: 606367 TBR=nzolghadr@chromium.org Change-Id: Idad0bcca2c03f961f6c6af211d7f843f06e14fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544170Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#653672}
-
Adam Ettenberger authored
1. ITextProvider::get_DocumentRange was returning an incorrect range end in some cases. If the node has soft line breaks, then the |start| would be at offset (0) for the first inline text box child of the static text, then end would be the last offset of the first inline child. This is beacuse |start| was a leaf text position, and |end| was based on that value. Calling |CreatePositionAtEndOfAnchor| before normalizing |end| to a leaf text position. Additionally, BrowserAccessibility treats text-only nodes as leaf nodes. Which means, |owner()->GetChildCount()| is (0) for the kStaticText even though it technically has children. 2. AXRange::GetScreenRects normalized the |current_line_start| as a parent position, but not the |current_line_end|. It would then pass incorrect text offsets to |GetRangeBoundsRect|. Normalizing the |current_line_end| as well so the offsets are correct. Bug: 847971 Change-Id: I439ae04d066fc087c9b1f1c14df5bbfc76af53fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575107 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653671}
-
Oystein Eftevaag authored
Startup tracing is currently causing deadlocks when Perfetto is enabled, in specific circumstances; since we don't currently need it on Android when background tracing is used, I'm temporarily disabling it to progress work on other areas of the pipeline. R=ssid@chromium.org Bug: 941318 Change-Id: I97609b059b9469e1a677c490aced9237c5043ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579781 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#653670}
-
jchen10 authored
If the extension hasn't been requested, the limit is 2, otherwise at least 4 and no more than half of hardware_concurrency(). Bug: 953687 Change-Id: I3051a4ee18b10c6c21487f7e06a6170aed1b5e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575970 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653669}
-
Jan Krcal authored
Tests that setup local data and only after that SetupSync are flaky on multiple bots. This spans many different integration test files and probably lies deeper in the interaction of Directory and USS types (these tests become very flaky after the last type gets switched to USS on trybots). This CL switches to sequential setup for such flaky tests for autofill_profile. In follow-up CLs, this will get fixed for further affected tests. Bug: 956043 Change-Id: I0e3c3bb76cbe1825ea5d55b6103972077b825e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581806 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653668}
-
Adam Langley authored
This change causes errors from parsing the authenticator extension outputs to be logged to chrome://device-log. Change-Id: Ide4a5d4514f5af51a2d36ce309dfd286edb84d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579913 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#653667}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/95b5ef9328dd..d153d1ae1284 git log 95b5ef9328dd..d153d1ae1284 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 roopeshr@google.com chromeos_config: Make Mistral as experimental board. Created with: gclient setdep -r src/third_party/chromite@d153d1ae1284 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ic17c3e57ff7ac0ca59ea4dd2e19ca3b554167672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582276Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653666}
-
Joshua Bell authored
NOTRY=true Change-Id: I35b58d906385e8785e2ff6ecc2b75a9a52cc4eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580319Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d1f8d05a85a..b328e0d3c319 git log 4d1f8d05a85a..b328e0d3c319 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 bclayton@google.com CMakeList: Remove the CLANG_VERSION_STRING check 2019-04-24 capn@google.com Refactor common sampler code 2019-04-24 capn@google.com Implement basic sampler parameters 2019-04-24 capn@google.com Default to [X,0,0,one] for undefined texture components 2019-04-24 capn@google.com Eliminate fixed-point texture sampling 2019-04-24 bclayton@google.com SpirvShader: Combine DivergentPointer and NonDivergentPointer 2019-04-24 bclayton@google.com Reactor: Add Gather and Scatter instructions. 2019-04-24 bclayton@google.com SpirvShader: Refactor loads and stores. Consider limits. Created with: gclient setdep -r src/third_party/swiftshader@b328e0d3c319 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279,chromium:b/129523279,chromium:b/131224163,chromium:b/131224163,chromium:b/131224163 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I49307829e66cc2ae10e1520af5f67f828e628847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582272Reviewed-by:
-
Etienne Pierre-doray authored
This CL is mostly mechanical and carefully replaces "Sequence" -> "TaskSource" "sequence" -> "task_source" in base/task/thread_pool/ whenever possible. The only exception that required manual modifications was to handle conversion of SequenceAndTransaction -> TaskSourceAndTransaction in PostTaskWithSequence. Change-Id: Ie241b76e4eeda878105d8f22977a19fa2963a04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579362 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653663}
-
Tommy C. Li authored
This adds a OmniboxAlternateMatchDescriptionSeparator feature flag. In the default locale, it replaces the '-' separator between the match contents and description with a '|' separator. Bug: 955585 Change-Id: I98253872642e89727fe3a0b29c18caf77ca94a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580101Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#653662}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a4d9f89..b80da604 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4dd46e417806345c02f091d0656ab23a93083868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581980Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653661}
-
Andrew Xu authored
There are four ways to trigger launcher animation in tablet mode: 1. Drag release to show the launcher. 2. Drag release to hide the launcher. 3. Click on the AppList button to show the launcher. 4. Activate a window to hide the launcher. This CL helps to record animation smoothness for these kinds of launcher animations respectively. Bug: 947125 Change-Id: I9b2f8fdcb5dbf8f893a9c5ef685d7da8f11fc729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560020 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653660}
-
David Bertoni authored
Bug: 955657 Change-Id: Id5124d9651d8939b8d4e37f6cfaca5b2561233d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579639 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653659}
-
James Cook authored
They are only available in OS settings. Eliminate type DateTimePageVisibility because neither it nor its only entry timeZoneSelector are used. I suspect they became unused when the per-user-timezone feature was added. Bug: 950007 Test: manual with SplitSettings, double-checked Linux settings Change-Id: I3ff19aec6e4f9c37b2003cfbc35a0b8812e3ed84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580119Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#653658}
-
Robert Phillips authored
This effectively reverts: https://chromium-review.googlesource.com/c/chromium/src/+/1561611 (Explicitly flush after an SkCanvas::writePixels) Together with the following Skia-side CL, this patch fixes Chrome's flushing behavior for platforms that prefer flushes over VRAM use (i.e., ANGLE) and for platforms that don't (e.g., Android). https://skia-review.googlesource.com/c/skia/+/210062 (Change flushing policy in GrContextPriv::writeSurfacePixels) Here are the perf numbers on Android and Windows for the putImageData performance test: Android (Nexus 5x) Windows (i.e., ANGLE) Current Chrome 112.9 512.1 Chrome w/ this CL 131.9 334.8 Chrome w/ this CL and 210062 133.6 589.4 So, after both CLs have landed, Android will be faster while Windows will, roughly, remain the same. Bug: 942538, 953720 Change-Id: I5db9f9fbc158e2132b1c532c40b60277a87d5e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582181Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#653657}
-
Guohui Deng authored
Change it to scoped enum type, and use kMaxValue so that if kMaxValue is out of sync we will receive error message. Bug: 925450 Test: None. Change-Id: Ieb4fef0cca1d8ef6aad3c116802b660c53df8fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570812Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653656}
-
James Cook authored
It's an OS-only setting. This CL does not change the appearance section in the OS settings page. Test: manually verified both the new change and that I didn't break Linux appearance settings Bug: 950007 Change-Id: Ie5fc110ffefcdeea8fa355df430e434dac1e704a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579583Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d8271895be7..323487161e02 git log 0d8271895be7..323487161e02 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@323487161e02 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2b7ea07dba0ff16355630e55769525fcdb2d993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582270Reviewed-by:
-
Andrew Grieve authored
This reverts commit 697c9ab8. Reason for revert: Broke resource_sizes.py Original change's description: > Android: Compile .proto and .arsc resources at the same time > > Saves a couple of seconds of build time for base bundle modules, > and simplifies the GN logic for resources. > > Also fixes chrome_apk using unoptimized arsc file when lemon is > enabled (broken by 2e296d82). > > Simplifies temp file usage in compile_resources.py by having all > outputs go to the staging directory. > > Removes cruft: > * Unused --no-compress flag > * Unnecessary "Touch()" of R.txt > > Bug: 950233 > Change-Id: Ida77380e8038002435ec3d320105d9feaa3c2136 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568568 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653275} TBR=agrieve@chromium.org,tiborg@chromium.org Change-Id: I76bd9cf76b357156efa2848613ab576486d18476 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950233, 955959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581988Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#653653}
-
Tim Volodine authored
Make sure to prevent crashes when io_thread_client is null, at the time when InterceptedRequest::Restart is called. There is a small amount of crash reports, see crbug.com/953584, which indicate this case could arise in special cases. BUG=953584,841556 Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I958fa4d622125a2d54ef99aee83a598f4cf46be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578751Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#653652}
-
Alex Newcomer authored
When the top window is deactivated, the AppListView is shown without any preparation. Fix this by resetting the focus and switching to the first page. Bug: 951586 Change-Id: I4a39dc503cf6cbee32cf60d29026eac10f3dc84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576142 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Sean Kau authored
Use a QuitClosure instead of RunUntilIdle in the CupsPrintersHandlerTest. Test started failing if CupsPrinterManager creation was delayed. Bug: 954623 Change-Id: I0ce986ce0995f678197b88c06186737ab56787aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579325Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#653650}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82de21cb71c0..c0bd9f9fe533 git log 82de21cb71c0..c0bd9f9fe533 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 mtklein@google.com rewrite includes to not need so much -Ifoo 2019-04-24 halcanary@google.com SkTInternalLList: remove SkPtrWrapper, SkNoncopyable 2019-04-24 robertphillips@google.com Implement alternate method for determining recycle-ability of allocated GrSurfaces (take 2) 2019-04-24 mtklein@google.com move SK_ENABLE_DISCRETE_GPU to cover only tools 2019-04-24 bsalomon@google.com Use tasks for GrVkGpuTextureCommandBuffer. 2019-04-24 reed@google.com rm older api from colormatrix, change to normalized translate Created with: gclient setdep -r src/third_party/skia@c0bd9f9fe533 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I51f18ade9656b86ac12ac276bd0736cbbdc5d67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582264Reviewed-by:
-
Mohamed Amir Yosef authored
Almost all data types have been migrated USS and yet USE_NEW conflict resolution has never been used. It's now deprecated in this CL, and we should bring it back if needed. This would unblock an upcoming clean up to remove EntityData.Clone() method. TBR=stevenjb@chromium.org Bug: 953281 Change-Id: Ic5469ffafceccd90fd279242c19ed20f8b512510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577419Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
BUG=955035 TEST=Manually verify that Custom Tabs is disabled when SPM is disabled Change-Id: I64edf464a3ab54f83460395e1c85f8febdc10f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580996 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653647}
-
Koji Ishii authored
This patch checks which CSS properties were changed to determine whether NeedsCollectInlines and/or re-shaping is needed. Following r651389 (CL:1554210) this change reduces cases where PrepareLayout/NeedsCollectInlines are needed to re-run. Bug: 636993 Change-Id: Ie0fa4e10b16860c8caecc22f767d408c231eba40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567555 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653646}
-
Evan Stade authored
Replace with PowerManagerClient::Observer::PowerManagerBecameAvailable() This should make it easier to support for the Mojo PowerManagerClient. Bug: 644348 Change-Id: I5c18e76eb34929a43769b6206ed16e8bc7fca4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574681Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
A Olsen authored
Source absolute paths //a/b/c are now supported, so no need to use ../../../../../a/b/c This migrates several tests where it is an easy change. Change-Id: Ia7a8ba50a20a9b218e4b271c25449e3064148e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578616Reviewed-by:
-
Eric Roman authored
Change-Id: Ib1725cf8380468329bcafc3f6d462b081f1e1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579462Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653643}
-
chrome://net-internals/#chromeosBen Chan authored
WiMAX support on Chrome OS has been deprecated along with daisy. This CL removes the button to set WiMAX debugging mode on chrome://net-internals/#chromeos. Bug: 954635 Test: Verify that chrome://net-internals/#chromeos no longer shows a 'WiMAX' button. Change-Id: Ia754b6aefcdb3ccdc976061038a004cc69171498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580903Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2635a51a68a1..07ff5e7b4122 Created with: gclient setdep -r src-internal@07ff5e7b4122 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:955935 TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: Id1d09ef363706d5770b985838d7fbf43e38fe342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582444Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653641}
-
Justin DeWitt authored
This gives some space beneath the text for the focus ring. Bug: 935795 Change-Id: I6b6f2a9165814f4d376ad0f5d133c975f3cc0142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579701Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653640}
-
Rune Lillesveen authored
In preparation for using the observer in WebContentsImpl, make it available for content/. Bug: 889087 Change-Id: Iff4dbfae5525c6bae1655662d5f29208a024da28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574802Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653639}
-
Mohamed Amir Yosef authored
Bug: 956011 Change-Id: I537118020a14ed0883fab998293c34a5555a7c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581582Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Add a new strings.grd file (and surrounding infrastructure) for Switch Access, following the pattern used Select-to-speak and ChromeVox (other component extensions). Bug: 864835 Change-Id: I84ebe33ff31e007357df14d67e4a70b516ae9e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574882Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Wez authored
zx::channel::read() now has the correct parameter order, so migrate to that, to allow rea2() to be removed. TBR=kmarshall Bug: 953523 Change-Id: I622531739609c0dfb935d44416687d7eca9a9567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582541Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653636}
-
Elly Fong-Jones authored
This change also removes the backing switch. Bug: None Change-Id: I10085a4d123978afd5819abbf8aca0f20ee67874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582226 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
inglorion authored
The consoles luci.chromium.clang and chromium.clang are duplicates of each other. This change removes one. Change-Id: I7f56221ce505632122640c1c4687d44f9bc643ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580499Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#653634}
-
Mohamed Amir Yosef authored
Bug: 922900 Change-Id: Ic3642e9bdb97c40b866f04703e6dc56a95586a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575939 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
