- 06 Oct, 2020 40 commits
-
-
Zufeng Wang authored
There's an issue of AppServiceAppResult::OnVisibilityChanged not being called for suggestion chips, which meant the Decrease function never ran. As a result, the release notes suggestion chip never disappeared. As a temporary workaround, move the Decrease function into AppServiceAppResult::HandleSuggestionChip. This gets called a bit more often (including when the session starts and when the launcher input is focused). Increase kTimesToShowSuggestionChip to compensate for this. Bug: b/169711884 Change-Id: I1f1827f5c8d4d5a37268074a4af4d2e4840c326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442809 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814044}
-
John Lee authored
The default contextmenu event is prevented because touch drag and drop on Windows does not interact well with the contextmenu events. Since on Windows, a mouse can be attached to a tablet and have the UI still be in tablet mode, a pointerup event is added to determine if a user actually right-clicks on a tab to invoke the context menu. Bug: 1134282 Change-Id: I92dca4d194905437b6396f42a7be1b6a272ea9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447091Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814043}
-
James Vecore authored
This plumbs through the allowed mediums for the discovery process which was previously not available. Fixed: 1135391 Change-Id: I95c8dbf70a6b120f7e6e0769a8535d99eec7800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451301 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#814042}
-
Bartek Nowierski authored
It doesn't depend on //base, which is needed for CheckedPtr Bug: 1069567 Change-Id: I4eb2d7e46b2a018f7de08d69aef32e0e3d23aa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440075 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#814041}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7de00dff..f3c9f8a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7929d226b2e926a102ba90ae74bc1142dea9047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449939Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814040}
-
Andrew Xu authored
MenuController::HandleMouseLocation() called in MenuController::OnMouseMoved() calls MenuController::SetSelection() which may reset the hot-tracked view. Meanwhile, in OnMouseMoved(), the hot-tracked view updates before HandleMouseLocation(). As a result, the hot-tracked view may fail to update after the mouse move event. This bug should have existed for long time. But it is not noticeable on real devices: when a user moves the mouse, it usually creates more than one mouse move events. Then the second mouse move event updates the hot-tracked view. This CL updates the hot-tracked view after HandleMouseLocation(). Bug: 1135000 Change-Id: Iae810563e897d75912bcc140ed56022d72e3170c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448650Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814039}
-
Haben Foto authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: I6619b77a6cf88d974625ebc472036e063601d9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441532Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Haben Foto <v-habenfoto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814038}
-
Malay Keshav authored
Adds an UMA metric that tracks the effective resolution of the primary display. To ensure the metric being measured is one that the user is to spends most time on, the signal is sent at every fixed interval of 30 minutes. Effective resolution takes into account the display zoom, device scale factor, and the display rotation. Bug: 1126489 Test: Tested manually on atlas and krane Change-Id: Id0f92867c6927f06f0c5c2288198f5bff3a5b8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412837Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Auto-Submit: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#814037}
-
Mike Wasserman authored
Similar to allowing requestFullscreen on screen orientation changes. Allows sites to requestFullscreen when the user changes screen config (e.g. when the user connects an external display to a laptop) Add TransientAllowFullscreen for async support like UserActivationState. (ScopedAllowFullscreen only supports sync, stack-allocation scopes) Add a basic unit test for the new class, and an integration test. Bug: 1077402 Test: window.onscreenschange = async () => { element.requestFullscreen({screen:(await getScreens())[1]}); }; Change-Id: Iffc5bb419e2b016704b923bd8454cb422672b5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429967 Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#814036}
-
Yulun Wu authored
This addresses the changes in these CLs https://chromium-review.googlesource.com/c/chromium/src/+/2376417 https://chromium-review.googlesource.com/c/chromium/src/+/2378801 Bug: 1134854 Change-Id: I360e46cc4d0e8247eed799b7f1c7b1d1c4f9da5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447045Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
Change-Id: I4b5185850d75e5b20d4f0516b596e502f2cdb47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388770Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#814034}
-
Minoru Chikamune authored
This CL moves AgentGroupScheduler to third_party/blink/public and renames it to WebAgentGroupScheduler so that it can be used from the content layer. Bug: 1105403, 1113102 Change-Id: I1736c8e6951e0abb5b8f69a3409ddff338d6c336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444652Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#814033}
-
Yuke Liao authored
This CL makes the optimize_webui work with non-default toolchain by avoiding assuming that the gen directory will always be out/gen. Bug: 1129223 Change-Id: I575474c2ef983008979329706a029115fe34c9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419717 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814032}
-
Fergal Daly authored
PROBLEM: It's passing --demangle=True to the llvm symbolizer but some recent change made it so that is invalid. FIX: pass --demangle or --no-demangle instead. https://crrev.com/c/2436306 attempted to just update tools/valgrind/asan/third_party/asan_symbolize.py but that requires a lot of fixes to tools/valgrind/asan/asan_symbolize.py to work. So this is a temporary fix. Also I had to run git cl format and it changed some stuff. Bug: 1132789 Change-Id: I0358bfb49b1bd1370e607cf70d43a2f6a7ea11af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437085Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814031}
-
Jesse McKenna authored
This change adds command-line flag --cpu-seconds to IdleWakeups. This option makes IdleWakeups print absolute CPU time in seconds, rather than as a percentage. Because average and median CPU time in seconds are not meaningful measurements, this also adds a "Sum" row to the summary. This row appears only when --cpu-seconds is enabled, and displays only CPU time. Change-Id: I9bd4efd8712da9ac976eeb8dc435232c63170827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441321Reviewed-by:
-
Jinsuk Kim authored
Bottom toolbar does not to support swipe gesture. This CL deletes the code that handled it in ScrollingBottomViewResourceFrameLayout. Bug: 1127732 Change-Id: I058005c7f6acceda6872ad99c7cd52ac277fb82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428517Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#814029}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/952113a3bdf5..eee0513a73bc 2020-10-05 miu@chromium.org Cast Receiver Application Agent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibe984815cd9142620741cf4c4ae5009584443abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814028}
-
Ben Reich authored
Renames the browser_test_devtools_listener class to remove the browser_test prefix and updates the naming in the places that refer to it. Bug: 1113941 Change-Id: I4fe0827f5c332c8650367bff39eb144725723b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449940Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814027}
-
Joel Hockey authored
Cleanup flags to avoid unhelpful logging which makes it hard to determine real cause of test failures. Bug: 1132897 Change-Id: I53b874b689923f4c3ec75651f16f62d19d56b1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449835 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
Bug: 1069567 Change-Id: I4e525f6eab7390777fbc5e609d9f1a57e14730e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447389 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Kenneth Russell authored
These tests are flaking on the Nexus 5X in the webgl_conformance_tests suite run with the validating command decoder. Attempt to retry them. Bug: 1095679 No-Try: True Tbr: khushalsagar@chromium.org Change-Id: Iaaaf7d0766a361efa6feb24a2491287ceae31f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451297 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814024}
-
chrome://flagsTakumi Fujimoto authored
Set the expiration of cast-media-route-provider and global-media-controls-for-cast to M93 (branching in July 2021). Bug: 1135259, b/170118442 Change-Id: I167275443af80c88949de4a8d3574025894f18f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450577 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814023}
-
John Lee authored
If the tab strip was opened using a keyboard (and not touch), the view now tells the UI handler to inform the front-end that keyboard focus has moved into the tab strip. The front-end will automatically focus the first tab and add the focus indicators. Bug: 1135358 Change-Id: I3524e186638c61c128af9d1041d5573774ba14bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449941Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814022}
-
Michael Checo authored
This is temporary styling pending final mocks. - Adjusts spacing of data points and card items - Adjusts card-wrapper to allow for variable card height - Adds column layout styles Screenshots: - Diagnostics App (before) http://shortn/_PIhlqmECzl - Diagnostics App (after) http://shortn/_4xlkZL1oIV Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I1030cfde04eddea705f2056692a6ce98e7b8cb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442633 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#814021}
-
Elaine Chien authored
Bug: 1130078 Change-Id: Ic4a7e8812d14e68c2221d49e4cb23937c1e64d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451293 Commit-Queue: Elaine Chien <elainec@chromium.org> Auto-Submit: Elaine Chien <elainec@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#814020}
-
Ryan Heise authored
* Restructure document to be a simple overview + functional information (i.e. how do I X). * Remove discussion of implementation details (WPR, TBM, etc.) that are covered in child documents. * Add discussion on how to create a test. Change-Id: Id60882846b15aa557620d23516a1584f2ff62cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450715 Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814019}
-
Charles Zhao authored
UMA metrics RecordVisibilityHistogram and UKM metrics TabManager_TabLifetime are moved from TabActivityWatcher to TabStatsTracker without changing its logic. Bug: 1131349 Change-Id: Iee06e9ff87fb43293e62fd5d7b9d83af9437f205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437087Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#814018}
-
Brian Sheedy authored
Adds a new resultdb_bigquery_export entry to the GPU team's CI builders, exporting to luci-resultdb.chromium.gpu_ci_test_results. This is so that we can query the GPU test results more efficiently for an upcoming script. Bug: 1134751 Change-Id: Id4df6f97b920d4d91b2fd7e0e08dd196a3d469f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446893 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#814017}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09e5f06f05dd..2266710dd28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kristipark@google.com Change-Id: I043117f261193ee873f9b36b3d0d35de9fa1f418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814016}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS Build, but it will be unset. This is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I15f8a6f70c0f3ed17cbad78fd8dd7ddd71c31847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449611 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#814015}
-
Sami Kyostila authored
This replaces the previous mojo interface parameter for specifying the priority of a tracing session with an equivalent setting in the Perfetto trace config. This patch doesn't change the effective priority of existing tracing sessions; only the redundant parallel setting is removed. Bug: 1058632 Change-Id: I0f71edcf65c564df286191be4634555a09f93473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414253 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Yu Su authored
Change-Id: I3ef5e2dece7f02adef016d41ceb0330f59871e53 Bug: b/164245846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442009Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#814013}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cac85ac0. With Chromium commits locally applied on WPT: 430b7621 "[LayoutNG] Don't truncate margins after spanners." ce85ff61 "[LayoutNG] Correct column balancing for horizontal-rl." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I2c41f0d2a4032881a8f2ff5f9c6221802df0a42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450771Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814012}
-
Jinsuk Kim authored
Replaces |assert| which can be removed in release build with one of Assert.assert* variations in test. Bug: 1131424 Change-Id: Iadba51d09fb857a2db0f41357690361885e3c6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437669Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#814011}
-
Xing Liu authored
Currently we didn't build DownloadCollectionBridge for webview. Bug: 1135162 Change-Id: Id7a2cb3fa263281216304b1c519271c95b44ae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450721 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814010}
-
Leonid Baraz authored
Bug: None Change-Id: Ie4a0bf883e97cfd2b412583151030312048628a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450922 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#814009}
-
Ionel Popescu authored
This is a reland of c64eed06 The difference from the original change is that this CL updates the color-picker-show-eye-dropper.html test to provide user activation. Original change's description: > Add security mitigations for eye dropper IPC. > > As discussed on the security review this CL adds the following mitigations: > - require a transient user activation on the browser side, and consume > it when showing the eye dropper for the renderer (this will prevent a > compromised renderer to repeatedly ask for a color) > - require the eye dropper UI to be visible for a minimum amount of time > before color selection is allowed in order to ensure the user has a > chance to see the UI. > > There is also a fix for the popup not correctly updating the user > activation state. This happens because it is using a > EmptyLocalFrameClient and its frame is not related to the > owner element's frame. > > Bug: 992297 > Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812847} TBR=avi@chromium.org,tkent@chromium.org,masonfreed@chromium.org Bug: 992297 Change-Id: Icecebf941b277790e12a12d06bca5b20da404ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450731Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814008}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/df909306835a..326e14f34bb5 2020-10-05 kainino@chromium.org Revert "Add a per-thread proc table using thread local storage" 2020-10-05 enga@chromium.org Add a per-thread proc table using thread local storage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ia2310d80ddd10c2300ab6587ca397872cc72a6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451412Reviewed-by:
-
Yuke Liao authored
This CL moves ui/ozone/ozone.gni to build/config/ui.gni because a few args in ui/ozone/ozone.gni will be used by toolchain files under build/, and the reason is that in a LaCrOS build, ozone_platform is set to use Wayland, and meanwhile, we build an ash-chrome in an alternate toolchain, which requires re-setting the ozone_platform back to empty. For more details, please see: https://chromium-review.googlesource.com/c/chromium/src/+/2416999 Bug: 1129223 Change-Id: I8c1e94c568165de2a5c26ca103fa84a60eb68b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427423 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
When the VASliceData buffer is re-used, decoded frames randomly have artifacts. This is a workaround of the issue. VASliceData is always created on submitting each frame. Bug: b:166646505, b:169725321 Test: Play swirl_128x128_vp9.webm on eve-kernelnext Change-Id: I85d9b7902496b84fd905da0e80dd604298db0bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448272 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814005}
-
