- 16 Jul, 2018 40 commits
-
-
Bruno Kim Medeiros Cesar authored
Bug: 857533 Change-Id: I1aa1d88ba50f179fa73b1d563f7e3bc45d1176e4 Reviewed-on: https://chromium-review.googlesource.com/1122637 Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#575298}
-
Brandon Jones authored
In cases when we explicitly resolved multisampled framebuffers the resolved framebuffer was being discarded instead of the drawing framebuffer. This likely had no ill effects but was not giving us the benefit expected on those devices. Additionally, framebuffers were not clearing prior to each new frame (although discard would sometimes appear to have that effect), which would result in data from previous frames being left behind in the framebuffer in an unpredictable manner. This patch introduces a consistent clear for predictability. Bug: 863242 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib78c7d02812574a655220c6bdba50e02904dd483 Reviewed-on: https://chromium-review.googlesource.com/1135943Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575297}
-
Krishna Govind authored
R=amineer@chromium.org Change-Id: I7319e7c2a06d089ab543f2c068edb7242af84c88 Reviewed-on: https://chromium-review.googlesource.com/1138535Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#575296}
-
Ben Mason authored
Defaults to "$root_build_dir/apks/" if base_bundle_path is not specified. Bug: 863113 Change-Id: Ia41ab38bce589ea95b462ec0ebf705c17ebd91a9 Reviewed-on: https://chromium-review.googlesource.com/1136987 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#575295}
-
kylechar authored
This CL saves some state in local variables and aliases them for inclusion in crash minidumps. This information will help diagnose GPU process failures with OOP-D and the resulting browser crash when we can't launch a GPU process. Bug: 849639 Change-Id: Id5a65c428eff83c80208b53081083d4feaf26063 Reviewed-on: https://chromium-review.googlesource.com/1138178Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#575294}
-
Owen Min authored
Tbr: tmartino Bug: 863743 Change-Id: I732c8f932cdc9be220b35c8d78f19bbc54e44dcb Reviewed-on: https://chromium-review.googlesource.com/1138406Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575293}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f78c00ba. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21461 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rmcilroy@chromium.org: external/wpt/requestidlecallback TBR=raphael.kubo.da.costa@intel.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iac0d2ed302e9fb3b9cfdcda07060cf37525c36a8 Reviewed-on: https://chromium-review.googlesource.com/1138182 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575292}
-
Friedrich Horschig authored
There is an assumption that a call to PasswordManagerClient would finish before a call to PasswordManagerDriver although both are asynchronous. With https://crrev.com/c/1124466, more async calls happened which most likely caused an earlier use of PasswordManagerDriver and uncovered this issue. This CL fixes that issue by associating PasswordManagerDriver (like the PasswordManagerClient) to a RenderFrameHost. In order to use the WebContentsFrameBindingSet, the PasswordManagerDriver implementation moves into ChromePasswordManagerClient (which was called for most of these methods anyway - one layer of indirection begone!). In addition, it provides a workaround for a newly found bug that is loosely related (see crbug/862989): Even though the PasswordAutofillAgent is recreated to be accessible in tests, it is only bound once (to the test instance). This removes cases where FakeContentPasswordManagerDriver would be bound twice and the binding to TestPasswordAutofillAgent was lost. Bug: 862989 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic5f9b1c60850b8b2b3e452784a0cbc86d4fd7bd2 Reviewed-on: https://chromium-review.googlesource.com/1127995Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575291}
-
Nico Weber authored
src/ side Bug: 863924 Change-Id: Ic19ee2be442ba7a16acacf84cfd74ca9454f9446 Reviewed-on: https://chromium-review.googlesource.com/1138339Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575290}
-
Ryan Daum authored
Allows the margin allowed for the bottom system gesture to be specified separately from the top. Bug: internal b/111304882 Test: manual Change-Id: Ie549f2b7d48a4533eb5f493ed9255cf6ef6898d1 Reviewed-on: https://chromium-review.googlesource.com/1138395Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#575289}
-
Kyle Milka authored
More icons are coming for new NTP features. Add a subdirectory for them and move existing icons. Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3424d626d01fad8383f4d04e733510563c3e959d Reviewed-on: https://chromium-review.googlesource.com/1137031 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#575288}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d5eaf647fbe..e79ac55dc0ea git log 5d5eaf647fbe..e79ac55dc0ea --date=short --no-merges --format='%ad %ae %s' 2018-07-16 primiano@google.com Minor cleanup after Jumbo CL Created with: gclient setdep -r src/third_party/perfetto@e79ac55dc0ea The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:crbug.com/863831 TBR=perfetto-bugs@google.com Change-Id: I6150c46c2c6a71bd6b28d347c87b772d87a789ef Reviewed-on: https://chromium-review.googlesource.com/1138373 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575287}
-
Fady Samuel authored
This reverts commit 0449370c. Reason for revert: The culprit patch was a revert that relanded. Original change's description: > Disable WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject. > > Flaky. > > TBR=fsamuel@chromium.org,phoglund@chromium.org > > Bug: 846554 > Change-Id: I4eb5ef90717fd417aae68ef843365ad7cafaa87f > Reviewed-on: https://chromium-review.googlesource.com/1073031 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561765} TBR=tapted@chromium.org,phoglund@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846554 Change-Id: I3e46e97fdd6d782aa64912f46ab0ba70d3159755 Reviewed-on: https://chromium-review.googlesource.com/1138413Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575286}
-
Roman Sorokin authored
* Restarts Chrome for Active Directory at the end of successful enrollment * ESC not to cancel enrollment during next steps: "license", "attribute-prompt" TEST=manual Bug: 855379 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icaa3dc0f87bfa75c57c8b85c1b410b246fc194e6 Reviewed-on: https://chromium-review.googlesource.com/1118176 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575285}
-
Bailey Berro authored
This change transitions SmbFileSystem to using the StartCopy and ContinueCopy methods so that CopyEntry operations no longer block users from navigating around during a copy. Bug: 757625 Change-Id: I9a63e0198b6e529e935fab5f70e8aa95235d2b82 Reviewed-on: https://chromium-review.googlesource.com/1132465Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#575284}
-
Kevin Bailey authored
For suggestions with a tab switch button, advertise the ability to tab over to it and press enter, in the accessibility label. Bug: 780835, 853911, 853929 Change-Id: I91649d0517ab6e75970e49b5358e7d210c914071 Reviewed-on: https://chromium-review.googlesource.com/1106706Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575283}
-
kristipark authored
Setting ntp-ui-md also enables Material Design for Most Visited. This should not be the case. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic44b16b7016b7c8a5d807e81ce7b623227a57c72 Reviewed-on: https://chromium-review.googlesource.com/1137258 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Owen Min authored
This reverts commit 1c479eb8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Refactor BrowserDMTokenStorage for easier platform implementations. > > This CL refactors BrowserDMTokenStorage & BrowserDMTokenStorageWin to move code that is common to all platforms. > > After this CL, adding a new platform requires implementing the following methods: > > - virtual std::string InitClientId(); > - virtual std::string InitEnrollmentToken(); > - virtual std::string InitDMToken(); > - virtual void SaveDMToken(const std::string& token); > > Note that this CL keeps the existing Windows implementation, it only refactors the code (no functional change). > > BUG=812641 > > Change-Id: If362c4368160e7bd038a8a4b1d93e151c0a60e1b > Reviewed-on: https://chromium-review.googlesource.com/1133315 > Commit-Queue: Georges Khalil <georgesak@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575276} TBR=rogerta@chromium.org,pastarmovj@chromium.org,georgesak@chromium.org,zmin@chromium.org Change-Id: Idbf78da964051aaac710b780fabccf248c8d583e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812641 Reviewed-on: https://chromium-review.googlesource.com/1138513Reviewed-by:
-
Fabio Tirelo authored
Bug: 860493 Change-Id: Icf0f6bd8ccc8d8ed8f53ad060dd18f6cafba2824 Reviewed-on: https://chromium-review.googlesource.com/1138185 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Avi Drissman authored
NSTrackingCursorUpdate only triggers the -cursorUpdate: message for key windows. If MacViews tries to set a cursor for a non- key window that is the child of a key window, set the cursor manually. BUG=851834 Change-Id: I91fe5eb1bc4880d847799e2e1f3bb0a1eb140d5a Reviewed-on: https://chromium-review.googlesource.com/1135718Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575279}
-
Chris Lu authored
Clear Browsing Data is being presented as a modal form from History. For non-compact devices in UI Refresh, this is not ideal since History is presented as a "bubble". The ideal behavior is to cover the entire history page. - Uses UIViewControllerTransitioningDelegate to help manage presentation. - Adds popoverArrowDirection to ActionSheetCoordinator to ensure that popover direction of ClearBrowsingData button is pointing vertically, not horizontally. Bug:None Change-Id: I2b106c2b4373ea7785ec2ae5c6f6eba706be4012 Reviewed-on: https://chromium-review.googlesource.com/1133422 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575278}
-
nednguyen authored
Bug: 859524 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I98dd67a56c1da6f083e8853b6c08b5c87a7bd453 Reviewed-on: https://chromium-review.googlesource.com/1138181Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575277}
-
Georges Khalil authored
This CL refactors BrowserDMTokenStorage & BrowserDMTokenStorageWin to move code that is common to all platforms. After this CL, adding a new platform requires implementing the following methods: - virtual std::string InitClientId(); - virtual std::string InitEnrollmentToken(); - virtual std::string InitDMToken(); - virtual void SaveDMToken(const std::string& token); Note that this CL keeps the existing Windows implementation, it only refactors the code (no functional change). BUG=812641 Change-Id: If362c4368160e7bd038a8a4b1d93e151c0a60e1b Reviewed-on: https://chromium-review.googlesource.com/1133315 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#575276}
-
Bailey Berro authored
This change implements StartCopy and ContinueCopy on SmbFileSystems. StartCopy will be called by CopyEntry to begin a copy operation. When the StartCopy handler callback is run, if there is more work to do the ContinueCopy method is called. Bug: chromium:757625 Change-Id: I9a8640e6e6b5cd089d65d3d7b668159676121250 Reviewed-on: https://chromium-review.googlesource.com/1132462Reviewed-by:
-
Rayan Kanso authored
Change-Id: I172418ee124e867393cfb4a207fe4d898a06ec31 Reviewed-on: https://chromium-review.googlesource.com/1136447 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575274}
-
Emil A Eklund authored
Optimize ShapingLineBreaker::ShapeToEnd by handling the common case when an entire shape result can be reused thereby avoiding range comparisons, memory allocation, and the entire process of copying all the glyph data. This is especially common for complex scripts and results in a ~10% perf win on the layout/hindi-line-layout performance test. Test: perf_tests/layout/hindi-line-layout.html Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If90768aebe9007bf18e9beaa18554ef0efceab49 Reviewed-on: https://chromium-review.googlesource.com/1137796 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#575273}
-
Parastoo Geranmayeh authored
Problem: Some forms have multiple fields for a single logical field, only one of which is visible at a time. As the user is filling the form, the visibility of the fields switches. Case I: the user changes the country from US to CA, and the state field changes from a select to text. Case II: We have two fields, and both of them are detected as a certain type. One is hidden and the other is visible at the time of filling the form. Then as the autofill fills out the form, the visibility status of both fields change, and it looks as if the entered value was removed by the website. (See go/synthetic-fields section 2.2.) Solution: After filling the form, get the form of the clicked on element again, compare it with the old form, and if changed, trigger a refill. Bug: 861877, 863428 Change-Id: I32515e37b5f9f092fd213f9538fdc9dda3933747 Reviewed-on: https://chromium-review.googlesource.com/1135199Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#575272}
-
Fabio Tirelo authored
Cleanup of a feature that was launched a while ago and we don't intend to revert. Change-Id: Ib3cffcec69877c2fb72904bfd713e63c5524497c Reviewed-on: https://chromium-review.googlesource.com/1136588 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76c1d14b8e21..ddd8eaa8dca0 git log 76c1d14b8e21..ddd8eaa8dca0 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 cwallez@chromium.org Suppress reverse blits tests on Qualcomm/Vulkan Created with: gclient setdep -r src/third_party/angle@ddd8eaa8dca0 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8e92074b07cf8fb83cb632bcc60e69d37cfb5981 Reviewed-on: https://chromium-review.googlesource.com/1138195Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575270}
-
Antonio Gomes authored
This CL migrates AutofillDownloadManager away from URLFetcher, to SimpleURLLoader. As a notorious remark, the CL introduces a public method to SimpleURLLoader, LoadedFromCache. It allows to verify whether some specific content are served from the cache, as expected. BUG=773295,844929 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I92a36bc032b7c0e182ae83f367eefd605ad888ca Reviewed-on: https://chromium-review.googlesource.com/1114998Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#575269}
-
Stephen McGruer authored
The goal is to compare how often this histogram is logged with the existing kDataUriHasOctothorpe UseCounter for WebView, in order to determine what API path we might want to modify when doing a compat fix. The belief is that the histogram and UseCounter should be roughly comparable because the histogram will only be recorded at most once per site load (because the loadData APIs cause a site load). Bug: 823666 Change-Id: I0ce63b8c86bc3bcd02d3b10ab7a38112fb520439 Reviewed-on: https://chromium-review.googlesource.com/1112045 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#575268}
-
Peter Mayo authored
It seems that external/wpt/css/vendor-imports/mozilla/... mozilla-central-reftests/flexbox/... flexbox-baseline-multi-item-vert-001b.html has been passing consistently for as long as the flakiness dashboard has history now. https://test-results.appspot.com/dashboards/flakiness_dashboard.html# testType=webkit_layout_tests& tests=flexbox-baseline-multi-item-vert-001b.html This test also seems to pass on the Mac bots, so we might just as well enable it there at the same time. Bug: 736255,626703 Change-Id: I008407bfd4cf65c88d60b2095ecb58c4dd5a2cce Reviewed-on: https://chromium-review.googlesource.com/1133304Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575267}
-
Peter Wen authored
Explicitly call out what flag needs to be changed if a new SDK location is desired for Android Studio. This way the change is explicit and we do not fall into the trap of recommending the default location Android Studio suggests, which unfortunately happens to just be the last-used sdk location. We now recommend emulators so no need for the emulator warning section. ~/Android/Sdk is now the default, so removing blurb. Bug: 620034 Change-Id: I371f8576cdcb190e31cbf8ce537800db71cf04de Reviewed-on: https://chromium-review.googlesource.com/1138175Reviewed-by:
-
Reza.Zakerinasab authored
This CL adjusts the bug numbers for flaky tests that belong to crbug.com/860706 TBR=fserb@chromium.org NOTRY=true BUG=860706 Change-Id: Iacf8abbf1fefe41fa24cb443c1b34015bbeb4310 Reviewed-on: https://chromium-review.googlesource.com/1138335 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#575265}
-
nednguyen authored
NOTRY=true TBR=eyaich@chromium.org Bug: 863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I942eb00c9a4c5b0c4bb5b370f845b3d20cd97368 Reviewed-on: https://chromium-review.googlesource.com/1138397Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575264}
-
Gauthier Ambard authored
This CL fixes FindInPage UI to have the text field expanding before the done button and preventing the done button from being compressed by the text field. It also adds a padding to the results counter. Bug: 863858 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iec64c02ef8ac40ad7018fb617e09f0a508cefe3c Reviewed-on: https://chromium-review.googlesource.com/1138240Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575263}
-
Marc Treib authored
Bug: 862665 Change-Id: I5116783c22c7dc02ef057aa654528dfeaa3366fb Reviewed-on: https://chromium-review.googlesource.com/1138153Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#575262}
-
Justin Donnelly authored
Shift-enter will open the currently selected match in a new window. The primary purpose of this change is to avoid regressing the existing Cocoa behavior when MacViews launches. However, it seems just as useful on all desktop platforms and shift-enter isn't currently in use for anything else. Also, remove some dead code that was added to support tab switch back in https://crrev.com/c/809527. We don't use this shift-enter behavior anymore so the OnShiftKeyChanged method is no longer needed. Bug: 863156 Change-Id: I41960db2dd3a81be0ba79db90b2e69a69cf50031 Reviewed-on: https://chromium-review.googlesource.com/1136651Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575261}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c528c0a07f85..3643aef89c78 git log c528c0a07f85..3643aef89c78 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 danilchap@webrtc.org Revert "Fix buffer overflow in ulpfec recovery" 2018-07-16 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before MediaSource/Track in ObjC 2018-07-16 magjed@webrtc.org Android: Remove use of deprecated functions related to legacy video codecs 2018-07-16 buildbot@webrtc.org Roll chromium_revision 1447fae2..a0e2753f (574709:575203) 2018-07-16 mbonadei@webrtc.org Re-enable skipped test. 2018-07-14 emircan@webrtc.org Reland "Reland "Add Profile 2 configuration to VP9 Encoder and Decoder"" Created with: gclient setdep -r src/third_party/webrtc@3643aef89c78 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:856823,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idea864e0e750ba59042aeb6278bcdbf6bc057c53 Reviewed-on: https://chromium-review.googlesource.com/1138196Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575260}
-
Mugdha Lakhani authored
We now have utilities in blink/common which operate GURLs. To be able to call these utilities and use the returned GURL value in Blink, we should be able to convert it to KURL. Bug: 860507 Change-Id: I8175a432db5a1d1ab16770b7c1326042a5bcb306 Reviewed-on: https://chromium-review.googlesource.com/1131117Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#575259}
-
