- 12 Oct, 2019 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I93763520df60d63218c6664ce3fd0720fb642f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705369}
-
Miyoung Shin authored
ManifestManager could be unreachable before ContextDestroyed() gets called and destructed before the receiver set is cleared. Then, it could lead to UAP bug, so this CL clears ReceiverSet<T> in Prefinalize instead of ContextDestroyed. Bug: 1012055 Change-Id: I3b1a569c8b4e26fde0c8ae3ac3cab27f5efc7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855323Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#705368}
-
Lei Zhang authored
Similar to copyBetweenWindowsDriveToUsb, copyBetweenWindowsLocalToUsb and other related tests are also flaky. Disable them all. TBR=austinct@chromium.org Bug: 1008909 Change-Id: Ib87e1403a653fa599111faa38b30947ca0fbf216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857650Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705367}
-
Lei Zhang authored
Disable it on Android and Linux because it is very flaky. TBR=tbansal@chromium.org Bug: 1002223 Change-Id: Iec11ef5f5b093febac4cba3241073308bbb77f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857190Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 875ee43f. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I672a06d761ff891fac325eabfe852230a2604d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857379Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705365}
-
nancy authored
This is the follow up for crrev.com/c/1816495. InternalAppName has been moved to BuiltInAppName in AppService, so replace InternalAppName with BuiltInAppName, otherwise we have duplicate enum, which could cause confusing for the future change. Although the app_list/internal_app will be replaced by AppService for the long term goal, in short term(one or two months), they are still there, so as the temporary solution, update it to use the AppService's enum BuiltInAppName. BUG=1005640 Change-Id: I0992d549c25a40087212baba0b8d8305b1136d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852526 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705364}
-
Yoichi Osato authored
This patch changes network service to restrict sending the headers to the renderer not to leak info if handshake was failed. This also changes WebRequest API and devtools event listening as failed when handshake was failed. Change-Id: I03160b06546711365273180a8020239e09528a47 Bug: 944619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847592 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705363}
-
Lukasz Anforowicz authored
After https://crrev.com/c/1842112 ContentRendererClient::ShouldFork is only used for prerender. Since prerender has been unsupported in production for a while (see https://crbug.com/755921 opened in August 2017) we can remove ContentRendererClient::ShouldFork entirely. This CL also removes AlwaysForkingRenderViewTest-based tests. These tests were testing ShouldFork-specific implementation details and are not applicable after removal of ShouldFork. Bug: 1003957, 883549 Change-Id: Ifd88909be59896b35c61f286f5225e1ab08b8d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812128 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705362}
-
Xida Chen authored
Right now the FrameSequenceTracker::ThreadType has 3 values: kMain kCompositor kSlowerThread The kSlowerThread should just be kSlower, to be consistent with the other two. Bug: None Change-Id: Ib4aa32b1313bdf72b1317f37f29193beab28622c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856728Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#705361}
-
Ken MacKay authored
Avoid clamping the sample range for each filter group. We still clamp in StreamMixer::WriteMixedPcm() before sending to output. Bug: internal b/142504553 Change-Id: I5a7376c229e9146ea25ebed40f8da1a46cc40c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856462Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#705360}
-
Lei Zhang authored
ArcAppModelBuilderRecreate.AppModelRestart and ArcAppModelBuilderRecreate.AppsNotReportedNextSessionDisabled are flaky. TBR=khmel@chromium.org Bug: 1013813 Change-Id: I511392b15a1ebd70687fa2bcb3c105db045fe34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857188Reviewed-by:
-
Prabir Pradhan authored
As per the wayland-protocol spec for locked pointer, the locked pointer object is no longer valid if the surface to which it is constrained is destroyed. This CL makes sure to break the constraint and send an unlock event when the surface associated with a locked pointer is destroyed. Bug: None Change-Id: I368af9a725da3c3b871c7574b2c76fe5fc113fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854879Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#705358}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6787f232aedd..373b149d8cf2 git log 6787f232aedd..373b149d8cf2 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision da0e48ef..002d8b5c (705127:705236) Created with: gclient setdep -r src/third_party/webrtc@373b149d8cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7b7152c5a0461d42834e8d0386563b10b842bd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856873Reviewed-by:
-
Lukasz Anforowicz authored
This CL coverts two places that used to manually populate NavigateParams from OpenURLParams, to instead rely on FillNavigateParamsFromOpenURLParams (which correctly propagates all relevant pieces of data from OpenURLParams, unlike the old, manual propagation which would only copy a handful of properties). This CL also augments FillNavigateParamsFromOpenURLParams to cover 2 additional fields of NavigateParams: initiating_profile and source_contents. Bug: 1007041 Change-Id: I4b30d18699ce41bc188801ea80aeff549b26f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854209 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
David Benjamin authored
This makes it more obvious that state is only relevant for the CrOS-specific stuff, which should make it easier to split out. Bug: 125848 Change-Id: I45da1f43a2584271d9ec5aad07460200f9e948cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857040 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#705355}
-
Hector Carmona authored
Bug: 1012370 Change-Id: Ibd7304cc2a9c8fe81b60e26da5bbffeaa0eee324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857541Reviewed-by:
-
Sam Maier authored
Change-Id: I4a431f966ab297e7c81b7abe8e29ed302b984586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849181 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#705353}
-
Peter Kasting authored
This also uses auto more and a few other cleanups, mostly to limit the number of "cmds::" to be inserted. Bug: 82078 Change-Id: I62d7adda3f2a0eb4dfb264c3ac386e89e1979aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855582 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#705352}
-
Tsuyoshi Horo authored
When "Files by Google" opens a file "a.a.wbn" in USB storage, the URI is like content://com.google.android.apps.nbu.files.provider/3/content%3A%2F%2Fcom. android.externalstorage.documents%2Ftree%2FC93A-14FA%253A%2Fdocument%2FC93A- 14FA%253Aa.a.wbn There are five dots in the file name, and the URI doesn't match the current pathPattern due to the strange behavior of intent filter's pathPattern. https://stackoverflow.com/questions/51912180/strange-intent-filter-pathpattern-behaviour So "Files by Google" can't opens the file with Chrome. To fix this problem, this CL adds more android:pathPattern. Bug: 995177 Change-Id: I3c4652d6aff8508fa00ead0e3da2855706756725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852327Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705351}
-
Lei Zhang authored
TBR=dmazzoni@chromium.org Bug: 1013805 Change-Id: Ib1eeb62a00d7d4185f6a596635f8da861685da37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857567Reviewed-by:
-
James Hollyer authored
Previously we were losing filter data be merging an array of filters into one filter. This patch restructured the BluetoothDiscoveryFilter To have a list of DeviceInfoFilters which in turn keeps arrays of UUIDs which more accurately represents the filter being passed in per the web bluetooth specification. Bug: 490401 Change-Id: Icdf8d102276db79eaff81e823d6b7654b65ba1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842559 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#705349}
-
Shakti Sahu authored
This CL adds 1 - Clean up the extra bottom padding on the toolbar layout, since it is not required any more after defining custom height for PEEK state. 2 - Added accessibility strings for various height states Bug: 1013461 Change-Id: I2d5fd47be139bba0ad9a584aff175e32f76f5e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854795Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705348}
-
Luum Habtemariam authored
It seems CUPS expects that 'printer-name' holds last part of the printer's uri, despite contradicting the RFC2911. This change implements that and stuffs the printer's display_name into the 'printer-info' attribute. Bug: chromium:945409, chromium:1013698, b:117218264 Test: confirmed successful printer installation via cups_proxy Change-Id: I8db45623679160b681f2337600fafc4e8f5c0826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856889Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#705347}
-
Tim Judkins authored
This change adds logic to the extension installation flow that allows for host permissions to be withheld by default if certain creation flags are supplied. Bug: 984069 Change-Id: I53aa71814b34bd19dc30a9b11b1dc5955bec1106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759408 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705346}
-
Alex Moshchuk authored
Also update default Android memory threshold to 1900MB, which is what is currently used in field trials on Stable. Bug: 905513, 849815 Change-Id: I3d62efd55ed8c34ed057d49d8084473f51a6cc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836656Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705345}
-
Jeff Yoon authored
ios-simulator-cr-recipe bot will be used to stage changes in support of migration from iOS to Chromium recipes. Bug: 912681 Change-Id: I5869d0bce510dbaf8a802f9c90f6a1e3fdac81a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848367 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705344}
-
Mario Sanchez Prada authored
This CL adds the remaining bits needed to add support for the new mojo types pending_associated_remote & pending_associated_receiver to the JavaScript generators. Similarly to what was done for CL1507289, these types translate for now to the existing endpoint types in those language, to allow mojom conversions without having to adapt those bindings first. This will unblock cleaning up Blink from the old mojo types, as this is at least required to migrate references to the XREnvironmentIntegrationProvider and XRInputSourceButtonListener mojo interfaces (see CLs 1836416 & 1844995d). Bug: 875030, 955171, 978694 Change-Id: I9ccf1ef2dabcab1ef49b35cae244924bfb44534b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847331Reviewed-by:
-
Alex Newcomer authored
Changes: - Changing visibility within AppListControllerImpl before notifying observers (some observers later ask for visibility in later stages of reacting to visibility changes). - Move management of transition metrics reporter closer to where the animation is initiated. Opened bugs for some of the trickier issues (off by 1 layout test failures). Bug: 1009645, 1011128, 1011920 Change-Id: I0ed95b17b24367cbcdf515121c882ba8fa2a15f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832932 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6527adcbefb..a82bb0b1ae2e Created with: gclient setdep -r src-internal@a82bb0b1ae2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I9e134c24a5425b96175c558b7de89135908743c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705341}
-
Jinsuk Kim authored
Tab uses themed application context when creating the content view for rendered pages' WebContents. Views in gesture navigation should not use this context to create UI since dark mode is not enabled in the context. This CL lets the feature use activity context to deal with dark mode properly. Bug: 1010576, 1009393 Change-Id: I5373b7244767a35516138cb8d735be80a53df1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855148 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c869191c19f..2cbae8a8b9f6 git log 5c869191c19f..2cbae8a8b9f6 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 tandrii@chromium.org git cl: retry-failed avoid not useful retries. Created with: gclient setdep -r src/third_party/depot_tools@2cbae8a8b9f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012631 Change-Id: I26cdb94913f5703509c881bbc42a2f8b0d651742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856872Reviewed-by:
-
Sebastien Marchand authored
Change-Id: Ie8e2ee2fbfa52b333267715f074a4e471f38d795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857300 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#705338}
-
Kenneth Russell authored
Still being used by developers to try compute shaders on the web. Bug: 859249 Change-Id: I92ddd9ca91722e50794d717d8551f3eef6e5805c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857279 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#705337}
-
Alex Turner authored
Adapts NetworkContextTest.NotifyExternalCacheHit to enforce its assumption that the split cache is not enabled. Adds a DCHECK to GenerateCacheKey, ensuring that the NetworkIsolationKey (NIK) is present if the split cache is enabled (its absence had caused the test to fail). This DCHECK is hit by many tests when the split cache is enabled. We fix the URLLoaderTest.* and SimpleURLLoaderTest.* tests. Other tests will be fixed in future CLs. Bug: 1009595 Change-Id: Icf24ad810be6b8adbb179837020ac3520505dfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837235Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#705336}
-
danakj authored
Each RenderWidget is a unit of compositing that expects to have its inputs all modified atomically (via SynchronizeVisualProperties) and contribute to a globally atomic screen update. The latter is accomplished through the "RenderWidget waterfall dance" where visual properties flow down the RenderWidget tree along with synchronization tokens, which are fed through the compositing system to present changes to all frame RenderWidgets in a single screen update. ScreenInfo is conceptually a global value, but it should change for each RenderWidget along with the synchronization token. RenderViewImpl::CreateView makes a new RenderWidgetHost for the main frame that it creates. That RenderWidgetHost is responsible for providing the new RenderWidget its VisualProperties, so we add them to the CreateNewWindowReply message and hand them to the new RenderWidget. This ensures new RenderWidgets are initialized with real ScreenInfo values and other VisualProperties provided by their matching RenderWidgetHost. Other frame-based RenderWidgets also receive these properties in the IPC messages that lead to RenderWidget creation through RenderFrameImpl. R=avi@chromium.org Bug: 419087 Change-Id: Ibd438ef95c36cf4433f4aab77cd864b520179b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856859 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#705335}
-
Yue Zhang authored
For devices with Api < 21, when we do v.getContext() where v is a AppCompatImageView, we get a wrapped TintContextWrapper instead of a normal Context. Casting TintContextWrapper to Activity will cause crash. This CL fixes this misusage in TabGridDialogMenuCoordinator. Bug: 1013555 Change-Id: I7e48923c319393def4a3f2dc130bd681347c35b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850591 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#705334}
-
Henrique Nakashima authored
This guarantees no other classes use the same prefs. These pref names will be replaced eventually by a name generated from the flag. Bug: 1012975 Change-Id: If072aece06e1dd54a148e316f94c06e439f7032e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854531 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705333}
-
Lei Zhang authored
TBR=arthursonzogni@chromium.org Bug: 1013802 Change-Id: Ice9ead65f934634d6548cb458b7caa9fe1e13a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857586Reviewed-by:
-
yjliu authored
Timezone changes should refresh the schedule for both sunset-to-sunrise and custom schedule types. Bug: 1010981 Change-Id: Iec3ad0292cd016aac9dcf88fcdedd234f276311d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849425Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8be37a6d..2fafa247 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f9b962370c746e363d05104199890093d5ff8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857241Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705330}
-
