- 04 Sep, 2020 40 commits
-
-
Antonio Gomes authored
... as per section 2.1.2 in [1]. Method is also renamed to GetInstance(). [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80 BUG=787252 R=guidou@chromim.org, haraken@chromium.org Change-Id: I5a80ee2168d8b150439559ce74e9ce3fd6089b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391005 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#804551}
-
Jacobo Aragunde Pérez authored
This is a tricky test due to the asynchronous nature of the event. It is produced in response to a system window event, so we need the test to produce an actual window so we can listen to it, and we need to add a way to wait for it. Bug: None Change-Id: If7cd10c5db282f7cc465505286790ab1f4b458a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370984 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#804550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id55657d82c80a8effe0ea4fd40dff6ff4d1d5d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804549}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5a4db3ce43eea983700884294335834a53f84f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392846Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599069432-d8eb5597bd424e2ad3cbb5c17808a3e6923469d2.profdata to chrome-win32-master-1599190607-5206f3168b9b0d0e0456f3bee274b28f7a3aa0ec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1dbd55cbc1621458ea1e24c609a6b759852891e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391873Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599177512-32aa3809c8758c536a0ce48902826b7d778eb6b3.profdata to chrome-win64-master-1599198987-f51a65ad37e561beab550a72f46d734c30300605.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I022706382a42bc01dbe2cc8428e8a9fcc36a22a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393695Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 2020-09-04 treehugger-gerrit@google.com Merge "Add PERFETTO_EXPORT macros to GlobalNodeGraph" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If6a56a64657986260a2c0785ec9343cc0882ce43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393699Reviewed-by:
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2388721, done separately so that the rename itself was not noisy to reviewers. BUG=787252 R=guidou@chromim.org, haraken@chromium.org Change-Id: Ia64f7c4da453b8a2c313f79e13f811ccc41eba18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389018 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a41204d8175..4a7d7f1baef0 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5881c1ad to c934ea57 (380 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I927e8967dc65c061a91c65b529a5d3d2c7ad7435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393660 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6842d3aa4de..77ed48ad2159 2020-09-04 patrick.brosset@microsoft.com Grid: New histogram to track how many grids users highlight in the page If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibf7ad1d3695405df6f23a304c1c17cc0c5b0dd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392845Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599155892-1c7afa3c86090c53f24aedb3e14a5f3170b93aea.profdata to chrome-win64-master-1599177512-32aa3809c8758c536a0ce48902826b7d778eb6b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae3a14ffea0a1f61cd26640bb2fc7f981b18f6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393133Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/583b1e36f36b..36794166c410 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1101058,chromium:1124945 Tbr: Change-Id: Ic19aaf0f0f0896a72b41c2df51b491348cb4724f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804540}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c278dada96d9..fd05605bef1c 2020-09-03 stefanomil@google.com spirv-fuzz: Transformation to convert OpSelect to conditional branch (#3681) 2020-09-02 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Add Vulkan VUID labels to BuiltIn (#3756) 2020-09-02 vasniktel@gmail.com spirv-fuzz: Add support for BuiltIn decoration (#3736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I36e0f9d10e0d1d2e62f7350e679cca5322cc73a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393658Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23909d8cfc57..a6842d3aa4de 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89c190de93eebe3eff2bef4484d4731e28b52b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393656Reviewed-by:
-
Alexey Baskakov authored
Background: WebAppMigrationManager uses BookmarkAppRegistrar::GetAppUserDisplayMode() getter to obtain user_display_mode field. user_display_mode is a user-controllable field which we sync across all user's devices. user_display_mode shouldn't depend on anything else (like manifest display mode or any other web app field) The call path: BookmarkAppRegistrar::GetAppUserDisplayMode() -> extensions::GetLaunchContainer() -> extensions::GetLaunchType() -> extensions::GetLaunchTypePrefValue(). The problem: While extensions::GetLaunchTypePrefValue() returns a raw launch_type that we are really interested in, extensions::GetLaunchType() resets launch_type to "run as a tab" if the bookmark app is not locally installed (Background: we sync bookmark apps as non-locally installed on all OSes except ChromeOS): LaunchType GetLaunchType(const ExtensionPrefs* prefs, const Extension* extension) { ... // Force hosted apps that are not locally installed to open in tabs. if (extension->is_hosted_app() && !BookmarkAppIsLocallyInstalled(prefs, extension)) { result = LAUNCH_TYPE_REGULAR; } else ... } This is the place where we were loosing information. If local migration happens first on a device with non-locally installed app, this preference gets uploaded to the sync server as the source of truth. As a result, all secondary installs treat this "run as a tab" value as a user choice. Solution: Our ideal raw GetAppUserDisplayModeForMigration() getter must not "Force hosted apps that are not locally installed to open in tabs". We need to convert a raw value from prefs extensions::GetLaunchTypePrefValue() using a switch statement with all cases covered. This is a P0 bug. This CL will be merged into M85 branch ASAP. TBR=mgiuca@chromium.org Bug: 1125020 Change-Id: Ie68aa8a86a2a052456fa66349bbd86758aaa56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392168 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804537}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599177512-b01388e3af00195f29af1f849ccfb9a29d0804ad.profdata to chrome-mac-master-1599198987-d991dddb2c00d3ed866518be68c89430502fa377.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icb8f46f44e2abc74261ef75708bdf593974719da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393655Reviewed-by:
-
My Nguyen authored
As part of moving spell check settings to OS settings in Chrome OS, updating spelling service pref when spell check pref changed is identified to be better dealt with in spellcheck_service. Related CL: https://crrev.com/c/2360093 Bug: 1113439 Change-Id: I0532d28d92912e5437ef729bd84b4916ffc55af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387912Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84902ce006f0..d91cd6b5ee2b 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 210fb6b5 to 7a93e029 (467 revisions) 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 75690ce7ef4a to e63aa953ddfd (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ib6485c6ae29d552007899fc264237a93a5377273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391874Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_PrintingFailed message to PrintingFailed() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I9fa3b5d5ca1db492aeaa23cc3a13f467d3149c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377264 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804533}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bef95be956d4..23909d8cfc57 2020-09-04 chrche@microsoft.com [Loc] Presubmit performance improvement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116989 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e69839832a7ecb7638e1f132899d3132a6a8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391872Reviewed-by:
-
Victor Fei authored
AXPosition::AtEndOfTextSpan relies on CreateParentPosition to determine if an inline text box marks the end of text span. Since CreateParentPosition calls into AtStartOfLine which calls AtEndOfTextSpan so we end up with an infinite loop and stack overflow. https://crrev.com/c/2245611 fixed most cases with this infinite loop of AtStartOfLine/CreateParentPosition/AtEndOfTextSpan by checking for AtEndOfAnchor first before calling AtEndOfTextSpan. However consider the following example: <style> .required-label::after { content: " *"; } </style> <label class="required-label">Required </label> labelText #1 ++staticText name='Required ' nextOnLineId=inlineTextBox #2 ++++inlineTextBox name='Required ' nextOnLineId=inlineTextBox #3 ++staticText name=' *' previousOnLineId=inlineTextBox #4 ++++inlineTextBox name='*' previousOnLineId=inlineTextBox #5 AtEndOfAnchor check would not prevent this infinite loop, if AtStartOfLine is called on staticText #4 name=' *' as the max text offsets differ between staticText #4 and its inlineText #5. This CL fixes the above issue by making AtEndOfTextSpan not to call CreateParentPosition. Instead it determines end of text span by directly looking at the current position's parent role and its index among its siblings. AX-Relnotes: Fixes hangs in certain accessibility scenarios. Bug: 1120636 Change-Id: Ic99c27b069f220f26da736b3946560ef23d6b622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369681 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9eb24f89..5966c3d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia75618a5a90d9e1b35edd894b9343ea612fba1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391985Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804530}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1877f680e3b2..1e7df19a137f 2020-09-04 thestig@chromium.org Revert "Optimize a tight loop in FX_Number." 2020-09-04 tsepez@chromium.org Remove CFGAS_FontMgr::EnumFontFromFiles. 2020-09-03 nigi@chromium.org Enable FPDFFlattenEmbedderTest.BUG_889099 for Skia/SkiaPaths. 2020-09-03 tsepez@chromium.org Fix some layering between fpdfsdk and fxbarcode. 2020-09-03 tsepez@chromium.org Initialize CPPGC heap with kNoConservativeStack. 2020-09-03 tsepez@chromium.org Tidy CFX_Font If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124998 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icad9dc4826d872eb2bdb59afd73b9773d240e005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393386Reviewed-by:
-
Sadrul Habib Chowdhury authored
If the main-thread is blocked until a vsync's deadline, then the reporter is cloned, submitted, and marked as having 'partial update'. However, it is possible for the main-thread to respond, after the deadline, with 'no updates' (or 'no damage'). In such cases, the frame that was submitted did not really have a 'partial update' So reset the flag that was set, so that the metrics are reported correctly. To do this: . When a reporter is cloned, track the link between the original reporter and the cloned reporter. . When the original reporter is no longer blocked, check if the frame ended with 'no updates'. If it did, then unset the 'partial update' flag from the cloned reporter. . The cloned reporter can be displayed before the original reporter has a response from the main-thread. In such cases, keep the cloned reporter alive until the original reporter receives the main-thread response, so that the 'partial update' flag can be unset if necessary. BUG=1115376 Change-Id: Ib2e8b0bc1fc924e7442625c4cb82dfa5a88ced95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385929 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804528}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6763a713f957..84902ce006f0 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0c25fbe3e3ed to 4a41204d8175 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1117433 Tbr: michaelludwig@google.com Test: Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Change-Id: I1753145eed6bdad2da2693d745d58c5bfcd484db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393385Reviewed-by:
-
David Black authored
MenuItemView supports being a thin wrapper around a sole child view but the child view isn't notified of changes to the parent's selected state. This means the child view doesn't know to update itself if it has some state specific characteristics. This CL makes selected state a subscribe-able property so that changes can be observed and reacted to. Bug: 1112888 Change-Id: I305eb1dd8cdb735d1bb14bd0f7c86ce8193b3670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393261Reviewed-by:
-
Dmitry Titov authored
We still need some NewTabPage.ContentSuggestions histograms since Zine and Jardin are still in Stable. Bug: NONE Change-Id: I731f8734513df84fbc25bffffaaac3c2d5b1069f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393240 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804525}
-
Jenny Zhang authored
Enable ash to read and send lacros user log in the feedback report. This helps to collect lacros log in case lacros crashes or being terminated for some reason. User can still send feedback via ash-chrome ui or "alt-shift-i". TBR=afakhry@chromium.org Bug: 1119925 Change-Id: I1274f09f75b885627bd97ef165d55861bb7ead5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393235 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#804524}
-
Regan Hsu authored
The test was previously failing because it was using Time::Now() as a reference, instead of a fake clock as it does now. Fixed: 1122584 Change-Id: I04cbb723dabc38fa1aad391d1a601150ec43c0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392984 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Richard Li authored
We need to pass HDRMetadata to SwapChainPresenter which needs proper metadata to set video processor. Moving media::HDRMetadata to ui/gl/ is a prepared work for that. This CL also move media::DisplayHelper to ui/gl/. Since it only provide functions related with HDRMetadata, this CL renames it to HDRMetadataHelper. Bug: 1122910 Change-Id: I0670c210cd0c194bf0ec1872cb5442d1f6a9b324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387620 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#804522}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_ShowInvalidPrinterSettingsError message to ShowInvalidPrinterSettingsError() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I711f255d964ef3089de1b55e08b0b0bde38f9e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374929Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36b884e6ace1..4a41204d8175 2020-09-04 ianelliott@google.com Vulkan: Improve invalidate for depth/stencil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Change-Id: I3804c01b56d2a361ec0f683b5f2ce127d31ea171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393382Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2cdb9f1ed183..62442aceb0fb 2020-09-04 jiawei.shao@intel.com D3D12: Combine all the barriers before dispatch() in one call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie646b3ed3420084fb65d9da85c56787385f75c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393576Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2c5b4455854d..e63aa953ddfd 2020-09-04 capn@google.com Don't assert on component swizzle matching identity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0e4893180d7394c0b18684c44bb1cd8035be274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393383Reviewed-by:
-
Yuly Novikov authored
This is 2nd CL out of 3 moving SwANGLE GCEs into chromium.tests.gpu pool. 1. https://chrome-internal-review.googlesource.com/c/infradata/config/+/3251996 Allocate GCEs in chromium.tests.gpu pool and increase chrome-gpu quota 2. This CL Switch SwANGLE bots to trigger tests in chromium.tests.gpu pool 3. https://chrome-internal-review.googlesource.com/c/infradata/config/+/3251999 Remove GCEs from chromium.tests pool and decrease chrome-desktop quota Note that there is no need to restrict other builders to chromium.tests, so that they won't target SwANGLE GCEs, because it is the default. Bug: 1123215 Change-Id: I2f146467f118c23b38d4f15a1fea868fac8ecfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392952 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#804517}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66d4faca55b5..bef95be956d4 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fa575852a99ee3e63c82f0e05db09f52b784a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393134Reviewed-by:
-
Hazem Ashmawy authored
Add basic UI espresso tests to make sure the correct UI elements and info are shown for different crash reports status. Fixed: 1106312 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: Idf16e513133db7592887f2b881b1ffefe3792b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376805 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804515}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599134104-920143836f5d72550f74eec8979ce216d37b0d87.profdata to chrome-win64-master-1599155892-1c7afa3c86090c53f24aedb3e14a5f3170b93aea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I5d9cba8e96801402738e1d72ab23bcecc1325b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393139Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I2f067b3b5ca733b26ea355cad8ae110e28e9f705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393516Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53c397b6..9eb24f89 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bb0ccced79f343a1b247b3942a9bc8a48f22353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391983Reviewed-by:
-
