GitLab

When looking for a RFH by last committed URL, there is no need to do a ForEach with a private FindFrame() predicate, since that logic is already available from a public FrameMatchingPredicate method in browser_test_utils.

BUG=

Review URL: https://codereview.chromium.org/807463003

Cr-Commit-Position: refs/heads/master@{#308458}

There should be no functionality change.

Previously autofill results were passed through as a set of three or four vectors:
  std::vector<base::string16>* popup_values,
  std::vector<base::string16>* popup_labels,
  std::vector<base::string16>* popup_icons
  std::vector<int>* identifiers
all of which have to stay in sync. This makes it impossible to add metadata, function calls are ugly, and the code is error prone. As part of wallet credit card autofill, we'll need to add more metadata here.

This patch replaces this with a new autofill::Suggestion struct containing all of the information, and pipes this around to all the affected places. It also adds a new SuggestionBackendID struct to replace the old GUIDPair typedef which makes the code clearer.

There are three types of IDs for autofill suggestions which is kind of confusing: a GUID created by the database which is actually a GUID + an integer (GUIDPair typedef in the old code), an integer ID used by the frontend and IPC, and an intermediate integer used by the autofill manager to create the frontend int ID.

This patch adds the GUID and frontend integer ID to the new Suggestion class as the backend_id and frontend_id. It is kind of confusing to have two different types of IDs in the same class, and previously most code dealt with only one or the other. But I think the code is much cleaner not having to keep separate parallel lists of IDs all over the place.

Unified the naming in the autofill popup controller. It previously used name/subtext and now that it uses the standard Suggestion struct, I changed them to value/label to match everything else.

Added constants for the card types used by RequestAutocomplete

Added some additional stuff to the CreditCard class for wallet sync. Add additional members to the autofill table for wallet card manipulation. These are currently unused.

Review URL: https://codereview.chromium.org/772253003

Cr-Commit-Position: refs/heads/master@{#308457}

R=lcwu@chromium.org,damienv@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/802833002

Cr-Commit-Position: refs/heads/master@{#308456}

Using "x()" in TupleLeaf's default constructor causes primitive types
(e.g., integers and pointers) to be zero initialized, whereas
previously Tuple left them indeterminate.  Arguably zero-initializing
is better, but the change was inadvertant and results in a measurable
code size increase, so this CL reverts it (at least for now).

BUG=440806

Review URL: https://codereview.chromium.org/791883003

Cr-Commit-Position: refs/heads/master@{#308455}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70c04a5..5450ee0

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/809483004

Cr-Commit-Position: refs/heads/master@{#308454}

BUG=441561

Review URL: https://codereview.chromium.org/797113002

Cr-Commit-Position: refs/heads/master@{#308453}

WindowsEventRouter needs to broadcast when no Chrome window has focus.

When toolkit_views first flips on Mac, nothing should actually change in
the release.

Until Chrome on Mac *only* makes Windows with toolkit-views,
WindowsEventRouter on Mac should still use
NSWindowDidBecomeKeyNotification + NOTIFICATION_NO_KEY_WINDOW.

This works both for windows created with toolkit-views and those created
natively.

BUG=439882

Review URL: https://codereview.chromium.org/773303005

Cr-Commit-Position: refs/heads/master@{#308452}

Move WebDataServiceWrapper into its own component webdata_services so
that the code can be shared with iOS.

The code cannot go into webdata component since it depends on other
components (autofill, password_manager, search_engine, signin) that
depends on webdata (as they implements the WebDataService interface).

BUG=437508

Review URL: https://codereview.chromium.org/777863002

Cr-Commit-Position: refs/heads/master@{#308451}

OOP PDF causes that the print-preview page to contain an iframe of the
PDF extension instead of directly including a plugin element. However,
the tests for PrintWebViewHelper use a fake print-preview page that
cannot contain an iframe of the extension because the necessary
infrastructure is not available in the test. This relaxes the
expectations so that in tests where the pdf element isn't an iframe,
that element is used instead.

BUG=303491

Review URL: https://codereview.chromium.org/800343004

Cr-Commit-Position: refs/heads/master@{#308450}

This is required for running the tests as a standalone APK.

BUG=441187

Review URL: https://codereview.chromium.org/803293002

Cr-Commit-Position: refs/heads/master@{#308449}

Re-enabled building of the browser_ui target on iOS (lost when
unit_tests was turned down). As with browser, removes non_android
sources and puts everything in non_mobile_sources.

See also https://codereview.chromium.org/785233002

BUG=432994

Review URL: https://codereview.chromium.org/801643006

Cr-Commit-Position: refs/heads/master@{#308448}

No layout switching; uses a hard-coded US layout.

BUG=430194

Review URL: https://codereview.chromium.org/778503002

Cr-Commit-Position: refs/heads/master@{#308447}

BUG=441997
TBR=bajones@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/791083004

Cr-Commit-Position: refs/heads/master@{#308446}

BUG=433014

Review URL: https://codereview.chromium.org/743773003

Cr-Commit-Position: refs/heads/master@{#308445}

The TaskQueue handles the basics of running a set of queued up tasks, and providing updates and various other callbacks for clients to be notified about queue and task state.

BUG=

Review URL: https://codereview.chromium.org/789603004

Cr-Commit-Position: refs/heads/master@{#308444}

BUG=

Review URL: https://codereview.chromium.org/807463002

Cr-Commit-Position: refs/heads/master@{#308443}

Revert of Include MTP devices in Cloud Import happiness. (patchset #9 id:160001 of https://codereview.chromium.org/778123006/)

Reason for revert:
seems to be causing crashes on chrome os:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/53530
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/35254

Original issue's description:
> Include MTP devices in Cloud Import happiness.
> Nuke "VolumeManager.isType".
> Add test coverage of importer_common methods.
> Make all "DCIM" dir-name matching case-insensitive.
>
> BUG=420680
> TEST=browser_test: FileManagerJsTest.*
>
> Committed: https://crrev.com/15d1aae4da7783607df3fac2d38198e817cf6fa0
> Cr-Commit-Position: refs/heads/master@{#308414}

TBR=mtomasz@chromium.org,smckay@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420680

Review URL: https://codereview.chromium.org/807583003

Cr-Commit-Position: refs/heads/master@{#308442}

BUG=428729

Review URL: https://codereview.chromium.org/788753002

Cr-Commit-Position: refs/heads/master@{#308441}

This will be used in https://codereview.chromium.org/798163003/

BUG=432500

Review URL: https://codereview.chromium.org/806433002

Cr-Commit-Position: refs/heads/master@{#308440}

cocoa/media_indicator_button.* is renamed to media_indicator_button_cocoa.* to
avoid conflict with views/media_indicator_button.*

BUG=425229

Review URL: https://codereview.chromium.org/797393003

Cr-Commit-Position: refs/heads/master@{#308439}

TBR=orglofch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/810503002

Cr-Commit-Position: refs/heads/master@{#308438}

Per Ryan's recent announcement, SSLWatcher's Alpha log is no longer
recognized by Chrome, so remove it.

This change also removes the assumption (made in the CertPolicyEnforcer)
that in case of having only 2 logs recognized by Chrome, only 2 will
be required where the policy currently says 3 would be necessary.

BUG=441337

Review URL: https://codereview.chromium.org/795013003

Cr-Commit-Position: refs/heads/master@{#308437}

Implement CommitVSyncParameter in SingleThreadProxy like ThreadProxy.

BUG=372086

Review URL: https://codereview.chromium.org/797693004

Cr-Commit-Position: refs/heads/master@{#308436}

This CL also makes it more clear in gin when type
coercion fails what argument (0-indexed) failed
to convert and what js type was seen in the process.

I started down the path of logging the c++ destination
type as well, but found I couldn't with our current
RTTI-less build.

This was already reviewed in:
https://codereview.chromium.org/798163002/
before I realized that gin was maintained in chromium.

TBR=abarth@chromium.org
BUG=

Review URL: https://codereview.chromium.org/805993002

Cr-Commit-Position: refs/heads/master@{#308435}

make it less flaky on memory.fyi bots.

BUG=441291
R=chirantan@chromium.org

Review URL: https://codereview.chromium.org/794303002

Cr-Commit-Position: refs/heads/master@{#308434}

The IPC still needs to be sent because it's used by the webview permission helper to permit PPAPI plugins to run inside a webview.

Remove all the code that backed this, including UMA actions, and a test.  The NPAPI purge, begun, it has.

BUG=439972

Review URL: https://codereview.chromium.org/801053003

Cr-Commit-Position: refs/heads/master@{#308433}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ffba57d..70c04a5

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/805043004

Cr-Commit-Position: refs/heads/master@{#308432}

that is used for easy sign-in protocol, and for signing data provided by
Easy Unlock app using the created private key.

Per user public keys are kept in the local state and added to challenge data when challenges
are created (while resetting cryptohome sign-in secrets).
During challenge creation, existence of the Easy Sign-in TPM key is
checked for user, and the key pair is created if necessary.
Additionally, key pair presence is ensured when EasyUnlockService is
started after user log in. This is done to handle the case where Easy Unlock
has previously been set up. At this time, it is verified that
the private key actually
exists in the TPM slot.

Mapping from user id to public TPM key is kept in local state
so it can be accessed on sign in screen (as it will be needed before a user logs in;
the public key is used to identify the private key in the system slot)

BUG=409027
TEST=Confirmed easy sign-in works

Review URL: https://codereview.chromium.org/729803002

Cr-Commit-Position: refs/heads/master@{#308431}

Renaming this thread broke some of the thread_times metrics.

TBR=epenner@chromium.org
BUG=440188

Review URL: https://codereview.chromium.org/806923002

Cr-Commit-Position: refs/heads/master@{#308430}

Provide generic desktop and mobile gesture configurations, in addition
to the native platform configuration. This will allow devtools touch
emulation to more faithfully emulate a particular device.

Note that this change involved decoupling the TouchEventQueue from
platform-specific slop region constants, afforded by a WebTouchEvent
flag indicating whether the event may cause scrolling as a default
action.

BUG=425586

Review URL: https://codereview.chromium.org/679633005

Cr-Commit-Position: refs/heads/master@{#308429}

BUG=438230

Review URL: https://codereview.chromium.org/747903006

Cr-Commit-Position: refs/heads/master@{#308428}

Part of change to collect, upload and expose histogram data
for Cronet.

BUG=441466

Committed: https://crrev.com/4eb0fd47de0736f3f4c970e8d7f8813ef2177886
Cr-Commit-Position: refs/heads/master@{#308239}

Review URL: https://codereview.chromium.org/794493002

Cr-Commit-Position: refs/heads/master@{#308427}

BUG=441848
TBR=newt@chromium.org

Review URL: https://codereview.chromium.org/792233005

Cr-Commit-Position: refs/heads/master@{#308426}

1. Use camera icon for "Scan new card".
2. Fix regression where icon wasn't showing

BUG=441534,441533
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/802553003

Cr-Commit-Position: refs/heads/master@{#308425}

* tools/perf/(benchmarks|measurements)/
* content/test/gpu

BUG=439512

Review URL: https://codereview.chromium.org/800863003

Cr-Commit-Position: refs/heads/master@{#308424}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e05fed0..41c9cbe

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/804013003

Cr-Commit-Position: refs/heads/master@{#308423}

This CL:
* Adds a new chrome page, chrome://device-log for the device log UI
* Eliminates the log from chrome://network, links to device-log

BUG=293739
For browser_resources.grd:
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/793933003

Cr-Commit-Position: refs/heads/master@{#308422}

Provide stubs for chrome.identity.removeCachedAuthToken() and chrome.identity.
onSignInChanged.

BUG=441976
TEST=added to app_shell_unittests

Review URL: https://codereview.chromium.org/804673002

Cr-Commit-Position: refs/heads/master@{#308421}

- Specify format of NMH manifest.
- Specify the expected locations of the NMH on all platforms.
- Fully document the communication protocol and constraints.
- Document every error and offer tips for resolving the issues.
- Document other common problems and how-to-solve.

BUG=377582
R=sergeyu@chromium.org,kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/768373004

Cr-Commit-Position: refs/heads/master@{#308420}

BUG=425756

Review URL: https://codereview.chromium.org/803673002

Cr-Commit-Position: refs/heads/master@{#308419}