GitLab

BUG=221813
TEST=compile chrome
TBR=satorux@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16067007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/16057010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203938 0039d316-1c4b-4281-b951-d872f2087c98

A couple of exceptions:
'... for your computer and mobile devices' -> 'computer and other devices'
'For mobile device' -> 'For Android device'
   These occur in the field 'desc', so don't affect the translation. They
   are all about Android device and 'Android device' seems better than
   just 'For device' to me.

BUG=242805

Review URL: https://chromiumcodereview.appspot.com/15980011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203937 0039d316-1c4b-4281-b951-d872f2087c98

We shouldn't do find-in-page while a IME is composing.  This CL delays the actual search until the IME composition is committed.

BUG=158911
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/15841009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203936 0039d316-1c4b-4281-b951-d872f2087c98

A client's didReceiveResponse can cancel a request; by protecting the
Context we avoid a use after free in this case.

Interestingly, we really had very good warning about this problem, see 
https://codereview.chromium.org/11900002/ back in January.

R=darin
BUG=241139

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202821

Review URL: https://chromiumcodereview.appspot.com/15738007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/15979019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203934 0039d316-1c4b-4281-b951-d872f2087c98

Originally getter StepsRunner.next has a side effect, thus
if it is called twice in one step, it shows unexpected behaviors.
This CL removed the side effect.

BUG=246463
TEST=browser_tests

Review URL: https://chromiumcodereview.appspot.com/15682007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203933 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/16217003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203930 0039d316-1c4b-4281-b951-d872f2087c98

R=jvoung@chromium.org
BUG= https://code.google.com/p/chromium/issues/detail?id=246092
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372
TEST= unit_tests --gtest_filter=PNaClTranslationCacheTest.*

Review URL: https://chromiumcodereview.appspot.com/16295020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162530

Review URL: https://chromiumcodereview.appspot.com/16248002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245268
TEST=
DriveFileSyncServiceTest.DisableOriginForTrackingChangesPendingOrigin
DriveFileSyncServiceTest.DisableOriginForTrackingChangesIncrementalOrigin
DriveFileSyncServiceTest.ReenableOriginForTrackingChanges

Review URL: https://chromiumcodereview.appspot.com/16232019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203927 0039d316-1c4b-4281-b951-d872f2087c98

Add jarjar rules that will rename all the Java classes defined in
Chromium code to be under a private package name when building the
WebView. This is only used when building inside the Android tree, so
does not affect upstream testing.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16154019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203926 0039d316-1c4b-4281-b951-d872f2087c98

We reach this all the time, and all it does is spam the logs

R=jamesr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15994007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203925 0039d316-1c4b-4281-b951-d872f2087c98

The location arbitrator relies on pointer comparisons to identify
which location provider provided a reported location.

Now, we clear this state when the providers are shut down.

This prevents a bug where a stale location prevented the arbitrator
from updating its clients with a newer location.

BUG=240956

Review URL: https://chromiumcodereview.appspot.com/15968009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243522

Review URL: https://chromiumcodereview.appspot.com/15942004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203923 0039d316-1c4b-4281-b951-d872f2087c98

- Closing a single tab, run beforeunload (if needed), then detached the tab from
   tab strip and close it asynchronously (no ui).
- Closing a window, run all beforeunload handlers (same as before), then detach all tabs with unload handlers. Close any remaining tabs and hide the browser window while waiting for the unload handlers to complete.

This CL started with fast-tab-closure and has grown to include fast-window-closure too.

BUG=142458,156896

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195108

R=avi@chromium.org, ben@chromium.org

Review URL: https://codereview.chromium.org/11016023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203922 0039d316-1c4b-4281-b951-d872f2087c98

The app launcher enable state no longer requires a registry check so
we can remove all of the asynchronous apis that were in place for it.

BUG=

Review URL: https://chromiumcodereview.appspot.com/16172005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203921 0039d316-1c4b-4281-b951-d872f2087c98

A new BrowserRenderingStats containing the latency info will be sent to the renderer so it can be retrieved from javascript.

BUG=155367

Review URL: https://chromiumcodereview.appspot.com/14931012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203920 0039d316-1c4b-4281-b951-d872f2087c98

Due to crrev.com/203393 we now blacklist the user data dir in
DoCheckWritableFile(). However, on Chrome OS the user Downloads
folder (~/Downloads) is a subdirectory of the user data dir and
serves the role of local storage. This should be writable for
file system API.

BUG=246339
TEST=verified Downloads folder is writable by v2 apps on Chrome OS.

Review URL: https://chromiumcodereview.appspot.com/15896035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203919 0039d316-1c4b-4281-b951-d872f2087c98

Since r202992 Mailboxes are now implicitly refcounted by client textures, so we
don't need to manually destroy them if the guest is lost (it's essentially a
noop at this point).

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15896031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244334
TEST=None. Underflow covered by existing tests.

Review URL: https://chromiumcodereview.appspot.com/15872004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203917 0039d316-1c4b-4281-b951-d872f2087c98

This is a workaround to prevent a browser crash when non-incognito windows
are disabled.

BUG=38676,244246
TBR=mnissler@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15859011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203916 0039d316-1c4b-4281-b951-d872f2087c98

This CL deletes DriveMetadataDB::DeleteEntry as a preparation for merging DriveMetadataDB into DriveMetadataStore.

BUG=246460
TEST=DriveMetadataStoreTest.*
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/15711009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203915 0039d316-1c4b-4281-b951-d872f2087c98

Enable visual styles for content_shell.exe, so that tooltips can work when hover around an element with title attribution.

BUG=239437
TEST=Run content_shell.exe and go to http://xkcd.com, hover around the image in the middle should show the tooltips.

Review URL: https://chromiumcodereview.appspot.com/15649020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203914 0039d316-1c4b-4281-b951-d872f2087c98

DragSelector class enables user to select multiple files by dragging.  By
calling DragSelector#startDragSelection(event), drag selection is
started. DragSelector class added handlers of mouse events, shows drag handler
and selects files by the mouse operation.

In order to call startDragSelection, users of DragSelector class must handle
'dragStart' event of the list and decide whether to call startDragSelection or
not according to the event. (e.g. whether the start point is hit to background
of the list or not)

If the drag selection is started with modifier keys (shift or ctrl),
DragSelector stores the selection state at the beginning of drag selection. If
an item included in drag handle once and then it is get out of the handler, the
selection state of the item is restored by the stored initial selection state.

BUG=224832
TEST=Added a call of startDragSelection to FileTransferManager, and
do drag operation on the file list.

Review URL: https://chromiumcodereview.appspot.com/15643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237912

Review URL: https://chromiumcodereview.appspot.com/14803010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203912 0039d316-1c4b-4281-b951-d872f2087c98

Fails to compile:

88>allocator.lib(allocator_shim.obj) :error LNK2005: "void * __cdecl operator new[](unsigned int,struct std::nothrow_t const &)" (??_U@YAPAXIABUnothrow_t@std@@@Z) already defined in libcmt.lib(newaopnt.obj)
88>..\build\Release\base_unittests.exe : fatalerror LNK1169: one or more multiply defined symbols found

> Modify base_unittests.exe to use the allocator shims
> required to use tcmalloc on Windows.
> 
> This fixes failing SecurityTest.MemoryAllocationRestriction
> tests which are testing the tcmalloc 2Gb memory limits
> imposed for security
> 
> BUG=242304
> 
> Review URL: https://chromiumcodereview.appspot.com/15674003

TBR=wfh@chromium.org

Review URL: https://codereview.chromium.org/16154020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203911 0039d316-1c4b-4281-b951-d872f2087c98

Before, the resizing of the file list and the grid list was delayed to avoid making the UI janky. That delay caused flickering of the screen when showing the Save-as dialog as well as when maximizing/restoring the window.
This patch solves this problem by calling immediately resizing the file list and grid view, but delaying any consecutive resizes.

TEST=Maximize, minimize, check the Save-as dialog.
BUG=245042

Review URL: https://chromiumcodereview.appspot.com/15809008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203910 0039d316-1c4b-4281-b951-d872f2087c98

From within a packaged app, clicking target=_blank links or calling window.open will now launch the given URL using the system's default handler. 

This behavior only affects Linux, OS X, and Windows builds. 

BUG=145646,227011

Review URL: https://chromiumcodereview.appspot.com/15720009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203909 0039d316-1c4b-4281-b951-d872f2087c98

base/string16.h was moved into base namespace in r191198 by Brett.

BUG=None
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15704005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203908 0039d316-1c4b-4281-b951-d872f2087c98

required to use tcmalloc on Windows.

This fixes failing SecurityTest.MemoryAllocationRestriction
tests which are testing the tcmalloc 2Gb memory limits
imposed for security

BUG=242304

Review URL: https://chromiumcodereview.appspot.com/15674003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203907 0039d316-1c4b-4281-b951-d872f2087c98

Both tyoshino and yhirano are pywebsocket developer and maintaining WebSocket code that uses pywebsocket for testing.

TBR=yhirano@chromium.org

NOTRY=true

Review URL: https://codereview.chromium.org/16349002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203905 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Issue 236549: Inactive window should not be capturing mouseover"

This reverts commit bb5596a0.

See issue 246335: pepper plugin no longer gets notified on of didChangeFocus.

BUG=245137

Review URL: https://chromiumcodereview.appspot.com/16140022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246229
TEST=Manually.

Review URL: https://chromiumcodereview.appspot.com/16336020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203903 0039d316-1c4b-4281-b951-d872f2087c98

The struct does not help simplifying the test at all, it just complicates everything around it instead.

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/16024007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203902 0039d316-1c4b-4281-b951-d872f2087c98

After the upload is moved into its own class, the tile
can either have a resource or not. If it doesn't have
a resource, but has a raster task, the memory is unreleasable.
That makes all the memory states are implicit.

Review URL: https://chromiumcodereview.appspot.com/15715031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203901 0039d316-1c4b-4281-b951-d872f2087c98

Original codereview at https://codereview.chromium.org/14789020/

This fixes the win_aura failure from the original patch.

BUG=none
TBR=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16105012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203900 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203899 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151669:151677&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16337011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203898 0039d316-1c4b-4281-b951-d872f2087c98

This is a fairly direct port, except for the removal of the frontend
test for ForceClosed

BUG=234278

Review URL: https://chromiumcodereview.appspot.com/15724006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203897 0039d316-1c4b-4281-b951-d872f2087c98