GitLab

A previous CL (*) already did this up to the first observation.
Now we enforce it for all times content skips and unskips.

The rationale for this change is that content-visibility is a
UA-controlled best practice, and it is mostly up to the UA to avoid
layout shifts when using this feature.

Note that there will still be layout shifts reported for elements
adjacent to (but not descendants of) content-visibility:auto elements
if the content-visibility:auto element resizes and causes a shift.
The change in this CL applies only to the content-visibility:auto
element itself.

Bug: 1151526

Change-Id: Ie3aed71b2f2500ea799c7bf77dbdd28e60a9175a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566270Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832142}

Add readPixels validation for RGBA / UNSIGNED_SHORT combination. This is
only valid with EXT_texture_norm16 extension enabled.

Bug: 1152259
Change-Id: I0e10b7d29f3b362c4054500270bbad87dcde599f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559797
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832141}

There was a recent regression in the search the menus behavior where
search results were not being read aloud to the user; however, the issue
no longer reproduces as of 89.0.4342.0. To catch possible regressions in
the future, this change adds speech expectations to the existing search
the menus test.

Bug: 1151102
Change-Id: I201b8b12dfbf2025f42ced93ade5ac4c63c5c1a3
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565737Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832140}

Bug: 1153761
Change-Id: I0ccd25212c03c0b62609205f3f92fb965cbb2e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566732Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832139}

In preparation of 100% stable rollout, this CL turns on the feature
by default, and deletes the field trial configuration.

Bug: 1128629, 1006111
Change-Id: I03b8af9c5a3bbcb2b5ff20b567c86366e3122217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561910
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832138}

Bug:1150634

Change-Id: Ia9ac840f9d8eccf75ddb40d2dd55007e2e4a53ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556444Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832137}

This reverts commit a6c2104c. It also
adds iOS to the list of impacted platforms.

Reason for revert: crbug.com/1152130

Original change's description:
> [Lookalikes] Enable target embedding by default on ToT.
>
> Bug: 1076617
> Change-Id: I5d818d4db60fad9e4cdc8e862d82a5bff6372560
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505583
> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821978}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1076617
Change-Id: I43c31dc635ae879aa3ad3a326ea48cf49751f735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555466
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832136}

https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596

2020-11-30 primiano@google.com Cleanup for Windows standalone support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:174454879
Tbr: perfetto-bugs@google.com
Change-Id: If45d2cca32d624a563965b05b16091e8b5e3cca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566871Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832135}

This is a follow-up for https://crrev.com/c/2222362.
Add configs for the new analyzer to enable it on Gerrit.

Bug: 1058341
Change-Id: I0a3284bc0031be782002d87ec7350bf17eb4e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560519Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832134}

Leftover from cleanups from the related bug.

Bug: 688943
Change-Id: I32e81561ffc0834874203f1e1c16443d6156924e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563542
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832133}

New expectations were created due to renames of tests at:
https://github.com/web-platform-tests/wpt/pull/26588

This patch removes old expectations.

TBR=tkent@chromium.org

Bug: 1151800
Change-Id: I772fecea73d0987bda9d85e52ae390c0736ddd81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567070Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832132}

Previously only "org.h5l.kcm" was allowed, but user reports indicate
needing to access the "com.apple.GSSCred" service as well.

R=kerrnel@chromium.org, rsesek@chromium.org

Bug: 1134449
Change-Id: I4c61c82f448de8409c5e5cf3878451a4d69e1264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560804Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832131}

There are three WebUIs defined in Content which use Mojo:

- gpu
- process-internals
- conversion-internals

These are adapted here to use newer Mojo JS modules.

Bug: 1004256
Change-Id: If766eb81599d9311b79076011a8ac1d08f343927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555806Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#832130}

https://chromium.googlesource.com/angle/angle.git/+log/619ae0038825..3f564fc76ea8

2020-11-30 jmadill@chromium.org EGL: Generate entry points.
2020-11-30 paulthomson@google.com Capture/Replay: track swapWithDamage
2020-11-30 jmadill@chromium.org Rename FromGL to PackParam.
2020-11-30 jmadill@chromium.org EGL: Generalize the entry point enum.
2020-11-30 jmadill@chromium.org Vulkan: Use XFB queries with the XFB extension.
2020-11-30 syoussefi@chromium.org Fix ordering of stages in gl::ShaderType

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ianelliott@google.com
Change-Id: I04ee7198176350554faa969c042ef13b4df166dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566210
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832129}

This change decouples detecting the language of text from the model
inference of CLD3. This will enable the TFLite-based model to rely
on the same detection utilities that are not model specific.

Bug: 1151409
Change-Id: I7780a9a66efe8b0f1cdf765cfc838a4e98954f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560662
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832128}

aria-hidden=true is set on the toast when it's hidden, and removed right
before the toast is shown.

Tested manually for chrome://extensions on Mac using VoiceOver

Bug: 1084193
Change-Id: I5f11f5beec4facb52a6ab41fc34bc8b2a9d33651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559733Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832127}

Currently we have is_overriding_user_agent in
DidCommitProvisionalLoadParams to indicate if user-agent override is
used when loading a document. This information can be known entirely in
the browser side by checking the NavigationRequest's
is_overriding_user_agent for cross-document navigations, and reusing the
last value for same-document navigations - this CL adds
is_overriding_user_agent_ to RenderFrameHostImpl for this purpose.

This CL also adds DCHECK_EQs for is_overriding_user_agent calculated in
the browser vs the value sent by the renderer, and DumpWithoutCrashing
for this param is added in https://crrev.com/c/2557877.

See DidCommitProvisionalLoadParams removal doc:
https://docs.google.com/document/d/18FeFEnfH_hTeGH7b_qkIto8pGtxdU54msnPlWo-qldA/edit

Bug: 1131832
Change-Id: I569f5454c2efcac58c5e31470ae08f41b060717f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398000
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832126}

https://skia.googlesource.com/skia.git/+log/5b589fd27351..4c6f57a23e63

2020-11-30 tdenniston@google.com [svg] Use new code path for rest of presentation attrs
2020-11-30 bsalomon@google.com Remove GrRenderTargetContextPriv and GrSurfaceContextPriv
2020-11-30 reed@google.com move SkMipmapBuilder to private

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: westont@google.com
Change-Id: I6eb02db08d9b1182a6414bf4ad849dbb520ee159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566650Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832125}

This CL updates video-layer-crash.html to use
video.requestVideoFrameCallback() and guarantee that a frame is
outputed before ending the test.

Bug: 1082868
Change-Id: I7d75319a50f1f5eae07d3644e148c6cdf8558c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560879
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832124}

1. Remove fixed height
2. A padding on top & bottom
3. A max width on title and primary button to make it wrap text
correctly

A demo: https://hsv.googleplex.com/4791153801035776

Bug: 1152524
Change-Id: Ie8072005affac41a9be7abd2c1a06ff419808ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565384Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#832123}

R=dcheng@chromium.org, mlippautz@chromium.org

Change-Id: I52a8377e4811edb4f6f32dbb1749b3dfd03a4467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561108Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832122}

Improve handling conversion between a byte and a CtapDeviceResponseCode:
* Fix undefined behaviour from static_cast'ing a byte before verifying
  it's in the CtapDeviceResponseCode enum.
* Log the byte we actually received when we get an error, instead of
  converting the response code back into a byte. This way, we log codes
  we don't know about and save me some emabarrassment when reporting
  bugs to authenticator vendors.
* Convert the list of codes into a shiny new constexpr flat_set. Now we
  don't have to manually increase the array size to avoid the compiler
  yelling at us.
* Add some missing CTAP codes.
* Add a logging for bad GetInfo responses.

Fixed: 1148479
Change-Id: Ic8966f4c881d4a6c7872ed8dc6cbf1a5fd05377a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562973
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#832121}

A previous fix attempted to remove some warnings. Some source_sets were
not using the private_config needed to build. Adding the private_config.

Bug: 1152807
Test: CQ
Change-Id: I8f8f4a74affd161e7a39a99e43a8060d8421b4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566371
Auto-Submit: Andres Medina <medinaandres@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832120}

Integrate the core logic into AwContents for Android P and above.

Note that we are now using DisplayMode to check the fullscreen status.

Adding basic instrumentation tests require some plumbing into test
activity and its rule since we need to hide action bar *before* setting
the content view.

Bug: 1094366
Change-Id: I7296038f894861f68c57c025caa6a70ea9b69ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299461Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832119}

Never queue audio data, and limit to only one copy of other messages.

In particular, if a loopback receiver stopped receiving messages, the
mixer's send queue (for the audio data) could grow without bound,
leading to OOM.

Merge-With: eureka-internal/492543

Bug: internal b/165017599
Test: on device

Change-Id: Ib66c9f00fd4f451e8bba66e6586f9023cd1bc668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555726Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832118}

git grep -l '12b5035g' | xargs sed -i '' -e 's/12b5035g/12b5044c/g'

Bug: 1148325
Change-Id: Ifa509da0edd67c3666bf09345c8793d63274338f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566736Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832117}

This patch gets rid of unused function |VisibleSelection::
CreateWithoutValidationDeprecated()| for improving code health.

Change-Id: I17802935d39859369c62630c91e26acaa95fa8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563389
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832116}

Bug: 1144325
Change-Id: I59caaf4c860adce66fcda090c46a6dd91dc37ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533284Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832115}

ServiceWorkerStorageControl::ApplyPolicyUpdates() is changed to
return a response so that ServiceWorkerRegistry can check whether the
call is finished or not.

ServiceWorkerStorage::ApplyPolicyUpdates(), the implementation, is also
updated to initialize the internal storage if it's not initialized yet.
It is because ApplyPolicyUpdates() updates a list to specify which
resources should be purged on shutdown, and the internal storage needs
to be initialized before purging starts in the destructor of
ServiceWorkerStorage.

Bug: 1133143
Change-Id: Ibf9badedac78d946baed200dd84f826d9b0d26de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563187
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832114}

R=johnchen@chromium.org
CC=mlippautz@chromium.org,bikineev@chromium.org

Bug: v8:11180
Change-Id: I51056fe537f442cb266ad6c550e44149a93a0642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560596
Auto-Submit: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832113}

* Moves some platform-specific includes behind build flag
* Cleans up imports
* Deletes copy constructor and assignment operator (removes old macro)

Bug: 1147967
Change-Id: I4c7a69ed7999b66f0d3ae4b63542103f96a5293c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560532Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832112}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I117bde55d6a9b2ddbf2cfd05e6938a9cdc8d00ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832111}

Add the tabUpdate option to the setExtensionActionOptions API which
provides a way for extension developers to manually increase or decrease
the action count for a given tab.

Skipping presubmit since this seems to be hitting crbug.com/956368.

Bug: 1123296
No-Presubmit: True
Change-Id: Ie235f12841029aa45f92ed61b2e300d78d4d0fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489913
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832110}

When tab switcher return "immediate" is enabled, we shouldn't show the
Incognito Start surface (single) when resuming Chrome. Instead, we will
show the Incognito tab switcher.

Bug: 1153713
Change-Id: I2710e1bad9bca3f577354367e2b1363e72561812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565730
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832109}

Renames "PhoneHub.Connectivity.Success" to "PhoneHub.Connection.Result"
according to the metrics doc.

Bug: 1150634
Change-Id: I33cb9ab52c7d0011fb81fdfd98eef2ec7ee30876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559616
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832108}

Bug: 1152873
Test: CQ
Change-Id: Ib7bb8a862e8e72862a01d1e2087b567e09ddf3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560812Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832107}

Bug: 1138344,1138343,1138342,1138330,1138299
Change-Id: I888b5628cb2eb2703211a52c941d7da3d4eb128c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556698Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832106}

This reverts commit 411f55ec.

Reason for revert: New icons are slated for M-89

Original change's description:
> Revert "[CrOS Customization] Update app icons"
>
> This reverts commit dc1d693f.
>
> Reason for revert: No longer wanted in M-87
>
> Original change's description:
> > [CrOS Customization] Update app icons
> >
> > Includes icons for the Settings, Wallpapers, and Keyboard Shortcuts
> > apps.
> >
> > Screenshot: https://screenshot.googleplex.com/7KdMiBkMFH7fuxh.png
> >
> > Change-Id: I6cf1d45d78f36caeb1429629cc0067b1cbd57daa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429395
> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#810376}
>
> Bug: 1138609
> Change-Id: Iaa04c22814b3d8cd1ddc06ceb7a7beb14ad8d030
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472346
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817236}

TBR=jamescook@chromium.org,khorimoto@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138609
Change-Id: I1a21c836fe342ec5adc74978723a077a77a45071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561020
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832105}

Every time I change the declarative Shadow DOM syntax, I forget
to update this perf test. Sorry to the sheriffs. I wish there was
a CQ bot to test this.

Bug: 1042130
Change-Id: If3ba921ce72d30d8c66f71489d2c46272a78c042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565591
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832104}

Bug: 1153264
Change-Id: I82cb51a3f03ba9e8c7ad0f1e156f1f4ede680393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565713Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832103}