- 27 May, 2020 40 commits
-
-
Dominic Farolino authored
Bug: N/A Change-Id: I60d6097499d49c178d0da83197bb2316a2240e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215257Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#772065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be61a7c024b6..aef138255c4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039904,chromium:1083349 Tbr: mpearson@google.com Change-Id: I9bfe0c5001ba69ab37c4f45e43c114c4b4982d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216762Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772064}
-
nancylingwang@google.com authored
Ash(ShelfController) should observe AppRegistryCache to get the app notification badging information. Ash can't depend on chrome/*, so move AppRegistryCache to components directory to split AppRegistryCache from chrome. BUG=1068884 Change-Id: I215d02203a25f61a0b1dcb9a1a92d69768b4bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210208Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d4647dffe2f..a5e07cc3db44 2020-05-26 tommi@webrtc.org Rename more death test to *DeathTest 2020-05-26 handellm@webrtc.org AsyncResolver: remove dependency on SignalThread. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8e869fb068956b083336956da9edadc9a125c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772062}
-
Nidhi Jaju authored
ServiceWorkerDatabase for a OOM crash investigation Bug: 848194 Change-Id: Ie6f08af06575c024fe4f81e5725f3235b286d086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215652Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772061}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of an extensions/ test that didn't expect a change of RenderFrameHosts etc. on same-site navigations. This CL does not include fixes for other tests in chrome/ content/, components/, and layout tests (they're fixed in other CLs) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I8b1d61ab107b6cead501fee669f90aeca6c7a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212224 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772060}
-
Eric Willigers authored
The flag MediaSessionSeeking has been stable since 2019-08. Bug: 977375 Change-Id: I626de5ee229586f729681825e74d3d57e8c3b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209938Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772059}
-
Chong Gu authored
These tests will add a total of ~6 minutes to bot time and run time per builder run. Bug: 1086742 Change-Id: I29e42d62dc92569f86e941e1417cab6bd3a991a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217011Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#772058}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3393ea589ec..a03bec408ff6 2020-05-26 sadrul@chromium.org [tests] Re-enable some scroll-related unit-tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:934649 Tbr: eseckler@google.com Change-Id: I17f18f967db52a9a0e6a0f93d44881e8b65bcee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214998Reviewed-by:
-
En-Shuo Hsu authored
Add UMA to log the return event from a socket connecting to the Bluetooth device through SCO. This will be used to monitor how frequent the underlying SCO connection setups fail and if our fixes address the issue. The CL on CRAS side: http://crrev.com/c/2198851 BUG=b:2198851 TEST=Deploy adhd and chrome on DUT and verify the event is recorded at chrome: //histogram/Cras Change-Id: I84a817bb01b033e7250c1f5d9e7c4915d5d95851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208793Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772056}
-
Gabriel Charette authored
Note to QA: This CL is purely mechanical and shouldn't be blamed for future regressions on touched files. Only migrate explicit usage of content::BrowserThread in step #1 as these are the only ones that clearly map to a fully qualified call to content::Get(UI|IO)ThreadTaskRunner(). Script @ https://crbug.com/1026641#c91 Will make BrowserTaskTraits optional when empty in a follow-up (can't before end of migration because of cyclic dependency between browser_thread.h and browser_task_traits.h). (will TBR fdoray@ post-review for mechanical change) TBR=fdoray@chromium.org AX-Relnotes: n/a. Bug: 1026641 Change-Id: I27615773472c97d9bfd981c8c9e783c26525b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211138Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772055}
-
Victor Hugo Vianna Silva authored
This CL introduces a new frontendId field to chrome.passwordsPrivate types for passwords and exceptions. This field will be used to group existing duplicates across stores in future CLs. Bug: 1049141 Change-Id: Ib856778e0a06043e44d2d624d4440c38a3358527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210462Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#772054}
-
Xianzhu Wang authored
Extracted from pdr@'s https://chromium-review.googlesource.com/c/chromium/src/+/2209993/3. For testing non-composited-scrolling without depending on volatile composited-scrolling trigger rules based on style. Change-Id: I173e517da6539ca42336704c0a20942ef1c1e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213323 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772053}
-
Eric Willigers authored
The flag IntersectionObserverV2 has been stable since 2019-01. Bug: 827639 Change-Id: I31e4e6b5a0cdae99a0a3c56d504a99216cc653b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208802Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772052}
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I1ce62770cc27561d577a1508a87d677fad9da043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210350 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772051}
-
Anastasia Helfinstein authored
In an effort to better share test infrastructure, the first step is to move the currently shared files into a shared directory. AX-Relnotes: n/a. Bug: 1078119 Change-Id: I68240eea961dd6ca733cca483332dbd6caaa230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772050}
-
Nate Chapin authored
Bug: 1086668 Test: images/enable-images-then-detach-crash.html Change-Id: Id685d3fe1283efa2d3695a81c4154031f860b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216792 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772049}
-
Andres Pico authored
In the past, we've checked for the presence of the kNoSandbox switch when initializing sandbox_info, and if a child process was unsandboxed we would avoid initializing sandbox_info at all. However, the kNoSandbox switch is only meant to be used as a browser level flag for testing purposes only. There exist other ways to denote an unsandboxed process too, as in the case of the unsandboxed utility process which uses the switch service-sandbox-type=none instead of --no-sandbox. Similarly, there's also an unsandboxed GPU process which makes use of the --disable-gpu-sandbox switch instead of the --no-sandbox switch. This has resulted in having unsandboxed processes initializing their sandbox_info as if they were brokers, and as a consequence, having the same process mitigations applied to them. This last behavior is certainly an unintended side-effect that could manifest as a bug eventually. In this CL, we're updating the way in which we check whether a process is unsandboxed to ensure that no unsandboxed processes have their sandbox_info initialized as brokers, and to prevent applying the same process mitigations accidentally. Bug: 1066258 Change-Id: Ifdc14b0e29f9505edeec93417bd9cc7ab73e94c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208189 Auto-Submit: Andres Pico <anpico@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772048}
-
Anastasia Helfinstein authored
This is the (hopefully) penultimate change in the process of changing to a views-based menu for Switch Access, as part of implementing the visual specification. This change rewrites the menu manager to use the new menu, rather than the old menu. A clean-up change (to remove code for the old menu) will follow this. AX-Relnotes: n/a Bug: 973719 Change-Id: I596d47a8f976a531e545bc56555f9f8da80efbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176611 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Pete Williamson authored
As part of a three sided change, remove the old version of the API now that it is no longer in use. Bug: 1080884 Change-Id: If344fbbedadad6c5c807baad3443a3811860cdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199981Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#772046}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates the print dialog navigation test that previously didn't expect a change of RenderFrameHosts etc. on same-site navigations - we're now changing the test to do a same document navigation (which is what GMail is doing). For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: Ifeb972f92f86d45385545f84d27d53784d7abe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212287 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#772045}
-
Yue Li authored
Check the enrollment status before calling stop enrollment call. Also restore a JS method that was removed accidentally recently. Bug: 1084388, b/157268233 Test: Manual Test Change-Id: I86826951ee2185ca0b1635278ef5b2a84358ac35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213241Reviewed-by:
-
Greg Thompson authored
When loading a .pak file, allow other entities on the machine to open the file for deleting but not for writing. This is closer to the way an executable is mapped into memory for process creation. With any luck, this will reduce startup crashes resulting from an inability to map in the locale's pak file. This change also adds DataPack.Load to the Chromium metrics description files (it has historically been in the Google internal one). BUG=1076423 R=asvitkine@chromium.org Change-Id: I3039922d0edab047e48cf03699f93bcb2c2f0673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215241 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Add a WebEngineRenderFrameObserver object whose lifespan is bound to the RenderFrame. This class owns other objects whose lifespand is also bound to the RenderFrame and that need to be accessed through WebEngineRenderContentClient. * This is a preliminary refactor to add more objects to this class, particularly for the Cast Streaming Receiver. Bug: 1042501 Change-Id: I1b8ba1de47be717e1ce28a3fcd40ebccb7a2f4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209752 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772042}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I32807d7e13c9347b9c214eac7168649e4a8bbd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212115Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772041}
-
Victor Hugo Vianna Silva authored
This CL adds an integration test that checks that, if the user clicks "Save" on the bubble introduced in crrev.com/c/2112360, the unsynced credentials get saved in the profile store. Bug: 1060132 Change-Id: I014515112abfaf1d3955c06a1d1567cd6e9d6fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207228 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772040}
-
Rouslan Solomakhin authored
Before this patch, desktop was the only platform that stored the Payment Request data from the renderer in a payment_request_spec.cc class and all C++ payment app implementations depended on it. This complicated using the C++ payment app implementations from Android. This patch adds a JNI wrapper for payment_request_spec.cc, which is used on Android and is passed into native. After this patch, it's possible to pass the C++ payment_request_spec.cc into the native service_worker_payment_app.cc when it's created on Android. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: Ic78488ac8d565c9fe6a8f892b56d20c0666386c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212387 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772039}
-
Aaron Colwell authored
The original code created the CPSPI::Handle in response to RegisterHost() calls on the AppCacheBackendImpl. These calls can arrive after the process has been destroyed which is what was causing the invalid handles to get created. This change creates the Handle when the AppCacheBackendImpl is created and then duplicates this Handle when the RegisterHost() calls occur. Creating the Handle earlier allows the security state for the process to be kept alive beyond the process lifetime so it can be used by the RegisterHost() calls and the resulting AppCacheHost. This should prevent the invalid handle crashes reports that we have been receiving. Bug: 977169, 1086306 Change-Id: I987b8b22ce2c5e0db2fe9a42b5b329b487bed73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216913 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#772038}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/30298dc25394..9dac86c9c458 2020-05-26 gbiv@chromium.org gen_proc_table: generate `const` tables 2020-05-26 kbr@chromium.org Remove requirement of OES_texture_half_float for EXT_color_buffer_half_float. 2020-05-26 kbr@chromium.org Emulate GL_EXT_sRGB on ES 3.0 devices without native support. 2020-05-26 jmadill@chromium.org Vulkan: Fix bad delete of swapchain. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1079475,chromium:1084580 Tbr: ynovikov@google.com Change-Id: Iefc12e81d2178e0ba9c3c30ebcda9bb1efaf60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216761Reviewed-by:
-
Mustafa Emre Acer authored
This CL observers the creation of JavaScript dialogs. When it detects one, it immediately shows the delayed SafeBrowsing warning which also cancels the dialog. A new histogram bin is also added to record this event (kWarningShownOnJavaScriptDialog). Bug: 1081314 Change-Id: I7f8bcf1fc94f62007d8fc4e2170dadb613b7038a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216382 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772036}
-
Lukasz Anforowicz authored
Bug: 1085629 Change-Id: I9f4b25a064f523b30208405b17f33b1b0596f7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212999Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#772035}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79156e7a..c3f19085 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd6b8b876b7b0d0b7e4875f81ebafd7a64ef62af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772034}
-
Kurt Horimoto authored
This CL tests that the location bar state is set correctly when an HTTP authentication dialog finishes its dismissal when the active WebState is null. Bug: 1085676 Change-Id: I8ca8951b5782b8e239b5c2940ced10a6887924a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216639 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#772033}
-
Anders Hartvoll Ruud authored
There is currently some code in FontBuilder that tweaks the specified font size if the current generic font family changes to or from monospace. This code assumes that the FontDescription stored on the ComputedStyle pre-CreateFont is the inherited FontDescription, but this is no longer (always) true. This means that declarations like font-size:1em can be applied (and subjected to CreateFont) twice, which means that the second call to CheckForGenericFamilyChange won't detect a change in the monospace-ness, hence the specified size will fail to adjust. This CL fixes this by propagating the actual parent style to CheckForGenericFamilyChange. Bug: 1086082, 1086680 Change-Id: Ia61a2327890f27497e4ea5f41dec00a5e0a450d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216511Reviewed-by:
-
Tsuyoshi Horo authored
FrameNavigationEntry's |web_bundle_navigation_info_| is used for history navigations inside a web bundle. But it is set in NavigationControllerImpl::RendererDidNavigateToNewPage() only when the navigation type is NAVIGATION_TYPE_NEW_PAGE. It must be updated for other navigation types. So currently history navigations of iframe inside web bundle are broken. To fix this problem, this CL changes NavigationControllerImpl to update the |web_bundle_navigation_info_| of the FrameNavigationEntry for other navigation types. And also, this CL changes NavigationRequest::CommitNavigation() not to pass |web_bundle_handle_| to |render_frame_host_| when the navigation was not served from a web bundle. This is intended not to keep the |web_bundle_handle_| in RenderFrameHostImpl when the page is not served from the web bundle and to make RenderFrameHostImpl:: MaybeCreateWebBundleHandleTracker() checks the parent frame's |web_bundle_handle_| even after navigating the iframe out of web bundle. (ex: WebBundleNetworkBrowserTest.IframeOutOfBundleNavigation) Unfortunately remote iframe navigations can't load pages from parent frame's web bundle (ex: IframeParentInitiatedOutOfBundleNavigation of WebBundleFileBrowserTest and WebBundleTrustableFileBrowserTest). We need to change NavigationControllerImpl::NavigateFromFrameProxy() to correctly handle the WebBundleHandleTracker. But this CL keeps this problem as TODO. Bug: 1040800 Change-Id: Id416155502582e7f075cf7ceeb8dfa1bc2caac1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014625 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772031}
-
Wez authored
This fixes local-sdk.py SDK builds to match Fuchsia's 'terminal' SDK images. Bug: fuchsia:50751 Change-Id: I49bbd26eb94f438029f62f971ee823eb40e1435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215329 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#772030}
-
Mounir Lamouri authored
This removes the duality between PictureInPictureServiceImpl and PictureInPictureWindowControllerImpl that made handling the PictureInPictureSession object more complicated than it should. Now, the service is simply a shell passing the requests to the controller which then handles the current session at the WebContents level. This CL also introduces a content_browsertest test in order to allow for integration tests that do not include the //chrome layer. Follow-ups may include moving some browser_tests to it as they tend to be flaky and they are not testing the actual UI. Also adds a check for surface_id being null when the session creation is requested. Bug: 1067152, 1069858 FIXES: 1067152, 1069858 Change-Id: I1c389c513cc227e6d0f9d5e447926186600cdc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197996 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#772029}
-
Wez authored
Negative |Popen.returncode| values indicate that the process was terminated by a signal (e.g. SIGSEGV) under POSIX systems. Check for -ve |returncode| values and report them with a different message text, to make it clearer when things are crashing. Change-Id: I84a3e30d5babea9d630347e10fbd5b21df5f0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213539 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d $ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s' 2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket. no functional change, not flag protected. 2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl 2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight. protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi. 2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-05-21 dschinazi Rename some transport parameters Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Roll src/net/third_party/quiche/src/ 8aff71f6f..517beaa47 (5 commits) https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d $ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s' 2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket. no functional change, not flag protected. 2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl 2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight. protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi. 2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-05-21 dschinazi Rename some transport parameters Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I4ea2e5add772e4c619f8acf87d197e96862163a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216638Reviewed-by:David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772027}
-
Mounir Lamouri authored
The flag is now enabled by default. Bug: None Change-Id: Iab273e0d44c0e511c9e2efd1dfaa37d9dafa5a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018089 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#772026}
-
