- 28 Mar, 2019 40 commits
-
-
Nicholas Verne authored
Bug: 899568 Change-Id: Iedc639ec1da770bd79c3cbbc8572120b8707a24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541538Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#645185}
-
Peter Kasting authored
The underlying goal here was primarily to avoid child_count(). In many cases the resulting code is also shorter and easier to maintain, although sometimes it's longer. I chose to use algorithms over manual loops (using e.g. range-based for), based partly on my own preference (I think these give readers a better idea of the general purpose of the loop without having to back-figure from the actual function) and partly on encouragement from various other team members who apparently also prefer algorithms. This also fixes an apparent logic bug in MenuItemView::GetChildPreferredSize() which would add padding before the first visible child in some cases. Bug: 940135 Change-Id: I1cd657a21066bbd23b2ae1df46f9d6ad411772a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535291 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#645184}
-
Peter Kasting authored
This allows deleting GetMenuItemCount() and makes a number of callers more efficient. I did not attempt to delete GetMenuItemAt(), which would likely require more int->size_t conversions. Bug: none Change-Id: I1b8ad0e6f653001f27781343931e3d89b4e6a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536638Reviewed-by:
-
Matt Menke authored
Only the first is marked as flaky, but the second presumably is as well, for the same reason: There's no way to wait on an idle socket being added to the socket pool. This CL makes the tests make network requests with nominally reusable sockets. Waiting for them to complete is a way to guarantee the idle sockets have been added back to the socket pool. It also combines the tests, because making sockets this way takes a fair bit of boilerplate. Bug: 905423 Change-Id: Ia6b9a9d983e18c8025edf472435f4be416c87104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542337 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#645182}
-
Doug Arnett authored
This is the 2nd part of dropping the abstract interface for HintCacheStore. It is a simple rename of the implementaion name from HintCacheLevelDBStore to HintCacheStore. There are no functional changes. Change-Id: I276b47200b6ec206e1741d2f33947cf7aa83b24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542686Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#645181}
-
Christian Biesinger authored
This has a 7.1% improvement on add-remove-inline-floats: https://pinpoint-dot-chromeperf.appspot.com/job/10b95f77f40000 Change-Id: Ief88091dd5d945bf2624907434ac740595505998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540737 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#645180}
-
Dave Tapuska authored
Remove two usages of SimplifyWhiteSpace that didn't do anything with the return result. These can be safely removed because String::Split won't append a result because |allow_empty_entries| parameter to the function is false. BUG=756221 Change-Id: Iad498bd4bf4ec0f55bf8eb7464a5adc465d938d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542146 Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#645179}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/889d743baa3d..5f4bcbb9467f git log 889d743baa3d..5f4bcbb9467f --date=short --no-merges --format='%ad %ae %s' 2019-03-28 jiawei.shao@intel.com Disallow creating multisampled 2D array textures 2019-03-27 natlee@microsoft.com Destroy frontend and backend for Textures Created with: gclient setdep -r src/third_party/dawn@5f4bcbb9467f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I18301ce58af6b9dab70cc1088bcb98ab375e8549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542977Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645178}
-
Robert Ogden authored
Fixes all but testServerReturnsLitePageAfterRedirect which I'll keep working on. It's a special snowflake somehow but this change should apply to all the tests. Bug: 946215 Change-Id: Id6ad309c451e7d60a56ae074ca81be2ba9b1b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540541Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c98dabddb964..4788c03a0392 git log c98dabddb964..4788c03a0392 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 derat@chromium.org chromite: Run TastVMTest on amd64-generic-full. Created with: gclient setdep -r src/third_party/chromite@4788c03a0392 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I7abf1052dc5bb7866a31f494c317f3d147694cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542976Reviewed-by:
-
Noel Gordon authored
Fail external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-alphabetic-invalid.html Constantly fails on Lunix Tests (dbg) bots - current example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/79264 https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/79264/webkit_layout_tests/layout-test-results/results.html Expected output / actual look very different, something to do with our support for CSS list-style-type and/or CSS @counter-style Tbr: foolip@ No-try: true Bug: 626703 Change-Id: Ia1138a656614c2b453e8bf9e2ace5a4becdd02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541537Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#645175}
-
Yoshifumi Inoue authored
Since the CL[1], |CollectInlinesInternal()| doesn't reuse item data from |LayoutNGText| because of |NGInlineNode::MarkLineBoxesDirty()| resets items data in |LayoutNGText| by calling |ClearNeedsLayout()| in |CollectInlinesInternal()|. This patch makes |CollectInlinesInternal()| to change its behavior based on items builder instead of |update_layout| parameter to make |MarkLineBoxesDirty()| not to reset |LayoutNGText| items data. This patch improves "line-layout-repeat-append.html" performance test as - Before: 9.01 run/s - After: 54.03 run/s - Legacy: 77.42 run/s (for reference, this patch doesn't affect legacy layout) Above numbers come from my local Windows box. This patch also recovers following perf tests: - line-layout-repeat-append - line-layout-repeat-select - flexbox-lots-of-data - flexbox-column-wrap - flexbox-column-nowrap Note: This patch is inspired by the comment[2] in the CL[3]. [1] http://crrev.com/c/1379627 [LayoutNG] Fix NGLineBreaker crash when inside of an inline-block changes [2] http://crrev.com/c/1529503/4/third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc#738 [3] http://crrev.com/c/1529503 [LayoutNG] Reuse ShapeResult for appendChild case Change-Id: Id018ef9575abcf83ba8f2a7511784b79aeab335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538072 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
- Widget has a new arrow icon. - The widget expands to display a text indicating chrome will be closed if back navigation is attempted at the beginning of navigation history. Bug: 865567 Change-Id: I5b568d1474fcf515d5e548428081370add2557f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540021 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#645173}
-
John Budorick authored
Tbr: tedchoc@chromium.org Bug: 945887 Change-Id: I55cfb7077195dbecc00de1e6488800cba1cd6920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542958Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#645172}
-
Wei Lee authored
This CL puts NO_EFFECT in supported effects for all cases in CrosImageCapture. Such behavior fits our design more. And this CL also fixes an enum issue by assigning values to all entries. Bug: b/117817062 Test: Tested on DUT and NO_EFFECT works as expected. Change-Id: Ie19132635e3019650baafe80619979023d9d11f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540020Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#645171}
-
khmel@chromium.org authored
Use jank detector to analyze graphics model and extract janks for the various bands. Janks are visualized on UI. TEST=Locally, unit_tests BUG=b:122555793 Change-Id: Iaca0d82929aeea1cf1606573ea52bfa01d930391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539482 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#645170}
-
Abhishek Arya authored
This is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/1542669 TBR=jbudorick@chromium.org Change-Id: I7117e9b75cbfe1cecd43cc5e2d76b4f710bf6fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542733 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#645169}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c16f6d28a115..9614b75c12b4 Created with: gclient setdep -r src-internal@9614b75c12b4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I9b1be86f3f12e1cbe0cc282838a3bc66bb97dd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Sam McNally authored
Use a real Profile in the tests instead of a TestingProfile. A real Profile has an extensions::EventRouter, unlike a TestingProfile. Also replace some NOTREACHED()s with DCHECK()s and include extensions::EventRouterFactory in file_manager::EventRouterFactory's dependencies. Change-Id: I090432af1a89d364e797986d1c59fad66e90c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542739 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/208af3ebda25..e18ff25d261d git log 208af3ebda25..e18ff25d261d --date=short --no-merges --format='%ad %ae %s' 2019-03-28 tobine@google.com Vulkan:Refactor SecondaryCommandBuffers 2019-03-28 jdarpinian@chromium.org Sampler state overrides texture state if set 2019-03-28 jmadill@chromium.org Fix deleting a buffer not updating VAO validation. 2019-03-28 jonahr@google.com Remove EGLThreadTest to fix angle_end2end_tests failures on Android. Created with: gclient setdep -r src/third_party/angle@e18ff25d261d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:940080,chromium:809237,chromium:943538 TBR=jonahr@chromium.org Change-Id: I979f20fd06dc71a51daf0c6c8264aa0e8900b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542494Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5125eb58dbb5..e0d59bbe1857 git log 5125eb58dbb5..e0d59bbe1857 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 johnkslang@users.noreply.github.com Merge pull request #1742 from greg-lunarg/kg102 2019-03-27 johnkslang@users.noreply.github.com Merge pull request #1740 from ewerness-nv/callableincoming Created with: gclient setdep -r src/third_party/glslang/src@e0d59bbe1857 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I384239284a6c3513541289d0b248b0da86612448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542492Reviewed-by:
-
Shahriar Rostami authored
Use accessKey attribute to focus element with a defined accessKey. Bug: 878897 Change-Id: I47ec9f02da4f33d205a21b3a8aa243f2e8e326fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485063Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Shahriar Rostami <shahriar.rostami@gmail.com> Cr-Commit-Position: refs/heads/master@{#645164}
-
Luciano Pacheco authored
EntryListItem current implementation doesn't require the recursive update to update the visible sub-items. This is part of optimizing directory tree to perform less requests to file system backends. Bug: 946872 Test: browser_tests --gtest_filter=*myFilesUpdatesChildren* Change-Id: I236409754ea3f1877fd6ab419e43d3dcd4313474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540839 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645163}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/dom, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. There are too many usages of Foo:::Create() that returns an instance using MakeGarbageCollected<>. So following patches will continue to replace them. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I14fdc9571c6e81582575c28c05e6876affa94351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540018 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Vikas Soni authored
1. This CL forces GpuChannel creation to also create SharedImageFactory. Before this CL, SharedImageFactory was lazily created. 2. Update an existing gpu unittest and add a new test. Bug: 900963 Change-Id: I700b8cce373bd619b34919feb9a41baf6fabf983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540373 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#645161}
-
Maksym Onufriienko authored
Bug: 946675 Change-Id: I9c9557b50334d300dff2d6ac5366d5ab9796f7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542457Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#645160}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I0c425d318262ef25407482e3a5e80030aff045a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542049Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#645159}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d2c19554e4a..e4c67058ddb1 git log 8d2c19554e4a..e4c67058ddb1 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c240abe4ef2c..208af3ebda25 (3 commits) Created with: gclient setdep -r src/third_party/skia@e4c67058ddb1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ifd790d20d6733153280209e7e12bad0c447018c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542491Reviewed-by:
-
v.paturi authored
Divergence is removed as a metric to decide if a block is a background as the pixels with low divergence may very well belong to the foreground. All opaque pixels are considered for classification irrespective of whether they belong to a foreground block. Pixels to sample in the image should be set to the total pixels in the image if the total number of pixels are less than the initial value. Sampling at uniform intervals is introduced instead of sampling random pixels to avoid resampling of same pixels. A check is added to see if the bitmap contains any useful information at all. If not we don't proceed further with the classification and don't cache the result for that particular image. Bug: 944413 Change-Id: I6e92ed1b0d33c905bc6dfa6283bdeafa306d530a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535682Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#645157}
-
Kunihiko Sakamoto authored
Now that the HTML spec change (https://github.com/whatwg/html/pull/4048) is landed, let's remove the .tentative label from the tests. Bug: 813452 Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#645156}
-
Kunihiko Sakamoto authored
This adds a new preference for controlling the availability of Signed Exchange, and wires it up to a new enterprise policy, SignedHTTPExchangeEnabled. Now signed_exchange_utils::IsSignedExchangeHandlingEnabled() takes a ResourceContext and checks the preference value via ContentBrowserClient::AllowSignedExchange(). Bug: 943000 Change-Id: If09900d25148acdafe2aaa1ab31788bcc8b76397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529504 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#645155}
-
Carlos Knippschild authored
This reverts commit 3e770ce5. Reason for revert: Generating too much logs Original change's description: > Deprecate mojo::DataPipe > > This is the first step in eliminating mojo::DataPipe. Marking it as > deprecated with a comment and a DLOG will hopefully stop it from being > used in new code. > > Bug: 944990 > Change-Id: I28d7d252a84c2c5352f6fee0fd9f9b74c81b80a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538740 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644542} TBR=rockot@google.com,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 944990 Change-Id: I18927051da3c152e2da57648dac4850d83fd18d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542675Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fd0c889d. With Chromium commits locally applied on WPT: 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I2e3654a1ea45910db2cafcc7301041b244828c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542723Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645153}
-
Luciano Pacheco authored
Bug: 946371 Change-Id: Ib313869923511e594e74fad786240906dd0bf97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538073 Commit-Queue: Stuart Langley <slangley@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#645152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c6e6d1845f7..c16f6d28a115 Created with: gclient setdep -r src-internal@c16f6d28a115 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ie006f869dc4fdc4272d49beee7899337c1fa87b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542488Reviewed-by:
-
Collin Baker authored
SeparatorView paints a separator for IconLabelBubbleView in certain cases. This moves it into its own file and loosens the coupling between the two, while trying not to change any behavior (yet). This is in preparation for moving the separator out of IconLabelBubbleView entirely. Bug: 946293 Change-Id: Ia3b7c9c51c781dc75a7bcb33064d8cf0dc8c44ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540682 Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#645150}
-
Alexei Filippov authored
This reverts commit a1099f2f. Reason for revert: A fix for WeakPtr race has been landed. Original change's description: > Revert "[heap profiler] Remove profiler start code from HeapProfilerController" > > This reverts commit 7c328879. > > Reason for revert: HeapProfilerController implementation has racey use of WeakPtr, which may result in UaF of the |task_runner_| member during teardown. See crbug.com/945208. > > Original change's description: > > [heap profiler] Remove profiler start code from HeapProfilerController > > > > The patch unifies heap profiler startup workflow. > > It is now controlled through --memlog flag set. > > > > Change-Id: I7bc51925896a1e1be6157920f20f12c9629c259a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533096 > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#643171} > > TBR=sky@chromium.org,wittman@chromium.org,alph@chromium.org > > Bug: 945208 > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I30d2463614ca8e03c0e423aeb0ee1c185a78e810 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539103 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644138} TBR=sky@chromium.org,wez@chromium.org,wittman@chromium.org,alph@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945208 Change-Id: Id6329c7ec3c3504f2820f7ecced1b2d02d98e12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542838 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#645149}
-
Vlad Tsyrklevich authored
Statically allocating arrays based on the maximum possible slot indices makes increasing the limit painful as it increases memory usage for a maximum value that we might never use (but would like to have the flexibility to use in the future.) Dynamically allocating these arrays incurs no additional memory cost for using large maximum values with smaller defaults. Bug: 939142 Change-Id: Ia8482d50504537c5b4f6e518cf71c55b5a2d04ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534386 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#645148}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffac5b50358e..51c0f388a154 git log ffac5b50358e..51c0f388a154 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@51c0f388a154 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I34ffe85e5a04b9469143aafd6b24de2fe9a97672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542487Reviewed-by:
-
chaopeng authored
In previous CL, We just skip event dispatch to not expose the event which also skip the post event dispatch process eg. KeyboardEventManager::DefaultKeyboardEventHandler. In this patch, we use SetStopPropagation to skip the event expose to web but keep post event dispatch process. Bug: 920818 Change-Id: I478159aed53c73ec76c48a3077116dd4784c1d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539295Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#645146}
-
