GitLab

Session history keeps a SiteInstance associated with each entry to ensure
that back/forward navigations and reloads can correctly load in the right
process. However, it is possible that the SiteInstance changes between
the time the navigation that caused the session history entry to be
created and the subsequent history navigation/reload. In such case, a new
session history entry should be created with replacement instead of
reusing the existing entry.

This implies that SiteInstance should never be updated on its own for a
FrameNavigationEntry, so this CL is the first step along the way. It is
removing its setter for pending entries and enforces that it is never
changed once set. The follow up will do the same for updating entries,
however it does need to change how NavigationController works, so
it will come separately.

Bug: 849430
Change-Id: Ia0a21d55d9a81bd94b06fac97de1b04ecdd95fdc
Reviewed-on: https://chromium-review.googlesource.com/1083596
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564315}

In case the renderer dies before it gets the start detection command,
the metrics recorded will be wrong. So, initialize to 0. The 0x will
still be recorded in UMA to understand how often this happens.

BUG=843419

Change-Id: If00c4cf94376fb137d78bf22dabaab379f144107
Reviewed-on: https://chromium-review.googlesource.com/1086216
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564314}

Check whether we have access to the audio data when the format is set.
At this point we have enough information to determine this. The old approach
based on when the src was changed was incorrect because at the point, we
only know the new src; none of the response headers have been read yet.

This new approach also removes the incorrect message reported in 619114.

Bug: 826552, 619114
Change-Id: I95119b3a1e399c05d0fbd2da71f87967978efff6
Reviewed-on: https://chromium-review.googlesource.com/1069540
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564313}

Bug: 847686, 796250
Change-Id: Ifc2855c5ec7c6479fdeb405a0cd7f2f3e8c8697a
Reviewed-on: https://chromium-review.googlesource.com/1086232Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564312}

  In order to roll GN 0fbf0789..84176d72 (r555198:r564007) and pick up
  the following changes:

  ce772faa Remove references to exe_and_shlib_deps in src
  8492bbe2 Fix GN bootstrap
  6b9b0c9c Remove memory peak detection code.
  d7ed1f0a Add exe_and_shlib_deps to executable and shared_library configs
  8aca6d50 Fix gn bootstrap
  524e60fb Fix typo in gn documentation
  37097a96 Remove implementation of legacy heap profiler.
  3ae94eab Reland "GN: do not make indirect dependency to direct dependency"
  3685d341 Fix gn bootstrap
  75dfa0ea GN: Handle deps always in create_bundle target
  82a5f004 Reland "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK"
  4497a44f Fix gn CHECK()ing on not_needed() when given undefined identifiers
  7ad7e759 Revert "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK"
  5a7f3c44 Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK
  fa3fcf68 Revert "GN: do not make indirect dependency to direct dependency"
  443b70db Fix GN doc formatting.
  e8a3ce91 GN: do not make indirect dependency to direct dependency
  ea15ea06 Fully move PathService into the base namespace.
  ae62ba99 GN: Make the linker output file depend on the inputs.
  629ba73c [MessageLoop] Fix message_loop.h includes

TBR=dpranke@chromium.org

Bug: 843470
Change-Id: I6cde57fde9d867da6ae9f7c8039abcdf545b0b1c
Reviewed-on: https://chromium-review.googlesource.com/1085699
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564311}

Bug: 844940
Change-Id: I714d4b403345a3d44b82f217c4e3c103f6a7142e
Reviewed-on: https://chromium-review.googlesource.com/1082713
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564310}

TL;DR - these failures are from a bug/limitation in the test, not a bug
in the code being tested.

Also, I like it when my floating-point math expertise is actually
useful.

TimeTicks.FromQPCValue uses double math to verify some integer
calculations. Unfortunately, the double calculation involves a
multiplication and a division - two roundings - which means that the
result can end up being slightly more than 1.0 away from the correct
results. I used a combination of Wolfram Alpha and a tiny C++ program
to figure out the correct result and the double-rounded result and
confirm that an error of 1.00048828125 is actually expected given the
QPC frequency on this particular machine.

Increasing epsilon a tiny bit seems like the safest and simplest fix.
The alternative would be to set epsilon to 1.0 plus the machine epsilon
at the range of expected_microseconds_since_origin but at some point
that solution becomes too complex and error prone to justify its
existence. If failures happen with the slightly increased epsilon then
we can consider something more sophisticated.

Bug: 786046
Change-Id: I8045128747d72fe5df434905afcf043139f3123c
Reviewed-on: https://chromium-review.googlesource.com/1085461
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564309}

R=jialiul

Bug: 750327
Change-Id: I688565f5b3436e9787439e0211ec0c5911a28302
Reviewed-on: https://chromium-review.googlesource.com/1086297
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564308}

The cached config takes a few thread hops to apply and in the case of
opening the browser from an intent, may not be loaded by the time the
navigation occurs. There is a quick optimization to check if the config
would apply to the navigation URL that will fail if this race is lost.

Removing this optimization should not change the result of the preview
in the case that lite page should not be applied.

Bug: 849375
Change-Id: I5fa1c08710f2e60da5e218a02d2ba3849348ed78
Reviewed-on: https://chromium-review.googlesource.com/1086108Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564307}

Trying to fix the NPE in PopupTouchHandleDrawable, mWebContents was
probably set to null in destroy(), so onDetachedFromWindow() has no
mWebContents, we still need to set handles to invisible if not already
set.

Bug: 847802
Change-Id: Id92e55205e61334ea2ba89132212012602a99343
Reviewed-on: https://chromium-review.googlesource.com/1086295Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564306}

For Crostini apps, we'd like to replace the ShelfSpinnerItemController
with a controller for Crostini apps, instead of first closing the shelf
item and then re-opening it. This allows us to avoid having a shelf
item appear and then immediately disappear when the VM is already
running and launching an app which launches quickly.

This CL makes the ShelfSpinnerItemController a ShelfModelObserver so we
can observe ShelfItemDelegateChanged and update the shelf icon one more
time so it doesn't get stuck with the last state of the spinner.

Bug: 836673
Change-Id: Id6c0aa2055e587d6462fabb3432f7c9f5d2ee8e7
Reviewed-on: https://chromium-review.googlesource.com/1065552
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564305}

Allow requesting presentation-feedback during swap time, so that a
SwapPromise can make the request for the presentation time. This is
useful for cases for paint-timing, where the client may want to execute
some code after presentation, but it also wants to execute the code if
swap did not happen.

BUG=811961
TBR=haraken@ for trivial changes in content/renderer/gpu and blink.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I03a9d72b8d022926db94f143ff9ec774618bdfd4
Reviewed-on: https://chromium-review.googlesource.com/1076324
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564304}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d86c2be0..3c891581

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7730cd089644031ab14ea2fe587cf37534ae13d5
Reviewed-on: https://chromium-review.googlesource.com/1086137Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564303}

Bug: 848086
Change-Id: Icf22bbb2f3c82bdcb6ecdadf55967401630fe5fb
Reviewed-on: https://chromium-review.googlesource.com/1085896Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Johnny Ding <jnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564302}

https://chromium.googlesource.com/catapult.git/+log/bf32270..a9d8c29


git log bf32270..a9d8c29 --date=short --no-merges --format='%ad %ae %s'
2018-06-04 sadrul@chromium.org tabs: Update the measurements.
2018-06-04 sadrul@chromium.org tabs: Fix tabs metric.


Created with:
  gclient setdep -r src/third_party/catapult@a9d8c29

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:849182,chromium:842732
TBR=sullivan@chromium.org

Change-Id: Ia0082975bc8c135e38b8183ca31a22596f2f78b0
Reviewed-on: https://chromium-review.googlesource.com/1086070Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564301}

Updated the pre-existing script that removes invalid flakes from
TestExpectations to also remove invalid failures.

Added --type flag to choose functionality. In the default case (no flag)
both flakes and failures and checked. Options for the flag are
{flake,fail,all}.

Renamed script to update_expectations to reflect new functionality.

Bug: 730704
Change-Id: Iec23363fce7a8f39413a6fe42a1134ea10c614c4
Reviewed-on: https://chromium-review.googlesource.com/863002
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564300}

Bug: 649026
Change-Id: If023ec28835f1260e0cb21f4545f41e4a4f8ff88
Reviewed-on: https://chromium-review.googlesource.com/1086029
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564299}

When a fragment is not wrapped in any element, it should be
treated as an element or text node and not an attribute value.

Change-Id: Ife39f9e66dcfe27931af0f7bffaddd9a09b9bfcc
Reviewed-on: https://chromium-review.googlesource.com/1083837
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564298}

AwFieldTrialCreator previously kept the PrefServiceFactory around for
the lifetime of the process, but deleted the resulting PrefService at
the end of DoSetUpFieldTrials(). It should be the other way around.
VariationsSeedStore keeps a raw pointer to the PrefService, so
AwFieldTrialCreator must retain the PrefService. PrefServiceFactory is
not needed after creating the PrefService; PrefServiceFactory's members
are ref-counted, so they're not lost when PrefServiceFactory is deleted.

This is a speculative fix for bug 848201; I don't have a repro to
verify.

BUG=848201

Change-Id: Ie400c54e606a83f49c1b184d74d68ed11140ba01
Reviewed-on: https://chromium-review.googlesource.com/1086210Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564297}

https://skia.googlesource.com/skia.git/+log/69d0e51..1589154


git log 69d0e51..1589154 --date=short --no-merges --format='%ad %ae %s'
2018-06-04 mtklein@chromium.org rm dead code


Created with:
  gclient setdep -r src/third_party/skia@1589154

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: Id5b7ce453a674f637180f42391ee422dbca1412d
Reviewed-on: https://chromium-review.googlesource.com/1086069Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564296}

This eases in and out the Omnibox popup opacity over 82ms as it opens
and closes. This matches the animation spec provided by UX.

Bug: 823535
Change-Id: Ic2add1f57f63ae6d043812f2bd5a766f84d302c9
Reviewed-on: https://chromium-review.googlesource.com/1081198
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564295}

When a frame updates a child frame's sandbox flags or feature policy,
the update should only take effect when the child commits a
cross-document navigation.  Same-document navigations, such as
navigating to a hash or pushState/replaceState, should not trigger the
update.

Bug: 849311
Change-Id: Ie99de2225c790f86818dfb5c5aed13d0aad6427d
Reviewed-on: https://chromium-review.googlesource.com/1085627Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564294}

Bug: 642627
Change-Id: Ifbdf6871608937abd144d56704432fc433388e12
Reviewed-on: https://chromium-review.googlesource.com/1086091Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564293}

Allows better access to the differing colorspace logic per decoder.

Bug: 827645
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idf79ce18343d84689a43308e18a44a443bae3623
Reviewed-on: https://chromium-review.googlesource.com/1070620Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564292}

This reverts commit e9753daf.

Reason for revert: Possible suspect for crbug.com/849028.  The run_container.sh script would always start the container if it wasn't running but the new code path will not work if the container is not already running.

Bug: 849028

Original change's description:
> Supports the new vsh-into-running-container syntax
> 
> It is no longer necessary to use the run_container.sh script every time a
> container shell is needed. If the container is already running, vsh now allows
> "direct access".
> 
> Bug: 848447
> Change-Id: Ia9aeb120befd016386816cdd16fb3336b45426ff
> Reviewed-on: https://chromium-review.googlesource.com/1082055
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563568}

TBR=timloh@chromium.org,smbarber@chromium.org,nverne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 848447
Change-Id: I7af784e0d73814e1aa5aae5e70ea6d45f556c71f
Reviewed-on: https://chromium-review.googlesource.com/1086071Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564291}

Bug:799734
Change-Id: I5de93ee694f00a7b3571c8254b1f05cd0d640388

TBR=charliea@chromium.org
NOTRY=true  # test by CQ

Change-Id: I5de93ee694f00a7b3571c8254b1f05cd0d640388
Reviewed-on: https://chromium-review.googlesource.com/1086281
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#564290}

This CL adds 3 missing DCHECK()s that I forgot after [1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1079834/13/media/gpu/vaapi/vaapi_picture_factory.cc#50

TBR=dcastagna@chromium.org

Bug: 717265
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibfc9797bda93dd7660cc64317ab21794dbda6e10
Reviewed-on: https://chromium-review.googlesource.com/1086131Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564289}

https://swiftshader.googlesource.com/SwiftShader.git/+log/419e8a7..57776df

BUG=chromium:847094 chromium:848238

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Ib1ad80065f888a0aab0f9a4b13143967b0ca5a57
Reviewed-on: https://chromium-review.googlesource.com/1085483
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564288}

This was used in the old cross-process transfer navigation logic,
which is no longer used with PlzNavigate.  This CL just cleans up
some dead code.

BUG=789577
TEST=No behavior change.

Change-Id: I287ba0fa2d540e52767134781bc6563bd3bf7132
Reviewed-on: https://chromium-review.googlesource.com/1082115Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564287}

Screenshot: https://imgur.com/a/FUh1E91

Bug: 754216
Change-Id: Id7f04637f85ad776e4c61b0cedf500351723342d
Reviewed-on: https://chromium-review.googlesource.com/1081677
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564286}

Also record a single trace event during mash service registration. This
is needed to get the "shortcut_viewer" category to show up in the
chrome://tracing "Record" category picker.

Bug: 849413
Change-Id: I425481a1ace677ae9c9fd5107725b44dc83e1970
Reviewed-on: https://chromium-review.googlesource.com/1085932Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564285}

This reverts commit 3e5eaae2.

Reason for revert: causes multiple bugs on Windows and breaks viz_content_browsertests on Mac FYI bots

Original change's description:
> Make Compositor::DisableSwapUntilResize work with viz
> 
> Send a sync IPC to Viz process when size is changing in order
> to prevent frame swaps of wrong size. If a wrong size frame is
> swapped then Windows might stretch our content to fill the window.
> 
> Bug: 811945
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I4960e5a349902b75522c42a9f70b6eac531fdff6
> Reviewed-on: https://chromium-review.googlesource.com/1076530
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563676}

TBR=danakj@chromium.org,rockot@chromium.org,tsepez@chromium.org,kylechar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 811945, 849283, 849169, 849155
Change-Id: Ifada5eb26caf9fb7be5a242c0fb4b97070f4df57
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1085971Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564284}

- Modify when Extensions.ExtensionUpdaterUpdateCalls is emitted to match with the old extension
  updater.
- Add Extensions.UnifiedExtensionUpdaterUpdateCalls to measure calls to the new extension updater
  only (because old extension updater is still used for certain extensions, non CWS extensions
  for example).
- Add Extensions.UnifiedExtensionUpdaterUpdateCheckErrors to investigate why the new extension
  updater has more errors in the update check stage than the old extension updater.
- Some other small changes:
  + Don't update extension with empty IDS.
  + Extensions with empty update URLs.
  + Modify unit/browser tests to verify emitted histograms.
  + Add a new browser test for update check error.

Change-Id: I82fed27c0ab1a5e9ede1b98f0d820961d471c8fd
Bug: 722942
Reviewed-on: https://chromium-review.googlesource.com/1079317Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564283}

Bug: 848957
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48eebbe4a4cf25771d64fa5ee74d8ee3af0de90a
Reviewed-on: https://chromium-review.googlesource.com/1083941Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564282}

This allows context menus in DevTools to show the native option for
search providers: 'Search [[provider]] for [[query]]'

Screenshot: https://imgur.com/a/4f8fvSh

Bug: 824886
Change-Id: Id47dae16047b5f6639db26a90bf9d8e6ed107685
Reviewed-on: https://chromium-review.googlesource.com/1083122Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564281}

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibb47e67bf4eb8d89545ad3753175a4fba6921988
Reviewed-on: https://chromium-review.googlesource.com/1081306Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564280}

Update all histogram_tester.h includes in //chromeos to include
//base/test/metrics/histogram_tester.h

TBR=stevenjb@chromium.org

Bug: 846421
Change-Id: Icb755d8b4cf00f7d85c0c6e009643a52471c2db4
Reviewed-on: https://chromium-review.googlesource.com/1086227Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564279}

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I32abca6dd348eb5e1393be7ea8be617d83d23fda
Reviewed-on: https://chromium-review.googlesource.com/1086154Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564278}

Use RenderFrameSubmissionObserver to wait for renderer frames in the
browser instead of visual state update callbacks.

R=fsamuel@chromium.org

Bug: 839861
Change-Id: I9464b07c02090c3032fa9d26ec6483e4a34c399b
Reviewed-on: https://chromium-review.googlesource.com/1081186Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564277}

Currently calculating the skipped offset between sticky and its
containing block assumes that the latter is not scrollable. However,
when it is we should ignore the scroll offset from the container
otherwise scrolling the container would cause the sticky offset
incorrectly double accumulated.

Bug: 841551
Change-Id: Ib49aaa74808847dcf6fce7dc0db9ac4d2de06c64
Reviewed-on: https://chromium-review.googlesource.com/1054488
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564276}