- 30 Dec, 2020 32 commits
-
-
Toni Barzic authored
Adds OnFileModified observer interface to FileChangeServiceObserver called when the file is written, truncated, or copied to. Fixes file change service unit tests to verify that mocked observer methods actually get called. The observers were previously not getting invoked because the test suite did not set up fake chrome user manager, so user account IDs were not correctly mapped to the associated test profile, which is something ObservableFileSystemOperationImpl depends on to get the FileChangeService to notify of file changes. BUG=1139115 Change-Id: I9829db0a496eec301a7f7547ac74f61bc1a18bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603467Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839697}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.134. R=rmhasan@google.com, tikuta@chromium.org Bug: 1041619 Change-Id: I0ea3bed89c5bbabcd56698ed47a843e1a8d39f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606526 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#839696}
-
Yi Chou authored
BUG=b:175781791 Change-Id: I3d2769f53b051cf8e9ac45582ba394627cf73217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599560 Auto-Submit: Yi Chou <yich@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yi Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#839695}
-
Andrew Grieve authored
Allows Disassemble() to work for arm32 builds when output directory is not set. Bug: 999351 Change-Id: I6da45eb0c945f0239bd455b421ed0589ee987e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606515Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#839694}
-
Emily Stark authored
This update is usually done in smaller chunks but is larger than usual this time due to some technical difficulties between rolls. Binary-Size: Size increase is unavoidable (see above). Change-Id: I479a8b597b247378b56b0d6930b62236f3bce298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605574 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839693}
-
Alex Danilo authored
Strings being removed are: IDS_FILE_BROWSER_TO_FOLDER_NAME IDS_FILE_BROWSER_MOVED_TO IDS_FILE_BROWSER_MOVED IDS_FILE_BROWSER_COPIED_TO IDS_FILE_BROWSER_COPIED Only two of the strings (IDS_FILE_BROWSER_COPIED and IDS_FILE_BROWSER_MOVED) had an associated SHA1 file for the PNG image, remove those. No change in functionality. Bug: 953308, 1093603 Change-Id: Ia73a1eafa7e13a2b58f28d7e411a0e6e23c58cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605944 Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839692}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609077635-95cc21097bbc828eec82ee3506f035af36a6f657.profdata to chrome-win32-master-1609275440-37f4e219f6f270063631f0695ad136083abdbbb6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I816f9a3f7790a13d1c9212d582fe6001bd54d11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839691}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: I79b4e8d7cae6774a8c75c9bf67e0f93ec3b55309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577114Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#839690}
-
Mustafa Emre Acer authored
Bug: 1155516c Change-Id: Iaaf0cfc9ecc6e91ea1e058f93c35b03847d44493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605590Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#839689}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609264741-3c5a3a442fc29468a5cb13e2f3f40377429cca30.profdata to chrome-linux-master-1609286132-6b2bb166adffd428e5bb2e6ce712526c0f94dd16.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I75b4e0f4073cb2da26242b19fbb95894e1d5574a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603469Reviewed-by:
-
Stephen Chenney authored
Bug: 1161590 Change-Id: I4774e7ff6842b0d3738e5d37b927b502db897ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606688 Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#839687}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609264741-782c7fdabb35af8d5bad4658593c39d1b6051717.profdata to chrome-mac-master-1609286132-e98aa58d6cc3a7d229eb36e271def84a0465b555.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14a1e27fafb054c6c80d7183d28934b923708850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603470Reviewed-by:
-
Hoch Hochkeppel authored
The existing ShowShareUIForWindowOperation did not handle the case where the Window's ShowShareUIForWindow call executed its DataRequested event synchronously AND the the provided DataRequestedCallback destroyed the ShowShareUIForWindowOperation. Updating the ShowShareUIForWindowOperation to handle this case, and updating the ShowShareUIForWindowOperationTests to expose this case by disposing of Operation instances as part of the DataRequested callbacks (mirroring the behavior of the production code that uses this class). Bug: 1162330 Change-Id: I1c85fb3e16420a9742a75b2a049588c692886e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606786 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#839685}
-
Yi Chou authored
BUG=b:175781791 Change-Id: If77a2e480689bc49074deeacaa8c054a8705a1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599559 Auto-Submit: Yi Chou <yich@google.com> Reviewed-by:
-
John Lee authored
https://imgur.com/a/cL5kX12 Bug: 961480 Change-Id: I85fe65ee593b76014a2ddc3c1647bca9d5b6c2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606624Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839683}
-
shivanigithub authored
This CL adds the code to enable experimentation of different cache sizes. Now that cache will be partitioned, it makes sense to see if increasing the cache size helps offset some performance impact by lowering the eviction rate. The CL brings back similar logic as was removed using https://chromium-review.googlesource.com/c/chromium/src/+/1944285 Bug: 1160690 Change-Id: Ia774a8788caeb693a36b49050289161cd6843b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589117 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839682}
-
Chris Lu authored
Add a feature flag to encapsulate logic that will persist the crash restore infobar across navigations. Bug: 1162312 Change-Id: I70c00d3ebe8d382c4406286da18a49b608c6744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606625 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#839681}
-
Sophie Chang authored
Maybe this will help fix the download manager test flakes Bug: 1156112 Change-Id: Ice1add6879733c53eff58d932d177e63be3505d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606718Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b185d5bb82fb..ce202c065f97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: Ie3b5d125b9d691f9e062248682eb6b51b9551e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839679}
-
Sophie Chang authored
Doing it this way to get more correct metrics around coverage and to verify against server metrics for when this reactive prefetch can trigger TBR=jwd@chromium.org Change-Id: Ie8dc14673ea905c5a51e6fc130857e5255840da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599445 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#839678}
-
Stefan Zager authored
CompositingRequirementsUpdater is responsible for setting PaintLayerCompositor::compositing_, while GraphicsLayerTreeBuilder is responsible for attaching PaintLayerCompositor::RootGraphicsLayer() into the layer tree of its embedding document. The current code uses slightly different logic in those two places to determine whether an iframe is compositing, which may lead to inconsistent state when an iframe is throttled. This CL make them use the same logic. Bug: 1133662 Change-Id: I13276c0b0fb25921936d5319d4d983d720595557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606654 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839677}
-
Noel Gordon authored
Move the DriveSyncHandler fake definition after the VolumeManager fake and all the volume-related fakes. Bug: 1113981 Change-Id: Id0999b986230ae32d55baac07a8babaff45dcfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604785Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839676}
-
Austin Sullivan authored
Bug: N/A Change-Id: I08d9bb1facccd82648389453ea88067e7e1786d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601577 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#839675}
-
Takumi Fujimoto authored
Bug: 1160947 Change-Id: Iecc70cc8de059979bef787512b6bd3d2196d9890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600263 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
Hui Yingst authored
Bug: 1162346 Change-Id: Ifb876edf670d0346d3b38469349bd0d80028671c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602847Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839673}
-
Lukasz Anforowicz authored
Before this CL, in presence of AllowNonStandardSchemesForAndroidWebView, there would be an inconsistency between origins calculated for about:blank URL by Blink and //url: - The assertions added by this CL to SecurityOriginTest, NonStandardSchemeWithAndroidWebViewHack would pass before and after this CL (always returning an opaque, unique origin for "about:blank" URL). - The assertions added by this CL to OriginTest, NonStandardSchemeWithAndroidWebViewHack would fail before this CL (returning "about://" origin for "about:blank" URL) and pass after this CL. Before and after this CL, Blink would use an opaque origin because ShouldTreatAsOpaqueOrigin in Blink's security_origin.cc would match "about" in SchemeRegistry::ShouldTreatURLSchemeAsNoAccess. This CL makes sure that IsValidInput in //url's scheme_host_port.cc also takes no-access schemes into account. Making sure that Blink and //url origins are consistent is a step toward being able to calculate the origin to commit on the browser-side. Without this CL, Android WebView tests (e.g. ...android_webview.test.LoadDataWithBaseUrlTest#testNullBaseUrl) would fail in the follow-up CL here: https://crrev.com/c/2581008/13 Change-Id: Ic302abb8f61b16bacdcd5dc15f33718f94c106c9 Bug: 888079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601844 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#839672}
-
Noel Gordon authored
Remove definition of addEventListener() and retain the definition that takes arguments addEventListener(type, name). Bug: 1113981 Change-Id: Ibf97bf6a7cef740a58ad96e2823c39150f2b7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606405 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Mila Green authored
Bug: 1144151 Change-Id: I4890a1cfb7a02b038683620418e6032e907b6561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601281 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839670}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifeecc1b42d57c2a2643ff87ff47d39301e25983a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606710Reviewed-by:
-
Bruce Dawson authored
Anti-virus programs and other scanners may briefly lock new files which can lead to frequent problems with saving bookmarks and other files that use the ImportantFileWriter. This attempts to deal with this by retrying the racy ReplaceFile step a few times. This change also adds instrumentation to record how many retries are needed, for future tuning. It also moves the SetLastError call as close as possible to the function that will consume the last error code. This is only done on Windows because that is hoped to be the only place where it happens. Bug: 1099284 Change-Id: I7aa9a27e137d3df2c402de5f13bbe911521a711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559156Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#839668}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f81d75f9eee..b185d5bb82fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: I489e6d765f9125b2961d2d140fd3322908c41d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606804Reviewed-by:
-
Chris Mumford authored
Make IndexedDBContextImpl::data_path_ a constant member as it is never changed. Doing so makes it easier to reason about safe access on different sequences. set_data_path_for_testing() existed, and was used by IndexedDBQuotaClientTest, but was only ever set to the same path passed to the IndexedDBContextImpl constructor. Also make IndexedDBContextImpl::data_path() return a const reference to avoid unnecessary creation of intermediate base::FilePath instances. Bug: none Change-Id: If7c5a960c30dd7d4858fd332437548d7363247d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606651Reviewed-by:
-
- 29 Dec, 2020 8 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0eb61724c8f1..9a38e5b60dcc 2020-12-29 enga@chromium.org Make HLSL cache key guard comment ASSERT more specific If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ie51c8dadcf6b78bf5887689d34e3b32531fbfb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606766Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I82ee74c4d68eb5b7c6b33933a5a256cb578c93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606705Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5dd3d7ff936b644ad2eb1345ba1e4ffe785fe220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606712Reviewed-by:
-
Hui Yingst authored
[iOS]Re-enable [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] for iPad testing. [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] is only flaky on iPad. This CL re-enable this test for iPhone. Bug: 1162301 Change-Id: I8b53271babcca2b561ecf9b8169eaa3b83dc18b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606626 Commit-Queue: Hui Yingst <nigi@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#839662}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie5eb6d9e312cb37190ebdf28540558e1cc546dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606348Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839661}
-
Dylan Cutler authored
This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Make CanonicalCookie's constructor private. Bug: 1102874 Change-Id: I124942d0aea21cc26a9ee36f35032bde3cb6fba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595450Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#839660}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I37d9caff3d8fee1d226419441068d0a227ec26f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606686Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839659}
-
Toni Barzic authored
The goal is to avoid excessive image load requests if the backing file gets modified multiple times in quick succession. BUG=1139115 Change-Id: I5ecf0171d28c5c2882f660039a6923e0951ed68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606383Reviewed-by:
-
