- 22 Jan, 2020 40 commits
-
-
Boris Sazonov authored
This CL fixes ForcedSigninProcessor by marking the sync flow as completed after a forced sign-in. Bug: b/146775602 Change-Id: I5ea64edb79a975ff37ec5d19650534b5ac8c2cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013100Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734026}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a1aaa1a..3ff3368a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I88c64605be0d2924b0059a80899d21369cb27dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014780Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734025}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mathp@chromium.org Bug: 1042208 Change-Id: I572b636065ae19af26ff57ec90a98a002a5eb381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010767Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734024}
-
Francois Doray authored
Fixed: 1037321 Bug: 1037321 Change-Id: I2291c0dd3908a095d68a74751a395a5590c0147f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003211 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#734023}
-
Anton Bikineev authored
Members in stack allocated types issue redundant write-barriers. This CL provides an option --no-members-in-gc-allocated, which prohibits use of them. Bug: 1044611 Change-Id: Icc83756d9a1d6e414a09b705c0f008f9e79c4ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010986 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734022}
-
Mike Dougherty authored
CIPD packages: infra_internal/ios/xcode/mac 11c29 infra_internal/ios/xcode/ios 11c29 Bug: 1041618 Change-Id: I1cdbb3e33e21dc69307a535d63caeae109042951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999545 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734021}
-
Vasiliy Telezhnikov authored
This CL alters viz for WebView BeginFrame handling to use the same path as without viz. It also implements viz side View.Invalidation heuristics. Bug: 805739 Change-Id: I8bb1dd2879f50cdfff0df3a6f75b81e3785a2737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001120 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734020}
-
Charlie Hu authored
According to crbug.com/1043557, we should use blink::mojom::blink::T or mojom::blink::T in Blink over blink::mojom::T. This CL replaces all mojom::FeaturePolicyFeature with mojom: :blink::FeaturePolicyFeature and all mojom::PolicyValueType with mojom: :blink::PolicyValueType. Change-Id: I177c6186a1cd14578dd5dfffbf98a1fc7f221247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011171Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#734019}
-
Rohit Rao authored
BUG=None Change-Id: I5973080c15ffaa50b01a08cc271950e935ba8fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014102Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734018}
-
Mathias Bynens authored
Per the JSON specification base::JSONParser aims to follow [1] (as well as JSON specifications that supersede it, such as [2]), JSON can encode Unicode non-characters. This patch adds support for such characters to base::JSONParser so that they can safely be transmitted via the Chrome DevTools Protocol. Thus, this patch removes the need for workarounds like [3] that were only needed due to lack of support. For symmetry, support for non-characters is added to base::JSONWriter as well. Note that although base::JSONParser and base::JSONWriter now support Unicode non-characters, invalid code points (i.e. lone surrogates) remain unsupported. Note that this change impacts JsonSanitizer as well: previously, if its input contains a non-character, JsonSanitizer would produce an error. Now, JsonSanitizer successfully generates sanitized JSON in this case, and as always, this sanitized JSON parses to the same exact value as the original JSON. Tests: autoninja -C out/Release content_shell base base_unittests services services_unittests out/Release/base_unittests --gtest_filter=JSONParserTest.*:JSONReaderTest.*:JSONStringEscapeTest.*:StringUtilTest.IsStringUTF8 out/Release/services_unittests --gtest_filter=DataDecoderJsonSanitizerTest.Unicode third_party/blink/tools/run_web_tests.py -t Release http/tests/devtools/runtime/runtime-evaluate-bad-unicode.js autoninja -C out/Android services services_unittests out/Android/services_unittests --gtest_filter=DataDecoderJsonSanitizerTest.Unicode [1]: https://tools.ietf.org/html/rfc4627#section-2.5 [2]: https://ecma-international.org/publications/standards/Ecma-404.htm [3]: https://chromium-review.googlesource.com/c/1352588 Bug: chromium:848823, chromium:1042269 Change-Id: Ib949425939517d85f1545da9d215dd2d137cedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002813 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#734017}
-
Sebastien Lalancette authored
RenderFrameHostImplBeforeUnloadBrowserTest .SubframeShowsDialogWhenMainFrameNavigates See bug for details. TBR=kenrb@chromium.org Bug: 1044599 Change-Id: I3435c831f2bd35347f5caa51f14f168513a004ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014174Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734016}
-
Ian Kilpatrick authored
As above - followup from: https://chromium-review.googlesource.com/c/chromium/src/+/2012161 Bug: 845235 Change-Id: I48021b5a42b34500393594e7739a89289e9d8ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014447 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#734015}
-
Nico Weber authored
This reverts commit 0c31aad8. Reason for revert: Somewhat speculative; looks like it made the build nondeterministic (https://crbug.com/1038775) Original change's description: > Refactoring origin trial dependency generation in feature_policy_helper.cc > > This CL refactors build script code that generates feature_policy_helper.cc, > so that the logic could be reused for document policy. > > - Simplifies make_runtime_features_utilities.py API. > - Makes most util functions pure. > - Adds more unittests > > The output of make_feature_policy_helper is verified to be the same as before. > > Bug: 993790 > Change-Id: I0f0e07888f5b9e02727e3f210bbfb4cd871ecc15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003255 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Charlie Hu <chenleihu@google.com> > Cr-Commit-Position: refs/heads/master@{#733063} TBR=iclelland@chromium.org,chenleihu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993790 Change-Id: If7aaa4c6b851f74db6b418b480cf8482b15cf7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013472Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#734014}
-
Jonathan Ross authored
This reverts commit 6474322c. Reason for revert: The tests demonstrate flaky failures after being re-enabled: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/7441 Original change's description: > Re-enable some vulkan_content_browsertests > > Some of the bugs on Android's vulkan_content_browsertests have been fixed > so we will re-enable them. > > TBR=backer@chromium.org > TEST=vulkan_content_browsertests > Bug: 1037939, 1043934 > > Change-Id: I43f0890fb13fdf1abbbd89ce267ca9e40933b8c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008362 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733618} TBR=backer@chromium.org,jonross@chromium.org Change-Id: I461253501b3b1421713097cb5d581912174f5500 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1037939, 1043934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013471Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#734013}
-
Ryan Hamilton authored
quic_utils_chromium.{h,cc} This was suggested on https://chromium-review.googlesource.com/c/chromium/src/+/2005825 but autosubmit landed the CL before it could be addressed. Change-Id: Iebd6fee046714db75ee3a6a47443e60e63ced120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013201 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#734012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10a452110979..ba5dc20d6d6f git log 10a452110979..ba5dc20d6d6f --date=short --first-parent --format='%ad %ae %s' 2020-01-22 tvanderlippe@chromium.org Migrate worker_main/ to ESM internally 2020-01-22 aerotwist@chromium.org Migrates timeline/ to ESM internally 2020-01-22 tvanderlippe@chromium.org Migrate host/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@ba5dc20d6d6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8e16ef1a1f20fa9319b91f155c5a83a383196a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734011}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/402379f1f35c..6ce033a863ac git log 402379f1f35c..6ce033a863ac --date=short --first-parent --format='%ad %ae %s' 2020-01-22 srte@webrtc.org Moves ownership of time controller into NetworkEmulationManager. Created with: gclient setdep -r src/third_party/webrtc@6ce033a863ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ife33f069290cf2cb57acb1b9ec6f64def43262bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014667Reviewed-by:
-
Mike Reed authored
Note: SkCanvas now stores a 4x4 internally in its matrix stack... Change-Id: I13ea2702b764d46a11821344dabcef58b58909ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008085Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#734009}
-
Dominik Röttsches authored
Match Skia in not creating buffer-based fonts through CGFonts and CTFontCreateWithGraphicsFont any more, but instead use CTFontManagerCreateFontDescriptorFromData. This enables cleanup in Skia removing the CGFont parameter from SkCreateTypefaceFromCTFont, after Skia moved to using CTFontManagerCreateFontDescriptorFromData in [1]. [1] https://skia-review.googlesource.com/c/skia/+/257052 Bug: 1033478 Change-Id: I4048b683659e40eead9939697c4900a935623627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964073 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#734008}
-
Dave Tapuska authored
Change-Id: If8f9eb4c780d9dabc486315b9593c62ea34edd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013260Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734007}
-
Ilja H. Friedel authored
The flag is used for tast video/media testing to mock a stream source. BUG=chromium:1043402 TEST=None. Change-Id: Ib8eaaeb1106afb917b41d8104dd0ad80eac0c3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007877 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Ilja H. Friedel <ihf@chromium.org> Cr-Commit-Position: refs/heads/master@{#734006}
-
Colin Blundell authored
This pref is used by CaptivePortalService, which we are in the process of componentizing. As it controls various aspects of Chrome beyond just the usage of the CaptivePortalService, we place it in //components/embedder_support rather than //components/captive_portal. Bug: 1030692 Change-Id: I69aa83aa26250ced18175375488c3621f46caa58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010962Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#734005}
-
Vasiliy Telezhnikov authored
There are situations when viz::Display::DrawAndSwap will Draw but will skip Swap (when resize is happening and we have CopyOutput requests). For this frame presentation callback will not be called. This CL moves creation of PresentationGroupTiming for frame only if |should_swap| is true to avoid waiting for presentation that will never happen. Fixed: 1042938 Change-Id: I508679b2e5c7d2dceeba3c915479db7617d432ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008354 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#734004}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 1042208 Change-Id: I80b1b804c9c2f9938fd2f3fb3051623871cb0253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010821 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52524c03db2f..de885c91d53b Created with: gclient setdep -r src-internal@de885c91d53b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5d22d0e80442655f4ffef704ca1c425e9f48c94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734002}
-
Benjamin Beaudry authored
Before this change, focused gridcell were perceived as selected by ATs. This is because we assumed that a focused gridcell was also selected, but that can't be the case. Gridcells are mentioned here, but all ARIA grid roles and treeitem were affected by this misinterpretation of the specs. According to ARIA 1.0 and above, all ARIA grid cells, rows and columns are selectable, but not necessarily selected. We can't assume a relationship between the focused state and the selected state as they are completely independent. We can only do so when the aria-selected attribute is implied or required. To the best of my knowledge, it only is implied and/or required for: - ax::mojom::Role::kListBoxOption: - ax::mojom::Role::kMenuListOption: - ax::mojom::Role::kTab: This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). This method was implemented following the ARIA specs, so that only the elements with an implied and/or required aria-selected attribute value are also marked as selected when focused. Bug: 1030378 Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e5fb5497abf6..0a5ac419555b git log e5fb5497abf6..0a5ac419555b --date=short --first-parent --format='%ad %ae %s' 2020-01-22 nuskos@google.com Merge "Add is_nacl gn arg and prevent nacl from building ipc layer." 2020-01-22 lalitm@google.com Merge "tp: add benchmark for SetBitsIterator and test more bv fill %" 2020-01-22 lalitm@google.com Merge "Revert "Stack profiling: Don't attempt hex conversion on Breakpad build_ids"" 2020-01-22 lalitm@google.com Merge "trace_processor: fix mm ids in rss stat during vfork" 2020-01-22 fmayer@google.com Teach experimental_flamegraph to build native flamegraphs. 2020-01-22 fmayer@google.com Merge "Rate limit map reparsing." 2020-01-21 oysteine@google.com Stack profiling: Don't attempt hex conversion on Breakpad build_ids 2020-01-21 treehugger-gerrit@google.com Merge "logging: don't print negative numbers" 2020-01-21 treehugger-gerrit@google.com Merge "perfetto-ui: Fix thread state" 2020-01-21 treehugger-gerrit@google.com Merge "Define HWUI rendering metrics" 2020-01-21 nuskos@google.com Address comments we had offline. 2020-01-21 taylori@google.com Merge "perfetto-ui: Add panning hint" 2020-01-21 dproy@google.com Merge "Add custom field option annotations to json output" 2020-01-21 primiano@google.com Merge "Add /proc/kallsyms parsing" 2020-01-21 nuskos@google.com Update libperfetto to directly dep on the ipc target on posix systems. Created with: gclient setdep -r src/third_party/perfetto@0a5ac419555b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1041605 Tbr: perfetto-bugs@google.com Change-Id: I60c0911e5a6d2e5c897b5b742aba779f11e029f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014666Reviewed-by:
-
Hirokazu Honda authored
After crrev.com/c/1994849, a renderer process queries GPU process HW encoder capabilities when the renderer process is created. To get hw encoder capabilities, it is needed to open driver nodes and query them. The time is small but may not be small enough to ignore. This CL caches hw encoder capabilities so that GPU process only needs to query one time. The exception is V4L2 HW encoder. Since V4L2 driver nodes may not be loaded at the early time of a system boot up, we need to query it until the capabilities are detected. Bug: b:147404923 Bug: 948147 Test: HW encoder is used at appr.tc Test: tast run webrtc.* on krane Change-Id: Iba256bfda861adb75a5454eb011244cb193618d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994038 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733999}
-
Fergal Daly authored
This will only trigger once I land https://crrev.com/c/2006890 but we have no repro steps https://crbug.com/1014212 and are depending on crash reports. Check that: - the RFH pointer is always replaced by a non-null pointer - RFHI.frame_ is valid after we declare the RenderFrame to have been created - RFHI.frame_ remains valid after all calls to SetUpMojoIfNeeded Bug: 981339,1014212 Change-Id: Iab311832be80dcbe1a1ff431af551cdb3a3d645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010511 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#733998}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/80880ee99854..6b66b67f69e2 git log 80880ee99854..6b66b67f69e2 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Fix compilation of Log2(uint64_t) on MSVC Created with: gclient setdep -r src/third_party/dawn@6b66b67f69e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I399ef679a8a34174a63d9970e7040d3207580b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014663Reviewed-by:
-
Tim Van Patten authored
The test conformance/renderbuffers/depth-renderbuffer-initialization.html is flaky on AMD GPU on Windows: https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3210 https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3155 https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3113 This CL will suppress that test while the issue is investigated. Bug: 1043773 Tbr: ynovikov@chromium.org Change-Id: If8b39ea44d0b6c9a78f790c57d2f7897547b7768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013263 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#733996}
-
Olga Sharonova authored
This reverts commit b23ba4d3. Reason for revert: Speculative revert for multiple failures in https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2057 Original change's description: > Ice Server API integration > > Integrates network traversal API to fetch stun and turn servers for > webrtc p2p connection. Handles API failure by returning a list of > public Google stun servers as a fallback. > > Bug: 1031156 > Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733941} TBR=droger@chromium.org,msramek@chromium.org,knollr@chromium.org,himanshujaju@chromium.org,ajgo@chromium.org Change-Id: I62270288afa5716c4dfb5fa6c35df2cfe0a82d79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013288Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#733995}
-
Yann Dago authored
When navigating back from IE to Chrome using LBS, the latest Chrome installation was opened, unless the admin specified a Chrome path to use. By writing the chrome path of the browser that initiated the IE navigation cache.dat, the chrome instance was used last will be the one we back to. Bug: 1005849 Change-Id: Iad4c4d601eedcc8cd7d9bee6f0f90143352f96fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004949 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#733994}
-
Paul Jensen authored
Since Android P, ConnectivityManager's NetworkCallback signals (which NetworkChangeNotifierAutoDetect listens to) include changes to VPNs so Chrome doesn't need to use AddressTrackerLinux to detect VPNs coming and going. Avoiding it should speed up initialization and decrease memory usage. This change disables all of NetworkChangeNotifierAndroid's BlockingThreadObjects for Android P+ as it only contains an AddressTrackerLinux instantiation. Change-Id: Ic64f0360d78ee9d75e3f7e5a46ac7e57ccc2dd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007525 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Olga Sharonova authored
TBR=seblalancette@chromium.org Bug: 1044568 Change-Id: Ieec8a5cf947733a75be3167dcef69e457f033b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013051Reviewed-by:
-
Colin Blundell authored
This CL transforms CaptivePortalService's dependence on Profile to instead be a dependence on BrowserContext as a step in enabling the componentization of CaptivePortalService. The transformation is straightforward. Bug: 1030692 Change-Id: If23ff0b104b695a66bff4d5d99261c9cebd756e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007725Reviewed-by:
-
Nicolás Peña Moreno authored
We're currently still implementing changes in the LargestContentfulPaint metric, so it's good to keep ContentType metrics around to help debug metric changes. This CL extends the expiry by 6 months. Bug: 1037182 Change-Id: I0887fef67a587b27e5c9b0849e6bd26a28ef3d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013922 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733990}
-
Jit Yao Yap authored
The |ResultCatcher| and |ExtensionTestMessageListener| are possibly not ready before the login screen extension is re-enabled when the screen locks. This results in a race condition. This CL fixes the race by using 2 separate listeners which are initialised before the call to the lock. Bug: 1044280 Change-Id: I221f3f70e4eef02df3f13bd5c9c8cda24f132a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012952Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#733989}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1eb0ddb4d0c3..ed94ccdde306 git log 1eb0ddb4d0c3..ed94ccdde306 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 11cb891a01a2..b766e5e7fbf4 (1 commits) Created with: gclient setdep -r src/third_party/angle@ed94ccdde306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I99fc2ebc18e9030ae06f2bd67c8c271d7672bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014661Reviewed-by:
-
Stepan Khapugin authored
Remove the ability to hide OmniboxContainerView's leading image, since it's always shown in HL. Cleanup the implementation to not have that option anymore. Bug: 945334 Change-Id: I39107d51c69e861251f0fd2e2111542c1c075d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007411 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#733987}
-
