GitLab

Skips it during accessibility treatment.

BUG=326793

Review URL: https://codereview.chromium.org/569613003

Cr-Commit-Position: refs/heads/master@{#294659}

This is causing a compile failure in component mode.

TBR=dpranke

Review URL: https://codereview.chromium.org/566023003

Cr-Commit-Position: refs/heads/master@{#294658}

Use are brand-spanking-new options dictionary to be able to configure
the target and max burst size for the pacer. This should allow us to do
some basic experiments to determine if pacing is really helpful and what
the optimal batch size actually is.

Review URL: https://codereview.chromium.org/567853002

Cr-Commit-Position: refs/heads/master@{#294657}

BUG=397741

Review URL: https://codereview.chromium.org/565213005

Cr-Commit-Position: refs/heads/master@{#294656}

After a bunch of testing, it seems like there is a direct linear
relationship between RTT and the optimal playout delay. Packet loss
is also a factor, but since we expect packet loss to be low in
normal networks, perhaps we can make the formula as easy as RTT * 4.

This is disabled by default, the extension needs to set min_latency_ms
in order to activate it.

BUG=405339

Review URL: https://codereview.chromium.org/562653004

Cr-Commit-Position: refs/heads/master@{#294655}

BUG=409897
R=rsesek, DaleCurtis

Review URL: https://codereview.chromium.org/531863002

Cr-Commit-Position: refs/heads/master@{#294654}

Previously TransportFactory interface was responsible for creation
and initialization of several protocol layers, including PseudoTCP and
authentication (TLS). Simplified it so now it only creates raw datagram
transport channel. PseudoTcpChannelFactory is now responsible for
setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
of channel authentication. Also added DatagramChannelFactory for
Datagram channels.

This change will make it possible to replace PseudoTcpChannelFactory
with an object that creates SCTP-based channels.

Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
properly when deleted from the callback. (base::Callback objects
shouldn't be deleted while being called because when deleted they
also destroy reference parameters values they are holding).

BUG=402993

Review URL: https://codereview.chromium.org/551173004

Cr-Commit-Position: refs/heads/master@{#294653}

BUG=399643

Review URL: https://codereview.chromium.org/565963002

Cr-Commit-Position: refs/heads/master@{#294652}

BUG=413637

Review URL: https://codereview.chromium.org/564173002

Cr-Commit-Position: refs/heads/master@{#294651}

See also https://trac.xiph.org/ticket/2048

BUG=355440

Review URL: https://codereview.chromium.org/570443002

Cr-Commit-Position: refs/heads/master@{#294650}

Chrome was modified back in May 2014 to use SCM_CREDENTIALS instead of
--find-inode-switch and we haven't any heard any negative feedback, so
it's time to remove --find-inode-switch entirely.

BUG=357670

Review URL: https://codereview.chromium.org/569533002

Cr-Commit-Position: refs/heads/master@{#294649}

After changes that made Embed() always create a new connection this
test is now redundant with EmbedWithSameViewId*. Additionally it
wasn't properly waiting, leading to use after frees.

BUG=none
TEST=covered by tests
R=aa@chromium.org

Review URL: https://codereview.chromium.org/566463003

Cr-Commit-Position: refs/heads/master@{#294648}

BUG=355572

Review URL: https://codereview.chromium.org/562373002

Cr-Commit-Position: refs/heads/master@{#294647}

TBR=miguelg@chromium.org

Review URL: https://codereview.chromium.org/569483002

Cr-Commit-Position: refs/heads/master@{#294646}

Followup to CL 485833002, which mixed use of the OVERRIDE macro and
bare override.

BUG=400336

Review URL: https://codereview.chromium.org/562353004

Cr-Commit-Position: refs/heads/master@{#294645}

BUG=none
R=fgorski@chromium.org
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/566933004

Cr-Commit-Position: refs/heads/master@{#294644}

TBR=dsinclair, nduca

Review URL: https://codereview.chromium.org/540293003

Cr-Commit-Position: refs/heads/master@{#294643}

The W3C test suites are now being imported directly into Blink
(checked in under LayoutTests/imported). We no longer need to
pull in the repos via DEPS or have a separate expectations file.

This is patchset 4 of 4 and completes the cutover.

TBR=eseidel@chromium.org
BUG=413467

Review URL: https://codereview.chromium.org/557733003

Cr-Commit-Position: refs/heads/master@{#294642}

Instead of putting all the files in a bit test_support target, I made separate smaller test support targets for the various sub-projects (browser, common, etc.) and linked those in. This helps distribute the complexity.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/559543003

Cr-Commit-Position: refs/heads/master@{#294641}

Revert of Convert device::UsbConfigDescriptor and friends to structs. (patchset #2 id:60001 of https://codereview.chromium.org/562763002/)

Reason for revert:
This broken the Linux ASan LSan Tests:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717

Sample callstacks:

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    #5 0xb38aebf in Run base/bind_internal.h:288:12
    #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927
    #7 0x2d58bff in Run base/callback.h:401:12
    #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
    #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
    #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
    #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
    #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
    #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3
    #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14
    #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
    #19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Direct leak of 400 byte(s) in 10 object(s) allocated from:
    #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb)
    #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45
    #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7
    #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9
    #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42
    #5 0xb38aebf in Run base/bind_internal.h:288:12
    #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927
    #7 0x2d58bff in Run base/callback.h:401:12
    #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
    #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
    #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
    #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
    #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
    #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3
    #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
    #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3
    #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14
    #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
    #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
    #19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Original issue's description:
> Convert device::UsbConfigDescriptor and friends to structs.
>
> These classes do not need to be classes and expecially don't need to be
> abstract classes as this leads to a complicated implementation and
> complicated tests. All USB devices no matter the platform will have the
> same descriptor data.
>
> This change follows the model of device::HidDeviceInfo.
>
> BUG=
>
> Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5
> Cr-Commit-Position: refs/heads/master@{#294594}

TBR=dgozman@chromium.org,rockot@chromium.org,rpaquay@chromium.org,pfeldman@chromium.org,reillyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/567003002

Cr-Commit-Position: refs/heads/master@{#294640}

This pulls in the following Native Client changes:

r13734: (dyen) Added support for extending basic thread functions in irt_ext.
r13735: (dyen) Added testing for file link operations in irt_ext tests.
r13738: (dschuff) Override xcode architecture for ia32 standalone builds
r13739: (hidehiko) Non-SFI mode: Add -malign-double flag to pnacl-translate.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/569683002

Cr-Commit-Position: refs/heads/master@{#294639}

Also format text to match Adobe Reader.

BUG=307523
TEST=Manual, see bug (and duplicates for more examples)

Review URL: https://codereview.chromium.org/566773005

Cr-Commit-Position: refs/heads/master@{#294638}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/567923002

Cr-Commit-Position: refs/heads/master@{#294637}

This accidentally changed during the large fullscreen refactor. The method
enterPresentationModeForURL:* was previously used to enter both immersive
fullscreen and AppKit Fullscreen. Now it is only used to enter AppKit
Fullscreen.

BUG=406656

Review URL: https://codereview.chromium.org/565803004

Cr-Commit-Position: refs/heads/master@{#294636}

BUG=none
TBR=chirantan,xiyuan
NOTRY=true

Review URL: https://codereview.chromium.org/568853002

Cr-Commit-Position: refs/heads/master@{#294635}

We reuse SetupWindowEnvironment from the nacl build, in the sdk build.
To do this we inject a fake build context.
Previously windows in particular just needed an empty mutable context.
Now it assumes gyp_vars is set to a list of some kind.
Initializing 'gyp_vars' to unblock a deps roll.

BUG=None
TEST=trybots
R=binji@chromium.org

Review URL: https://codereview.chromium.org/566963002

Cr-Commit-Position: refs/heads/master@{#294634}

Previously it was running only on Windows, but due to migration to Aura,
we should be running it on Linux as well.

This makes the necessary changes to get it running on Linux.

BUG=None
TEST=unit_tests --gtest_filter=BookmarkEditor*
R=sky@chromium.org

Review URL: https://codereview.chromium.org/565143002

Cr-Commit-Position: refs/heads/master@{#294633}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/555163004

Cr-Commit-Position: refs/heads/master@{#294632}

In preparation for moving webrequest_action, webrequest_rules_registry,
we need to move this dependency.

BUG=352293

Review URL: https://codereview.chromium.org/565273002

Cr-Commit-Position: refs/heads/master@{#294631}

Revert of Gardening: Revert "Use AudioStreamMonitor to control power save blocking." (patchset #1 id:1 of https://codereview.chromium.org/562863002/)

Reason for revert:
Bugs should be fixed now... will CQ this revert.

Original issue's description:
> Gardening: Revert "Use AudioStreamMonitor to control power save blocking."
>
> This reverts commit 484d29dc.
>
> This patch made media/media-controller-playbackrate.html test crash on DEBUG.
>
> it crashes at content/browser/web_contents/web_contents_impl.cc:4296 on DCHECK
> Looks like AddMediaPlayerEntry was called twice for the same player_cookie
>
> It is not clear how it happens due to async nature of the notification.
> The author is sleeping at the moment, so I decided to roll back the patch.
>
> BUG=
> TBR=dalecurtis@chromium.org
>
> Committed: https://crrev.com/0381a74131887eb13b5d457cce756fb7066411ea
> Cr-Commit-Position: refs/heads/master@{#294370}

TBR=loislo@chromium.org,jam@chromium.org,miu@chromium.org,scherkus@chromium.org
BUG=43667, 367785

Review URL: https://codereview.chromium.org/569713002

Cr-Commit-Position: refs/heads/master@{#294630}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/563553005

Cr-Commit-Position: refs/heads/master@{#294629}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/561903002

Cr-Commit-Position: refs/heads/master@{#294628}

They don't need to run in Chrome's unit_tests suite any more.

The tests that depend on Chrome's version channel information move to
ChromeChannelFeatureFilterTest.

BUG=413319,397165
TEST=unit_tests ChromeChannelFeatureFilterTest.* and extensions_unittests

Review URL: https://codereview.chromium.org/563923004

Cr-Commit-Position: refs/heads/master@{#294627}

BUG=412875
TEST=WindowEventDispatcherTest.GestureEventCoordinates

Review URL: https://codereview.chromium.org/564923003

Cr-Commit-Position: refs/heads/master@{#294626}

Fixes windows component error since we use SkMatrix in DrawViewTree.

BUG=413727

Review URL: https://codereview.chromium.org/566933003

Cr-Commit-Position: refs/heads/master@{#294625}

The change decouples input device hotplug event processing from output device
hotplug processing. In addition, for input device event processing, it takes
advantage of the X11 caches in ui/events and simplifies how hotplug events are
propagated to the system.

Depends on https://codereview.chromium.org/508303002/

BUG=381326

Review URL: https://codereview.chromium.org/336863002

Cr-Commit-Position: refs/heads/master@{#294624}

Extension actions that are dragged out of the overflow menu should not force
another inside; rather they should "pop out" and cause the container to grow.
Analogously, actions dragged in should reduce the size of the container.

BUG=411394

Review URL: https://codereview.chromium.org/550313002

Cr-Commit-Position: refs/heads/master@{#294623}

TBR=loislo
BUG=

Review URL: https://codereview.chromium.org/563273002

Cr-Commit-Position: refs/heads/master@{#294622}

BUG=403645

Review URL: https://codereview.chromium.org/467263006

Cr-Commit-Position: refs/heads/master@{#294621}

This CL removes most usages of the guava library.

TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org
BUG=412673

Review URL: https://codereview.chromium.org/565743002

Cr-Commit-Position: refs/heads/master@{#294620}