- 12 Mar, 2020 40 commits
-
-
David Benjamin authored
Bug: 1048878 Change-Id: I02eb5d713deb4ebffb8066a5a3bddcc6a4c661ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098742Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#749524}
-
Livvie Lin authored
This feature param is no longer needed since the top sites based interstitial is fully launched. Bug: 1060247 Change-Id: I3599310225015a19f62017331bbd1f3361a99e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097331 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#749523}
-
Chih-Yu Huang authored
This CL adds a parameter "--use_vd_vda" to the video_decode_accelerator_tests and video_decode_accelerator_perf_tests to support VD-based VDA using VdVDA. Bug: b:136716838 Test: video_decode_accelerator_tests --use_vd_vda on Kevin and Eve Test: video_decode_accelerator_perf_tests --use_vd_vda on Kevin and Eve Change-Id: Ib515f97cef66412a3ff833686148d846148d6109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928519Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749522}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/21996bda4c52..276dc290d7ce git log 21996bda4c52..276dc290d7ce --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@276dc290d7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia976c94270e2bb9f66b4d58a7063c9ccd3297720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749521}
-
Ken Rockot authored
These tests haven't passed in a long time and a subsequent CL will make them pass. This CL formats them first to reduce noise in the subsequent CL. Files which are completely obsolete or not relevant to getting tests passing are also deleted here. No functional changes. Only file deletion or automated formatting from yapf --style=mojo/public/tools/.style.yapf Bug: 1060473 Change-Id: I312886956e74dd42f1f0deb474d44abeacdb61b5 Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100012Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c9e9039771e..94794ec0383c Created with: gclient setdep -r src-internal@94794ec0383c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I31ac382483c3a0eb72813e37b41287857cdd9e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749519}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dbb6fcdf4353..83d503bc728e git log dbb6fcdf4353..83d503bc728e --date=short --first-parent --format='%ad %ae %s' 2020-03-11 thestig@chromium.org Force .evt files to have LF line endings. 2020-03-11 tsepez@chromium.org Convert CFXJSE_FormCalcContext static methods to anon functions 2020-03-11 thestig@chromium.org Make more members const in cxfa_ffpageview.h. 2020-03-11 tsepez@chromium.org Remove indexing in CFXJSE_FormCalcContext::DotAccessorCommon(). Created with: gclient setdep -r src/third_party/pdfium@83d503bc728e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I384ebbb36561c529b7558c69e08b98fc76ca05ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100034Reviewed-by:
-
Kelvin Jiang authored
IndexedRule now has request and response header lists. Indexing these via FlatRulesetIndexer will be done in a follow-up. Bug: 947591 Change-Id: I0855ce4a85310b0df4992dd4dd326d66ff41ba14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095861 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749517}
-
Nicholas Verne authored
When the user has clicked the Restart button, there is a delay while Crostini is shutting down before we close the dialog. We disable the buttons in this state as feedback that something is happening and the user shouldn't proceed yet. Bug: 1060830 Change-Id: If0e654c6f63e182efc3e8d178cd2237db9a09807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099346Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749516}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibcc9e8b07d971d208f1e7030e080d1a949fc5dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100039Reviewed-by:
-
David Staessens authored
Similar to crrev.com/c/2094521 this CL marks the new video encoder performance tests as test-only. This prevents the pre-submit checks from displaying warnings about non-test code depending on test-only code. Bug: 1045825 Test: built video_encode_accelerator_perf_tests target Change-Id: Ib91045b226e15896f6fa74bacde4e4f83a097722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096606Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749514}
-
Makoto Shimazu authored
CORP check happens before a service worker sends the response back to the client. This CL plumbs a reporter to notify a server of failures of the check. Note that the error is going to the COEP reporter for the client, not for the service worker because the check in FetchRespondWithObserver is considered for the network request is initiated by the client. Bug: 1056122 Change-Id: Id8b83f8c506a78e15653a993e9471d9eab0532b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094073 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749513}
-
Victor Costan authored
This is a reland of 264654a0 The CL was reverted speculatively in https://crrev.com/c/2095733 to get the tree green. The compilation errors leading to tree closure did not seem related to the files changed in this CL. Original change's description: > WebLocks: Remove unused include from lock_manager.h. > > //content/browser/locks/lock_manager.h included > //content/public/browser/browser_context.h, despite not using > BrowserContext at all. > > Because lock_manager.h is included in storage_partition_impl.h, > browser_context.h was indirectly included in many files. This CL fixes > the IWYU violations highlighted by compiler errors. > > Change-Id: I46462b337d93a7ae1d60648cfd617b2e69662637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093553 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749082} Tbr: falken Change-Id: Iaa1527e4190a577d58355275f6badbd1c26ab44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100010Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749512}
-
Joel Hockey authored
Bug: 1056983 Change-Id: Ic0671f0c06a9390346537343a94a28b75adbca63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096605 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749511}
-
sauski authored
Previously link rows for content settings displayed one of two labels describing their current setting. This CL extends the capability of the cookies link rows specifically to express one of the four possible effective cookie settings. -Allow -Block Third Party only in Incognito -Block Third Party -Block To ensure that this label remains correct across both the preference and content settings changes that affect the effective cookie setting, an additional WebUI listener is created which pushes updates to JS for immediate display. This updated label is applied to both cookies link row locations when the privacySettingsRedesign flag is enabled, and applied to neither when it is disabled. Bug: 1032584 Change-Id: I11a984bce60878b6224506bfc1cd1a5cf3a2e63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095925 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
-
Toni Barzic authored
BUG=1055688 Change-Id: I4279ac1eaef74107fa710648c47217f33ebab27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097837 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749509}
-
Andrew Comminos authored
To enable impl-side frame attribution, add an association between layers and their containing frames. This element ID may be used later to look up the document via its associated DOM node ID. Bug: 910421 Change-Id: I5a70d2f42f94d72f76d9c4eb49cd6ee691e1f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077038Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#749508}
-
Peter Kasting authored
This is in preparation for basing AshTestHelper on AuraTestHelper. * AuraTestHelper will now create a context factory if one isn't provided. This will ultimately allow eliminating the same functionality from Ash and using the new GetContextFactory() method. * AshTestHelper no longer takes an optional ShellInitParams; instead the relevant arguments are added to InitParams. This will make it more obviously safe/correct for callers to supply a context factory alone or for the AshTestHelper to pass it to the AuraTestHelper. * Eliminated AshTestHelper::[set_]test_shell_delegate(). Since this needed to be passed in InitParams anyway, made all callers specify this directly at SetUp() time. This is more verbose in many cases, but prevents potential issues with incorrect downcasts, null derefs, etc. Bug: none Tbr: rdevlin.cronin Change-Id: I22d3c28bfdfb25327c5ebe25415de778558e815b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097462Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#749507}
-
Theresa Wellington authored
This reverts commit 782b48e7 Patchset 1 of 2 to introduce new target and switch upstream dependencies, temporarily breaking downstraem. Patchset 2 will update downstream build targets. Originally this was a 3-sided patch that attempted to keep downstream compiling, but it unfortunately broke upstream compilation instead. BUG=1052382 Change-Id: I5d3a64397e54ec3f6f1e3cac0619ecc796f710bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095371Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749506}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dafbf121a8b1..5082df1cf53e git log dafbf121a8b1..5082df1cf53e --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jvanverth@google.com Remove need for gpu when unrefing managed resources. 2020-03-11 brianosman@google.com Remove GrDrawVertices fast path for simple matrix + colors + no local coords 2020-03-11 robertphillips@google.com Make TessellatingPathOp surface its programInfo at record time 2020-03-11 rmistry@google.com Add wrapper script to call tool to bulk abandon Gerrit CLs 2020-03-11 egdaniel@google.com Have GrVkUniformBuffers own their descriptor sets. 2020-03-11 mtklein@google.com remove -D_GLIBCXX_DEBUG 2020-03-11 fmalita@chromium.org [skottie] Power reduce trivial spatial Berzier Created with: gclient setdep -r src/third_party/skia@5082df1cf53e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ic8b7d4924a86767f92d41d2a32263bc1cbda2186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099223Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9a13b17e77a83e1cac75395bd66aa4c61bfc4297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100037Reviewed-by:
-
Johann authored
ImplPointerType is only defined for mojo::Receiver. Change-Id: I06983fc3e987b34a8c5e00c9e6b14743d5cb1f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096604 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749503}
-
Xiaocheng Hu authored
StyleEngine shouldn't switch CSSFontSelector during its lifetime. It's almost ensured, except that popups may change it during initialization. This patch rewrites CSSFontSelector initialization in popup documents, so that the correct CSSFontSelector is used from the beginning, and does not need to be overridden later. This is preparation for ensuring no FontSelector switching for Font and FontFallbackList. Bug: 1049295 Change-Id: Iaee3121ef06e4d2d6ac357bfa61332eee1da0bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099297 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I7c4b0d723c62cfe6bd06c81becb159d74e0bab8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099594Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749501}
-
Luciano Pacheco authored
Body tag can have other CSS classes thus the class equality check can fail. Change to mark explicitly in the C++ browser test that the test is disabled for FilesNg. Bug: 1035691 Change-Id: I618a201fdecbb9785812c733196af47d160dac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098163Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#749500}
-
Liquan (Max) Gu authored
Before: Half height is the bottom-sheet default 75% (BottomSheet#HALF_HEIGHT_RATIO). After: Half height is customized to 50%. Change: Implement BottomSheetContent#getHalfHeightRatio. Bug: 1060676 Change-Id: Ib586d4cbc22721b4ecb3b81413dcd3a42bd7fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098264Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#749499}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90a8af383cf9..2e5bd9b1e658 git log 90a8af383cf9..2e5bd9b1e658 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 ynovikov@chromium.org Update SimpleStateChangeTest.DrawRepeatUnalignedVboChange suppression 2020-03-11 timvp@google.com Fix SearchProvider 2020-03-11 geofflang@google.com Refactor ANGLE target to allow GoogleANGLE to override it. 2020-03-11 geofflang@google.com Use ANGLE's vulkan-headers dep when rolling ANGLE into Android. Created with: gclient setdep -r src/third_party/angle@2e5bd9b1e658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ie9904307121ad35a74797e6e9f76a27d87616bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099626Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/84bd9713ed32..1480c41c16ee git log 84bd9713ed32..1480c41c16ee --date=short --first-parent --format='%ad %ae %s' 2020-03-11 btolsch@chromium.org Fix mDNS socket binding Created with: gclient setdep -r src/third_party/openscreen/src@1480c41c16ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia83758aa5dfd6b431883f3cb557f88e63228bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099629Reviewed-by:
-
Taylor Brandstetter authored
Follow up from https://chromium-review.googlesource.com/c/chromium/src/+/2078849 Bug: webrtc:5658 Change-Id: I88e59bca06212e6856f48a0791c063a1c158b044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097519Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#749496}
-
spdonghao authored
Bug: 1058829 Change-Id: Idfe84e89c5c390e5102e9d4e78c52fbf4c19fc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090207 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749495}
-
edchin authored
TBR=michaeldo@chromium.org Bug: 1058028 Change-Id: I4bbb97da0dc5835a59da40d2b211142820d2a314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099480Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749494}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de29e8343a24..a31b0a0fbc1c git log de29e8343a24..a31b0a0fbc1c --date=short --first-parent --format='%ad %ae %s' 2020-03-11 primiano@google.com Docs: fix long-traces.md (2) Created with: gclient setdep -r src/third_party/perfetto@a31b0a0fbc1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0e109601ef6ef03cdf91d7c702747b3e59c31eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099399Reviewed-by:
-
Nicholas Verne authored
See bug. Bug: 1060831 Change-Id: Icb09cce748fe8b9a6f1bfcf8371da6d8e76a2203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098142 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c7c4b4bc6e8..1ee78cdaac80 git log 4c7c4b4bc6e8..1ee78cdaac80 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 tandrii@google.com git cl: use short URLs in `git cl status`. Created with: gclient setdep -r src/third_party/depot_tools@1ee78cdaac80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4fcbdb33ccaa0d991b1571f6e661e0293d6fe522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099742Reviewed-by:
-
Ionel Popescu authored
This CL fixes some fit-and-finish issues for the color picker: - hue slider should be 12px - focus ring for the color-selection-ring should follow border radius - increase the margin between the input controls Bug: 1041686 Change-Id: I75fed1b4b1ae5fd5ccd979231bc5b166ef6e9616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098995 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
-
Arthur Eubanks authored
Pointers are only guaranteed to be castable to an integer of at least the same size. Bug: 1059231 Change-Id: I6c6089a13f5350745489915dd6ba41069a2a1a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098273 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#749489}
-
Danan S authored
This CL allows the management API to properly prompt child users for parent permission when they attempt to install an extension. This is required for the chrome://extensions page whose extension operations are handled via the management API. It also allows enabling of extensions that are already parentally-approved. Bug: 957832 Change-Id: Id40dd2f5138b4f5a85e91f2f9ffa676130ea9daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079529 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
-
John Lee authored
The chips should read out either the group title or "Unnamed group" and also read out the contents of the group. Bug: 1027373 Change-Id: Ia8eb6f31433e8cec7e1f80c1185e45d970100db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099024 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749487}
-
Hugo Benichi authored
This is a reland of 956b131c The original patch was reverted by markusheintz@ in commit a2c71349 because it turned out there were still bots running with ARC N. Original change's description: > arc: net: remove ARC N legacy APIs > > This patch removes net.mojom APIs and fields only used in ARC N: > - NetworkConfiguration mac_address: the host mac_address of a network > is now completely hidden in ARC P. > - GetDefaultNetwork and DefaultNetworkChanged: ARC P is multinetwork > aware and always need the full list of connected services. > > BUG=b:149716479 > BUG=b:145960788 > TEST=Compiled, flashed eve, ran CtsNetTestCases. > > Change-Id: I3368d620d44dd910aae7a12c84c207c3d5cb6cf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086362 > Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Hugo Benichi <hugobenichi@google.com> > Cr-Commit-Position: refs/heads/master@{#748094} Bug: b:149716479, b:145960788 Change-Id: I198438aec3c5422bbd6b8bf9258f16ab7dd194b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094759Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#749486}
-
Alex Danilo authored
The files-ng layout moves the breadcrumbs and action bar to the right hand side of the splitter. When the length of the breadcrumbs and action bar combined exceed the width available, the content was being pushed to the right in LTR layout and to the left in RTL layout. Adds an event handler for the 'relayout' event that checks the widths of the main panel, navigation list, splitter and main panel and sets the width of the main panel explicitly if the main panel content is too wide to fit in the main window (which forces the browser to layout the child content of the main panel). Limiting the width of the main panel makes the content fit, and hence, scrolling of the content in the viewport can't happen. Note, the problem appears in 2 cases - one by expanding the directory tree with nested directories and narrow windows. Secondly, if the search box is expanded and space in the dialog header runs out, causing the header width to expand. For either case, if style width has not been set on the main panel, we force the setting the first time in, in order to stop clipping of expanded content. We throttle this rAF sizing as recommended for scroll events[1]. [1] https://developer.mozilla.org/en-US/docs/Web/API/Document/scroll_event Bug: 1059643 Change-Id: I545ed89113f5840f96dda8a94f3ec0ae51b1cc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098140 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
