GitLab

BUG=328960

Review URL: https://codereview.chromium.org/156943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/161173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342832

Review URL: https://codereview.chromium.org/162363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251128 0039d316-1c4b-4281-b951-d872f2087c98

This adds didRequestMainThreadFrame() and didDrawFrame() so we can better
track impl-side frame lifecycle in DevTools

R=danakj, nduca

Review URL: https://codereview.chromium.org/144463016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251127 0039d316-1c4b-4281-b951-d872f2087c98

Chrome needs a pre-existing or creatable user-data-dir to run.
ChromeMainDelegate::PreSandboxStartup was CHECK'ing for this.
(crashing on startup with --user-data-dir="M:\invalid")
(crashing on startup with --user-data-dir="C:\windows")

Supposedly, we had a dialog to let users choose another dir.
(I've never gotten this to work on M28-M32 stable versions)

Revise the user-data-dir code to warn on invalid paths.
(see crbug.com/318999#c18 for the warning screenshot)
Then attempt to use the default directory as a backup.
(no alternate dir selection UI, users can try again)

This should avoid many of the numerous related crashes.

BUG=318999
TEST=Supplying an invalid --user-data-dir=<path> will warn users and attempt to use the default directory instead of silently crashing.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/123693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251126 0039d316-1c4b-4281-b951-d872f2087c98

Before, the CanOffer method could return true, while the web based signin was disabled through about:flags. This meant that neither the save password prompt, nor the sign-in interstitial were shown.

This CL ensures that CanOffer returns false if the web based signing is disabled in about:flags.

BUG=339804

Review URL: https://codereview.chromium.org/160363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251125 0039d316-1c4b-4281-b951-d872f2087c98

Rework the wait functions to use a TestNavigationObserver (waits for
DidStopLoading) rather than the commit, to avoid potential flakiness where the
load is still progressing. (prerender_loader_with_session_storage.html only
updates sessionStorage.counter at onload.)

BUG=249179,121130

Review URL: https://codereview.chromium.org/161323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334624

Review URL: https://codereview.chromium.org/130813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334665

Review URL: https://codereview.chromium.org/160463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251120 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org

Review URL: https://codereview.chromium.org/164593002

Patch from Michael Starzinger <mstarzinger@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251119 0039d316-1c4b-4281-b951-d872f2087c98

The current mechanism by which these convenience macros find their
backend is confusing, at best; the macro has the form of our include
guard macros, but describes a CC file. Embedded within the
histogram_macros.h then is an abstraction violation: it just knows
which object has backend information depending on which file it was
included from.

Some downstream reviews have made this even more confusing; rather
than continue this, let's parameterize the backend object to the
convenience macros, so each translation unit is responsible for
knowing its own context.

R=mmenke@chromium.org, rvargas@chromium.org
TBR=mmenke@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/140893013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251116 0039d316-1c4b-4281-b951-d872f2087c98

The test runner can then inject dependencies into it (just as we do for
system and gles2).

This removes public/tests's base dependency.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/160003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251115 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/)
> 
> Reason for revert:
> Possible build bustage on Win64.
> 
> Original issue's description:
> > [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService
> > 
> > BUG=80194
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814
> 
> TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=80194
> 
> Review URL: https://codereview.chromium.org/162943002

TBR=tim@chromium.org

Review URL: https://codereview.chromium.org/163983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251114 0039d316-1c4b-4281-b951-d872f2087c98

Speculative re-land. Sync tests are passing now, but we're not sure
which revert fixed them. Let's see if this makes the tree red again
or not.

> Revert 250826 "Remove Profile dependency from apps::ShellWindow"
> 
> Speculative revert for failures:
> 
> http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201
> 
> > Remove Profile dependency from apps::ShellWindow
> > 
> > Part of the effort to remove src/chrome dependencies from src/{apps, extensions}
> > 
> > BUG=341690
> > TBR=tapted@chromium.org,stevenjb@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/157813007
> 
> TBR=rockot@chromium.org
> 
> Review URL: https://codereview.chromium.org/163913004

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/164613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=darin

Review URL: https://codereview.chromium.org/164313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251111 0039d316-1c4b-4281-b951-d872f2087c98

Relanding, this wasn't the cause of the failures.

> Revert 250823 "With --site-per-process, avoid a crash when a sub..."
> 
> Speculative revert to see if the navigation changes here are causing
> sync_integration_tests to fail on:
> 
> http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11217
> 
> > With --site-per-process, avoid a crash when a subframe process goes away.
> > 
> > We need to clear out the children of any nodes that are affected by the
> > crash, not the entire FrameTree.
> > 
> > BUG=338508
> > TEST=Killing an iframe process with --site-per-process shows a green rectangle.
> > R=ajwong@chromium.org, nasko@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/156303004
> 
> TBR=creis@chromium.org
> 
> Review URL: https://codereview.chromium.org/163703004

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/163183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251110 0039d316-1c4b-4281-b951-d872f2087c98

Mac and Windows are at 251082, and Linux is at 251083.

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/164233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294008
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/164193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251108 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 250830 "Exclude notification strings for builds that dont..."
> 
> > Exclude notification strings for builds that dont use it.
> > 
> > BUG=326023
> > 
> > Review URL: https://codereview.chromium.org/160113002
> 
> Broke win64 sync tests, e.g. output:
> 
> c:\b\build\slave\cr-win-rel-x64\build\src\chrome\browser\sync\test\integration\sync_test.cc(707): error: Value of: UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()-> GetTitle())
>   Actual: ""
> Expected: "Notifications enabled"
> 
> TBR=aurimas@chromium.org
> 
> Review URL: https://codereview.chromium.org/163713002

Reverting the revert, since this wasn't responsible for the failures.

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/164573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251106 0039d316-1c4b-4281-b951-d872f2087c98

cause a variable name collision in JS.

BUG=325500
R=darin@chromium.org

Review URL: https://codereview.chromium.org/159983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251105 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251104 0039d316-1c4b-4281-b951-d872f2087c98

r251066 reverted the backgrounding of the print dialog.

Before the revert

http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context_win_unittest.cc?r1=232466&r2=232611

assumed they were going to be async, so added RunLoop. Now that the
dialog is synchronous again, remove that code which is causing the
MessageLoop to complain.

TBR=vitalybuka@chromium.org
R=asvitkine@chromium.org
BUG=180997,342697

Review URL: https://codereview.chromium.org/164483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251102 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert for failures here:

http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201

> Add a UMA stat to track if the Browser blacklist is Set on the Renderer
> 
> This shouldn't be happening, but we got some crash reports suggesting it
> does. Unable to repo locally so this stat will verify it does occur and
> then can be used to verify our fixes actually fix it.
> 
> BUG=329023
> 
> Review URL: https://codereview.chromium.org/140763008

TBR=csharp@chromium.org

Review URL: https://codereview.chromium.org/163633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251095 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert for failures:

http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201

> Remove Profile dependency from apps::ShellWindow
> 
> Part of the effort to remove src/chrome dependencies from src/{apps, extensions}
> 
> BUG=341690
> TBR=tapted@chromium.org,stevenjb@chromium.org
> 
> Review URL: https://codereview.chromium.org/157813007

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/163913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251094 0039d316-1c4b-4281-b951-d872f2087c98

This incorporates a neccessary fix.

BUG=None
TEST=None
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/164243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251091 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see if the navigation changes here are causing
sync_integration_tests to fail on:

http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11217

> With --site-per-process, avoid a crash when a subframe process goes away.
> 
> We need to clear out the children of any nodes that are affected by the
> crash, not the entire FrameTree.
> 
> BUG=338508
> TEST=Killing an iframe process with --site-per-process shows a green rectangle.
> R=ajwong@chromium.org, nasko@chromium.org
> 
> Review URL: https://codereview.chromium.org/156303004

TBR=creis@chromium.org

Review URL: https://codereview.chromium.org/163703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251090 0039d316-1c4b-4281-b951-d872f2087c98

The previous code would fail for the case of the app window already
present before the observer gets registered.

BUG=chromium:343540

Review URL: https://codereview.chromium.org/163493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251088 0039d316-1c4b-4281-b951-d872f2087c98

This CL add the following tests:
1. test chrome.setWallpaper can set ChromeOS wallpaper from jpg or png formatted arraybuffer.
2. test chrome.setWallpaper can set ChromeOS wallpaper from a valid url that point to a jpg or png image.
3. test an invalide URL wont set wallpaper
4. test a new wallpaper request will cancel previous unfinished request


BUG=176183

Review URL: https://codereview.chromium.org/153093010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251087 0039d316-1c4b-4281-b951-d872f2087c98

Since iOS 7, the iPhone 5s, the iPad Air and the iPad Mini Retina
supports 64-bits binaries. This requires building a fat binary with
support for both armv7 and arm64 (and optionally armv7s).

In an effort to prepare building such a fat binary for Chrome on
iOS, introduce a "target_subarch" variable that control the variant
we want to build (32-bit only, 64-bit only -- mainly for debugging,
fat binary).

This require introducing way to use the clang compiler shipped with
Xcode, as the clang compiler shipped with Chromium code does not
support "arm64" architecture yet (Apple has not yet opensource the
implementation).

BUG=341453, 314720
R=mark@chromium.org

Review URL: https://codereview.chromium.org/156473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251083 0039d316-1c4b-4281-b951-d872f2087c98

This partially reverts the "cleanup" of r250260. The "cleaner" version is not equivalent if the call to -[NSWindow animations] returns nil.

BUG=none
TEST=no change

Review URL: https://codereview.chromium.org/148113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251082 0039d316-1c4b-4281-b951-d872f2087c98

Previously we would check for unused args on a per-build basis. In the GYP build we run the build multiple times, and not all args might be declared in all types of builds. For example, clang args would only be relevant for clang builds, which might only be in the host GYP build.

Makes unused args errors nonfatal. This was coming up a lot in benign cases. It's important to notify people about unused arguments, but it's not critical to block progress on this problem.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/137713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251080 0039d316-1c4b-4281-b951-d872f2087c98

The manager will now wait 400ms after it receives both a request and its view
before showing a bubble.  This allows permissions that are requested
quickly in sequence to be shown together, in only one bubble.  Permission
requests that occur when there is already a bubble visible are queued and not
shown until the current bubble disappears.

This simple wait period is probably simpler than the final design, but is a
good stepping stone toward a better algorithm.

BUG=None

Review URL: https://codereview.chromium.org/150103013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/138913011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251078 0039d316-1c4b-4281-b951-d872f2087c98

I'm planning on reusing the name test_support for something slightly
different: a dynamic library that can thunk to an implementation
provided by the test runner (much like we do for system and gles2). This
is so we can remove public/tests's base dependency (by injecting it
instead).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/132353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=darin@chromium.org, ben

Review URL: https://codereview.chromium.org/162213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251076 0039d316-1c4b-4281-b951-d872f2087c98

The old default causes weird scaling on the Chromebook Pixel. Try to use
the display size to set the scale.

TEST=content_shell with embedded=1 on pixel
TBR=rjkroege

Review URL: https://codereview.chromium.org/131373007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251075 0039d316-1c4b-4281-b951-d872f2087c98

This means no file can be opened for write during the test run.

R=vadimsh@chromium.org
NOTRY=true
BUG=116251

Review URL: https://codereview.chromium.org/137133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251074 0039d316-1c4b-4281-b951-d872f2087c98

The |nestable_tasks_allowed| parameter was always being set to true from the
callsites. So get rid of the variable, and use ScopedNestableTaskAllower in
the RunWithDispatcher implementations.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/162633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294477
TEST=browser_tests:CaptivePortalWindowCtorDtor*

Review URL: https://codereview.chromium.org/163413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251071 0039d316-1c4b-4281-b951-d872f2087c98