GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=japhet@chromium.org

Review URL: https://codereview.chromium.org/13517005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192515 0039d316-1c4b-4281-b951-d872f2087c98

Commands are updated when focus is updated. This makes sense, when executing commands by pressing an ui element. However, when executing a command via a shortcut, we may execute it while it shouldn't be allowed to be executed. This patch fixes it by updating the command's state (disabled/enabled) just before executing it via a shortcut.

TEST=Enter Files.app, select a file, then deselect a file, hit Delete button. A delete command should not be invoked.
BUG=174554


Review URL: https://chromiumcodereview.appspot.com/13532006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222218
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/13434005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192513 0039d316-1c4b-4281-b951-d872f2087c98

Fixed IsCapturingUserMedia() and IsBeingMirrored() to use WebContents pointer
to identify tabs.


Review URL: https://chromiumcodereview.appspot.com/13355003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192512 0039d316-1c4b-4281-b951-d872f2087c98

When the browser cache for a given profile is cleared
we will now clear out any shaders stored in the
shader disk cache for that profile.

BUG=176289


Review URL: https://chromiumcodereview.appspot.com/12500009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192511 0039d316-1c4b-4281-b951-d872f2087c98

> Re-apply 192420: Move login switches to src/chromeos
> Includes fix for GOOGLE_CHROME_BUILD
> 
> BUG=192420
> TBR=ben@chromium.org, nkostylev@google.com
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13671005

TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/13590004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180591
TEST=misc audio clients in Chrome using the new --force-wave-audio flag on Win7
Review URL: https://codereview.chromium.org/13639002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192509 0039d316-1c4b-4281-b951-d872f2087c98

Add ContentViewCore#udpateFrameInfo trace event.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13688003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192508 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192507 0039d316-1c4b-4281-b951-d872f2087c98

scoped_ptr<T[]>, which will replace scoped_array<T>, does not support
passing NULL as an explicit argument to reset().

BUG=171118

Review URL: https://codereview.chromium.org/13692002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192506 0039d316-1c4b-4281-b951-d872f2087c98

Includes fix for GOOGLE_CHROME_BUILD

BUG=192420
TBR=ben@chromium.org, nkostylev@google.com


Review URL: https://chromiumcodereview.appspot.com/13671005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192504 0039d316-1c4b-4281-b951-d872f2087c98

Image and tracking updates are now tracked separately, so that we properly
distinguish between adds/updates.

BUG=226539


Review URL: https://chromiumcodereview.appspot.com/13666003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192503 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192502 0039d316-1c4b-4281-b951-d872f2087c98

-Track frame info for newly inserted nodes via DOM.childNodeInserted.
-Update subframe execution context IDs.
-Return NoSuchFrame if the frame doesn't have a execution context
BUG=chromedriver:279


Review URL: https://chromiumcodereview.appspot.com/13651002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225857


Review URL: https://chromiumcodereview.appspot.com/13650008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192500 0039d316-1c4b-4281-b951-d872f2087c98

Previously, there were two code paths in BrowserPluginGuest to request a new window (new <webview>) from the embedder: one for suppressed openers and one for unsuppressed openers. This CL unifies the two code paths.

BUG=none
Test=WebViewTest.Shim, WebViewTest.NewWindow


Review URL: https://chromiumcodereview.appspot.com/13649007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226642
TEST=AACTest_TestImplicitSBR_ChannelConfig0,AACTest_TestImplicitSBR_ChannelConfig1


Review URL: https://chromiumcodereview.appspot.com/13648007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192498 0039d316-1c4b-4281-b951-d872f2087c98

- we want to check a data block of a specific tag and enough length,
  which doesn't mean && here.
- data_block skipping length is different between two continue

BUG=226318
TEST=ui_unittests passed


Review URL: https://chromiumcodereview.appspot.com/13648004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192497 0039d316-1c4b-4281-b951-d872f2087c98

These are only used downstream, so the failure was invisible upstream.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13691002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172584


Review URL: https://chromiumcodereview.appspot.com/13620002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192495 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that users don't lose any saved settings when upgrading to M27.

BUG=226488


Review URL: https://chromiumcodereview.appspot.com/13619010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192494 0039d316-1c4b-4281-b951-d872f2087c98

Remove NativeWidgetWin::RestoreFocusOnActivate's built-in hack.
Always use kReasonFocusRestore in FocusManager::RestoreFocusedView().
Always run FocusManager::SetFocusedViewWithReason with kReasonFocusRestore.
(this clears and resets child HWND focus, needed for the hack)

Fixes initial omnibox focus on Win with --enable-views-textfield; plus:
interactive_ui_tests.exe --gtest_filter=BrowserFocusTest.ClickingMovesFocus --enable-views-textfield
views_unittests.exe --gtest_filter=BubbleDelegateTest.InitiallyFocusedView --enable-views-textfield
(test updated to have the proper expectation, removing a non-Aura Win hack)
Doesn't regress child HWND focus like the previous attempt: http://crrev.com/186235

Remove SearchTextfieldView Textfield subclass; make RequestFocus non-virtual.
TODO(followup): Polish find-bar focus behavior as needed in followups.

BUG=125976,131660,224591,225963
TEST=View and web-contents focus restoration on minimize/restore; repro steps in bugs. Find bar works as expected (may need attention in followups). Tests pass with --enable-views-textfield.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13227002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192493 0039d316-1c4b-4281-b951-d872f2087c98

This is for working around the case when <input type="file"/> control is used
twice; CrOS file picker kindly resolves a remote file path to a local cache
and the type=file control tries to default to the path, but the cache path
itself is out of user-visible directory. In such a case, we just use the
last_selected_directory(), rather than going back to the very default directory.

BUG=178013

Review URL: https://chromiumcodereview.appspot.com/13614002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192492 0039d316-1c4b-4281-b951-d872f2087c98

A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem. 

This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url.

BUG=224462

Review URL: https://chromiumcodereview.appspot.com/13599003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192491 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/12983010/

reversed_root_transform is passed into event::UpdateForRootTransform.

Then for TouchEvent::UpdateForRootTransform(), the radius_x/y now
should times the inverted device scale factor instead of being
divided by it. The same in ScrollEvent::UpdateForRootTransform() for
scroll offset ordinal.

BUG=chromium:226169
TEST=On Link, visit http://www.rbyers.net/paint.html, make sure
     touch radius has normal range.

Review URL: https://chromiumcodereview.appspot.com/13594009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192490 0039d316-1c4b-4281-b951-d872f2087c98

The Menu Button ui control that the history action pop-ups employ
handle the resize event by hiding the menu.  This CL will similarly
hide the menu on a |scroll| event is triggered.

This resolves the scrolling problem in the referenced bug.

However, this change does not address the reported behavior that the
pop-up remains visible when changing tabs. I tend to agree with
sergiu@ that the existing behavior seems proper.

BUG=222313
TEST=The MenuButton ui element is used in several places; I tested the History, Bookmark Manager and NTP but I can see it also being used in ChromeOS login screen and File Manager which I am unable to test. The change involves hiding the menu pop-up when the document scroll event is triggered.

Review URL: https://chromiumcodereview.appspot.com/13532014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192489 0039d316-1c4b-4281-b951-d872f2087c98

- Remove the EndKeepALive work arounds;
- Manage app session lifetime explicitly by watching app
  window counts;

BUG=226103

Review URL: https://chromiumcodereview.appspot.com/13581008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192487 0039d316-1c4b-4281-b951-d872f2087c98

Due to weirdness with GPUs on trybots causing flakiness in tests, the initial implementation of CompositingIOSurfaceTransformer was committed with all unit tests disabled.  This change will enable the tests, but force the software-based OpenGL implementation to be used.

In a later change, we will allow the OpenGL implementation to auto-detect and utilize a GPU, where one is available.  However, first the tests should prove themselves as stable when not using GPU.

TBR=kbr


Review URL: https://chromiumcodereview.appspot.com/13573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192486 0039d316-1c4b-4281-b951-d872f2087c98

install-build-deps.sh runs "sudo /path/to/src/build/linux/install-chromeos-fonts.py".
If the repo is on a filer, sudo fails because root is not allowed to access files on
a filer. However, installing a Repo on a Filer is not recommended.
Solution:
install-build-deps.sh attempts to detect that the Repo is not on a Filer and
in that case prints a warning with instructions.

Note: install-build-deps.sh exits immediately on failure because it uses "bash -e".

BUG=225543
R=derat@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/13532003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192485 0039d316-1c4b-4281-b951-d872f2087c98

The md5 stamp path includes the device serial (i.e. the stamp is
library-device specific).

Also, this no longer creates a shell for-loop as the command to send to
adb. adb shell has a ~1000 character limit for commands, and the
for-loop was exceeding that limit. Now that we only create links for
libraries that actually have changed, there is not as much benefit to
creating all the links in one adb command.

BUG=158821


Review URL: https://chromiumcodereview.appspot.com/13537006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192484 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192483 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet@chromoum.org
BUG=

Review URL: https://codereview.chromium.org/13701003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192482 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192481 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue with the default selected categories for tracing
not being propagated correctly.

BUG=trace-viewer:146


Review URL: https://chromiumcodereview.appspot.com/13521005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192480 0039d316-1c4b-4281-b951-d872f2087c98

For non-chromium code, suppress all output when successful (i.e. warnings).

For chromium code, add -Xlint:deprecation to get detailed deprecation
warnings.

BUG=164395


Review URL: https://chromiumcodereview.appspot.com/13489006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192479 0039d316-1c4b-4281-b951-d872f2087c98

Use a simple wrapper script for calling ant. This allows us to suppress the
"BUILD SUCCESSFUL" + timing output from ant.

BUG=164395


Review URL: https://chromiumcodereview.appspot.com/13470026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192478 0039d316-1c4b-4281-b951-d872f2087c98

Noone else is using Uploader in the Drive implementation.
All Drive operations should be under the control of Scheduler.

BUG=147358

Review URL: https://chromiumcodereview.appspot.com/13448003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192477 0039d316-1c4b-4281-b951-d872f2087c98

Previously, calling this function crashed, if ChangeListLoader is not yet
created. This change is in preparation for writing browser tests for
Drive in Files.app

BUG=224534
TEST=none

Review URL: https://codereview.chromium.org/13575003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192476 0039d316-1c4b-4281-b951-d872f2087c98

The abstract BluetoothDevice class has a few problems inherited from
its origin as a ChromeOS-specific class split between implementation
and platform-specific components.

Clean those problems up, specifically:
 - replace bluetooth_class_, name_ and address_ non-abstract members
   with getter functions that the platform should implement.
 - also make IsConnected(), IsConnectable() and IsConnecting()
   abstract functions rather than providing an implementation
 - remove IsVisible() which was a CrOS-specific hack
 - remove IsBonded(), use IsPaired() instead
 - remove service_uuids_ non-abstract member; make GetServices return
   a copy of the list to allow implementations to fetch it on demand

BluetoothDevice retains implementations for GetName(), GetDisplayType()
and ProvidesServiceWithUUID() since those can be implemented entirely
using platform-provided information functions and would be identical
in each platform.

Also rename BluetoothAdapter::address() and BluetoothAdapter::name() to
GetAddress() and GetName() to match since they are also pure virtual.

BUG=none
TEST=device_unittests, browser_tests, unit_tests


Review URL: https://chromiumcodereview.appspot.com/13416005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192474 0039d316-1c4b-4281-b951-d872f2087c98