- 13 Nov, 2019 40 commits
-
-
Eric Roman authored
Bug: 993499 Change-Id: I0d2f535ca6958d6e77ee9f854f30519a73ba57d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912823 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714989}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e156cb1e..b6857b74 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a51610a2c086d6e9f1bb811389a1fca82431963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914194Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714988}
-
Piotr Zarycki authored
The feature shipped in M76, is safe to remove the related flags and switches. Bug: 1019233 Change-Id: I9d0379a358a146a4f62a24356bea738c229247ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903132Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714987}
-
Jun Mukai authored
This CL adds getting and setting the mouse state to autotestPrivate API. Although Tast / testing infra should have the feature to cause mouse events through device files, it turns out not quite helpful for the use of UI tests; the new APIs addresses to the situation; obtaining the current mouse status, and causing the mouse events exactly at a location. Bug: 1019000 Test: with Tast Change-Id: Iafacca190e057653565a685794cf3833a2411a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896385Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714986}
-
Bailey Berro authored
autofocus does not make sense for the edit-printer-dialog since the user is not filling out information but rather editing information that already exists Bug: 1015673 Change-Id: I2d4725ad42e4785f38c1ef1a8e559e6871016f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906255Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714985}
-
Raymond Toy authored
Converting multi_channel_resmpler and sinc_resampler to use RepeatingCallback and BindRepeating. Bug: 1007799 Change-Id: Ic2d20e1d6880b47278b61e62ca5f3764a0feaba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907275Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714984}
-
jongdeok.kim authored
This CL changes some classes in ui/views/accessibility/ and view_tracker.{h,cc} to use ScopedObserver. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=940796 Change-Id: Iee16691098fae2e3cba4f11a9d970181ca28f659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558558 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#714983}
-
Robert Liao authored
BUG=5027 Change-Id: Ie5c2b37de94b6614a8ed7e55b329da22bd672aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904311 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#714982}
-
Rune Lillesveen authored
When we mark the light tree ancestors child-dirty for style, we could not set a node inside a shadow scope as a style recalc root because slotted nodes could require traversal via the host light tree parent. With FlatTreeStyleRecalc enabled, we can now allow that. This affected performance for the perf_test below because the elements needing recalc where light-tree children of a shadow host high up the light-tree which were slotted deep into the chain of shadow hosts with slots. With the recalc root in the document scope, that made us traverse deep in the flat tree to reach the dirty nodes, while the light-tree traversal would skip the shadow trees and recalc the styles for the dirty nodes as part of the light tree children of the outer shadow host. It's not certain this makes all the perf regression recover, but local testing shows that it definitely improves. TEST=perf_tests/shadow_dom/v1-mutate-shallow-tree-then-re-layout.html Bug: 1023215 Change-Id: Id7143bf0e8fd7c298d6b683be8ead0fd23941f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912711Reviewed-by:
-
Bailey Berro authored
Previously, there were 3 navigation stops for Parental Controls: 1) Title of the row, 2) sub-text, and 3) Set Up button. With this change there are now two stops: 1) Title of the row with sub-text as description, and 2) Set Up button with sub-text as description. Bug: 1012565 Change-Id: I5ebe2afe3d8b43a0ad7e60aeffcc5ea35a28eaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912697Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/359bc80a7ee4..b5407bfb585e git log 359bc80a7ee4..b5407bfb585e --date=short --no-merges --format='%ad %ae %s' 2019-11-13 swiftshader.regress@gmail.com Regres: Update test lists @ 88632cac Created with: gclient setdep -r src/third_party/swiftshader@b5407bfb585e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I0def1413313352681965f9b2ad0247aa7ac2c826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714979}
-
Matt Menke authored
Make HostResolverMojo take a NetworkIsolationKey. It now both passes the NetworkIsolationKey to the HostResolverMojo::Impl it wraps, and uses the NetworkIsolationKey as part of the key into its local HostCache. Bug: 1021661 Change-Id: Ib9fc433635933c0e0a587c762d4ce6e581bf7317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904487 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714978}
-
Elly Fong-Jones authored
This change: 1) Fixes two errors in flag-metadata.json, both instances of: "owners": [ "foo,bar" ] where "owners": [ "foo", "bar" ] was meant. 2) Adds a new unit test, AboutFlagsTest.OwnersLookValid, that detects this mistake and another couple of common syntax mistakes in owner metadata. Bug: None Change-Id: I944efd9c95fcb6a2ccdce2b174b542ddf3e451d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912803 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714977}
-
Ioana Pandele authored
The overhead of creating a proper ChromePasswordManagerClient instance is too big for unit tests and may lead to unexpected side-effects. Bug: 1007218 Change-Id: I98f02d64a513befa1cf22346ca94847fa7b1f75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912717Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#714976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4e6d1590f29..57d0093ac901 Created with: gclient setdep -r src-internal@57d0093ac901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7e463cb7cb298c3d8037a377590bcc1060a9bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913654Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714975}
-
Azeem Arshad authored
This CL adds aria labels for the 4 custom name server input fields. The fields will be announced as "Custom name server 1", "Custom name server 2" etc. Bug: 1005944 Change-Id: I79eb275d5ad3ca60b1f29ea04c455fd8258d7939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913880Reviewed-by:
-
Jesse Schettler authored
This reverts commit 3af7932b. Reason for revert: ARC++ printing can pass CTS Original change's description: > Revert "arc: Enable print-spooler-experiment feature flag by default" > > This reverts commit c79e6751. > > Reason for revert: Fixing CTS for ToT > > Original change's description: > > arc: Enable print-spooler-experiment feature flag by default > > > > Also, enable the flag for all channels except stable. > > > > Bug: b:130798103 > > Test: android-sh -c getprop | grep ro.boot.arc_print_spooler > > Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006 > > Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> > > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693860} > > TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:130798103 > Change-Id: I400c7050bbf4c82ffba230b1900d14daa309c628 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831273 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701184} TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org Bug: b:130798103 Change-Id: I378ae1dee61231462f8588bd1303400b47158bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914479Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#714973}
-
Stephen Roe authored
This is a reland of 8db01995 after fixing https://b.corp.google.com/issues/143701391 It adds the parentheses changes from https://chromium-review.googlesource.com/c/chromium/src/+/1893190 Original change's description: > Add third_party/qemu-linux-arm64 to DEPS runhooks. > > qemu-linux-arm64 is from the /fuchsia/qemu/linux-arm64 CIPD package. > > Bug: 1015177 > Change-Id: Ie193d18e4b52059ad853cee07075979b1faea038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865751 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#708478} Bug: 1015177 Change-Id: I27c848336a3466ef2aa2801d29b7b850fd0411d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913570 Auto-Submit: Stephen Roe <steveroe@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714972}
-
Koji Ishii authored
Following bot results are included. 265 266 269 270 271 272 273 275 30 lines were removed and 32 lines were deflaked by consecutive results since 253. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4c914f77da1efc37c6305d97136d48893b8546d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912399Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714971}
-
Anastasia Helfinstein authored
All calls to connectChildren were immediately followed by a call to setChildren, so I combined them, along with several other readability changes. This change is a pure refactor. Bug: None Change-Id: If340c812127d95412939977a12f247203da07d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902516 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714970}
-
Ken Rockot authored
This changes the GPU process to expose browser-facing interfaces through the Content ChildProcess interface. ChildThreadImpl now allows subclasses to provide a BinderMap to handle incoming interface binding requests from the browser. This is a fairly simple drop-in replacement for what used to be done through the Service Manager with a ConnectionFilter. There should be no behavioral changes here. In particular for GPU interfaces, this CL is careful to preserve the behavior which avoids binding incoming interface receivers until |OnGpuServiceConnection()| is invoked. Bug: 977637 Change-Id: Id00a1f0b1178f9c3fed2816eea9808f162829798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905050Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#714969}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cfdbaaa37664..9e7107eb96af git log cfdbaaa37664..9e7107eb96af --date=short --no-merges --format='%ad %ae %s' 2019-11-13 rharrison@chromium.org Migrate Dawn fuzzers to using new SPVC split API Created with: gclient setdep -r src/third_party/dawn@9e7107eb96af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I096cc1e4cc76941e6f391813770fd4754c8f64a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913658Reviewed-by:
-
Daniel Vogelheim authored
Bug: 1020589 Change-Id: Ieefc31f5a16f9d374577cd498a493d86ba95d4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913256Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714967}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 222d1e64. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-contain external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Id5e8f88d03784476d8d6fb40b1ed8100c0b9ea7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914190Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714966}
-
Saman Sami authored
Video frames that are capable of being put in an overlay should be marked as such. This bug only affects the ChromeosVideoDecoder experiment. Bug: 984482,756454 Change-Id: I1b6b31adb8525e8081ae8cd404b00bcd62b3f305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913210 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714965}
-
Jinsuk Kim authored
Tab's 2 public methods updateWindowAndroid and notifyActivityAttachmentChanged are related, one calling the other. This CL consolidates them into one to make the API surface smaller. Bug: 995903 Change-Id: I0ad30525451c633a18d49c4b419be91bbab83754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906847 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#714964}
-
Yue Zhang authored
Bug: 1024089 Change-Id: Ie8e0a95b6dd2151cbf88f9e42c0791cc6f264c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913713Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714963}
-
Manuel Rego Casasnovas authored
This patch separates PaintLayer::NeedsRepaint() into two flags: * PaintLayer::SelfNeedsRepaint() * PaintLayer::DescendantNeedsRepaint() This also introduces a method SelfOrDescendantNeedsRepaint() that is used in the places where we need to check for any of the flags (somehow the equivalent to the previous NeedsRepaint()). This is the initial step to allow optimizations in future patches. Ideally we should be able to avoid repainting a PaintLayer if it only has DescendantNeedsRepaint(). BUG=917911 Change-Id: Ie9d509328515492905d8da3b11d2cbf95da5f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911792Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#714962}
-
Livvie Lin authored
Call to the method was fixed in https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1dc0ccf4574deb1d4a5ea95b2397ba44a5d48e14 Bug: 1020670 Change-Id: I25a2b9768cfcab42e6dd86b25b72cafa1fc76296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907077Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714961}
-
Xiaoqian Dai authored
If hotseat was hidden before window drag starts, the drag will first bring up the hotseat and then after hotseat is fully brought up, the window can be dragged up. In this case we should calculate the initial window drag scale at the initial event location, otherwise we'll see a jump of window scaling down effect. For the extended hotseat case, since the drag can start below the mini shelf, we should continue use window bottom location to calculate the initial window drag scale, otherwise the dragged window might be above the finger, not under the finger. Bug: 997885 Change-Id: I81c100379899d032442522460b5085f97aadb4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913482Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714960}
-
Vincent Boisselle authored
To stay consistent with the UmaAndUkmDemographics Finch config, the tested group UMA_enabled should disable UkmReportNoisedUserBirthYearAndGender feature. Bug: 1023825 Change-Id: I8c8bbd341b576ea67cd6bd88a28a87c34b29977d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914193Reviewed-by:
-
Henrique Nakashima authored
Chromium's only exists for historic reasons, currently serving documentation purposes only. AndroidX's version is supported by Android lint, though the check at build time is not currently working (crbug.com/1022939). This check is still useful for Android Studio. Bug: 889467 Change-Id: I6fefc44c8cda5d744bd722ca20a7583f8e5e19cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901635 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#714958}
-
Andrew Grieve authored
* Ignore library when License File: NOT_SHIPPED * Expand regex to match a few more variation of existing licenses. Bug: 693079 Change-Id: I87cba0fc358f155a3c8fd3f590fc5ec5210ce896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911603Reviewed-by:
-
Chris Lu authored
This change implements the model logic for InfobarTranslateTableViewController. This change also adds a infobarButtonText method that returns the desired action button text depending on the current TranslateStep. Screenshot: https://drive.google.com/open?id=1UFfeJc56Hh1e0boGRfxPAOLNPFRle0v4 Bug: 1014959 Change-Id: I04a1021fbf6024527050691bc7704cda0668e478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899201 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714956}
-
Tibor Goldschwendt authored
Change-Id: Id5315c46499b56e49e6acebe1aff67d84ab6bc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903931 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#714955}
-
Aaron Krajeski authored
By the old method both the paint canvas and the recorder canvas would hold the transform, thus it would be applied twice. With this change OffscreenCanvas::TransferToImageBitmap restores the matrix onto the recorder directly if it is deferred. In general, canvas hosts should not reach directly into resource provider's paint canvases. Bug: 1021321 Change-Id: I1f499218c6e58168d13b6fc88ad88d69b4435191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904266Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714954}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: I431823141a8d2affe9d9ac24b5e4964626166c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908924 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#714953}
-
Lukasz Anforowicz authored
There are multiple calls to GetOriginForURLLoaderFactory made from RenderFrameHostImpl::CommitNavigation. Instead of making these calls, we can make a single call early during CommitNavigation and store the result in a variable that gets reused later on. This refactoring has been suggested when code reviewing another CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1875273/15/content/browser/frame_host/render_frame_host_impl.cc#5420 It turns out that moving the GetOriginForURLLoaderFactory call earlier means that it also gets called for navigations to about:srcdoc. In this case the URLLoaderFactory should be inherited from the parent, so the origin calculated by GetOriginForURLLoaderFactory is not technically needed. OTOH, GetOriginForURLLoaderFactory should in the future calculate the origin to commit, and therefore we should make sure it correctly handles all the cases. In particular, without special-casing about:srcdoc, NavigationBrowserTest.BlockedSrcDocRendererInitiated* tests would hit a CHECK(...CanAccessDataForOrigin...) in GetOriginForURLLoaderFactory. This CL fixes this. Bug: 998247, 920634, 936310 Change-Id: I1ca851c8e574d24f05b4943f6bee186ebd50aa61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910865Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#714952}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c5ec54e51b91..06a394e036ab git log c5ec54e51b91..06a394e036ab --date=short --no-merges --format='%ad %ae %s' 2019-11-13 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-13 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-13 mbonadei@webrtc.org Use explicit template decl/def for RTCNonStandardStatsMember. Created with: gclient setdep -r src/third_party/webrtc@06a394e036ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I3c7b20e7733c19a86155b6d455484d508771f6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913653Reviewed-by:
-
Elly Fong-Jones authored
TBR=wjmaclean@chromium.org Bug: 1024028 Change-Id: I22a4a2bf37a28243f926b53c03e6ff4741494e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913864Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714950}
-
