- 20 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b19e9782ebef..ab2265ec86ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1068160,chromium:1077221,chromium:1083995 Tbr: sebsg@google.com,kmilka@google.com Change-Id: I76366a3169787c5c88fa8c17cfc680192fb9192e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770776}
-
Jesse Schettler authored
Remove CreateStatefulPartitionResult() since it is unneeded. Also, explicitly set relevant policies to ensure they are tested. Bug: None Change-Id: Ic81c99c34e357fb9978081b2337deb9fd96da323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209595 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#770775}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37c97e9aca20..7f02db5d3be5 2020-05-20 sigurds@chromium.org Make progress typescriptifying DebuggerModel 2020-05-20 rreverser@google.com Move wasm_source_map to ES module; update Rust+wasm tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233,chromium:1082720 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4137bee705e4b16507a055cfdd8d21a8cceb84a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770774}
-
Istiaque Ahmed authored
For the page that performs fetch, ensure it is controlled by the service worker before initiating fetch. This is ensured by waiting for oncontrollerchange event if navigator.serviceWorker.controller is null. Note that the worker claiming itself and messaging the page isn't enough, and causes flakiness. Bug: 1006129 Change-Id: I313bbc79e04bd162c8dbd302b61c9ced446be39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207861Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770773}
-
Joel Hockey authored
This object is needed outside of ash. Bug: 1083825 Change-Id: Id3ab099925ac6cee0810815eb377aa745b44e060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208883Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#770772}
-
David Tseng authored
Removes opening of web page which appears to be causing flakes according to logs. TBR=dtseng@chromium.org Fixed: 1065877 Change-Id: Ie80e84bfd1df56bff60d4d55292c3a8825c850d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210656Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770771}
-
Maksim Moskvitin authored
The previous implementation of key retrieval notification on Android didn't notify TrustedVaultClient about changed keys upon completion. In order to detect completion of key retrieval pending intent, this CL adds TrustedVaultKeyRetrievalProxyActivity that just launches the real key retrieval pending intent, detects its completion and notifies TrustedVaultClient about changed keys. This activity doesn't require the Chrome browser process to be running when the user taps on notification. In order to avoid too many pending intents being created for this notification it's not allowed to create a new notification if one is already exists or being created. To ensure that newest real pending intent used for new notification, this CL also populates FLAG_UPDATE_CURRENT into PendingIntentProvider for Sync notifications. Bug: 1071377 Change-Id: Ibba3c9f02aa0bd233c128d98aa194f781a49d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179547 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770770}
-
Dirk Pranke authored
I'm switching to using just my @google.com account everywhere. R=pinkerton@chromium.org Change-Id: I06ee1b3a7068107f71de4b6072f9ca0585dbd8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207588Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770769}
-
Martin Kreichgauer authored
CreateAuthenticator() relies on VirtualAuthenticator IDs being unique, which they are. But if they weren't, it would first dereference and then return a dangling VirtualAuthenticator pointer. Since a similar code piece has recently shown that same bug, make this method more defensive so it doesn't regress under future changes. Also fix a possible nullptr dereference. Change-Id: Ia769929f94360eabcdadb5e0f706f83d031231f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209905 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#770768}
-
Shengfa Lin authored
After setting window bounds, could potentially wait for 1 second using retries for window state to reflect. Bug: chromium:1068467 Change-Id: I94cd7919487dcda3faf3b39b87b9378057bb192c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209898 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770767}
-
Dale Curtis authored
R=tguilbert Fixed: 1084886 Change-Id: I544bef88c9b727b4fa1e6f0672fb396200a1b957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209904 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#770766}
-
Michael Achenbach authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc0292ca..aea6c4ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org Change-Id: I1bfdc3e0bf15b991ec2b4d0a93432318805991ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210444Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#770765}
-
Avi Drissman authored
FileChooserImpl is-a WebContentsObserver, which violates layering. Move it to web_contents where that’s OK. Bug: 1076947 Change-Id: I62d97a0b2a85cc370b252627df1ad94fe8c711b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202787 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770764}
-
Yue Zhang authored
This reverts commit 2808b517. Reason for revert: Add missed dependency. Original change's description: > Revert "Add simple info bar to opt-out for conditional tab strip" > > This reverts commit e4d36bfb. > > Reason for revert: breaks download stream compile, might be build issue. please do "gn check target". > > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout > > Original change's description: > > Add simple info bar to opt-out for conditional tab strip > > > > This CL adds an info bar for conditional tab strip to allow user to > > opt-out the feature. Some behavior of the info bar: > > > > * It will show after three consecutive sessions of dismissals. > > * If user clicks the "Don't show again" button, conditional tab strip > > will never show for this user in later sessions. > > * If user clicks the "Show later" button, conditional tab strip > > will show again for this user in later sessions, and the info bar will > > never reshow. > > * If user clicks the dismiss button to dismiss the info bar, the info > > bar will reshow after another three consecutive dismissal, but the > > limit times of info bar showing is two, i.e. 6 consecutive sessions of > > dismissal. > > * When the info bar shows, the undo snackbar will not show. > > > > Note that this is the simple version of info bar that we want, in that > > it is tied to one tab and cannot live across tab navigation. > > > > Bug: 1076295 > > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770632} > > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org > > Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1076295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770647} TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1076295 Change-Id: I89ec83eb3211a090f8e21004418eede65330959d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209902 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770763}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/503f81b8fe09..ae2ed9f992e1 2020-05-20 sadrul@chromium.org Revert "[Telemetry] Add LocalFirstBinaryManager" 2020-05-20 fancl@chromium.org sheriff-config: Increase per instance resources 2020-05-20 bsheedy@chromium.org [Telemetry] Add LocalFirstBinaryManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054583 Tbr: sadrul@google.com Change-Id: I9ca69e4918353a651f41dee0367fcee5ea85dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770762}
-
Sophie Chang authored
Bug: 1085065 Change-Id: I7d702ecc4d44bcea29172de8b6b6eb359915feb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209604Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770761}
-
Matt Reynolds authored
On Linux, the physical device ID is the sysfs path of the device that best represents the physical device connected to the system. For USB and Bluetooth devices, this is a device node that represents the entire physical device as opposed to one particular HID interface exposed by the device. For some devices, this cannot be determined because the device driver does not expose the information or the device is not physical. For these cases, the sysfs path of the HID interface is used instead. BUG=1011499 Change-Id: Ia887baa3dd78c0132d6e9fa0d37791941cd17bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966499Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#770760}
-
Li Lin authored
CLD3 is the on-device language detector. The surrounding text is not sent to server. Bug: 1084381e Test: manual test Change-Id: I9f12151847122c30352883607ac724c45d5001b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207859Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770759}
-
Taylor Bergquist authored
Bug: 1082755 Change-Id: Id8e174625f16e9a319000eb7427ec8659174c7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204259 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770758}
-
rbpotter authored
Bug: 1048812 Change-Id: I1afeb8a40e320b05a3dcc56d89584b3e65eac968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209600Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770757}
-
Miriam Polzer authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/69985fadf06b..2b37f52a06d9 $ git log 69985fadf..2b37f52a0 --date=short --no-merges --format='%ad %ae %s' 2020-05-06 mpolzer system_api: Add powerwash flag to update status 2020-04-21 clarkchung platform2: run gn format BUILD.gn and *.gni 2020-05-14 akhouderchah shill: Remove unused OfflineMode property 2020-05-10 ahassani dlcservice: Make install single DLC only 2020-05-12 acostinas system_api: Update System-proxy proto 2019-12-25 dtor system_api: introduce VM_ERR_SRV_SHUTDOWN_IN_PROGRESS for Plugin VM 2020-04-28 chirantan system_api: Add uid/gid map fields to seneschal's StartServer proto 2020-05-07 akhouderchah system_api: hermes: Update D-Bus interfaces/paths 2020-05-04 yichengli cryptohome: Add fingerprint auth session methods to userdataauth 2020-05-01 yichengli cryptohome: Add DBus methods to start/end fingerprint auth session Created with: roll-dep src/third_party/cros_system_api Bug: 1070563 Change-Id: I911bb7374142ca4fdec338983ca15d544471cfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210356 Auto-Submit: Miriam Polzer <mpolzer@google.com> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770756}
-
Yury Semikhatsky authored
Schedule deletion of pipe IO threads in a way that doesn't trigger DCHECK in base::DeleteSoon (https://source.chromium.org/chromium/chromium/src/+/master:base/task/post_task.h;l=246). Bug: none Change-Id: Icba9fd2bebc9e8c30fee36864417a5ad161feca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210621Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#770755}
-
Natalie Chouinard authored
HyperlinkPreference is only used by About Chrome > Legal information settings screen, and is not going to be modularized as a shared component (see https://crbug.com/1044685#c1), so moving it alongside the code where it's used. Bug: 1044685 Change-Id: Icbd6f9cee42800bbd217b59816c1c49470f79a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210664Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#770754}
-
David Bokan authored
These metrics were being called with the histogram name based on a conditional. This is a bug since the macro caches the histogram name. This CL updates these calls to use a compile-time constant for each call of the macro. Bug: 1085032 Change-Id: I0b4f4ddec8dae1aa6337e8e6081ce636d04d1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210006Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770753}
-
David Tseng authored
This change plumbs through a new member array<AXEventIntent> event_intents into AXTreeUpdate. Background Accessibility in Blink surfaces two primary streams of data: 1. tree updates 2. events Within Blink itself, these two streams are actually the same and thought of as an event. For example, a text selection changed event can occur when a text field caret moves. Recently, Blink started surfacing more metadata about events; namely, event intents. Within content/renderer/accessibility, we decouple the event from the tree update. Here, the event is placed into an array of events, and separately, an array of tree updates are generated for each event. However, these two separate arrays are forever decoupled after this point, so any consumers of the data further down the line (e.g. within the browser, in extension renderers) cannot associate a tree update with an event again. As a result, we have to associate event params with both tree updates and events at the above layer. Previous changes have already wired up some metadata about events into both events and tree updates. (e.g. event from). However, event intents have only thus far been associated with events, but not tree updates. This unfortunately means we're losing information about each tree update. Namely, the event intents which generated the tree update. R=dmazzoni@chromium.org, nektar@chromium.org AX-Relnotes: Fixes an issue where ChromeVox reads the entire line when pressing left or right arrow. It now reads the character to the right. Bug: 989156 Test: manually verify ChromeVox reads the next character when moving from line to line via left/right arrows. Change-Id: I0efbf8f5d6afcd4bf86e51219e0b8e8c903ce94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203658Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770752}
-
Karandeep Bhatia authored
BUG=None Change-Id: Ia758064db72c5c58b86df4764a94e2430f23b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210781 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#770751}
-
David Tseng authored
Mostly speculative; run locally release/debug with 20 parallel processes e.g. testing/xvfb.py out/d/browser_tests --gtest_filter=ChromeVoxOptionsPageTest.NumberReadingStyleSelect !! & !! & !! ... TBR=dtseng@chromium.org Fixed: 1052175 Change-Id: If574b244b07fd67ab3303974f554193dfd64659a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209999Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770750}
-
Bailey Berro authored
The former logic was susceptible to rounding errors when the aspect ratio of the current display mode did not perfectly match the aspect ratio of the display's native mode. The former logic was unnecessarily strict because all we need to determine the order of the dimensions must be flipped is to check whether the longer edge of the current mode and native mode are the same edge or not. Bug: 1085064 Change-Id: I86d4f4fb77098f1a034e0bc62671a7aa1cd62e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210008 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#770749}
-
Sammie Quon authored
As requested from UX in the bug, if the window has restore bounds the formula (cursorX - appX) / appWidth should yield the same results. That is, after restoring and dragging: ratio = (initCursorX - initAppX) / initAppWidth restoreX = cursorX - ratio * restoreWidth The bug also mentions the width of the control buttons, though that is skipped in this CL due to such an API not existing and the complexity (many different frames for different apps). Test: manual Bug: 1082839 Change-Id: Iceb41389fc8226f1c5286b7370a4d9b8029ed652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208098 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#770748}
-
Toni Barzic authored
BUG=1085130 Change-Id: Iff53ea98b0665fb082e39d27675dbdf6ad2c4c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210737Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#770747}
-
Jesse Doherty authored
Change-Id: I895eeb2d83e4ad3dc14cafd8c6e11c09a0c9d465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184951 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770746}
-
Dominique Fauteux-Chapleau authored
This reuses tests by having the policy setters of DeepScanningBrowserTestBase set either legacy or Connector policies, and then making every upload browsertest parametrized with a bool so both policy sets get tested. The DeepScanningDialogViews test also change a bit, the ScanType test parameter is removed since this dialog doesn't depend on the type of scanning being done. This avoids having a very large number of combinations for that test that don't cover different code paths. Bug: 1076083 Change-Id: I419b21de0095add8b5b214993be010d022941202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210782Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770745}
-
Adrian Taylor authored
On Android and iOS platforms, we do not currently pin TLS connections, so verifying Variations payloads is important to ensure that the data has not been tampered with in transit from Google to the device. Such verification of these payloads on mobile devices previously added 25ms to process startup; modern mobile devices are much quicker and we do not anticipate such an impact but we will assess on the perf bots. Unfortunately we can't delete the SignatureVerificationEnabled() call entirely because it's still needed in order to disable signature verification for unit tests. This would be hard to solve because unit tests would need to simulate the real signing procedure of the variations servers, using their private key. This may be worth further investigation in future (e.g. using a different key pair for unit tests) as it would allow removal of quite a bit of production code. Change-Id: I9cb89750e100bf7204140920583db8bd0fa0f41a Bug: 1078056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181564 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770744}
-
Bo Liu authored
Webview tests does not run on the cq L bot, and these tests are flaky on the non-cq L bot because the trick to remove the reference from InputMethodManager does not appear to work on L. It's fine as long as there is some cq bot running these tests, so just disable them on L. Bug: 1085101 Change-Id: Iedff862ca0d6ee53b62879ac1e6f688fbc1d4123 Tbr: torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210787Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770743}
-
Ken Rockot authored
I've left myself in OWNERS of some specific device APIs just to share the load with other owners there, but it seems like there is diminishing value in having me own the broader extensions/ dir given my waning familiarity with the system. Bug: None Change-Id: I502d6ae4f61ba9b5cadf1bdc083b53d6160b9891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210624 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770742}
-
Bettina authored
Increasing the deadline for this metric as we are making changes to CSD model so want to keep the metric for regression sake. Bug: 1072672 Change-Id: I8ea89a9a1b280ee6deb81374d62c3dd57dfabc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207956Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#770741}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7d8cbfcebb1d9fe51601e36dd95df13bace71aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49de1031d4d8..c5eb5c7127b2 2020-05-20 herb@google.com Cleanup text vertex structs 2020-05-20 robertphillips@google.com Update GrVkRenderTarget to store both stencil & non-stencil render passes (for real) 2020-05-20 johnstiles@google.com Add workaround 'fDisallowDirectRG8ReadPixels' for Radeon Pro 5000 GPUs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Iee1480cc080d48e033d7d7dbe3d648d522e4b977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770739}
-
Dave Tapuska authored
With Frame, Widget and Synchronous mojom definitions no longer dependent on content types it can now move into blink. Eventually the implementation will move as well. BUG=1073560 Change-Id: I1c567c3a7f1a8eb1e9d2567b4eee71d3b81de38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204308 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770738}
-
Xianzhu Wang authored
Remove the extra baseline that was produced when the test flakily failed. The flakiness has been fixed by another CL. TBR=clamy@chromium.org Bug: 1084448 Change-Id: Ic7d01deeea6d0ca3511f572808d2e16ec6237550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210622Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770737}
-