- 14 Jan, 2021 26 commits
-
-
Hiroshige Hayashizaki authored
Previously, second successful import map was rejected during registration. It didn't trigger error events, and the second import map wasn't rejected if the first import map had errors. This CL follows https://github.com/WICG/import-maps/pull/242 and changes these behavior (the second import map is rejected with an error event no matter whether the first import map has errors). This CL also introduces Modulator::AcquiringImportMapsState, just for better error messaging. Bug: 848607 Change-Id: Iadfc59dc0ae9b64262908dbf27d44a4c24a74c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618838Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#843277}
-
Francois Doray authored
[sheriff] Disable core.benchmark_runner_test.BenchmarkRunnerIntegrationTest.testTimelineBasedEndToEnd on ChromeOS. R=achuith@chromium.org Bug: 1098412 Change-Id: Ib19a9a0e93339c2a5e3aff75897cff8a2ebbe9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626410 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#843276}
-
Jeffrey Kardatzke authored
This feature is launching with M89, so we need to enable it by default now. The code that uses this feature check has other build flags around it to limit it to the platforms that actually support it. BUG=1146646,b:153111783 TEST=HWDRM is used by default w/out setting flag Change-Id: I836c71ec2ba5752b737d6aef76c825f0dcf5fc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627168Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843275}
-
David Bokan authored
This Blink RuntimeEnabledFeature was previously used to enable this opt-out for the TextFragment (and other kinds of load-time scrolls) feature using an Origin-Trial. The feature shipped for real as part of Document-Policy and the Origin-Trial has been wound-down. This CL removes the no longer needed RuntimeEnabledFeature. Bug: 1047900 Change-Id: Ie8e8180aae6a9d76e4626eb2d5c8e4b3a9fb582c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622240 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843274}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e0ef215f6da..9b5dd7ab8a98 2021-01-13 vapier@chromium.org repo: upgrade to v2.11 2021-01-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib83a0812a752852364928a9ac9beec1bc43a379a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843273}
-
Luciano Pacheco authored
This is a follow up to the changes in the interfaces: CL:2613848. Remove launcher from BackgroundWindow and add launchFileManager() to FileBrowserBackgroundFUll. Move registerDialog() from BackgroundWindow to FileBrowserBackgroundFUll. Removed the class FileBrowserBackground and merged its content in FileBrowserBackgroundFull. This distinction it's only relevant for other apps (Gallery, Audio and Video Players). For Files app only the "full" version is relevant. NOTE: This file isn't checked by Closure compiler, so there is no automatic check if these implementations adhere to the interface. Test: Checked manually that loading the SWA doesn't produce any JS error in the console. Bug: 1113981 Change-Id: Ie0b792e7c88db908c2939723df14c7b713eddfe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617407 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843272}
-
Robbie McElrath authored
This CL adds some missing dependencies to //chrome/services/cups_proxy, and moves ipp_parser_service.* to //chrome/services/ipp_parser/public because it needs to depend on code in the browser process, which targets in //chrome/services/ipp_parser shouldn't. Bug: 949535 Change-Id: Ia49760580de1dc6e8ff2e0c743fde0369d625084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583215Reviewed-by:
Luum Habtemariam <luum@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#843271}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ib1322083b9e0dca577b3ccb301be47a14fb875b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626521Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843270}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I63a44b2b2ac5a278dc902e9e010b4554f3d5c0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626003Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843269}
-
Domenic Denicola authored
This is a reland of 13fc65a6. It originally broke the build and was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2625916 due to a collision with https://chromium-review.googlesource.com/c/chromium/src/+/2589206. However, the sheriffs reverted *both* offending CLs, the latter in https://chromium-review.googlesource.com/c/chromium/src/+/2626099. So, now we just need to land them one at a time, properly rebased on top of each other. Original change's description: > Origin-keyed agent clusters: rename in Blink and plumbing > > 942aca88 performed the minimal updates > to the implementation to shift from "origin isolation" to "origin-keyed > agent clusters" for the web-observable API surface. This followup also > renames much of our internal implementation references to the concept. > > Specifically, it takes care of all the Blink-side infrastructure > supporting the window.originAgentCluster getter, as well as > document.domain restrictions. This includes all the navigation-params > plumbing to get the value from the browser process into the renderer > process. > > This does not yet tackle any renaming for code that is entirely within > the browser process. > > The only observable effect of this is changing the console warning > message for document.domain to mention "origin-keyed" instead of > "origin-isolated". > > Bug: 1158853 > Change-Id: I8feb507eee17db53e58b70e4ee5820c555ba962f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617583 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843082} Bug: 1158853 Change-Id: I11548beaf4c5615b71e12f5e2a76293b0226731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627996 Auto-Submit: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#843268}
-
Xing Liu authored
Reading list backend only supports http/https. We should hide the context menu entry point for invalid schemes. Also add the missing test for context menu. Bug: 1157808 Change-Id: I3a65626ca7d058211d9042e6d9069d9a73d47611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623649Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843267}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ia75100b4e4f620e5adbcfe2631899dcdfa9c0b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626052Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843266}
-
Mike Dougherty authored
The shared JavaScript files (base.js, common.js, and message.js) need to be moved to JavaScriptFeature instances in order to correctly establish dependencies within WKContentWorlds. This CL uses these new classes to inject the shared JavaScript. This CL has no change in behavior. Bug: 1042335, 1152112 Change-Id: Ie26fc65c1ddb3ee3ff6f4f626111159c243abc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612516 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#843265}
-
Gordon Seto authored
Add UI for invalid confirmation code state on confirmation code page and UI for 'No profile' state when the user comes from activation code page. Screenshot: https://screenshot.googleplex.com/PZgyBnE96aXgM4w.png Bug: 1093185 Change-Id: Ia12e1d57c78c9eb5b227efb396bce5d8a2c5403a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626072Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#843264}
-
Jesse Schettler authored
Update the done page to show the app title instead of replacing it. Also add text to indicate scanning is complete and a link to the scanned file(s). Before and after: http://shortn/_U80YRweWzm Bug: 1059779 Change-Id: I1bb500937677854a4c035b7f0dc9ab27156239f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625231Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#843263}
-
rbpotter authored
Warnings suppressed policy is no longer used in 88+, as cloud printing is deprecated. Add a separate policy for deprecating privet instead of re-using the warnings policy, to reduce confusion. Bug: 1144931 Change-Id: I99b10b222b37e91149f3936f7de8e16ed3c51047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617141 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843262}
-
Lily Chen authored
These are no longer needed. Bug: 1165012 Change-Id: I4c0c9bdf824359bc55686b67a293cf8203af6512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627694Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843261}
-
Bo Liu authored
Implement vulkan instrumentation shell. This requires dependency on gpu/vulkan for vulkan bindings and initialization, and skia for setting up pipeline and secondary command buffer to be passed to webview. The skia dependency is largely the same as hwui's implementation vulkan draw functor implementation. This requires one fix to VulkanSwapChain to not try to get the current TaskRunner on initialization. Webview's render thread does not have a TaskRunner. Also needed to plumb an explicit resize event to native ContextManager to resize the vulkan surface. Make sure to install draw_fn function table before calling AwBrowserProcess.start everywhere, so it can call query_render_mode on initialization. Add plumbing to allow test to choose to use vulkan, and add a test rendering test using vulkan. The test is limited to P+ and a hard coded list of supported devices. Verified the android-pie-arm64-rel bot can successfully run the test. Bug: 1141687 Change-Id: Id49b770728d993c7764d7dc044a3d990df5bef3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620539 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843260}
-
Sophie Chang authored
This reverts commit 1a291df2. Reason for revert: Some issues with Windows Original change's description: > Re-enable PredictionManager browser tests on Win/Mac/CrOS > > And fix init issue on ChromeOS for sign in profiles > > Change-Id: I26b87d58f2eae2afecf67685690312a8aed70c60 > Bug: 1146151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625157 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843176} TBR=sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4cb2f29850ebfe025ff9d3d016e2c1c31f4471de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626981Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843259}
-
Xiaoqian Dai authored
Bug: 1159111 Change-Id: I386eb512739a88b09b3703de400a03f7b77ba887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628036 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#843258}
-
Joe DeBlasio authored
This CL marks edit distance matches that only differ due to a single dash. This is a temporary mitigation for a large class of false positives until a DAL approach is able to offer better tools for domain owners. Fixed: 1159473 Change-Id: Ibe2f34b71ee219a01383b0d46937d2749ba50a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628073 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843257}
-
Bartek Nowierski authored
Bug: 1086388 Change-Id: Ifd280c58451c2730ac0a844a9c5e02c41d0baaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626697 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843256}
-
Dan Harrington authored
This removes Feedv1 from the build. Bug: 1165828 Change-Id: I9178d22a1c2929870e678b39d4e8da9b84d095cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624531Reviewed-by:
Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#843255}
-
Eric Orth authored
Similar logic is currently duplicated between DnsConfigServiceWin and DnsConfigServicePosix, and there would be even more duplication if DCSPosix is further split by platforms (as I intend to do in a subsequent CL). As HOSTS-reading logic is so similar between platforms, the base implementation is now able to do everything for the Posix platforms with just a simple constructor param to set the file location, and only minimal overriding is needed for Windows. Bug: 1157492 Change-Id: I1051580c891b8c86f46ac6d0b68f89c7b60244b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625348 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#843254}
-
Francois Doray authored
It was already disabled on Mac. Given that crbug.com/1163775 documents failures on Windows and Linux too, this CL disables it for all platforms. R=cyan@chromium.org Bug: 1163775 Change-Id: Ic80521a7879ed88eb8f62082bedc4368dabaecf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626780 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843253}
-
Caitlin Fischer authored
The study ended about five months ago. Filed crbug.com/1166263 for cleaning up the associated features. Bug: 1126640, 1166263 Change-Id: I9967fb96858460da5ce02e894176b0118b3165af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627092Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843252}
-
- 13 Jan, 2021 14 commits
-
-
Yue Zhang authored
Old fallback icon: https://drive.google.com/file/d/1P4EuaMFbiwqBASNa_L4-ku7e8qDW9TUW/view?usp=sharing&resourcekey=0-zS83XcqbTFlFDFvdJYvLFg New fallback icon: https://drive.google.com/file/d/18EHhQzDu9MO2Xts_16F2tg4ldVDWWn8J/view?usp=sharing&resourcekey=0-HppUS-6Mru9nk35DgfGImQ Bug: 1157892 Change-Id: I1ca918ab039b6bf9a11befef118d46b8bc99ce5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627437 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843251}
-
Jesse Doherty authored
This action is logged at the same time as RenderViewContextMenu.Used::IDC_CONTENT_CONTEXT_SEARCHWEBFOR. The value is used as part of a high-level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: Id084907ea8b00954b7a235385c7b9ec75d4d642f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628149 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843250}
-
Sam Thorogood authored
This will control whether we document a Promise-ified version of an API. (Chrome's implementation CPP already pierces into the JSON directly to answer the support Q.) Bug: 1142991 Bug: 1143020 Change-Id: I1a3c29c7d1c21cc52b55b88db12478e4b1e14811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569130Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sam Thorogood <thorogood@google.com> Cr-Commit-Position: refs/heads/master@{#843249}
-
Ben Mason authored
R=govind@google.com Change-Id: If1a77000b27fb1e818d46e66706cba92fb57fc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625997 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#843248}
-
Tom Sepez authored
A DCHECK() here isn't sufficient to prevent the use of uninitialized memory should this someday return false. Bug: 1166091 Change-Id: I4cfd28653f2e6882f227299d68605be706b75b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628044Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843247}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I81efe729e921c24db6662daa2c1f87f4d36c73c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626515Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843246}
-
Jeffrey Kardatzke authored
There are downscaling limitations on overlays. When we have reached this limit, rather than failing to promote to an overlay, we clip the content so that the scale factor is within the allowed range. This is more visually appealing than blacking out the quad instead. When doing this we track the range of the max value that worked and the min value that failed. When we first hit a failure, we iteratively increase the value until we have success to find the initial lower bound. Subsequent tests will almost always hit on the first retry. BUG=b:155511837,b:174174828 TEST=Protected content renders w/ clipping when downscaled too much Change-Id: Icf294de47e396fd760f77e9d93b18894c275a1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622762Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843245}
-
David Roger authored
IDS_SIGNIN_DICE_WEB_INTERCEPT_CONSUMER_BUBBLE_DESC Elisa is already signed in to this Chrome profile. To keep your browsing separate, Chrome can create your own profile for you. https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V1 Continue in a new Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/d1425d72f32531ab6ad2d1787e2a0c5e20837f91 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V2 Move account to a new Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/e1b3d8f599d8e554b4efa2b85e2289020e17f846 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V3 Separate Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/7d40a8bbb90c63280555096b5ddf7c3edda5e105 IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_DESC A Chrome profile with this account already exists https://storage.cloud.google.com/chromium-translation-screenshots/88c3cc7489c08fffe78b92d0d10ffef32d9c88cf IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_DESC_V2 Bob's profile is linked to bob@gmail.com https://storage.cloud.google.com/chromium-translation-screenshots/7b055dcacda680767b62c358a4fd5ffe2f913014 Note: not used in code now IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_TITLE Switch to existing Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/88c3cc7489c08fffe78b92d0d10ffef32d9c88cf IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_NEW_PROFILE_BUTTON_LABEL_V2 Continue https://storage.cloud.google.com/chromium-translation-screenshots/fc87331e840b0ff507e4778b3cf5c0e870683270 Note: not used in the code for now. IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_CONFIRM_SWITCH_BUTTON_LABEL_V2 Continue https://storage.cloud.google.com/chromium-translation-screenshots/7b055dcacda680767b62c358a4fd5ffe2f913014 Note: not used in the code for now. IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_CONFIRM_SWITCH_BUTTON_LABEL Ok https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_NEW_PROFILE_BUTTON_LABEL Ok https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_ENTERPRISE_BUBBLE_DESC This will separate your browsing from bob@example.com https://storage.cloud.google.com/chromium-translation-screenshots/d1425d72f32531ab6ad2d1787e2a0c5e20837f91 Change-Id: I7bbdaddb79084b42005e16c50b100c79f3b4ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626658 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843244}
-
Robert Sesek authored
This will record the ARM CPU's implementer and part number values. Bug: 1164549 Change-Id: I09ea0d852fda6b05c50a16b64bfcde6f4f5f62b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615326 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#843243}
-
Hui Yingst authored
This CL changes BackgroundPart::location from pp::Rect to gfx::Rect so that `background_parts_` can be migrated to PdfViewPluginBase later. Bug: 1101101 Change-Id: Ib2ab5ab6cfb4c58bde3a2a4e71fd2886231a8a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625088 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843242}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/111ba65a5e3d..8ba0a01d1e59 2021-01-13 enga@chromium.org Ensure all wire child objects are destroyed before their device 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 395ec2c4aed8 to 313ae9e87f37 (1 revision) 2021-01-13 bclayton@google.com [wgsl]: s/texture_sampled_/texture_ 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 57166264e01f to 395ec2c4aed8 (2 revisions) 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1c200cffd051 to 57166264e01f (4 revisions) 2021-01-13 enga@chromium.org Remove special-casing of device reference/release in the wire 2021-01-13 enga@chromium.org dawn_wire: Make all objects owned by the client 2021-01-13 enga@chromium.org Make the Device ref the Instance 2021-01-13 enga@chromium.org Don't forward device lost errors to the uncaptured error callback 2021-01-13 cwoffenden@gmail.com Further fixes to build with with VS2019 (end2end tests) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 1c200cffd051 to 313ae9e87f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1160459 Tbr: dsinclair@google.com Change-Id: I454d4c075a8abb7a910a0d4043c35359db8b88f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e3d4af7bd5f..20d3823787dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mpearson@google.com,fdoray@google.com Change-Id: If5140533dff51315e5f24698e316c359d8735336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627292Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843240}
-
Sylvain Defresne authored
The code responsible for the creation of the regular and incognito Browsers was duplicated. Introduce an helper method that creates a Browser associated with a BrowserState and sets it up, then change BrowserViewWrangler to use this method for creating both Browsers. Bug: 1165798 Change-Id: I7a02f7fb8bc3e724ee9064a29956ecd316074e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627318 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 742358cf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7dbe53f34a9d563adbc9195d0d268e102a50ba01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627249Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843238}
-