GitLab

BUG=none
TEST=Verify clicks don't close sub-pages when an overlay is visible.
Review URL: http://codereview.chromium.org/6375006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiled and viewed under linux.

Review URL: http://codereview.chromium.org/6222004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72027 0039d316-1c4b-4281-b951-d872f2087c98

Long cookie contents will now wrap earlier than they need to. CSS really doesn't want to do what we want (wrap the text at the inherited width, or anything except a hardcoded width). So I set the width to be narrower (300 instead of 520) and also set the table's layout to fixed, so that even if 300 is too wide the whole table won't overflow.

BUG=69447
TEST=LANGUAGE=fr_FR ./out/Release/chrome

Review URL: http://codereview.chromium.org/6327013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72026 0039d316-1c4b-4281-b951-d872f2087c98

If the gpu process dies, CommandBufferProxy might be the first one to find out about it.  When the context is being created, GpuChannelHost still thinks there is no error.  It will send CreateViewCommandBuffer message to establish a communication channel, which will fail, and GPU process will not restart.  To prevent that, we set GpuChannelHost state to lost as soon as CommandBufferProxy finds out about it.

BUG=58785
TEST=open a composited tab, in another tab go to about:gpucrash

Review URL: http://codereview.chromium.org/6384003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72023 0039d316-1c4b-4281-b951-d872f2087c98

 This change makes the textfield uneditable. The text can
still be updated via API (which is necessary to show URL
in popup).

BUG=none
TEST=uadded new ReadOnlyTest

Review URL: http://codereview.chromium.org/6314012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70280
TEST=none

Review URL: http://codereview.chromium.org/6338012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6265016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:430
TEST=try bots (win, linux, linux_chromeos); tested on device

Review URL: http://codereview.chromium.org/6268008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72017 0039d316-1c4b-4281-b951-d872f2087c98

Fix for:
themes.py:106: SyntaxWarning: assertion is always true, perhaps remove
parentheses?

Review URL: http://codereview.chromium.org/6309009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72016 0039d316-1c4b-4281-b951-d872f2087c98

But OrphanJob() call job_->Kill() internally, so first Kill() call 
in PrepareToRestart() is not needed. 
This changelist remove the duplicated Kill() call. 

BUG=chromium:69937
TEST=pass net_unittests.

Patch provided by toyoshim@google.com.
Original review: http://codereview.chromium.org/6373002/


Review URL: http://codereview.chromium.org/6250021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72015 0039d316-1c4b-4281-b951-d872f2087c98

We were previously doing this pretty late in Chrome's
shutdown process, which resulted in the closing of
individual browser windows often being visible onscreen.

This change makes us send the message before closing any
windows (at least in the
no-beforeunload-handlers-or-downloads case) and flushes the
Xlib request queue to make sure that the message won't sit
around until the next time that we process events.

Note that there are still cases where beforeunload handlers
aren't registered but we still won't close the window
without warning and hence still show the flip through the
windows.  See RenderViewHost::sudden_termination_allowed_.

BUG=chromium-os:9915
TEST=opened a bunch of windows and checked that we fade to black and hide the cursor immediately on ctrl-shift-q and wrench->sign out.  also tested that we don't fade out until the dialog is closed with an affirmative response when http://goo.gl/gzMdN is open

Review URL: http://codereview.chromium.org/6353001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68682
TEST=compiles

Review URL: http://codereview.chromium.org/6382003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72013 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam
BUG=70291
TEST=none

Review URL: http://codereview.chromium.org/6313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72012 0039d316-1c4b-4281-b951-d872f2087c98

Fixing test testBlockPluginException
Sometimes we fail to retrieve the shockwave flash process id.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6260015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6352001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=TabSpecificContentSettingsTest.EmptyCookieList

Review URL: http://codereview.chromium.org/6352005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72009 0039d316-1c4b-4281-b951-d872f2087c98

R=willchan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6368010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:7473
TEST=none

Review URL: http://codereview.chromium.org/6280009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72007 0039d316-1c4b-4281-b951-d872f2087c98

- New APIs:
  - Add a "visible" property to the Layer class to mimick the visible property of the Transform class.
  - Add a method to set an affine transform on Pattern objects so that texture patterns can be transformed independently from the Layers that use them.
  - Add a "paint operators" API for Layers and define four operators (currently only three of them implemented). The previous hard-coded behaviour was equivalent to the BLEND_WITH_TRANSPARENCY operator.
- Fixes:
  - Replace the "mask" nomenclature with "clip", which is a more standard name.
  - Don't clip alpha-blended layers.
  - Restrict Layer painting to the rectangle defined by the attributes.
  - Set default alpha value to 0.0 instead of 1.0 to match what JavaScript expects.

TEST=loaded O2D and verified all new functionality is working
BUG=none

Review URL: http://codereview.chromium.org/6255003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69797
Review URL: http://codereview.chromium.org/6304013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=PersonalDataManagerTest.*, AutoFillManagerTest.*

Review URL: http://codereview.chromium.org/6286003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72004 0039d316-1c4b-4281-b951-d872f2087c98

This CL disables implicit keyword accepting completely. The user can only
accept a keyword by pressing Tab or space explicitly while the keyword hint
UI is visible.

BUG=60972
TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.AcceptKeywordBySpace

Review URL: http://codereview.chromium.org/6252003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72003 0039d316-1c4b-4281-b951-d872f2087c98

This allows touch devices to be grabbed when events from the mouse/keyboard are
grabbed. This also exposes TouchFactory, which will eventually be used in more
places.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71879

Review URL: http://codereview.chromium.org/6300007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72002 0039d316-1c4b-4281-b951-d872f2087c98

Fix build!

BUG=none
TEST=none
TBR= alekseys@chromium.org

Review URL: http://codereview.chromium.org/6269013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72001 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r71998. It was committed by error by the commit bot.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6351011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72000 0039d316-1c4b-4281-b951-d872f2087c98

Native ConstrainedWindows are invisible upon creation on Windows.  Mark the
associated NonClientView as hidden to keep the visibility state in sync.

BUG=69673
TEST=none

Review URL: http://codereview.chromium.org/6261015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71999 0039d316-1c4b-4281-b951-d872f2087c98

preparation for experimenting with them to gpu-accelerate various aspects of
chrome's drawing. In this initial patch, the files will be built, but not
called.

TEST=be sure that page rendering, and <canvas> rendering, look the same as before

Review URL: http://codereview.chromium.org/6357006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=focusing the omnibox, then touching a textfield in a webpage shows the
keyboard, but keys don't go to the textfield.
TEST=see bug

Review URL: http://codereview.chromium.org/6312009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71997 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony

Review URL: http://codereview.chromium.org/6254013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71996 0039d316-1c4b-4281-b951-d872f2087c98

R=tony
BUG=69592

Review URL: http://codereview.chromium.org/6325012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71995 0039d316-1c4b-4281-b951-d872f2087c98

When StopRecognition is invoked and no data was recorded, there is a possibility that the delegate
might release the recognizer within the DidCompleteRecognition callback. So we now perform cleanup
tasks such as freeing the encoder_ object before invoking the delegate. Without this change there
would be an assert in the SpeechRecognizer dtor about encoder_ remaining valid.

BUG=none
TEST=Manual, double-click on the speech button quickly a few times and verify no assert pops up in the dtor.

Review URL: http://codereview.chromium.org/6381004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71994 0039d316-1c4b-4281-b951-d872f2087c98

  "sidebar": {
    "default_url": "",
    "default_title": "",
    "default_icon": ""
  }

Allow extension to access experimental.sidebar API only in presence of this section.

BUG=51084
TEST=unit_tests, ExtensionManifestTest.Sidebar

Review URL: http://codereview.chromium.org/6321006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61745
TEST=in progress

Review URL: http://codereview.chromium.org/6247013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9256
TEST=Verify web widgets (aka form controls) look close to the mock in chromium-os:9256.

Review URL: http://codereview.chromium.org/6247012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71991 0039d316-1c4b-4281-b951-d872f2087c98

Changing the behaviour of DOMStorageMessageFilter so that receiving invalid messages does not terminate the renderer.

For background, see remarks in the associated bug.

BUG=69729
TEST=None

Review URL: http://codereview.chromium.org/6342011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71990 0039d316-1c4b-4281-b951-d872f2087c98

broken in r71858.

BUG=70244
TEST=manual (in and out of --kiosk)

Review URL: http://codereview.chromium.org/6343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=thakis


TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/6287006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71987 0039d316-1c4b-4281-b951-d872f2087c98

Add gpu/ files from the public skia project into the chrome build. This is in
preparation for experimenting with them to gpu-accelerate various aspects of
chrome's drawing. In this initial patch, the files will be built, but not
called.

BUG=none
TEST=be sure that page rendering, and <canvas> rendering, look the same as before

Review URL:  http://codereview.chromium.org/6357006


TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/6329014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Pepper Flash, PPAPITests

Review URL: http://codereview.chromium.org/6261017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71985 0039d316-1c4b-4281-b951-d872f2087c98

The |WebViewClient::didAcceptAutocompleteSuggestion| method is no longer dispatched from the WebKit side, and had been replaced by |WebViewClient::didAcceptAutoFillSuggestion|.  The PasswordAutocompleteManager had not been updated to account for this.  Those updates are made in this patch.  Follow up is to remove the |WebViewClient::didAcceptAutocompleteSuggestion| method from WebKit.  Also, the |PasswordAutocompleteManager::FrameClosing| method was not getting properly dispatched to perform cleanup tasks.  This is fixed now.

BUG=68681
TEST=PasswordAutocompleteManagerTest.SuggestionSelect

Review URL: http://codereview.chromium.org/6262008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71984 0039d316-1c4b-4281-b951-d872f2087c98