GitLab

Previously, out of process calls to AssistantScreenContextController and
AssistantSetupController were proxied through AssistantController. Now,
we expose those subcontrollers directly for binding.

Bug: b:119272394
Change-Id: I136d0e025761b4fe99151218512f83eeb00a6541
Reviewed-on: https://chromium-review.googlesource.com/c/1327532
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611327}

- When suggestions are shown,
- When a suggestion has been selected.

Added UMA histograms, and extended unit test coverage of some metrics.

Also tested manually by looking at local histograms after playing around a test page.

Bug: 907902
Change-Id: I5f7a363416d3c0c4b7e1b44a782d5205ed7a6787
Reviewed-on: https://chromium-review.googlesource.com/c/1352331Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611326}

https://chromium.googlesource.com/angle/angle.git/+log/5552cdf032dd..4f2b94cb9a6b


git log 5552cdf032dd..4f2b94cb9a6b --date=short --no-merges --format='%ad %ae %s'
2018-11-27 geofflang@chromium.org Expose EXT_color_buffer_half_float if RGBA16F is renderable.
2018-11-27 jiajia.qin@intel.com ES31: Add swizzle support in SSBO (Part 1)
2018-11-27 jdarpinian@chromium.org WebGL, D3D: Forbid multiple TF outputs in one buffer


Created with:
  gclient setdep -r src/third_party/angle@4f2b94cb9a6b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866089
TBR=fjhenigman@chromium.org

Change-Id: I2f9f64d4e1a188df1612ecfb8c66b6129dc5a202
Reviewed-on: https://chromium-review.googlesource.com/c/1352244Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611325}

Bounds passed over mojo should be in Screen coordinates since
Chrome and Ash do not share a common window tree in Mash.

For comment-only change to keyboard_controller.mojom:
TBR=tsepez@chromium.org

Bug: 843332
Change-Id: I40cee828ee5872cf69c4589141a9bb79c7c08cee
Reviewed-on: https://chromium-review.googlesource.com/c/1351801
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611324}

I also added a unit test for occlusion tracker pause during
overview transition.

Bug: None
Test: covered by unittests.

Change-Id: I5e8441e176eaa0dc9793d22059edb22e357d899e
Reviewed-on: https://chromium-review.googlesource.com/c/1344888
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611323}

If there are no visible app windows, restoring app window wasn't re-registering
events because OnWindowVisiblityChanged notification wasn't generated for root window.

Add unit test for going from visible to hidden to occluded.

Bug: 813093
Change-Id: I11b5fd7c7dc104ec74699c8e66aa06d9954a5977
Reviewed-on: https://chromium-review.googlesource.com/c/1326621
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611322}

Allowing overflow scrolling lets users with high page zoom
settings scroll across and down overflowing content.

Bug: 899774
Change-Id: I9bb6a8ea622b61c1d7b76d3cadb0f9be694fe4d3
Reviewed-on: https://chromium-review.googlesource.com/c/1343191Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611321}

This CL aligns the IDL with the spec. Intent to Ship:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ

Bug: 898768
Change-Id: I88dbc89d30aac7840c47d727d2ed3c8044452b68
Reviewed-on: https://chromium-review.googlesource.com/c/1352429Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611320}

Currently RenderWidgetHostViewAura allocates a new LocalSurfaceId upon
Navigation. However if this navigation is for a hidden view, then we are
allocating very early. This has skewed the statistics for embedding times.

This updates RenderWidgetHostViewAura::DidNavigate to Invalidate the
LocalSurfaceId if hidden. A new one will be allocated once the view is shown.

Bug: 655231
Change-Id: I86cc4efade8b927149f57323281a87b0dcd1aac3
Reviewed-on: https://chromium-review.googlesource.com/c/1347446
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611319}

This is to ensure the memory is properly released on the GPU process side.

Bug: 905495
Change-Id: I152494878a602e748eefb29f0f91f364e6752e42
Reviewed-on: https://chromium-review.googlesource.com/c/1347355
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611318}

This ensures that that token is always at the end of
a token chunk. This is important because the parser can
only yield or pause at token chunk boundaries. Pausing
may be forced by a custom element because its createdCallback
routine may add a stylesheet, which blocks the HTML parser.

Bug: 904966

Change-Id: I9252067f435d048b860cc9725ba23d829c9f644d
Reviewed-on: https://chromium-review.googlesource.com/c/1351366Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611317}

https://skia.googlesource.com/skia.git/+log/4f83c59eea19..09523b43fc28


git log 4f83c59eea19..09523b43fc28 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4ad2322aa9cf..67c93d206431 (1 commits)
2018-11-27 mtklein@google.com Reland "move decal_filter_scale inline, walk decal in 32.32""
2018-11-27 brianosman@google.com Remove tonalshadows GMs
2018-11-27 reed@google.com Revert "migrate to passing paint/ctm for bounds"
2018-11-27 borenet@google.com [infra] Blacklist another SKP for IntelHD405 Vulkan perf bot
2018-11-27 mtklein@google.com Revert "move decal_filter_scale inline, walk decal in 32.32"
2018-11-27 michaelludwig@google.com Reland "Optimize trivial per-edge aa rect tessellation"
2018-11-27 mtklein@google.com move decal_filter_scale inline, walk decal in 32.32


Created with:
  gclient setdep -r src/third_party/skia@09523b43fc28

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I4c858d036efb7c4ed9c94a64b17c2e563594b677
Reviewed-on: https://chromium-review.googlesource.com/c/1352241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611316}

Test bless.html on a local linux machine and all test runs passed. Thus remove bless.html from the TestExpectation file.

Bug: 875249
Change-Id: Ic5de42921e496e199b3be79e9920e5366205e9ee
Reviewed-on: https://chromium-review.googlesource.com/c/1351599
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611315}

This CL removes macro usage from /ios/chrome/browser/itunes_urls.

This CL was uploaded by git cl split.

R=mrefaat@chromium.org

Bug: 589840
Change-Id: I38d1ef88b752deda3e77f02fdb7208ddc13cd214
Reviewed-on: https://chromium-review.googlesource.com/c/1351964Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611314}

Read $policy_dir/enrollment/CloudManagementEnrollmentOptions file. If it
contains 'Mandatory', then the enrollment is forced.

Bug: 904983
Change-Id: I44452f1c016a0432bf541b3ee6605f24ec3898ff
Reviewed-on: https://chromium-review.googlesource.com/c/1349773
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611313}

Also, enables Option-Up and Option-Down on the Mac.
R=sky@chromium.org, aleventhal@chromium.org, dmazzoni@chromium.org, pboss@chromium.org

Change-Id: I78b32b170e4600c14faf81fdfb1850bb0a720cd6
Bug: 908522
Reviewed-on: https://chromium-review.googlesource.com/c/1337819
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611312}

This CL removes macro usage from /ios/web/public/test.

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 589840
Change-Id: I507c145fbe39d32120bec413834873ed2d92604e
Reviewed-on: https://chromium-review.googlesource.com/c/1351963Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611311}

Bug: 898326
Change-Id: Ife17e6b2ce3ad21d5049377318a8e14c70e5ec98
Reviewed-on: https://chromium-review.googlesource.com/c/1351591
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611310}

Bug: 908443
Change-Id: Icf41f1753450cee63b9296652599f5eb7c4de671
Reviewed-on: https://chromium-review.googlesource.com/c/1351149
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611309}

- The kUnifiedConsentGiven pref and the APIs SetUnifiedConsentGiven()
  and IsUnifiedConsentGiven() are removed from UnifiedConsentService
  and all dependent services.

- UnifiedConsentService::EnableGoogleServices() is added to enable all
  Google services tied to Unified Consent during opt-in.

- The metric UnifiedConsent.RevokeReason is made obsolete.

- The item of the histogram
  UnifiedConsent.SyncAndGoogleServicesSettings that recorded the
  state of the kUnifiedConsentGiven pref now records the state of
  kAllUnifiedConsentServicesWereEnabled.
  Note: This pref is set to true when the user enables all Google
  services by going through the new opt-in dialog.

- Move the code enabling contextual search to
  UnifiedConsentServiceClient.

Bug: 906031
Change-Id: I19bad51196f3bd01c700ad23da117615f32d7c74
Reviewed-on: https://chromium-review.googlesource.com/c/1346400Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611308}

When a registration request is received by Cryptotoken,
proxy that request to WebAuthn.

Bug: 906881
Change-Id: Ie3aac8bfb8bd4349eb29e7741bd5242b70842236
Reviewed-on: https://chromium-review.googlesource.com/c/1342687
Commit-Queue: Casey Piper <piperc@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611307}

- Add ContentBrowserClient::ShouldDisableSiteIsolation() so embedders
  can disable Site Isolation.
- Move Chrome memory checks in ChromeContentBrowserClient from
  ShouldEnableStrictSiteIsolation() to ShouldDisableSiteIsolation() so
  they can also disable Site Isolation.
- Added tests that verify memory constraints now disable trial isolated
  origins

Bug: 899116
Change-Id: Ibe4cbb93486db7e70cadf9a306d33606a8b33510
Reviewed-on: https://chromium-review.googlesource.com/c/1347443
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611306}

We should be able to avoid this with careful use of a trampoline
through the media thread after PipelineImpl::Stop() completes.

This is an updated version of the last CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1336659

The difference is we now also preserve the RendererFactorySelector
until after renderer shutdown. This passes all the failing tests
I could find locally.

BUG=521176, 905506
TEST=passes cq.
R=sandersd

Change-Id: I86c4814a91ee6c41f20f6bb8a05859ac44171d7e
Reviewed-on: https://chromium-review.googlesource.com/c/1351791Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611305}

This CL adds a ScheduleImageDecode() method to RasterInterface that
locks a transfer cache entry and sends an image decode request. This is
done so that it's convenient for the GpuImageDecodeCache to eventually
request image decodes.

Note that a new interface was introduced:
ImageDecodeAcceleratorInterface. This is necessary to allow
RasterImplementation to use ImageDecodeAcceleratorProxy without breaking
dependencies.

Bug: 868400
Change-Id: Ib24ffa9f5855cc843e1bf83ef4cd2ebb039c04d8
Reviewed-on: https://chromium-review.googlesource.com/c/1313671Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611304}

https://chromium-review.googlesource.com/c/chromium/src/+/1351501 has
reverted some perf changes due to high-end mac laptops crashing. Re-add
that CL piece by piece, starting here.

Re-add 2 tests: a render of google-sheets and an intense shader-based
test that will be GPU bound.

Bug: 908515
Change-Id: I2d371c1db7e5e1502367fb7c2093f4ec521f3b62
Reviewed-on: https://chromium-review.googlesource.com/c/1352339Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611303}

The web tests checks runtime flag idleSpellCheckingCallbackEnabled, which
is a removed flag after shipping of idle time spellchecker.

Hence, this patch removes the checking of the flag.

Change-Id: Ie8f279854a2b7625d7b526bfe0e50534cf9f8891
Reviewed-on: https://chromium-review.googlesource.com/c/1351872Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611302}

|NEW_PASSWORD| votes should be sent when a user presses "Update" button in the prompt

Bug: 907910, 552420
Change-Id: I0fd422255bd0ae599c833e11a9b64529d8bddecb
Reviewed-on: https://chromium-review.googlesource.com/c/1350611
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611301}

The Mojo InterfacePtr is not thread-safe. The MdnsResponderAdapter,
which is the client of the mDNS responder service via a Mojo binding, is
created on the main thread to access the connector to the service
manager, while being used exclusively on a WebRTC work thread. As a
result, it should own a thread-safe InterfacePtr to the mDNS service.

Bug: 905566
Change-Id: I8395f4163d0d9f17b954d082a580af673bb107f3
Reviewed-on: https://chromium-review.googlesource.com/c/1351596Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#611300}

This will eventually be 0 and then we can DCHECK, but is currently blocked on a few things (see blocking bugs).

Bug: 837753
Change-Id: I078cba0cf622cd9f2baf084f6c1d371b5e44457a
Reviewed-on: https://chromium-review.googlesource.com/c/1351774Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611299}

Bug: b/119185871
Test: local build

Change-Id: Id3f86cf28fe789008a479c30b916b1da64c61e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1330688Reviewed-by: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611298}

This reverts commit 30e1dd18.

Reason for revert: https://crbug.com/908970

Original change's description:
> [ios] add credit card test for manual fallback
> 
> Also adds AutofillManualFallbackPhaseTwo to test bots.
> 
> Bug: 845472
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ied47c5923ca1a71604a04df719bf2a18bae39265
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845472
Reviewed-on: https://chromium-review.googlesource.com/c/1352513Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611297}

This is to synchronize it with the CQ settings which cosinders builds pending
>2h as timed out.

Bug: 908943
Change-Id: I56285d4236eeae1a38e525ea0f18c68f80c07d14
Reviewed-on: https://chromium-review.googlesource.com/c/1352446
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611296}

BUG=908548

Change-Id: I1f471655a5e3f629c0d316b2617fbeaf62b7ba06
Reviewed-on: https://chromium-review.googlesource.com/c/1351499
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611295}

Previously it used to use tab.tabmodel which is going to be deleted.

Bug: 899839
Change-Id: I86584dfcd6bae44b289585fe1562c2f160715406
Reviewed-on: https://chromium-review.googlesource.com/c/1321669
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611294}

Required for next work where new WebInfo structure needs to be included
into PackageInfo

TEST=unit_tests
BUG=None

Change-Id: I5b1a680c3f68e5ca0d5f37a1735efcd2a76dad7d
Reviewed-on: https://chromium-review.googlesource.com/c/1343190Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611293}

There are a few TODO(vabr) in the code. Some of them are about old
code-health improvements which proved to be unimportant enough to
consider, those are being removed in this CL. A few are still relevant
and have an associated bug filed, those are redirected to that bug
instead.

Bug: 908813, 397083, 415449, 543085
Change-Id: If506009ce54016f8a1d9680a90b6516b399af4aa
Reviewed-on: https://chromium-review.googlesource.com/c/1352186Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611292}

* Remove unnecessary top_right() calls
* Use temps to reduce wrapping
* Use WindowFromTarget() more consistently
* For parallelism, always convert from targets to windows, instead of sometimes
  using the "target" version and sometimes the "window" version and mixing calls
* Group all the EventGenerator constructor variants that take a root window

Bug: none
Change-Id: I707780ee21ec2d3652fd3d1a38e3607e1ba980be
Reviewed-on: https://chromium-review.googlesource.com/c/1347277
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611291}

The same issue as the one fixed by https://crrev.com/c/1351286.

Bug: 908781
Change-Id: Iba5696ebdebdc286949ab62b24e8c6464354e7d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351948Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611290}

It hasn't run successfully in ages, and our bot seems to be the only one
running it under ASan on Android.

Bug: 908832
Change-Id: I12270a54ac34c659669b38a0f6639757bea89a48
Reviewed-on: https://chromium-review.googlesource.com/c/1350906Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611289}

This CL removes macro usage from /ios/chrome/browser/history.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 589840
Change-Id: I8f5c3e1980e622a55202a76db722dd65bcf348e4
Reviewed-on: https://chromium-review.googlesource.com/c/1351960Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611288}