- 27 Sep, 2019 40 commits
-
-
Kevin Ellis authored
This patch updates the implementation of the finish method to align with the web-animations specification. This change only affects synchronously finishing an animation. Support for async finish promises in a later patch will address additional test failures. Bug: 960944 Change-Id: I8323f1885c3fba6b098c53318c964d2d718c9101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827500Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#700861}
-
Sergey Ulanov authored
Previously SkiaRenderer wasn't setting YCbCr conversion info for promise images in formats that require YCbCr conversion. It was only set for textures that are rendered using StreamVideoDrawQuad, but not TextureDrawQuad. Now YCbCr conversion info is sent to the GPU process as part of TransferableResource, which allows to set it for all images that require it. Bug: 1004517 Change-Id: I810b38790095c2e86484d2422c2dc21006bb70e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824539 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#700860}
-
Mike Dougherty authored
These points were fanning out so much that text could not be selected above or below a link. Reduce the distance between the touced point and locations tested for a context menu element. Additionally, fix the context_menu.html test page. The value of webkit-touch-callout should be overridden to default. This broke when the test page was moved to its own file in crrev.com/c/1543633, but the test failure was covered up by the large spiralCoordinates used. Bug: 1000611 Change-Id: If2c06f86c33bf7b8cb244c2e67e8c72df4b952bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828103 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700859}
-
Avery Musbach authored
While editing split_view_controller.h in emacs, I am always constantly inconvenienced by error messages for reasons related to "it’s" in a comment. The apostrophe is actually an unusual character. Compare: ' is on your keyboard. ’ is in the comment in split_view_controller.h. There should not even be an apostrophe there, because the grammar of the sentence requires the possessive "its" rather than the contraction. Change-Id: I2b9e0397ad5019940769d224959a05bb073837a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829651Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#700858}
-
Ilia Samsonov authored
Bug: 993428 Change-Id: Id21490633dfb7ae92f73b0bdc9b2f81191f00ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801021Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#700857}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: Ida7049128d84a8bcb4ffc449c691fdffd2913264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814576 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#700856}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b37784118cd4..69d781151b8a git log b37784118cd4..69d781151b8a --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ehmaldonado@chromium.org Revert "Reland "depot_tools: Use vpython to execute fetch."" Created with: gclient setdep -r src/third_party/depot_tools@69d781151b8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I65b3aa3d332300f5b1d0940cda08632a37226e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700855}
-
Chris Harrelson authored
Bug: 967076 Change-Id: I9a5fe56098f31d2722fe8b15d1040baa19745a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829940Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700854}
-
Robert Liao authored
This ensure all invocations of --test-launcher-interactive get the prerequisite flags even if they do not run through BrowserUiTest.Invoke. BUG=687387 Change-Id: Iaa72a6281c0e561f44d919c487fd8b7bcbc1689c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816646Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#700853}
-
Jon Mann authored
Bug: 991928 Change-Id: I22f5e2e41daa6bc94110ce0641c7e9df510517e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824437 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700852}
-
Daniel Hosseinian authored
Flash isn't able to handle scaling, and currently changing the scaling settings for Flash content has no effect on the print preview. Effectively, we're hiding a stale setting. Bug: 989978 Change-Id: I1da86b3f1d517b6733946e7a26ba5504c3d4042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824131 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#700851}
-
Jasper Chapman-Black authored
Canary reports are approximately triplets of (apk, architecture, revision), but not all revisions have all apks. On apk change, update the version to match. (This means that selecting a version followed by an APK will change your selected version if that APK is not available at that version. But I think the alternative of 'update selectable APKs by version' is worse.) Bug: 1008475 Change-Id: I3d711cb6cbb4a5b1c72c207b21466b6fe8474e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830138Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700850}
-
Wojciech Dzierżanowski authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/1731919, ChromeContentBrowserClient never creates DataReductionProxyThrottleManager outside of the UI thread. Thus, the use of OnTaskRunnerDeleter is now redundant. Bug: 824840 Change-Id: I1a38f1898d58cb60dd87896cfa14205f7ac0d426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829197Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#700849}
-
Adam Langley authored
The recognition of EIDs is the most error-prone part of caBLE (v1 and v2) and the current debug logging is useless for diagnosing anything. This change reworks how EID detection is done and writes much more helpful information to the device-log. Change-Id: I7275242ec3505fa0b8a73daa27b42fa33144f38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830058 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#700848}
-
Lucas Furukawa Gadani authored
This CL converts files in services/network/test to use the mojom::URLResponseHead type instead of the native ResourceResponseHead struct. Bug: 984550 Change-Id: I59e3900f9b3865b29e5b976226a249e8d47f2dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808489Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#700847}
-
Renjie Tang authored
It seems that when writing a CRYPTO frame, the frame data is manually saved to the send buffer before the CRYPTO frame is added to the packet. I'm not sure on how to log it. Change-Id: If9b4b3361a72b09beca364e3fd2ebdf89bc3d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829466Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700846}
-
Eric Orth authored
Will be implemented in subsequent CLs. For now, just created the method and added the logic to call it or pass through wrapping implementations. Bug: 1006902 Change-Id: Iba093b7392bbb8ce1220c78a4fe11b3e3e3fb198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826870 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#700845}
-
Toni Barzic authored
AppListView::last_fling_velocity_ is used to decide whether app list should be dismissed when swipe occurs, but it's not reset once the gesture ends, which means the last recorded value will influence reseults of subsequent drags (if they do not generate ET_GESTURE_SCROLL_UPDATE event which updates the cached velocity value; e.g. for mouse drags) BUG=1008702 Change-Id: I3e55b05321388c39f354bf78e6a70e78370544d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828498 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#700844}
-
Stephen McGruer authored
This CL is part of the shift away from NonInterpolableValues to instead having more InterpolableValue subclasses. It introduces a new subclass, InterpolableFilter, which can represent a blink::FilterOperation. This should enable us to more easily implement the correct additive behavior for filter, see [0]. There should be no behavioral change from this CL, it is (intended to be) a pure refactoring. Bug: 1005828 [0]: https://docs.google.com/document/d/1aAvTNwxSSl0OWP3hQAV-Q7ru5-o5MzV4UEz7Uw9VHZk/edit#heading=h.9b2xtih585di Change-Id: Ib60b5857167db8950f3eb457cfaeec98ee781ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817284 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700843}
-
Joey Arhar authored
This patch makes document.body.insertAdjacentHTML('afterend', '<p>') insert the <p> as a sibling of document.body rather than creating a duplicate body and putting <p> in the duplicate. This fix was made in webkit in 2016: https://github.com/WebKit/webkit/commit/e3ca66a98a2a5edd553c411d6249a3a6a176174a fast/dom/insertAdjacentHTML-DocumentFragment-crash no longer produces a console message because using insertAdjacentHTML to create a child of a DocumentFragment now works, just as it does in safari and firefox. Bug: 978148 Change-Id: I22248b914753a450e54f0a72066f5b0dcf584cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824030Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Ben Pastene authored
Currently breaks on component builds (see bug). Bug: 1008962 Change-Id: Ifaf717b248b623ef7d32d3939e405015b1bd4b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829543Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#700841}
-
Carlos Knippschild authored
******************************Resource Sizes Diff****************************** Specifics: +73,728 bytes main lib size +621,920 bytes main dex size +1,048,949 bytes normalized apk size InstallSize: +402,200 bytes APK size +1,129,846 bytes Estimated installed size (Android Go) +2,914,757 bytes Estimated installed size InstallBreakdown (+2,910,135 bytes): +3,954 bytes Native resources (no l10n) size +2,702 bytes Non-compiled Android resources size +73,728 bytes Native code size +3,412 bytes PNG drawables size +705 bytes Package metadata size +2,797,566 bytes Java code size +28,068 bytes Compiled Android resources size Dex: +2,960 entries fields +2,522 entries strings +3,793 entries unique methods +1,275 entries types +3,793 entries methods Bug: 948739, 1006189 Change-Id: I78326484208068aa7b9b40b1ec2bf9833bc4cb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829821Reviewed-by:Dan H <harringtond@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#700840}
-
Andrew Luo authored
Bug: 1001309 Change-Id: I49d9b7adc9f62efed2c6f403ba7f3ab0e51a9e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828457Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700839}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2ed47b33935..30058d417f4c Created with: gclient setdep -r src-internal@30058d417f4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I9679e7540f34fe006e10694e8ed0fd44b1d3e9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829999Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700838}
-
Boris Sazonov authored
This reverts commit f6ce0a33. Reason for revert: compilation errors were caused by lint complaining that chrome/android/java/res_template/xml/syncadapter.xml is unused, so now it is removed as well (downstream usage has been removed in the meantime). Original change's description: > Revert "[Android] Remove ChromeBrowserSyncAdapterService from manifest" > > This reverts commit 230b08fa. > > Reason for revert: android-builder-perf and android_arm64-builder-perf failures. > See: > https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115865 > https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/114816 > > Original change's description: > > [Android] Remove ChromeBrowserSyncAdapterService from manifest > > > > This is a follow-up to https://crrev.com/c/1821784 that removes > > ChromeBrowserSyncAdapterService from AndroidManifest. > > > > Please note that chrome/android/java/res_template/xml/syncadapter.xml > > is kept in the repo for the time being, as it is being used downstream. > > This file will be removed in subsequent CLs. > > > > Bug: 1002894, 1008314 > > Change-Id: I7aa5fd7e2b5c982192aa07970d7400945f95116f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827413 > > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Auto-Submit: Boris Sazonov <bsazonov@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#700703} > > TBR=treib@chromium.org,bsazonov@chromium.org,mamir@chromium.org > > Change-Id: If68359d7398372debbaec730e7df22e4cf91602a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1002894, 1008314 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829339 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700729} TBR=treib@chromium.org,mamir@chromium.org Bug: 1002894, 1008314 Change-Id: I7a05b2fcc3e91267f67c4db70b91a5498efa9396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829201 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700837}
-
Aaron Krajeski authored
In the past we were calling UpdateMemoryUsage with the old size. Make it clear that the canvas is being reset if the size is not changing. Change-Id: Iea8b9d50ce4b01b82611bc8ff665b5cf673f79db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829801 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700836}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: I19886e1608085745ae686a86f560eaa484a39760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829644Reviewed-by:
-
Nate Fischer authored
This adds a "More docs" link to the end of the navbar, which links to the /android_webview/docs/ directory listing. Not all docs are in the navbar (not everything is relevant to everyone), but there should still be a way to navigate there from the navbar interface. This adds a comment to tell future contributors to leave this entry last. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ibfd27d9d3724d31543532da0e5507dc97a6ba11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829241 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700834}
-
Elly Fong-Jones authored
At least on Mac, a "splitter" is an interactable thing that allows the user to adjust the boundary between two groups of things. The Views splitter is not like this - it is basically just an <hr> type line. The Views control is more or less purely presentational and should not have an AX role. Bug: 961324 Change-Id: I8cfcd657c2ee9cae462a208e616dd8364cdb6428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827944Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#700833}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b8293682955..b37784118cd4 git log 2b8293682955..b37784118cd4 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ehmaldonado@chromium.org Reland "depot_tools: Use vpython to execute fetch." Created with: gclient setdep -r src/third_party/depot_tools@b37784118cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: Idaebcf08ad056bc056ab3f2a5a93bf9f5c6e78c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829284Reviewed-by:
-
rbpotter authored
(1) Regex for replacing the thousands delimiter needs to use an escape, because the thousands delimiter may have another meaning (e.g. in the case of '.'). (2) Remove thousands delimiters before replacing the decimal delimiter with '.', because the thousands delimiter may be '.', in which case replacing decimal delimiters with this value first will lead to them being removed. Also adding a test to run all current textbox parsing logic test cases with a metric unit system and different delimiters, which would have caught this bug. Bug: 1005816 Change-Id: I7bf84fe819bdfecfc344ff0e9fefd1322a5b622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827682 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#700831}
-
Elly Fong-Jones authored
Animations on these chips are used to get the user's attention; as such they should also cause screenreader alerts with their text, if they have such text. Bug: 801764 Change-Id: I7a111a1484de5752d83b9243c101291546293045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829949 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Bug: 1002704 Change-Id: Ic8d882f2c3a7e1955827c00332824afc095d82ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828061 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#700829}
-
chrome://bluetooth-internalsKyle Horimoto authored
This CL: (1) Calls DebugLogsManagerFactory::GetInstance() within ChromeBrowserMainExtraPartsProfiles to ensure that DebugLogsManager is created as soon as the user logs in, regardless of whether chrome://bluetooth-internals is visited. (2) Converts the <cr-toggle> used in the page into an <input> instead. This was necessary because chrome://bluetooth-internals is also used by Chromium for Android, which doesn't use Polymer. (3) Adds the chromeos::bluetooth namespace to these classes. Bug: 1006293 Change-Id: Ib163f55af376ff646f69790948af852e2ca07aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825171 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: -
Ryan Sturm authored
This CL adds parity between Android and Desktop for new battery monitors. Currently, the second observer that is added for battery will only receive new updates. This cl pushes the latest battery status update to the new observer. Bug: 999063 Change-Id: I6cfa7eeb6a355d03f2b1f0d9e8b7a73ffd8452e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829023Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#700827}
-
Avery Musbach authored
Bug: 1008408 Change-Id: I1998eb54d4645741dd1f311147a0cacdb1b136c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829540 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Eric Willigers authored
WPT for animation and transition shorthand computed values. Open spec issues: https://github.com/w3c/csswg-drafts/issues/2031 https://github.com/w3c/csswg-drafts/issues/4034 https://github.com/w3c/csswg-drafts/issues/4223 Change-Id: I3cac663f8a4cdce53856a9152e7b38033be9a76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827317 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: -
Vasiliy Telezhnikov authored
Add check for |cache_controller_| in ~VizProcessContextProvider(). It can be nullptr if InitializeContext() failed. Bug: 1008966 Change-Id: I13204bdf56996850186dcfd312374b05c8161b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829546Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700824}
-
Tommy Steimel authored
This CL updates the TestExpectation for the toggle-class-with-state-source.html test to also include virtual/audio-service Bug: 981303 Change-Id: Ifd3c452299d55ccd90aebb00d1830f8694334999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829238Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#700823}
-
Evan Stade authored
Make it a pure virtual interface. Per the style guide, classes should have no more than one superclass that actually provides implementation. This fixes BrowserView in that regard. This is also necessary for upcoming ScopedObserver updates. Bug: 998625 Change-Id: I387e2ef98af0035023a72853b10cc5fba8db1df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828280Reviewed-by:
-
