GitLab

Before this patch, users selecting "Go Back" when asked to confirm
inconsistent details caused a crash. This was caused by std::move being
called twice on the same callback.

This patch gets rid of the crash by keeping the callback in the action
instance instead of the individual callbacks.

Bug: 806868
Change-Id: I6f8520e4f3b97bed40369cc95f19c5d2e763f95f
Reviewed-on: https://chromium-review.googlesource.com/c/1442651Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626978}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a58fb5f..22de82ca

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1e3688bcbabc067111c669955601424e9bed88ea
Reviewed-on: https://chromium-review.googlesource.com/c/1442292Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626977}

Change DEV_SUFFIX presubmit check to use the pattern
'\bDEV_SUFFIX\b' instead of searching for the raw
string 'DEV_SUFFIX'. This can potentially avoid some
false positives.

boundary_interfaces no longer triggers a false positive.

Bug: 921784
Test: Locally adding SOME_DEV_SUFFIX or DEV_SUFFIX_SOME in
Change-Id: I5a9d6b04182ec8ebcbb3e6d9eba3f757da0c0847
Reviewed-on: https://chromium-review.googlesource.com/c/1436032
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626976}

Bug: 925374, 860467
Change-Id: If11e171966d2bca09254ec5ff942c75556c0b490
Reviewed-on: https://chromium-review.googlesource.com/c/1436261
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626975}

First import of PFFFT. No build file has been added yet.
For more details, see http://bugs.webrtc.org/9577

Bug: webrtc:9577
Change-Id: I62e688faf4fcd847541a885a52e7dc8ef78fe0e7
Reviewed-on: https://chromium-review.googlesource.com/c/1155600Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626974}

On CL https://chromium-review.googlesource.com/c/chromium/src/+/1384258
it was implemented using a new architecture for automatic generation.

This CL implements using the same infrastructure for manual generation
with using renderer ids as indentifiers instead of id attribute. As result,
it fixes cases with fields with no id attributes, on which manual
generation usually failed before.

Bug: 866444
Change-Id: Iaf268fc3c92e27b5ca05ba528f487558a2a168eb
Reviewed-on: https://chromium-review.googlesource.com/c/1393363
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626973}

This reverts commit 5f7f5569.

Reason for revert: Seems to break multiple Chrome OS trybots. See crbug.com/926154 for more details.

Original change's description:
> [s13n] Migrate ContentAreaAccountsMigration away from GCMS::Observer
> 
> CL changes the inheritance ofi ContentAreaAccountsMigration from
> GaiaCookieManagerService::Observer to IdentityManager::Observer instead.
> 
> No functionality change expected.
> 
> BUG=859882
> 
> Change-Id: I907b2624d23e93b6a0ecbcda3e39f0322f238612
> Reviewed-on: https://chromium-review.googlesource.com/c/1436916
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Lowell Manners <lowell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626748}

TBR=xiyuan@chromium.org,tonikitoo@igalia.com,lowell@chromium.org

Change-Id: Ide04520a6a6f249e5220a6b9086c80b591bc923e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859882,926154
Reviewed-on: https://chromium-review.googlesource.com/c/1442197Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626972}

Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eFZ3h_A3VTY

Bug: 917303
Change-Id: I96e19600bad93f53b2014bacea6aa49c9d74a269
Reviewed-on: https://chromium-review.googlesource.com/c/1426703Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#626971}

This CL stops calling 'delete this' in WorkerScriptLoadFailed(), and instead
makes sure WorkerContextDestroyed() is called in any case.

This cleanup is necessary for off-the-main-thread shared worker script fetch
because when the feature is enabled, we cannot destroy the worker at
WorkerScriptLoadFailed(), and need to wait for completion of worker thread
termination.

Bug: 924041
Change-Id: Ia4b744f1d7302efbc53fdc09e42e414a7b768865
Reviewed-on: https://chromium-review.googlesource.com/c/1441735Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626970}

Enable the feature by default, but with a FeatureList kill-switch.

Bug: 570205
Change-Id: I003c21871ab71e47a863707b9709a39d76883635
Reviewed-on: https://chromium-review.googlesource.com/c/1429820Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626969}

The very fact that AppCache is supported introduces a delay to preloaded
requests. We could use the `manifest` attribute to detect pages where
AppCache is used and only delay requests there.
This CL adds a counter for pages where this heuristic will fail (and
likely result in a spurious download). Assuming the counter is
relatively low, we'd be able to go ahead with implementing the
heuristic.

Bug: 788757
Change-Id: If5ca0c8682fa677677df38f59946b3198588d4a3
Reviewed-on: https://chromium-review.googlesource.com/c/1442051
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626968}

BUG=762641
TBR=newcomer@google.com

Change-Id: Idfee4530b90be0b2cecd0a37dfc7b7c194423bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1442533Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626967}

This allows two console layout tests to fail as they have a wrong
result expectation which is fixed as soon as the tests do not report
failures anymore.

Reference: https://chromium-review.googlesource.com/c/v8/v8/+/1350790
Issue: https://crbug.com/924308
Change-Id: I5d9fc375c675c2914a473d06d8e1ce047df30238
Reviewed-on: https://chromium-review.googlesource.com/c/1427980
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626966}

Chromium requires some special annotation for using a C-style string
literal as a GMock expected argument on a mocked method that takes a
QuicStringPiece.  This CL replaces QuicStringPiece constructors with the
more idiomatic ::testing::Eq matcher.

This CL lands server change 230912128 by bnc.

BUG=488484

Change-Id: Icb43cc2ad771dc8e0e4194e03617b31319021763
Reviewed-on: https://chromium-review.googlesource.com/c/1441497Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626965}

https://webrtc.googlesource.com/src.git/+log/190713c7cd0f..3d02384487f8


git log 190713c7cd0f..3d02384487f8 --date=short --no-merges --format='%ad %ae %s'
2019-01-29 steveanton@webrtc.org Fix inverted DCHECK conditional
2019-01-29 steveanton@webrtc.org Use Abseil container algorithms in media/
2019-01-29 steveanton@webrtc.org Use Abseil container algorithms in pc/
2019-01-29 amithi@webrtc.org Removing receive RIDs and Simulcast Layers.
2019-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa9574f1..ed7fd9b7 (626644:626752)
2019-01-28 terelius@webrtc.org Ignore duplicated incoming RTCP packets in RTC event log parser.
2019-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a788fba..fa9574f1 (626455:626644)
2019-01-28 amithi@webrtc.org Creating Simulcast offer and answer in Peer Connection.
2019-01-28 steveanton@webrtc.org Allow use of functions in absl/algorithms
2019-01-28 Peter) Slatala Add 'UpdateAllocationLimits' in media transport.
2019-01-28 nisse@webrtc.org Add is_fec property to RtpPacketToSend
2019-01-28 titovartem@webrtc.org Add static factory method from FrameGenerator for FrameGeneratorCapturer.
2019-01-28 mbonadei@webrtc.org [clang-tidy] Apply performance-faster-string-find fixes.


Created with:
  gclient setdep -r src/third_party/webrtc@3d02384487f8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I38967aaf2893afb73c1aaf912d894fcbff457682
Reviewed-on: https://chromium-review.googlesource.com/c/1441537Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626964}

This is a reland of 8f8d11a2

Original change's description:
> [base] Cleanup base::win::i18n and prepare for string16 Switch
>
> This change prepares base::win::i18n for the base::string16 switch and
> cleans up LanguageSelectors' interface and implementation by e.g.
> replacing a pair of pointers with a base::span.
>
> Bug: 911896
> Change-Id: If02538532908c1ea1e92044fc9f37176c085f3f5
> Reviewed-on: https://chromium-review.googlesource.com/c/1437210
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626663}

TBR=rogerta@chromium.org

Bug: 911896
Change-Id: Ide5358f2a9e29a9f27082033614643c87cf50fc2
Reviewed-on: https://chromium-review.googlesource.com/c/1440422
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626963}

This reverts commit a0a86f28.

Reason for revert: no flakes observed recently.

Original change's description:
> Mark UkmTest#singleDisableHistorySyncCheck as flaky
>
> Bug: 879248
> Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5
>
> TBR=mastiz@chromium.org
>
> Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5
> Reviewed-on: https://chromium-review.googlesource.com/1199696
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588157}

TBR=mastiz@chromium.org,oksamyt@chromium.org

Bug: 879248
Change-Id: If583a1642571675130fb2638bb8ebab2ad7a7a4f
Reviewed-on: https://chromium-review.googlesource.com/c/1442253Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626962}

Bug: 908833
Change-Id: I45fac73b7ed4db17d1d8b2605c715aac977c98bc
Reviewed-on: https://chromium-review.googlesource.com/c/1395963
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626961}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/950cb58638ea..3c93600f78b3


Created with:
  gclient setdep -r src-internal@3c93600f78b3

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3c1db355a9d4ba0ae266ab357448e98a55c59506
Reviewed-on: https://chromium-review.googlesource.com/c/1442451Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626960}

https://skia.googlesource.com/skia.git/+log/70041cf243b8..be6549a59d50


git log 70041cf243b8..be6549a59d50 --date=short --no-merges --format='%ad %ae %s'
2019-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0f073667daf0..4b2e00f4d180 (3 commits)


Created with:
  gclient setdep -r src/third_party/skia@be6549a59d50

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: If3129e497829ddd6d432c71132372c2db40b873a
Reviewed-on: https://chromium-review.googlesource.com/c/1442452Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626959}

This CL removes the arc_support note on VideoCaptureAllowed. Android P
added external camera support which allows this policy to be enforced on
external USB cameras as well.

Bug: 914526
Change-Id: Ifa253ff7d8ffe546ded6ad88b7b6c6008c1a5408
Reviewed-on: https://chromium-review.googlesource.com/c/1433254
Auto-Submit: Jasmine Chen <lnishan@google.com>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Jasmine Chen <lnishan@google.com>
Cr-Commit-Position: refs/heads/master@{#626958}

Bug: 925166
Test: Manual test
Change-Id: I4e3a24023e711ed8888d8c0a9e8e6734424db8ef
Reviewed-on: https://chromium-review.googlesource.com/c/1439459Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626957}

Previously, we only checked CSP upon navigation commit. That was
sufficient to respect CSP when applied via <iframe sandbox>, but
not sufficient to respect CSP when applied via HTTP response header,
since it's before the CSP header is parsed and applied to the frame

This created two bugs:
- clients.get() or clients.openWindow() could resolve to a client that
  was really cross-origin, because it was sandboxed to a unique origin.
- A service worker could control a cross-origin client.

The solution is to recheck CSP after the Document is loaded, and then
tear down service worker state if it's for a unique origin, as we
wouldn't create that state for <iframe sandbox> in the first place.

Bug: 924959, 771815
Change-Id: I291a71468fdbfc8bd38531f2d49578c458b32e85
Reviewed-on: https://chromium-review.googlesource.com/c/1438775
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626956}

Change it to isTabbedModeComponentName which also allows <package
name>.Main pattern.

See internal bug b/122899279

Change-Id: Iee3f920a59101ffda334f83f286c7b2320508598
Reviewed-on: https://chromium-review.googlesource.com/c/1441647
Auto-Submit: Bo <boliu@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626955}

Blink text segmentation works on UChar* buffers. Define an adapter class
that can iterate over the Blink UTF-16 buffers returning character
classes that are compatible with the Ragel grammar that we will be using
for scanning text runs for text presentation or emoji presentation.

The Ragel grammar and generated code can be found
here. https://github.com/googlei18n/emoji-segmenter Integration to a
Chromium mirror is tracked in https://crbug.com/925792.

Bug: 892589
Change-Id: I76c9a4e4aa63eaf8bcd4b3d4e8a8111bb5244a4a
Reviewed-on: https://chromium-review.googlesource.com/c/1439298
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626954}

This is required for Onion Souping the MediaStream module.

Bug: 921006
Change-Id: I2ce54d8a3d49d95b6e9954483cc5ec7e75c06b11
TBR: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1437625
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626953}

The following timestamps are collected:
* When the active account has loged in
* When the token was updated for the active account
* When the active account has loged out.
* When instance id was requested and recieved
* When service was started and stopped


Bug: 924957
Change-Id: I2f6839a9dd2858342372977d34ae35cfb59639f8
Reviewed-on: https://chromium-review.googlesource.com/c/1439076
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626952}

Bug: 924864
Change-Id: Iefbd3a429f8e76c0c91c3ef15caba042a3366b0e
Tbr: fdoray@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1442341Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626951}

Bug: v8:8319,926016
Change-Id: Id4e9751bbad3bf769608905acc704d22907b69b4
Tbr: dmurph@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1442344Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626950}

Right now, cryptohome has its own copy of the file. The goal is to get
rid of that. Therefore, this CL adds the version field used by
cryptohome. However, it changes it to optional since Chrome unit tests
don't set it (and 'required' is not recommended, anyway).

The file is mirrored to Chrome OS with the protofiles ebuild.

BUG=chromium:775087
TEST=Tryjobs

Change-Id: I0852f5f96d4d012f3e44f3f7d7560817c670e14e
Reviewed-on: https://chromium-review.googlesource.com/c/1436367
Auto-Submit: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626949}

This CL moves account_consistency_method.cc/h from the signin
component's 'internals' GN target to its 'shared' GN target as
it has only an enum.

Bug: 925345
Change-Id: I10873fba052a879d53f373b7b905c0aa4d472bc2
Reviewed-on: https://chromium-review.googlesource.com/c/1442039Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626948}

The use of this member was removed as a part of addressing
crbug.com/904566. This CL completes the clean up.

TBR=rbyers@chromium.org
BUG=904566

Change-Id: Iba297c9c623ad33005d2f868eddfa4401abc819c
Reviewed-on: https://chromium-review.googlesource.com/c/1442078
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626947}

BUG=None

Change-Id: Iaa8eebeef8cb9169255918bf299562fa83926d4f
Reviewed-on: https://chromium-review.googlesource.com/c/1440802Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626946}

As a preparation for CL:1404078, where
CertificatesHandler::HandleDeleteCertificte will access a CertInfo
field.

Bug: 872785
Change-Id: Iff4428f03d7b22be9fa2cef34c6f20b76af5fb7e
Reviewed-on: https://chromium-review.googlesource.com/c/1436360Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626945}

Bug: 894819
Change-Id: I9d1af51eff828564aa748742355e84695b6a1de7
Reviewed-on: https://chromium-review.googlesource.com/c/1442340
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626944}

Before this patch, buttons were always displayed on prompt. That was
incomplete: it did not allow reproducing the behavior we currently have
between scripts where button appear as a result of DOM changes.

With this patch, prompt button reproduce the between-script behavior,
allowing buttons to be shown only conditionally.

Bug: 122825639
Change-Id: I53eee48156cac1f2e5f1b81dd86a48bb25566a0c
Reviewed-on: https://chromium-review.googlesource.com/c/1437084
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626943}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7d49c734..4a58fb5f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I7df0d92af7aaa3c854d36960d95b4c4df43037f8
Reviewed-on: https://chromium-review.googlesource.com/c/1442171Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626942}

Bug: 894819
Change-Id: Iae4624aeddfe755ce7fd34ce797d89fc0dfad039
Reviewed-on: https://chromium-review.googlesource.com/c/1428626
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626941}

This test has been disabled for rebaselining for a V8 change.

Bug: v8:8124
Change-Id: Ica0becc9069be89a723b7a26a3d5aafd4fd1a415
Reviewed-on: https://chromium-review.googlesource.com/c/1441972Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626940}

Change-Id: I64b2f250e6d7573a9b3a5145d1a4f4f530b813a3
Reviewed-on: https://chromium-review.googlesource.com/c/1441958Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626939}