- 04 Jun, 2020 40 commits
-
-
Naomi Musgrave authored
Bug: 1084582 Change-Id: Ia384e12083a590f52beb1f98d50b192ab20f31cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182654 Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775171}
-
Koji Ishii authored
Minor refactoring while reviewing crbug.com/1091188. This patch has no behavior changes. Change-Id: Ic1ccef8b6c093039e34b536573ef16889a52dc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230585 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775170}
-
Tarun Bansal authored
These are flaky on other platforms too. Bug: 1087675,1087728,1087697,1087876,1088454,1088454 Change-Id: I73833f8edae03ba2c62c8093f9808b1667dcdbef TBR: ryansturm@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231444 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775169}
-
Sean O'Brien authored
Currently a keyboard device must present the udev attribute 'function_row_physmap' if we want to handle custom top row mappings. This change also allows the same mapping to be provided in a udev property. This will allow us to move existing keyboards to the custom layout codepath. BUG=b:157067041 TEST=Add udev rule for an external keyboard and test manually. Unit tests. Change-Id: I8f213b5254e34ad6ce9403e66aadb65e6b5c5d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229665Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#775168}
-
Gyuyoung Kim authored
This CL converts GetSavableResourceLinksFoo IPC messages to Mojo, - FrameMsg_GetSavableResourceLinks - FrameHostMsg_SavableResourceLinksResponse - FrameHostMsg_SavableResourceLinksError FrameMsg_GetSavableResourceLinks is converted to the blink's LocalFrame interface with a reply. GetSavableResourceLinks will return a callback with a result(GetSavableResourceLinksReply struct). If the result is nullptr, it means that an error happens. Thus, we don't need to keep FrameHostMsg_SavableResourceLinksResponse and FrameHostMsg_SavableResourceLinksError messages anymore. SavableSubframe native struct is moved to the blink's frame.mojom, then savable_subframe.h file is removed. This CL moves savable_resource.h/cc from //content/renderer to blink. But, DomSerializerTests should continue using it. So, this CL introduces web_savable_resources_test_support.h/cc files which support below testing function in order to support the tests. - GetSubResourceLinkFromElementForTesting Bug: 1047312 Change-Id: I8e95afcb4f55efa23a106654ec92729424301d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208085 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775167}
-
Eric Orth authored
Bug: 878582,1087444 Change-Id: I46d852911322d1a246ec48ca45f61c18ff485de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219016 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775166}
-
Peng Huang authored
For non-GL backends, shared image backings doesn't need GL API, so call MakeCurrent with needs_gl = false. For GL backend, MakeCurrent() will ignore needs_gl, and always make the context current. Bug: None Change-Id: I95ab79f0bb332122d7243f2a7361c6ff07e85407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230327 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775165}
-
arthursonzogni authored
This test is consistently failing on the test-o-phone bot. This patch disables it on Oreo. TBR=wychen@chromium.org, meiliang@chromium.org Bug: 1091148 Change-Id: I6931a1ebfe3f18d3657a0d2c251c9adbf2e304c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230492Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#775164}
-
Yi Gu authored
TBR=johnchen@chromium.org Bug: 1091274 Change-Id: I1e4b6ccf64c3966b17ba582f420b2f0e83648fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230763Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775163}
-
Dave Tapuska authored
This class duplicated ui::ImeTextSpan. blink/public already depended on a number of parts of base/ime so this is just another one. BUG=1073560 Change-Id: I042d613d6f7fa2490f507193a2b1611054bbe511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225240Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#775162}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/4026f6e15a63..d7b17f31c55ae $ git log 4026f6e15..d7b17f31c --date=short --no-merges --format='%ad %ae %s' 2020-06-02 bnc Deprecate gfe2_reloadable_flag_spdy_hpack_use_indexed_name. 2020-06-02 renjietang Add << operator for TransmissionType to make debugging easier. 2020-06-02 fayang Deflake //third_party/quic/core/http:end_to_end_test. 2020-06-02 fayang In quic, add num_draining_outgoing_streams_ to quicsession, and this counter will be used to determine shouldkeepconnectionalive in quicspdyclientsessionbase. client side only. not protected. 2020-06-02 fayang In quic, do not arm pto if the only in flight packet is half rtt data before handshake completion. protected by gfe2_reloadable_flag_quic_fix_server_pto_timeout. 2020-06-02 fayang Log max_packet_length and header when failed to serialize packet. 2020-06-02 nharper Improve QuicCryptoServerStreamBase functions for querying resumption status 2020-06-02 renjietang Internal QUICHE change 2020-06-02 fayang In quicsession, unify num_*_incoming_streams_ and num_*_outgoing_streams_. refactoring only, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src substitute GetNumDrainingStreams and GetNumOpenDynamicStreams R=dschinazi@chromium.org Change-Id: I65bf6eb1a694d62ba4bc25a1142f587595de79aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229719 Commit-Queue: Dan Zhang <danzh@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775161}
-
Gabriel Charette authored
As a new name for ScopedNestableTaskAllower. A migration will follow to move callers either to the new name or to RunLoop::Type::kNestableTasksAllowed. R=fdoray@chromium.org Bug: 781352 Change-Id: I5208655072728b4305e70815ccb933173ff0842e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225834 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#775160}
-
Liviu Tinta authored
This fails the DCHECK at https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/mouse_wheel_event_queue.cc?rcl=ef743dd6fa992f43b9417d07c281b1f39b7d5ad2&l=273 leading to subsequent wheel events be not cancelable when preventDefault is called. Also even if preventDefault is called the page still scrolls. Bug: 1063722 Change-Id: I89170b16be4d0ee3151872e7bbaca8182db93b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229000Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#775159}
-
David Black authored
Bug: b:157689497 Change-Id: Ibbb23b34f8fd4b335b418bdb9213f9eaf0381aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226313 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#775158}
-
Teresa Kang authored
As part of the performance improvement for read access, the `willReadFrequently` attribute is added to `CanvasRenderingContext2DSettings`. It's currently hidden behind the feature flag `NewCanvas2DAPI`. Bug: 1090180 Change-Id: I0e9f542b9b45c940d7a55f9ebf5451972492dc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225495Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#775157}
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/dac952eb0a27..431d6e57284a $ git log dac952eb0..431d6e572 --date=short --no-merges --format='%ad %ae %s' 2020-06-04 adam.sawicki Fix VmaAllocator_T::ImportVulkanFunctions_Dynamic for cases when Vulkan 1.1 is used 2020-05-25 adam.sawicki Remove invalid outdated assert in vmaBeginDefragmentationPass 2020-05-08 Adam.Sawicki Clarified documentation in few places to mention textures need to use LINEAR layout when accessed from the host 2020-05-03 hartmut.behrens fix(docs): instance not optional in quick start Created with: roll-dep src/third_party/vulkan_memory_allocator Bug: angleproject:4685 Change-Id: Id6ee6468b9ad60573c69b05d4f0f6b961aad976f Tbr: penghuang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231279Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#775156}
-
David Roger authored
Bug: 1091232 Change-Id: Idfbecb611c0bde730a375a3bf3059c19c4d115ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231221Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#775155}
-
Denis Kuznetsov authored
This CL Adds MultiStepBehavior that eases implementation of multistep screens. Bug: 1073095 Change-Id: I5d56449abdc8c25dde8c9e332a4820f2e3ec4389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228656 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#775154}
-
Varun Khaneja authored
Rename SetExtendedReportingPref() to SetExtendedReportingPrefForTests() since it is used only in tests. R=drubery TBR=agl Change-Id: I31a887e2a8f55e3fc34dff70aa543bb44fde6acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225472 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#775153}
-
Milica Selakovic authored
The new variation will allow showing credential leaked dialog after every form submission (helpful for testing). Bug: 1086111 Change-Id: Ifdc553e98ac923f2b762621c25ea0becc35134ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228619Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#775152}
-
Denis Kuznetsov authored
Bug: 1067260 Change-Id: I4d99ac3a4821a2116319e181e8a3781a5125251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231361 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Adrian Taylor authored
As discussed and agreed with the V8 team (vahl@). Change-Id: Ife8785cc0ac0201ab0813a6486b3ee88de70ca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229603Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#775150}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3d920083ed23..273da44ed986 2020-06-04 lalitm@google.com tp: add dense mode for sparse vector 2020-06-04 simonmacm@google.com Fix disappearance of all little core summaries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157216280 Tbr: perfetto-bugs@google.com Change-Id: I99ff1865353feea6947543f5439300c1bd84b81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775149}
-
John Williams authored
This CL fixes an issue where all Cast devices show "source not supported" after selecting a local file to cast. Bug: 1078448, b/155777239 Change-Id: Ia71a0cca55c45ed9578e7d49ffccef7333b3319e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210634Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#775148}
-
Juanmi Huertas authored
There was two TODOs in CanvasResourceProvider of some checks that were leftovers of the previous. Both of them involved SharedBitmap resource provider. Both of them were a check that the Create method was doing. One of the tests is about checking we have a Dispatcher. That is needed as inside the constructor of the CanvasResourceProvider of SharedBitmap it has a DCHECK that it has a valid Dispatcher. However the other check about the max texture size of the WebGraphicsContext3dProviderWrapper is not needed, thus, I'm removing that in this CL and simplifying the API. Bug: 1035589 Change-Id: Id53f45c178b0ca5d8c143d411832731742e699e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225330Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, some of the Android integration tests for payment handler capabilities still used the internals of ServiceWorkerPaymentApp.java, which prevented moving the payment handler logic from Java to the C++ service_worker_payment_app. This patch replaces all of the Android integration tests for capabilities with the cross-platform Android browsertests. After this patch, payment handler capabilities tests don't depend on ServiceWorkerPaymentApp.java internals, so its logic can be moved from Java to C++. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I40710b81cd21669b738f80c9e8fe013ad5769dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223997Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775146}
-
chrome://discards/graphSigurdur Asgeirsson authored
This CL applies the swimlane constraints to the page bounds in X, to squish all nodes into the page bounds instead of overflowing out through both edges. Bug: 1086231 Change-Id: I78755ec8edc054d9f18f91766a5460313715b3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230323 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775145}
-
Rune Lillesveen authored
We don't support MediaValues based feature evaluation in UA stylesheet, only matching media types. There was an instance of (-webkit-min-device-pixel-ratio: 2) in mediaControls.css which would always evaluate to true in the UA sheet, but not in the context of the evaluator in the StyleEngine for dpr=1. That caused us to constantly update active stylesheets for frame resizes because we thought the media result would change. This also contributed to hide a bug on tweetdeck.twitter.com before we optimized the ruleset invalidation for media query changes. This should not be a behavior change for the mediaControls stylesheet since the removed query would always evaluate to true so that we would always use the high resolution image. Bug: 1088340 Change-Id: I23f582893b21db6f14903836d58608caa82e5577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228848Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#775144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23708cd50e93..024d42fdd6bb 2020-06-04 kjlubick@google.com [canvaskit] roll v0.16.1 2020-06-04 jvanverth@google.com Direct3D: Create samplers and shaderResourceViews for textures. 2020-06-04 egdaniel@google.com Update GrVkImage setImageLayout to take a specific queue index. 2020-06-04 mtklein@google.com Revert "apply SkOpts_skx approach to SkOpts_hsw" 2020-06-04 mtklein@google.com Revert "finish new-style opts" 2020-06-04 bungeman@google.com Don't leak ref returned by SkFontMgr::matchFamilyStyle. 2020-06-04 geofflang@google.com Reland "Request specific ANGLE context versions." 2020-06-04 kjlubick@google.com [canvaskit] Fix JS representation of Color If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I0b33345989e8e077646701a10fefad4addaf2563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231241Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a437e061d367..615880b58043 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073932 Tbr: yigu@google.com,msramek@google.com Change-Id: I0462f3c5edf24fd4fc3d3a6665b25b9aa7613b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775142}
-
Yi Gu authored
This reverts commit b2a16218. Reason for revert: Consistent failure on Linux ASAN build. Original change's description: > Use last committed origin to track active content with cert errors > > This is a speculative fix for a test flake that I can't reproduce > locally or on trybots. > > Previously, when a page loaded an active subresource with a cert error, > we were using the *visible* navigation entry to compute the > origin to mark as insecure. My theory is that the visible navigation > entry might not correspond to the document that actually loaded the > subresource. In the flaky test, we load a page with a cert error, and > then navigate back. The page with a cert error triggers a favicon > request (we treat favicons as active subresources even though they are > just images), and I think (?) it's possible that this insecure favicon > resource will be processed by SSLManager after the back navigation has > changed the visible entry, therefore marking the page we're going back > to as insecure even though it shouldn't be affected. > > This speculative fix drops the code that computes an origin from the > visible navigation entry and passes that into SSLManager (and also > drops a couple obsolete TODOs alongside it). Instead, we look at the > committed entry's origin and mark that origin as insecure. > > Bug: 638576 > Change-Id: Ief60adf121261a7021bf5be6c196d5c065b06663 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218545 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775122} TBR=alexmos@chromium.org,estark@chromium.org,carlosil@chromium.org Change-Id: I8042062ebdc136988b7a4e5eb095845cfab9bc38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230773Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I06c19d931309c96c9b480f89f043d10a3444d82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231000Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds the Credential Provider Entitlement at the app level. Bug: 1044639 Change-Id: Iabdf3084ed457b4cce2e604a32a4c1f671d4ed35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209073Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775139}
-
Lei Zhang authored
Just assume the feature is always enabled on Chrome OS. Bug: 1010663 Change-Id: I562d18a782dc8ba0e938698697f3beeccf2919d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229317Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#775138}
-
Robert Sesek authored
Callers only ever passed MOJO_DEADLINE_INFINITE. Bug: 973213 Change-Id: I4c62b48b424e91dcb21ea9bb0afa13e4deb6ba29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229458Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#775137}
-
Gyuyoung Kim authored
This CL applies mojo::PendingRemote and mojo::Remote to uses of ScreenCaptureSessionNotifier interface. Bug: 955171 Change-Id: I4e37dd66399b988b67f7fe7a60ff0628b284c839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224481Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Moving input handling into blink (from content) requires some additional typemaps. BUG=1073560 Change-Id: I5f58dbd11905a3195be1d31f442a963b8f0034f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226312Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#775135}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1feb578b5252..93c0a8991c77 2020-06-04 bpastene@chromium.org cros_test: Let cros_build_lib quote SSH commands itself. 2020-06-04 kramasub@google.com dedede: Apply the flashing sequence to C2D2 and CCD 2020-06-04 seanabraham@chromium.org image: allow image_to_vm.sh to use --disk_layout arg 2020-06-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-03 mmortensen@google.com BuildAPI: update packages.testMockCall for GetBuilderMetadata. 2020-06-03 stevenjb@chromium.org deploy_chrome: Fix logging level after verbosity cleanup 2020-06-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-03 navil@google.com cbuildbot: DebugSymbolsStage separate generate and upload logic. 2020-06-03 seanabraham@chromium.org cros_branch: fail tool unless user acks deprecation warning 2020-06-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-02 bpastene@chromium.org remote_access: When building the SSH cmd string, wrap the cmd in quotes. 2020-06-02 bpastene@chromium.org cros_chrome_sdk: Print duration of SDK fetches when using --no-shell. 2020-06-02 dhanyaganesh@chromium.org Remove redundant board entries in chromite 2020-06-02 cjmcdonald@chromium.org cros_build_lib: Hide `cros_build_lib.run` in test backtraces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: 1090956 Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I4422f5b2a7e007aa104a161959edf3ed8ece5092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231242Reviewed-by:
-
Annie Sullivan authored
Change-Id: I72deba54f44bceeae2e3780efb5ea94ded86ed6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230920Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775133}
-
Leonid Baraz authored
See also https://docs.google.com/document/d/1yixj-sTbcpZjZvWjytERfJ4ZnEyuntC67qgp9oyBeIU Change-Id: Ib6b6e59b2013c004d1e5e43c05c1cc97b489e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191121Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#775132}
-
