GitLab

NOTRY=true
TBR=pdr@chromium.org,mlamouri@chromium.org
BUG=527044,521764

Review URL: https://codereview.chromium.org/1309843008

git-svn-id: svn://svn.chromium.org/blink/trunk@201554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/1265953002/ contained a typo which
moved all 'plugin' content to blockable mixed content. It should have
been slightly more selective. Oops. :(

BUG=513163

Review URL: https://codereview.chromium.org/1326593002

git-svn-id: svn://svn.chromium.org/blink/trunk@201553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These test very likely need a rebaseline following
https://codereview.chromium.org/1322933003

BUG=506669,506669
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/1326493003

git-svn-id: svn://svn.chromium.org/blink/trunk@201552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=machenbach@chromium.org
BUG=chromium:527009
LOG=n

Review URL: https://codereview.chromium.org/1316203004

git-svn-id: svn://svn.chromium.org/blink/trunk@201551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove some now-unbound virtual slimmingpaint test entries along with
removing expectation for

 svg/as-background-image/animated-svg-animation-control.html

which was removed in r201021.

R=haraken
BUG=345655,370906,356658,356742,456357,522652
NOTRY=true

Review URL: https://codereview.chromium.org/1323963002

git-svn-id: svn://svn.chromium.org/blink/trunk@201550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Alternative approach for http://crrev.com/1274023003

Add WebThreadSupportingGC::createForThread(), which takes an
existing thread and add GC support for the thread.

If a thread is not given WebThreadSupportingGC creates a new thread
and owns it, otherwise it just uses the given thread.

BUG=518708

Review URL: https://codereview.chromium.org/1319363002

git-svn-id: svn://svn.chromium.org/blink/trunk@201549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prepares moving WorkerInspectorProxy and WorkerInspectorProxy::PageInspector to the heap.

BUG=509911

Review URL: https://codereview.chromium.org/1253293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=510650,525479
R=japhet

Review URL: https://codereview.chromium.org/1304183006

git-svn-id: svn://svn.chromium.org/blink/trunk@201547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature will not be used in Blink in the immediate future, so
remove it.

There are no callers or users.

BUG=348877
TEST=compiled

Review URL: https://codereview.chromium.org/1325613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |absoluteCaretBoundsOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1324873002

git-svn-id: svn://svn.chromium.org/blink/trunk@201545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Discussion: https://codereview.chromium.org/1306083008/
BUG=526608

Review URL: https://codereview.chromium.org/1322673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The StylePropertySet passed in to CSSParser::parseValue already has a
parse mode associated with it, which we can use instead of passing a
separate parser mode argument.

Review URL: https://codereview.chromium.org/1312843008

git-svn-id: svn://svn.chromium.org/blink/trunk@201543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Inline CSSCounterValue::listStyle in CSSCounterValue::customCSSText()
where it's used, and renamed listStyleIdent() to just listStyle().

Review URL: https://codereview.chromium.org/1314353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/1322083002

git-svn-id: svn://svn.chromium.org/blink/trunk@201541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460722

Review URL: https://codereview.chromium.org/1326523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace deprecated --enable-overlay-fullscreen-video with
--force-overlay-fullscreen-video so that the former can be
removed on the chromium side.

BUG=511376
TEST=virtual/android/fullscreen layout tests

Review URL: https://codereview.chromium.org/1314983004

git-svn-id: svn://svn.chromium.org/blink/trunk@201539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves static member function |normalizeRange()| out from
|VisibleSelection| to "EditingUtilities.{cpp,h}" to make |VisibleSelection|
class not to use |PositionInComposedTree| directly for ease of templatazing
|VisibleSelection| to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1328493002

git-svn-id: svn://svn.chromium.org/blink/trunk@201538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebVector<WebVRDevice>* (ownership not transferred)
  => const WebVector<WebVRDevice>&

1/3: https://codereview.chromium.org/1317243002/
2/3: https://codereview.chromium.org/1309803006/
3/3: https://codereview.chromium.org/1321763002/

BUG=493531

Review URL: https://codereview.chromium.org/1317243002

git-svn-id: svn://svn.chromium.org/blink/trunk@201537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460722
R=domenic@chromium.org

Review URL: https://codereview.chromium.org/1308553005

git-svn-id: svn://svn.chromium.org/blink/trunk@201536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames |visiblePositionOf()| to |createVisiblePosition()| to follow
a review comment in http://crrev.com/1326563002, to indicate this function
isn't cheap like a accessor for improving code health.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311853004

git-svn-id: svn://svn.chromium.org/blink/trunk@201535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Attributes from CSSPrimitiveValue and updated callsites to
instead create CSSFunctionValues. This only affects the 'content'
property (no other properties currently support CSS attributes).

BUG=523893

Review URL: https://codereview.chromium.org/1312543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer have internals.settings.setThreadedHTMLParser.
Remove its reference from a performance test.

BUG=None

Review URL: https://codereview.chromium.org/1308273008

git-svn-id: svn://svn.chromium.org/blink/trunk@201533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change the first() and second() methods in CSSPairValue to return const
references instead of pointers, since CSSPairValue never stores null
objects.

BUG=526586

Review URL: https://codereview.chromium.org/1318543010

git-svn-id: svn://svn.chromium.org/blink/trunk@201532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove declarations of HTMLTreeBuilder::processIsindexStartTagForInBody and attributesForIsindexInput.

They are not defined.
This CL has no behavior changes.

BUG=

Review URL: https://codereview.chromium.org/1306323003

git-svn-id: svn://svn.chromium.org/blink/trunk@201531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLSourceTracker enables XSSAuditor to examine corresponding raw HTML source
to check if it contains XSS attempts. HTMLSourceTracker is currently very slow
involving full copy of pending input SegmentedString.

Before this CL, HTMLSourceTracker was invoked on every HTMLToken regardless
of XSSAuditor is enabled.

This CL avoids running HTMLSourceTracker when XSSAuditor is not enabled.

BUG=520296

Review URL: https://codereview.chromium.org/1322063002

git-svn-id: svn://svn.chromium.org/blink/trunk@201530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL re-enables threaded parser microbenchmark.

The comment said there was a bug where display:none-ed <iframe> created
its LayoutObjectTree, but the bug no longer repros on current Blink.

BUG=https://bugs.webkit.org/show_bug.cgi?id=107236

Review URL: https://codereview.chromium.org/1316283003

git-svn-id: svn://svn.chromium.org/blink/trunk@201529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changed CSSPropertyObjectPosition back to use legacy interpolation, as
the new interpolation doesn't support interpolating between pairs and
pairs-of-pairs.

Suspected CL:
https://chromium.googlesource.com/chromium/blink/+/a3be631e4554bcf918ef17f31112a3f7d93f376d.

BUG=526738

Review URL: https://codereview.chromium.org/1325783004

git-svn-id: svn://svn.chromium.org/blink/trunk@201528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The updated design spec for the 'overlay cast off' asset is partially transparent.  This CL incorporates that asset, and moves to the new position of 8px from the upper left.

Also adds an 'overlay cast on' asset, which has been missing for quite some time.  It is unreferenced, but is needed so that it can be added to blink_resources_constants.h in a separate CL.  We can then start using it in blink in a third CL.

BUG=522580

Review URL: https://codereview.chromium.org/1305793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |canonicalPosition()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1314033005

git-svn-id: svn://svn.chromium.org/blink/trunk@201526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

validateTexFuncFormatAndType is called twice from validateTexFuncData and
validateTexFunc. This isn't necessary.

BUG=295792

Review URL: https://codereview.chromium.org/1311413003

git-svn-id: svn://svn.chromium.org/blink/trunk@201525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the use of quirky CSS values like -webkit-text color
and unitless dimensions fail to parse when used in element.animate().

BUG=526921

Review URL: https://codereview.chromium.org/1305893005

git-svn-id: svn://svn.chromium.org/blink/trunk@201524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |lineDirectionPointForBlockDirectionNavigationOf()| to
"FrameSelection.cpp" as static function for improving code health since
it used only in "FrameSelection.cpp".

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

Review URL: https://codereview.chromium.org/1301423005

git-svn-id: svn://svn.chromium.org/blink/trunk@201523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A common pattern on the web is to animate both -webkit-filter and filter.
-webkit-filter can currently be composited while filter cannot.
Composited animations are not started if there are non-compositable properties
being animated simultaneously.
This patch ignores filter in CSS keyframes so that animations using
-webkit-filter and filter will run on the compositor.

Once -webkit-filter becomes an alias for filter we can stop ignoring filter
in CSS Animations.

BUG=520610

Review URL: https://codereview.chromium.org/1319083003

git-svn-id: svn://svn.chromium.org/blink/trunk@201522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I missed LocalToWindowPointTest in https://codereview.chromium.org/1308663004/,
and there are two more tests with different subclasses too.

BUG=523910
TBR=chrishtr

Review URL: https://codereview.chromium.org/1314353004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=519650

Review URL: https://codereview.chromium.org/1307743008

git-svn-id: svn://svn.chromium.org/blink/trunk@201520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |character{After,Before}()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568

Review URL: https://codereview.chromium.org/1320233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructor

This patch introduces |visiblePositionOf()| with |PositionWithAffinity| as
replacement of |VisiblePosition| constructor with |PositionWithAffinity| to
prepare making |VisiblePosition| constructors private.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326563002

git-svn-id: svn://svn.chromium.org/blink/trunk@201518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before r201294, SegmentedString::push() had an exotic behavior where two
consecutive push() results are swapped.  SegmentedString stored those two
chars into m_pushedChar{1,2} to avoid messing up SegmentedSubString.

After r201294, SegmentedString::push() is guaranteed to be used for
ungetc()-like usecase, where it reverts the SegmentedString::advance()
which was issued just before the call.

This CL removes m_pushedChar{1,2} optimization, and replace it with
SegmentedSubstring::push() which simply decrement m_data.string{8,16}Ptr.
In pessimistic case, this may end up prepending wtf::String inside
SegmentedSubstring, but this should be very rare.

BUG=None
TESTS=SegmentedStringTest

Review URL: https://codereview.chromium.org/1319913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch disables kSubpixelPositioning_Flag for "Dotum" in small
sizes.

The embedded bitmap of "Dotum" font looks poorly positioned when linear
metrics is used. This patch improves the positioning of the font by
disabling linear metrics.

Skia disables linear metrics and use DWRITE_MEASURING_MODE_GDI_CLASSIC
when kEmbeddedBitmapText_Flag & the font has 'eblc' OpenType table for
the specified size & !kSubpixelPositioning_Flag. The first two
conditions are already true, this patch turns the last condition to
true.

BUG=394585

Review URL: https://codereview.chromium.org/1304363011

git-svn-id: svn://svn.chromium.org/blink/trunk@201515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of document.querySelector[All]() should check selector context (patchset #6 id:100001 of https://codereview.chromium.org/1245933002/ )

Reason for revert:
This seems to have caused a significant perf
regression.  Reverting.

BUG=526742

Original issue's description:
> document.querySelector[All]() should check selector context
> 
> Blink failed to check whether the left-most matched selector ends up
> in Document TreeScope.
> The check was only enabled for querySelector*() is called on
> a regular element, not on document.
> 
> This issue can be exposed by passing "::shadow" or "/deep/"
> which pierces shadow boundary and the selector can
> incorrectly match inside shadow.
> 
> BUG=511486
> TEST=fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201461

TBR=esprehn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511486

Review URL: https://codereview.chromium.org/1329523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201514 bbb929c8-8fbe-4397-9dbb-9b2b20218538