- 26 Nov, 2019 40 commits
-
-
Tomasz Wiszkowski authored
TBR=pkotwicz@chromium.org Bug: 1028636 Change-Id: Ib43142773bc7ae526d8e45149384bee16f1a7663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935370Reviewed-by:
Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719268}
-
Jenny Zhang authored
Bug:1025880 Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e TBR=holte@chromium.org Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935547Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719267}
-
Ken Buchanan authored
remote_viewport_intersection_ was subsumed by IntersectionObservationState and is no longer referenced. This is just a cleanup. Change-Id: I326b1199172d7dc4d38bb4783d78350aa35ebca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937133 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719266}
-
Michael Crouse authored
This change persists the model and host model features received from a fetch to the remote Optimization Guide Service by places them within the store owned by the PredictionManager. A future change will add browser tests and metrics to confirm expected behavior of prediction manager, fetcher, and models. Bug: 1001194 Change-Id: I705785d32560160b14f69f846f0148d3ef6abc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934827Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#719265}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a069fea..c92a0fa4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90ccb314d5553d6f971b53aa3ce5baed70e47dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937228Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719264}
-
Alan Screen authored
During print preview user can choose a custom page range for printing. This can easily be less than the entire document. The recent change for concurrent PDF composition [1] erroneously always expected the full document to be collected, which fails with a hung preview if the user selects a custom page range. Correct this by updating the PrintRenderFrameHelper to pass along only the number of pages rendered for the page selection. [1] https://crrev.com/c/1917685 Bug: 1028104 Change-Id: Ic6ecbc09d09a8c7f30bc959b0a3808d66f1274ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935724Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719263}
-
Sidney San Martín authored
Issue: When "Add period with double-space" is turned on in System Preferences, typing two spaces after a word inserted a space, a period, then a second space. The period should replace the first space instead. It turned out that, since a key event is being handled at the time of the replacement, insertText:replacementRange: took a path that didn't consider replacementRange, and the period just got appended before the second space. The fix avoids the key press path when a replacement range is specified. Bug: 752640 Change-Id: Ia051e04f87345cd12bbd3438cf351cdc649149c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933408Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719262}
-
Matt Falkenhagen authored
As part of converting to Once/Repeating variants of base::Callback. This CL also converts away from gmock action templates, which don't support move-only types. Bug: 1007685, 1007763 Change-Id: I5386a16ba2cbb6339aae2e00c2d1f49d7ec9d959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935294 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719261}
-
Demetrios Papadopoulos authored
- Moving no-var and prefer-const to the top-level .eslintrc.js file. - Enable prefer-const in a few folders that were only using no-var previously. - Explicitly turn off no-var and prefer-const on folders that still have plenty of violations, for example chrome/test/data/extensions. Bug: 720034 Change-Id: I927fff375b04cd8f1326082c99ceef6f8e01e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885181Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719260}
-
rbpotter authored
Update template expressions replacement to use the new HTML template start and end markers instead of looking for _template: html` and `,. This allows some simplification of the logic and will enable i18n replacements in JS files using class based Polymer 3 syntax, since the autogeneration code adds these markers to the start and end of HTML templates at build time regardless of syntax. Also modifying some existing tests to use class based syntax, and adding more tests for less common cases and for mixed class/legacy syntax. Bug: 1023841 Change-Id: I764ee18621bc526f259b7b970e6008e0de220711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935609Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719259}
-
Andrew Grieve authored
Two semantic changes here: 1. ChromeTabUtils.java had a milliseconds vs seconds mismatch in a timeout (passing ms to function that took seconds). 2. Disables errorprone in custom_tabs_client_shared_java since it contains an unused import in a sub-repository. Fixes failures for: * BinderIdentityRestoredDangerously * EmptyIf * EqualsBrokenForNull * InvalidThrows * LongLiteralLowerCaseSuffix * RedundantOverride * RemoveUnusedImports * StaticQualifiedUsingExpression * StringEquality * TimeUnitMismatch * UnnecessaryStaticImport * UseBinds * WildcardImport Will enable these checks in a subsequent CL. TBR=agrieve # lint fixes Bug: 894616 Change-Id: Iee4b8bd187d68af93fcff042e58e87bb7faf46db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935889 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#719258}
-
rbpotter authored
This utility function and corresponding handler are only used by the history UI, so move them to history specific files/folders. Bug: 1022212 Change-Id: I12c1cd4758980ca36888922f289674f1b79637ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928160 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719257}
-
Corentin Wallez authored
This actually tightens a very broad RetryOnFailure suppression that was done on Win/NVIDIA/Vulkan/Passthrough when only three different tests were flaky. Tags these as failure instead because they are very flaky. BUG=chromium:1017162 BUG=chromium:1028639 TBR=ynovikov@chromium.org Change-Id: I1be168722e0ffecd4cd8d9b4ba1aefcb9d37ba15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937072Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719256}
-
Joe DeBlasio authored
This CL makes three small tweaks to how mixed content download blocking handles cases where initiator origins are unknown in an attempt to better understand/track down those cases: 1. It infers an initiator when there is no explicitly set initiator by looking at the tab URL. This is 'correct' in the case of a context-menu-initiated download. 2. It updates metrics to disambiguate these inferred initiators from 'true' initiators. 3. It dumps without crashing in cases when initiators aren't as expected. We expect these cases to be rare, and this portion of the change is temporary. Until we understand these edge cases, it would be useful to have the full callstack, otherwise we'd just add another histogram. We make use of download source to achieve this, so I've moved DownloadItemImpl::download_source() to DownloadItem::GetDownloadSource() so that we can determine download source without a downcast. #1 is user-visible only if they have enabled the #treat-unsafe-downloads-as-active-content flag. #2 and #3 are not user-visible. Bug: 1028179 Change-Id: I1ea38170eb62554a93d2f2f394efb9b006581ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934246 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719255}
-
Johannes Henkel authored
With this roll, tweak the dependency from inspector to a public_deps. It's needed because Serializable is exported from CRDTP now. Upstream review (already merged): https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1931280 Change-Id: I33c4aee3397ed4e746fc8605ce5911a2efc4c2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927577Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719254}
-
Owen Min authored
EnrollmentErrorConsumerAccountWithPackagedLicense ManualEnrollmentWithMultipleLicenses are disabled due to flaky Bug: 1028650 Tbr: poromov@chromium.org Change-Id: I7240fb19e577f07b9bec5ebce82ddcedbecc9161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935372Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719253}
-
Reilly Grant authored
Bug: 1007656 Change-Id: Ie1e65006e62d17843b716a0e860b74a2f26d506c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925697 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Darren Krahn <dkrahn@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719252}
-
Christopher Grant authored
The targets adjusted here should never have existed on 32-bit build configurations. Additionally, be more explicit about the various configurations in 64-bit targets. Currently, the extra arguments may not be used, but in follow-on changes, they will be. Bug: 1027573 Change-Id: I42efc07618a7bfa64a04dd8d1b6c5ccc79076ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934837Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#719251}
-
Stephen Nusko authored
While I was developing TRACE_EVENT_BEGIN and TRACE_EVENT_END these macros were added to the perfetto client library. Add mirrors of them in Chromium so we have access as well. TRACE_EVENT will allow people to conveniently emit trace events tied to a scope and TRACE_EVENT_INSTANT for things that have no duration. Change-Id: I474901a0ca53521b00199e32da5e21143d6781c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935113 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719250}
-
danakj authored
The PRESUBMIT.py rule checking for base::Bind and base::Callback usage was not working, so new usage crept into places that were previously marked clean. This CL updates the list in PRESUBMIT.py. A lot of places listed in the list are now clean or no longer exist. For places that were previously clean and now violate the rule, we mostly convert them over. 3 exceptions that we add to the PRESUBMIT.py list are: //jingle //media/blink //weblayer R=sky@chromium.org Bug: 1028284 Change-Id: I2e34f57879265c4894be1d1c4d132bf17fb973a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934767 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719249}
-
Friedrich Horschig authored
The password check switch can only be toggled when the Safe Browsing toggle is enabled. The subtitle is displayed when the user is signed out and safe browsing is enabled, since that is the moment when leak detection will be enabled when signing in. Note that disabling the Safe Browsing toggle only disabled the switch in the UI and doesn't change the pref. The code which prevents the leak detection logic to be run if safe browsing is disabled is on the native side in https://crrev.com/c/1937175. Bug: 1028095 Change-Id: I84ff30b8245417e8255024cea2e7679437a98636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932785 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#719248}
-
Sean Kau authored
git cl lint wants the WeakPtrFactory to be the last element in the class. However, DISALLOW_COPY_AND_ASSIGN is also supposed to be last. To fix this, remove the use of the macro. Bug: None Change-Id: Id617ab238d1a7929017fe8c28be2689e4d3df404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937137 Commit-Queue: Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#719247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/978d58b7ae4d..c959541ab602 Created with: gclient setdep -r src-internal@c959541ab602 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I3c9102191a4a505e4f85316c6027e11993516f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719246}
-
Roman Sorokin authored
* Make buttons stick * Content scrollable together with the title * Buttons not go under shelf * Tweak eula paddings Bug: 1019879 Change-Id: I9722316531eafcee7b496cd394b6768192184966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928703 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719245}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9356045a4e0..20c014cee7c3 git log e9356045a4e0..20c014cee7c3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 cwallez@chromium.org Fix typo in the name of wgpuGetProcAddress Created with: gclient setdep -r src/third_party/dawn@20c014cee7c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iac01f43bc9f4a3bf7b8a3443089b3006aab4169b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719244}
-
Sven Zheng authored
Test still failed on Win7 with TIMED_OUT. After some checking, I found PostRunTestOnMainThread should get skipped. There are several RunLoop in https://cs.chromium.org/chromium/src/chrome/test/base/in_process_browser_test.cc?g=0&l=550 We did not proper setup the browser so shutting down the browser would potentially have some unknown issues. TEST: Tested on Win7: https://chromium-swarm.appspot.com/task?id=48bce24f0c843610 Bug: 1025335 Change-Id: I323cf6aaad599fb0661949281dd97e0f58117b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933383Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719243}
-
rbpotter authored
Failure could not be reproduced locally on a Chrome OS debug build; this is a speculative fix based on the stack trace. Bug: 1028272 Change-Id: I1c10839a82061b6ce4daf7a1d8d80ce0e6210dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935720Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719242}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/68c657298074..6a4a14635e70 git log 68c657298074..6a4a14635e70 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 titovartem@webrtc.org Add ability to strip out logging messages from the binary Created with: gclient setdep -r src/third_party/webrtc@6a4a14635e70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If4b648ba4792822c51373a6b61132789ccc8aaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719241}
-
kdillon authored
Login handler test fix needed to land field trial testing config for compositor priority experiments. This CL fixes a login handler browsertest that flakes with a timing error when theses experiments are turned. The fix ensures that the web contents are finished loading before we attempt to do anything with them. Bug: 1027606 Change-Id: Ie504a14b831940a8552358a2890904c9c0eca9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854646 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719240}
-
Caleb Rouleau authored
This feature was originally intended for Pinpoint's use, but that never happened. Supporting this feature would complicate my work in crbug.com/965158. We can re-add this feature later if Pinpoint ever wants it. Bug: 965158 Change-Id: Ifef1e2ae844b5bd047e033461a4f9a0bb116c5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935748Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719239}
-
Rune Lillesveen authored
Test extensively testing HaveRenderBlockingResourcesLoaded is always run with the BlockHTMLParserOnStyleSheets disabled since it always true with that flag enabled. Various tests required us to test::RunPendingTasks() to do the work after unblocking the parser. There is one test still not passing because xml-stylesheet processing instructions are not blocking parsing with the runtime flag enabled. Will address that separately. Bug: 891767 Change-Id: If237faca49ba965114e51b02763307f56039d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936256Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719238}
-
Dominique Fauteux-Chapleau authored
This DCHECK was not included to avoid causing problems with older code that would read the value of empty tokens. Now that this code is migrated the check can be included. Change-Id: I1a9daff8624ba1f7e72df269636d765f2ad9ee20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935833Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719237}
-
Daniel Rubery authored
It's possible the new UX won't have UX approval by the M80 branch point, so place all the changes behind a feature flag, just to be safe. Bug: 1020423 Change-Id: Ia10280e3313fc5754c0c0ac46a33db59f98cf7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931646Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#719236}
-
Daniel Rubery authored
Now that the necessary tests have been added, we can safely add the new endpoint URL. Fixed: 1020434 Change-Id: Ib1b3073a1368d9e794104a4e8df5449cc3c4ef4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927571 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719235}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b62621c1dd8e..1b1f18689958 git log b62621c1dd8e..1b1f18689958 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 primiano@google.com Fix chromium build, remove some assert_no_deps 2019-11-26 treehugger-gerrit@google.com Merge "Refactor: define oom_score_adj span once" 2019-11-26 fmayer@google.com Merge "Handle DeobfuscationMapping." 2019-11-26 treehugger-gerrit@google.com Merge "perfetto-ui: Changing picture in the record page for heap profiling" 2019-11-26 primiano@google.com Merge "Remove libprotobuf from IPC layer" 2019-11-26 primiano@google.com Merge "tools(tmux): correctly find ninja" Change-Id: I3d771fa153e89ac0b8edf1a7c40b27f3d151bb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937169 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719234}
-
David Bokan authored
This CL adds back the source bit on injected ACTION_SCROLL motion events. This got lost when [1] tried to make this bit a parameter and then subsequently removed the option due to performance regressions in [2]. The reason this breaks is because in ContentUiEventHandler.java, onGenericMotionEvent only dispatches a wheel event if the ACTION_SCROLL event comes from a Pointer source[3]. [1] https://crrev.com/02cd150c24de8bdebb14d88c1a144b921a47756f [2] https://crrev.com/14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f [3] https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java?rcl=3df6abb639be7564b7743ade8db455a3564e7d32&l=67 Change-Id: I1ba4143f61ad889173735b0a168d7790a00d0865 Bug: 1025789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935432Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719233}
-
Erik Staab authored
Bug: 1007744 Change-Id: Iad1c2de0d2f611feec63175905254d9a739e0a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931917Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719232}
-
Matt Wolenetz authored
BUG=920044 Change-Id: Idb03f2bc1d2a2f7fb9f9ebd6247259ca097e2ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933385 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719231}
-
Tomasz Wiszkowski authored
TBR=pkotwicz@chromium.org Bug: 1028636 Change-Id: I749bc375a59582d6369edfa05910cea5e6849692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935368 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719230}
-
Ayu Ishii authored
Bug: 1007736 Change-Id: I2304f4f2bb6b031f1834fa23054027a315ef9781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934887Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719229}
-