GitLab

Bug: 736944
Change-Id: I718a06fd59eb773512545054aaecd89ff9fbe0cd
Reviewed-on: https://chromium-review.googlesource.com/820619Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#523469}

An update to the extensions landing page,
emphasizes the single purpose policy,
gives range to the UI, and clarifies store hosting.

Includes a "hello world" type tutorial.

Bug: 
Change-Id: I050f70ee909a1ed95964c77f4df95e762420abd6
Reviewed-on: https://chromium-review.googlesource.com/744993
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523468}

This is the final CL in step 1. This CL removes all color temperature
code from the UI layer, and hooks up the night light controller to the
newly added display color matrix in the UI compositor.

BUG=749250
TEST=covered by tests

Change-Id: Ia0263d0e530508c5820a3c8332b00228bff7ec38
Reviewed-on: https://chromium-review.googlesource.com/820173
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523467}

There is no clients. Remove them.

BUG=234463
TEST=Ran bots.

Change-Id: Ic9ab45b52a6067daa04ec2323aec7189c9d68a37
Reviewed-on: https://chromium-review.googlesource.com/822312Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523466}

BUG=None
TEST=Ran on bots.

Change-Id: I457634c3c9d514dcdce6d70054389863363b6789
Reviewed-on: https://chromium-review.googlesource.com/822670Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523465}

Bug: 787943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I332dac25551ae39094356846121e835faf3dceeb
Reviewed-on: https://chromium-review.googlesource.com/818077
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523464}

Probe requests (i.e., warmup URL fetches) may be
intercepted and restarted by the data reduction proxy
component. This CL prevents the probe requests from
being restarted.

Bug: 760294,792841
Change-Id: Iee54a9dce507d48121e71c58ff2079b9b1b67f1b
Reviewed-on: https://chromium-review.googlesource.com/818385Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523463}

This involved:
-persisting cookies with network service
-converting the browser tests to work with the network service

Bug: 789644, 769401, 776589
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I70320d5550e433049a910c64f055c1809aecbff1
Reviewed-on: https://chromium-review.googlesource.com/818486Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523462}

The omnibox textfield moves its text content area to account for the
leftView; however the leftView is now replaced with leadingButton in
the LocationBarView, so the leading offset should not be adjusted on
the textfield level.
This CL makes LocationBarView inset the textfield from the leading side
as necessary, and makes the textfield always align the text area to the
leading edge.

Bug: 791630
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I28ccb76eef95d0b50f24ff3ca3b437e03efce8cb
Reviewed-on: https://chromium-review.googlesource.com/818342Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523461}

Bug: 793028
Change-Id: I2c75fa078becfd638afe6072e9e2aa59198af66c
Reviewed-on: https://chromium-review.googlesource.com/815391Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523460}

Bug: 656607
Change-Id: I0719514369f834d93049d0161d2e1d33b9713c87
Reviewed-on: https://chromium-review.googlesource.com/817368
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523459}

Using wpt-import in Chromium 6b746d57.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7508

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I343d64276260c86b352b18c9cb478aa095312b12
Reviewed-on: https://chromium-review.googlesource.com/822690
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523458}

Without this CL we show only first line, sometimes other lines are
important as well (see attached bug). With this CL we show message
until first call frame.

TBR=lushnikov@chromium.org

Bug: chromium:780816
Change-Id: If5e9322e8bb5b2c263c1a95e4026347db14b1b6d
Reviewed-on: https://chromium-review.googlesource.com/802076Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521587}
Reviewed-on: https://chromium-review.googlesource.com/822131Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523457}

This reverts commit db213ff6.

Reason for reland: Downstream issue fixed. No changes here.

This CL makes aapt2 perform the final resource processing and packaging for an
apk as well as outputting proguard files.

TBR=agrieve

Bug: 782316
Change-Id: I1b35f49f2e4b4d503cc7ae07dabc18d9014abea5
Reviewed-on: https://chromium-review.googlesource.com/817377Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523456}

Bug: 627772
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic22d1c83b13835b8c8c10bdab7c0221dc5ca38ba
Reviewed-on: https://chromium-review.googlesource.com/820194
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523455}

Bug: 732612
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I685af535011500633865953799a6c4ae128ab5e8
Reviewed-on: https://chromium-review.googlesource.com/820043Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523454}

This CL adds AccountManagerFacade.waitForPendingUpdates and reimplements
addAccountHolderBlocking/removeAccountHolderBlocking in
FakeAccountManagerDelegate using newly-added waitForPendingUpdates.
This is necessary precaution before adding account list filtering, as
the old implementation of addAccountHolderBlocking was using account
list returned by AccountManagerFacade to wait for the update to finish.
Such approach will no longer work if account list is filtered.

Bug: 779568
Change-Id: I4e80a9070f31c0cd0bb9111eef9293213705700f
Reviewed-on: https://chromium-review.googlesource.com/817444
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523453}

This CL adds a new ShortcutSource for a WebAPK getting launched via an external
intent from Chrome. The purpose of the metric is to help quantify the user
benefit of WebAPKs. In particular:
- A user launching a WebAPK from an external app (e.g. from GMail) improves
the user's engagement with the web browser.
- A user launching a WebAPK from Chrome does not affect the user's engagement
with the web browser. Launching a WebAPK might be worsening the user
experience because the site that the user wants to visit takes longer to load
because a new APK needs to be launched and a new renderer process needs to be
spun up.

This CL divides the existing EXTERNAL_INTENT launch source for WebAPKs into
two buckets - one for intents originated from the browser that hosts the WebAPK
(i.e. links in the tabbed browser that were intercepted), and one for intents
that originated from other Android apps.

BUG=781659

Change-Id: I4fa9d0a7d57d79a33df6a3de88986dba49a373e9
Reviewed-on: https://chromium-review.googlesource.com/754594
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523452}

IOSChromeSigninClient directly inherit from SigninClient.

Partial implementations are not preferred when sharing code between
//ios/chrome and //ios/web_view. Instead, convert to using helper
classes (using composition) wherever possible.

Bug: 774517
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0fa0ad558ee518b0eefb110f34f9480d69b59a6a
Reviewed-on: https://chromium-review.googlesource.com/792252Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523451}

ImportNotifier.file_new_failures() calls LocalWPT's commits_in_range()
method, which returns a list of (SHA, commit subject) pairs.

It was then passing this list of tuples directly to format_commit_list(),
which expects a simple list of hashes instead, which led to failures such
as:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module>
    main()
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 168, in main
    if not self.send_notifications(local_wpt):
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 631, in send_notifications
    issue, patchset)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 64, in main
    self.file_new_failures(wpt_revision_start, wpt_revision_end, issue, gerrit_url)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 179, in file_new_failures
    commit_list = self.format_commit_list(imported_commits, full_directory)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 199, in format_commit_list
    line = '{}: {}'.format(self.local_wpt.commit_subject(commit), GITHUB_COMMIT_PREFIX + commit)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 191, in commit_subject
    output = self.run(['git', 'show', '--format=%s', '-q', commit])
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 50, in run
    return self.host.executive.run_command(command, cwd=self.path, **kwargs)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 337, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 244, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'show', '--format=%s', '-q', (u'a4c37295163abd475704cc032a304c83b14f9202', u'Add tests for slot.assignedElements method (#8636)')]" exit_code: 128 cwd: /tmp/wpt
output: fatal: ambiguous argument '(u'a4c37295163abd475704cc032a304c83b14f9202', u'Add tests for slot.assignedElements method (#8636)')': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
step returned non-zero exit code: 1
(via https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7486)

Bug: 765334
Change-Id: Iec2f574e5c308cd10f028e9ad1496be7967c0843
Reviewed-on: https://chromium-review.googlesource.com/822253Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#523450}

With one of the next rolls, V8 will no longer force context allocation
of module-scope variables.

Bug: 791334
Change-Id: I93f38c190cc0ee68df4f2834083308b4504a8032
Reviewed-on: https://chromium-review.googlesource.com/822432Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523449}

This CL is a workaround for fixing the pointer lock issue
caused by a bug in Windows Fall Creators update (16299).
Windows OS doesn't generate a WM_MOUSEMOVE after a SetCursor
call.
The code added here should be removed once Microsoft fix
the bug in their next release.

Bug: 781182
Change-Id: I690d5017e079ab32ef3cb55a2b136e8d0140bc6b
Reviewed-on: https://chromium-review.googlesource.com/791330
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523448}

https://chromium.googlesource.com/angle/angle.git/+log/629a64498dde..7f5c3eb76834

$ git log 629a64498..7f5c3eb76 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 cwallez Revert "Implement EGL_ANGLE_iosurface_client_buffer"
2017-12-08 jiajia.qin ES31: Fixed the SSBO instance array error

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ia21d92a544b78902d54a3033305dfbb4fa7f1eff
Reviewed-on: https://chromium-review.googlesource.com/822592Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523447}

Bug: 598854
Change-Id: Ifb15b66ced051591cbcaf4e28691abc9267fe7a7
Reviewed-on: https://chromium-review.googlesource.com/817794
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523446}

https://chromium.googlesource.com/angle/angle.git/+log/629a644..7f5c3eb

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: If669a599167db4f048280ef957551625be3d6a1b
Reviewed-on: https://chromium-review.googlesource.com/822174Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523445}

It is flaky

TBR=caseq@chromium.org

Bug: 794180
No-Try: True
Change-Id: Id66f1df0844ba8f6bed757b244c8c50d65eb48d4
Reviewed-on: https://chromium-review.googlesource.com/822416Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523444}

Blink side UseCounter counts SVG usage when containing document is an HTML doc.
PageLoadMetrics restrict mime type to text/html or xhtml, which might filter out
SVG document.
Overriding mime type restriction supports usage tracking SVG docs in UseCounterPageLoadMetricsObserver.

Bug: 786414
Change-Id: I53e4afcae51166ce6f9cdde7c35d9a249dd94d2a
Reviewed-on: https://chromium-review.googlesource.com/776164Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523443}

Media: refactor "SupportsSave()" to be implemented by Blink instead of relying on the WebMediaPlayer instance.

The media controls already have a definition for this which is more
detailed than the one that WebMediaPlayer instances use. This will also
allow consistency between the presence of the download button and the
context menu entry for "save video as".

Bug: 780858
Change-Id: I6e439be9cedef9c8862cd1d0d497eac6cb3c800b
Reviewed-on: https://chromium-review.googlesource.com/806654
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523442}

There was no need for AXNotification to be exposed in AXObjectCache.
It's more of an internal detail to accessibility and doesn't belong
in the public interface to it in core/dom.

This is a pure refactoring change only.

Bug: 699438
Change-Id: I17c02dd093d4857dab1ce015d4e55dd6bed567af
Reviewed-on: https://chromium-review.googlesource.com/820097Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523441}

There is no behavior change but add a test to check it.

Bug: none
Change-Id: I883fd6eb5f848c7416b810460c182c7509d6c35c
Reviewed-on: https://chromium-review.googlesource.com/818595Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#523440}

https://pdfium.googlesource.com/pdfium.git/+log/909fa2daa49e..a4789fffa5f9

$ git log 909fa2daa..a4789fffa --date=short --no-merges --format='%ad %ae %s'
2017-12-12 thestig Remove non-const refs in CPDF_NameTree functions.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7448b2d87936e5659277677c777a7075ab92e4a5
Reviewed-on: https://chromium-review.googlesource.com/822213
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523439}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7fcbcafb..111e9904

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If9302cf4dc1609533087d505951634a100fc6101
Reviewed-on: https://chromium-review.googlesource.com/822650Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523438}

According to the spec,
https://www.w3.org/TR/css-scroll-snap-1/#propdef-scroll-snap-margin
scroll-snap-margin should only accept length value, so we reject
percentage value at parsing stage. As the percentage is no longer
needed, we also change its type to float from Length.

This patch also makes sure that all scroll-snap-margin properties
accept negative values, and adds tests for parsing scroll-snap-type,
scroll-padding and scroll-snap-margin.

Bug: 778257
Change-Id: I6a5c7c4e76d53439af3d2976d04f47c8aafa1662
Reviewed-on: https://chromium-review.googlesource.com/782742Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523437}

These aren't being used yet and we'll reintroduce them as struct traits.
Just cleaning up dead code allowing that work to cleanly start.

TBR=avi for BUILD.gn/DEPS removals
Bug:

Change-Id: I23db121f17a68c205f10a367eb04f708c8e2790b
Reviewed-on: https://chromium-review.googlesource.com/822257
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523436}

Updated DOMString type with USVString for URL-related IDL attributes/operations
to match the html specification.

https://html.spec.whatwg.org/

Bug: 790860
Change-Id: I23a10706e309305d5da337c0b43c79b9faec8a22
Reviewed-on: https://chromium-review.googlesource.com/808404
Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523435}

Bug: 776538
Change-Id: I468c9c995df3d2abd1631254966debb97ce751e8
Reviewed-on: https://chromium-review.googlesource.com/820893Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523434}

This CL fixes a crash happening when the signin tab is closed during
the signin process. This CL also adds unittests for the class.

Bug: 794152
Change-Id: I9c0c1faec7e2a9e564dc35f1b76eb2fa4f8d9bb7
Reviewed-on: https://chromium-review.googlesource.com/817596
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523433}

Remove the scheme and store it as either HTTPS-only or
HTTP+HTTPS in the metadata. This means that sites
which are migrating to HTTPS will not be affected by
the preloaded list.

BUG=787464

Change-Id: I520c6b9138c4f59136e728165d140daa63e4bec7
Reviewed-on: https://chromium-review.googlesource.com/810769
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523432}

https://skia.googlesource.com/skia.git/+log/376fd31ad485..3250a487ea97

$ git log 376fd31ad..3250a487e --date=short --no-merges --format='%ad %ae %s'
2017-12-12 kjlubick Search more for stacktrace to symbolize
2017-12-12 kjlubick Scale extra CPUs to powersave during nanobench.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Ic27fbad057686f0492f35270ae36bcdd5ed4cbc6
Reviewed-on: https://chromium-review.googlesource.com/822591Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523431}

Currently this only creates the an appropriater delegate in net/, calling it from there.
There still needs to be created code in cronet which registers and appropriate delegate,
and then populates the metrics object that will finally be given to the client.

Bug: 702796
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33a8ce1f489a7bfb74b4c9561a57b7b5a71013e0
Reviewed-on: https://chromium-review.googlesource.com/763934
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523430}