GitLab

R=yurys
TEST=inspector/sources/debugger/debugger-autocontinue-on-syntax-error.html, inspector/sources/debugger/debugger-step-into-v8-internals.html

Review URL: https://codereview.chromium.org/424813004

git-svn-id: svn://svn.chromium.org/blink/trunk@179137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html as flaky in debug

TBR=simonjam@chromium.org
NOTRY=TRUE
BUG=398295

Review URL: https://codereview.chromium.org/426953003

git-svn-id: svn://svn.chromium.org/blink/trunk@179136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/KS5GAM7JXtg/7KyhsqQFZMkJ

BUG=398352

Review URL: https://codereview.chromium.org/428533003

git-svn-id: svn://svn.chromium.org/blink/trunk@179135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/KYJoVzmi_tw/OsTpm27Ty9YJ

BUG=398356

Review URL: https://codereview.chromium.org/416403013

git-svn-id: svn://svn.chromium.org/blink/trunk@179134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

layout. 

We use VisiblePosition canonicalize to know where to draw a caret.
However if selection is on a text input, we need concern just whether the text 
input is visible or not.
It means we can change VisiblePosition to PositionWithAffinity.

Source/core/editing/Caret.cpp/h:
- Add a override method of updateCaretRect using PositionWithAffinity.

Source/core/editing/FrameSelection.cpp:
- if selection is on a TextFormControl, use the updateCaretRect function.

Source/core/editing/PositionWithAffinity.h, VisiblePosition.h:
- Move the localCaretRect function to PositionWithAffinity. It uses position and 
affinity so moving is straightforward.

Source/core/html/HTMLTextFormControlElementTest.cpp:
- Add a test to confirm FrameSelection::localCaretRect not to cause layout.

BUG=382809
TEST=HTMLTextFormControlElementTest.cpp

Review URL: https://codereview.chromium.org/429453004

git-svn-id: svn://svn.chromium.org/blink/trunk@179133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test is crashing in debug after a V8 roll in Chromium to v3.28.43.1.
Updating expectations to turn the tree green while this gets investigated.

NOTRY=TRUE
TBR=haraken@chromium.org,ishell@chromium.org
BUG=398306

Review URL: https://codereview.chromium.org/429573003

git-svn-id: svn://svn.chromium.org/blink/trunk@179132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/XiDb0IKd2rw/Bb8IPddHejMJ

BUG=398353

Review URL: https://codereview.chromium.org/427533003

git-svn-id: svn://svn.chromium.org/blink/trunk@179131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/nECqqvgxIek/poPQf2KX3jMJ

BUG=398351

Review URL: https://codereview.chromium.org/427563002

git-svn-id: svn://svn.chromium.org/blink/trunk@179130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The PLY lexer caches its table as a Python module (lextab.py). The
cache is loaded by attempting to import the module, which succeeds
if there's a lextab.py{,c,o} anywhere in the Python path. If the
import succeeds, the cache is assumed by PLY to be up-to-date, so
to update the cache, we need to remove those files before calling
PLY to initialize the lexer.

This patch makes blink_idl_lexer.main() do just that. It also
extends blink_idl_parser.main() to call the former, since the GYP
(and GN) build systems only actually call the latter script.

BUG=397909

Review URL: https://codereview.chromium.org/425953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer use this enum in Chromium; everything has been ported over
to using '::RequestContext' and '::FrameType', so we can safely remove
both the enum and the translation machinery in '::setTargetType'.

BUG=390497

Review URL: https://codereview.chromium.org/417483002

git-svn-id: svn://svn.chromium.org/blink/trunk@179125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ccameron@chromium.org,jamesr@chromium.org
NOTRY=TRUE
BUG=396798

Review URL: https://codereview.chromium.org/426893004

git-svn-id: svn://svn.chromium.org/blink/trunk@179124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Change WokerThread to use a blink::WebThread. (https://codereview.chromium.org/400153002/)

Reason for revert:
Failed compile on Linux Tests and Linux Tests (dbg) builders.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/38284
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3339

../../mojo/services/html_viewer/blink_platform_impl.cc:183:14:error: allocating an object of abstract class type 'mojo::WebThreadImpl'
  return new WebThreadImpl(name);
             ^
../../third_party/WebKit/public/platform/WebThread.h:73:18: note: unimplemented pure virtual method 'setSharedTimerFiredFunction' in 'WebThreadImpl'
    virtual void setSharedTimerFiredFunction(SharedTimerFunction) = 0;
                 ^

Original issue's description:
> Change WokerThread to use a blink::WebThread.
> 
> BUG=301515
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179117

TBR=jochen@chromium.org,ager@chromium.org,aandrey@chromium.org,yurys@chromium.org,oilpan-reviews@chromium.org,haraken@chromium.org,darin@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=301515

Review URL: https://codereview.chromium.org/430493002

git-svn-id: svn://svn.chromium.org/blink/trunk@179123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGAnimationElement derives SVGTests, but it never checked for its results.
This patch modifies |SVGSMILElement::progress| so it will query |SVGElement::isValid()| before applying animation.

BUG=397991

Review URL: https://codereview.chromium.org/424753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=171447

Review URL: https://codereview.chromium.org/401523004

git-svn-id: svn://svn.chromium.org/blink/trunk@179121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, this CL adds missing ResourceLoaderSet factory.

BUG=393516

Review URL: https://codereview.chromium.org/414423003

git-svn-id: svn://svn.chromium.org/blink/trunk@179120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes raw Element* pointers from the EventDelegate hierarchy.

BUG=340522

Review URL: https://codereview.chromium.org/427673004

git-svn-id: svn://svn.chromium.org/blink/trunk@179119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- |SVGAnimate{Motion,Transform}Element::isSupportedAttribute| is only
called from |SVGAnimate{Motion,Transform}Element::parseAttribute|. Inlined.

BUG=397902

Review URL: https://codereview.chromium.org/424733002

git-svn-id: svn://svn.chromium.org/blink/trunk@179118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=301515

Review URL: https://codereview.chromium.org/400153002

git-svn-id: svn://svn.chromium.org/blink/trunk@179117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397440
R=yurys

Review URL: https://codereview.chromium.org/416363002

git-svn-id: svn://svn.chromium.org/blink/trunk@179116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Supply row height corresponding to current data grid style.

BUG=316092

Review URL: https://codereview.chromium.org/420183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates the templates we use for generated code to use |blink| rather
than |WebCore|. I've also updated a number comments and such that weren't
caught by my Python renaming script.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/424983002

git-svn-id: svn://svn.chromium.org/blink/trunk@179114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All the tests were adjusted to the buffered mode.
Console.timeline also records timeline in buffered mode.

BUG=361045
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/399043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/412143002

git-svn-id: svn://svn.chromium.org/blink/trunk@179112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Mark 63 inspector/ tests as flaky on Linux ASAN (https://codereview.chromium.org/407113002/)

Reason for revert:
Since patch https://codereview.chromium.org/399383005 has been successfully landed, lets try revert this one, test should be ok now

Original issue's description:
> Mark 63 inspector/ tests as flaky on Linux ASAN
> 
> (and clean up old expectations for these tests)
> 
> BUG=395997,395676
> TBR=sergeyv@chromium.org
> NOTRY=true
> NOTREECHECKS=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178638

TBR=johnme@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395997,395676

Review URL: https://codereview.chromium.org/413473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik

Review URL: https://codereview.chromium.org/414013002

git-svn-id: svn://svn.chromium.org/blink/trunk@179110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Send async stack trace for Network.Initiator to frontend, and show it in console
and popover in the Network panel.

BUG=169721
R=eustas, apavlov

Review URL: https://codereview.chromium.org/416843002

git-svn-id: svn://svn.chromium.org/blink/trunk@179109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch separates style used for error message repeat count bubble
in console. The style is already used in Resources panel, and will be
used later for editor errors.

BUG=397217
R=vsevik, apavlov
NOTRY=true

Review URL: https://codereview.chromium.org/428563002

git-svn-id: svn://svn.chromium.org/blink/trunk@179108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SVGAnimationElement derived SVGTests.
However, given that SVGDiscardElement, which also derives SVGSMILElement
need SVGTests support too, this CL changes SVGTests to be inherited in
SVGSMILElement.

Before:
class SVGSMILElement {}
class SVGAnimationElement : SVGSMILElement, SVGTests {}
class SVGDiscardElement : SVGSMILElement {}

After:
class SVGSMILElement : SVGTests {}
class SVGAnimationElement : SVGSMILElement {}
class SVGDiscardElement : SVGSMILElement {}

BUG=397991

Review URL: https://codereview.chromium.org/427613006

git-svn-id: svn://svn.chromium.org/blink/trunk@179107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew| *LANDED*
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call. <-- This patch
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (b).

Bonus: Remove {parseAttribute,isSupportedAttribute,svgAttributeChanged} on SVGGElement which was a noop.

BUG=397902

Review URL: https://codereview.chromium.org/420193011

git-svn-id: svn://svn.chromium.org/blink/trunk@179105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes uses of the WebCore namespace that have crept in during the
transition.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/426863003

git-svn-id: svn://svn.chromium.org/blink/trunk@179104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

'rem' and 'ch' units were unrecognized when used inside MQs/sizes, since they were not in the unit table.
I've added them and fixed another bug related to CH and MQs.

I've also added the 'fr' and 'turn' units to the unit table, even though there aren't valid MQs that can use them,
since some other code may use the unit table in the future, and they should be there for completeness.

BUG=398185

Review URL: https://codereview.chromium.org/427683002

git-svn-id: svn://svn.chromium.org/blink/trunk@179103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the size of ScriptWrappableBase is zero, this change will not increase the size of CSSValue, etc.

BUG=235436

Review URL: https://codereview.chromium.org/424783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the CSS3 standard calc() expressions can contain time,
angle and frequency values. (http://www.w3.org/TR/css3-values/#calc).
The patch implements this feature.

The patch is partially based on http://trac.webkit.org/changeset/168685
and http://trac.webkit.org/changeset/170544 (Patch by Martin Hodovan,
reviewers were: Darin Adler and Simon Fraser)

R=mikelawther@chromium.org,alancutter@chromium.org
BUG=390566

Review URL: https://codereview.chromium.org/345903005

git-svn-id: svn://svn.chromium.org/blink/trunk@179101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html as flaky on debug Windows

TBR=simonjam@chromium.org
NOTRY=TRUE
BUG=398295

Review URL: https://codereview.chromium.org/422223004

git-svn-id: svn://svn.chromium.org/blink/trunk@179100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/415013003

git-svn-id: svn://svn.chromium.org/blink/trunk@179099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduces ScriptWrappableBase class in order to provide the internal pointer independent from V8Type.

The end to end change will be http://crrev.com/420233002

BUG=235436

Review URL: https://codereview.chromium.org/422873002

git-svn-id: svn://svn.chromium.org/blink/trunk@179098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r172647, I changed the AnimationPlayerCountedSet from a HashCountedSet to a HashMap, because at that time Oilpan didn't support a HashCountedSet. Now that Oilpan supports a HashCountedSet, this CL changes it back to a HashCountedSet again.

BUG=340522

Review URL: https://codereview.chromium.org/425903003

git-svn-id: svn://svn.chromium.org/blink/trunk@179097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
    Children of flexbox with flex-direction: column/column-reverse
    shrinked their height after applying the overflow: scroll
    style. Children shows an incorrect height. The difference
    in height coming is equal to scrollbarLogicalHeight.
    
    This bug is occuring because we are not taking into
    account the scrollbar height while computing the
    mainAxisExtentForChild. This patch fixes this bug
    by adding scrollbarLogicalHeight while calculating
    mainAxisExtentForChild.
    
    BUG=364977

Review URL: https://codereview.chromium.org/417153003

git-svn-id: svn://svn.chromium.org/blink/trunk@179095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179076

BUG=394619
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/422843006

git-svn-id: svn://svn.chromium.org/blink/trunk@179094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cast highestEnclosingNodeOfType() return value to tighter type to increase
code readability. This CL also renames the type checking functions passed
to highestEnclosingNodeOfType() to make it clear what type of Node/Element
is returned.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/417113011

git-svn-id: svn://svn.chromium.org/blink/trunk@179093 bbb929c8-8fbe-4397-9dbb-9b2b20218538