GitLab

blink::kAuto and blink::kFixed from the enum LengthType is often
shadowed by other kAuto and other kFixed which triggers a ton of
warnings when trying to enable -Wshadow. This makes enum LengthType
into e class enum in Length, named Type. (So it will be be
Length::kAuto instead of just kAuto)

Bug: 925310
Change-Id: I6da0577c1a52954229297d9e0d81cb93fda60376
Reviewed-on: https://chromium-review.googlesource.com/c/1437282Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632694}

This reverts commit 6e200e4f.

Reason for revert: Unfortunately, this CL landed within minutes of
this other CL that renames TYPE_CLIPBOARD_URL to TYPE_CLIPBOARD.

That causes a genuine merge conflict and makes all the buildbots fail
the compile step. I recommend this CL be relanded with the enum name
updated. I can review the reland in short order.

Original change's description:
> [omnibox]: Initialize HistoryURLProvider earlier.
> 
> This CL moves the HistoryURlProvider's initialization after the SearchProvider's
> but before the ZeroSuggestProvider's and ClipboardURLProvider's.
> 
> For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization
> last in the AutocompleteController's constructor. However, the zero suggest and
> clipboard URL providers take a reference of the history URL provider when
> initialized. To avoid setting these references to NULL, this CL moves the
> history URL provider's initialization before the other two's but keeps
> it after the search provider's for the reasons described in the other CL.
> 
> Bug: 932257
> Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17
> Reviewed-on: https://chromium-review.googlesource.com/c/1474383
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632682}

TBR=mpearson@chromium.org,jdonnelly@chromium.org,manukh@chromium.org

Change-Id: Ie825b2782b3d7cc4f48619b71955d641756d2f00
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 932257
Reviewed-on: https://chromium-review.googlesource.com/c/1475795Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632693}

This reverts commit 03f4bd63.

Reason for revert: landed fixes that was causing tab dragging to break (specifically https://chromium-review.googlesource.com/c/chromium/src/+/1474797 )

Original change's description:
> Revert "chromeos: disables event throttling in window-service clients"
> 
> This reverts commit 8e40f476.
> 
> Reason for revert: crbug.com/931878, touch tab-dragging gets broken
> 
> Original change's description:
> > chromeos: disables event throttling in window-service clients
> > 
> > Only the window-service should throttle.
> > 
> > BUG=929914
> > TEST=none
> > TBR=sadrul@chromium.org
> > 
> > Change-Id: Iab7ea987c8fcb1f52b9c1e69576a0f950d790787
> > Reviewed-on: https://chromium-review.googlesource.com/c/1470941
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#631868}
> 
> TBR=sadrul@chromium.org,sky@chromium.org
> 
> Change-Id: I4c356212aed1cf03b6c381ef05ce404a58517351
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 929914
> Reviewed-on: https://chromium-review.googlesource.com/c/1471458
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632025}

TBR=sadrul@chromium.org,mukai@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 929914
Change-Id: Ic0ee152a49bf03eb74fd5e1705cbab0f0e1248c1
Reviewed-on: https://chromium-review.googlesource.com/c/1475745Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632692}

The problem is URLLoader doesn't know chrome://external-file
So providing it with the actual file:// URL fixes the problem.

Bug: 928252
Change-Id: I1cda9cc076bd804a660aa46fdea84569bf7a5829
Reviewed-on: https://chromium-review.googlesource.com/c/1474686Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632691}

I have not made any significant contribution in compositor/ in the last
3 years. Since I'm focusing more on android_webview/, I'd like to unown
compositor/. Hopefully, this can open up more opportunity for others.

Change-Id: I9eb227c78b777199e78a89d5893febb652626d77
Reviewed-on: https://chromium-review.googlesource.com/c/1474598Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632690}

Bug: 790139
Change-Id: I78592ed1ca48b1f7ba44f496f5a82927a907ddf7
Reviewed-on: https://chromium-review.googlesource.com/c/1474545Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brad Hall <bradhall@google.com>
Cr-Commit-Position: refs/heads/master@{#632689}

This reverts commit da307f24.

Reason for revert: should no longer depend on chrome_login

Original change's description:
> chromeos: Disable Tast test security.Mtab to unblock LKGM rolls.
> 
> It's failing with:
> Error: [mtab.go:41] Root partition is mounted read/write; rootfs verification disabled?
> 
> Let's disable it while we figure out a workaround since it's blocking
> lkgm rolls.
> 
> Bug: 931431
> Change-Id: Ibf953f77009ead69902da163b750e53cf43c6ffe
> Reviewed-on: https://chromium-review.googlesource.com/c/1468599
> Reviewed-by: Dan Erat <derat@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631479}

TBR=derat@chromium.org,achuith@chromium.org,bpastene@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 931431
Change-Id: Ia496c1f04aaaabebc2737cca585a500a02c9928a
Reviewed-on: https://chromium-review.googlesource.com/c/1475814Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632688}

This document describes:
* Features (base::FeatureList)
* Flags (chrome://flags)
* Switches (command-line args)
* Prefs
* Settings (chrome://settings)

and outlines when and how to use each of them.

Bug: None
Change-Id: Ic2fa2151eb1ef0c1144ec007cb7d5e4a8b7f6343
Reviewed-on: https://chromium-review.googlesource.com/c/1470930
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632687}

Add histograms for different behaviors when scheduler refresh to easy
understand why scheduler returns kNoRequestWithWait so often.

Bug: 931265
Change-Id: I59f5a08f262b1c11c152790d442bb6c900c3045b
Reviewed-on: https://chromium-review.googlesource.com/c/1471391
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632686}

Initialize all ProtoDatabases on construction of UsageStatsDatabase.

Initialization is asynchronous, so in the event that a
UsageStatsDatabase function is called when the underlying
ProtoDatabases are not yet initialized, store a base::Closure in a
queue for later execution.

Bug: 931476
Change-Id: I76399c3ceb1ad92075af70d5976fa182cb8dfb45
Reviewed-on: https://chromium-review.googlesource.com/c/1474540
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632685}

This CL assigns:
  enable-ntp-asset-download-suggestions
  enable-ntp-bookmark-suggestions
  enable-ntp-offline-page-download-suggestions
  enable-ntp-remote-suggestions
  enable-ntp-snippets-increased-visibility
  enable-ntp-suggestions-notifications
to fgorski@ for M76. These flags are currently in the process of being cleaned
up.

Bug: None
Change-Id: Idef188192a6cb9bd4a8ebee6a3232421c5a84cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1474465
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632684}

RTCPeerConnectionHandler.

Currently RTCPeerConnectionHandler::OnIceCandidate only considers
candidates with literal IPv4 or IPv6 addresses as legitimate. Hostname
candidates are now supported by WebRTC, notably when the mDNS
concealment of local IPs is enabled.

Bug: 930339
Change-Id: Ia84328c39a5163f0816b7522421a56cc79aaf965
Reviewed-on: https://chromium-review.googlesource.com/c/1472253Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Auto-Submit: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#632683}

This CL moves the HistoryURlProvider's initialization after the SearchProvider's
but before the ZeroSuggestProvider's and ClipboardURLProvider's.

For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization
last in the AutocompleteController's constructor. However, the zero suggest and
clipboard URL providers take a reference of the history URL provider when
initialized. To avoid setting these references to NULL, this CL moves the
history URL provider's initialization before the other two's but keeps
it after the search provider's for the reasons described in the other CL.

Bug: 932257
Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17
Reviewed-on: https://chromium-review.googlesource.com/c/1474383Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632682}

ClipboardURLProvider now provides matches for text and images on the
clipboard as well as URLs. Therefore, we should rename it to just
ClipboardProvider.

Bug: 923443
Change-Id: I43ab8036cf2b0c564ebc3588b4c2324628ab2ee7
Reviewed-on: https://chromium-review.googlesource.com/c/1445401Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#632681}

Migration is complete! Delete AssertBlockingAllowedDeprecated().

Bug: 903957
Change-Id: I683e879f8d1f07a1e38d2fa6bb1423101699fb68
Reviewed-on: https://chromium-review.googlesource.com/c/1474826
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632680}

The heap collector is enabled only on devices with the new version of tcmalloc
on the canary and dev channels.

The collector is enabled for all browser processes on the canary channel and
with a 20% probability for browser processes on the dev channel.

Added a new collection status value, UNABLE_TO_COLLECT, used when collection
cannot be started due to technical reasons.

BUG=b:121160411
TEST=Unit tests pass

Change-Id: I3b71c2b10cc00cda66bf845fc5ac6f255dade3c6
Reviewed-on: https://chromium-review.googlesource.com/c/1435075
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632679}

This reverts commit 860f3c63.

Reason for revert: landed fixes that was causing tab dragging to break (specifically https://chromium-review.googlesource.com/c/chromium/src/+/1474797 )

Original change's description:
> Revert "Reland "chromeos: makes resizes smoother with mash""
> 
> This reverts commit fca998b7.
> 
> Reason for revert: crbug.com/931878, touch tab-dragging gets broken
> 
> Original change's description:
> > Reland "chromeos: makes resizes smoother with mash"
> > 
> > This reverts commit 643813e1.
> > 
> > Reason for revert: My test was wrong, we actually block mouse on device in certain modes. Sorry for the noise.
> > 
> > Original change's description:
> > > Revert "chromeos: makes resizes smoother with mash"
> > > 
> > > This reverts commit b805090b.
> > > 
> > > Reason for revert: This makes the mouse get stuck hidden on device.
> > > 
> > > Original change's description:
> > > > chromeos: makes resizes smoother with mash
> > > > 
> > > > This contains two changes:
> > > > 1. Adds call from ClientRoot to Compositor::OnChildResizing(). This ensures
> > > >    that WindowTreeHost doesn't dispatch move events until the frame has been
> > > >    activated.
> > > > 2. Converts resetting of pointer moves lock from OnCompositingDidCommit()
> > > >    to OnCompositingEnded(). OnCompositingDidCommit() seems to be called much
> > > >    to earlier in the mash case, and results in jank when resizing.
> > > > 
> > > > BUG=929914
> > > > TEST=none
> > > > 
> > > > Change-Id: I68d87d6e7f237f246c2fad6218d9da5356c98641
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1467917
> > > > Commit-Queue: Scott Violet <sky@chromium.org>
> > > > Reviewed-by: Saman Sami <samans@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#631743}
> > > 
> > > TBR=sky@chromium.org,samans@chromium.org
> > > 
> > > Change-Id: Iaf103ed66885da652c7013fcc412b0269e10b303
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 929914
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1470935
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Commit-Queue: Scott Violet <sky@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#631803}
> > 
> > TBR=sky@chromium.org,samans@chromium.org
> > 
> > Change-Id: I828256b878dfb8f5a8ec0bbd6c6c533e091ddb5f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 929914
> > Reviewed-on: https://chromium-review.googlesource.com/c/1471010
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#631820}
> 
> TBR=sky@chromium.org,samans@chromium.org
> 
> Change-Id: Id7eb67f636e13677122c6a8bd0c8e50bd4b51986
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 929914
> Reviewed-on: https://chromium-review.googlesource.com/c/1471493
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632024}

TBR=mukai@chromium.org,sky@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 929914
Change-Id: I773ef9e31de890222104dc6cbf9e0f44466901d4
Reviewed-on: https://chromium-review.googlesource.com/c/1475743Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632678}

This reverts commit 7fd1139c.

Reason for revert: It will fix unnecessary Vox announcement for app list button when launcher is opened.

Original change's description:
> CrOS Shelf: Cleanup unnecessary override in ShelfButton
> 
> The implementation of |GetAccessibleNodeData| in the base
> Button class is more than sufficient, and does all the things
> the ShelfButton does (and more).
> 
> Change-Id: I3ee2d6f8ecff676fcad34e2216199128394cf731
> Reviewed-on: https://chromium-review.googlesource.com/c/1446256
> Auto-Submit: Manu Cornet <manucornet@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#627956}

Bug: 932200
TBR=xiyuan@chromium.org,manucornet@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icd7ef295f026f4dc237d7920185eebb3a2aa51b2
Reviewed-on: https://chromium-review.googlesource.com/c/1474680Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Auto-Submit: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632677}

This hasn't had any builds since 04/2018

Bug: 790146
Change-Id: I867b60e3dd9e4250fc739aa4ec13d97f32e65c23
Reviewed-on: https://chromium-review.googlesource.com/c/1475168
Commit-Queue: Brad Hall <bradhall@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632676}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug: 714018
Change-Id: I94b9f1129b8e818b2ecb4896f8974bf08cc66f2c
Reviewed-on: https://chromium-review.googlesource.com/c/1474821
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632675}

https://android.googlesource.com/platform/external/perfetto.git/+log/2f1b272e0818..5e577f20fc7c


git log 2f1b272e0818..5e577f20fc7c --date=short --no-merges --format='%ad %ae %s'
2019-02-15 fmayer@google.com Merge "Protect SharedRingbuffer against concurrent manipulation."


Created with:
  gclient setdep -r src/third_party/perfetto@5e577f20fc7c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I4a432a2fb2328983f25f9213493f6cf10ea00467
Reviewed-on: https://chromium-review.googlesource.com/c/1475588Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632674}

These tests assume that native memory buffers are not available on
Android. This is not true for Android O and above. The fix uses
base::AndroidHardwareBuffercompat to check availability of native
buffers.

BUG=931937

Change-Id: Ia8938b1d2301d841b1c0aaf06b116dc19976c35a
Reviewed-on: https://chromium-review.googlesource.com/c/1474439Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632673}

This CL removes a member that became unused because EventTiming should
report even when no listener or default actions are executed.

Change-Id: I5dc175640278bc930c97b90ecce09deb8b79786b
Reviewed-on: https://chromium-review.googlesource.com/c/1475741Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632672}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=jbudorick@chromium.org

Bug: 714018
Change-Id: I2dc7e10e53b85661d646a0c2abb429eb05a9abcf
Reviewed-on: https://chromium-review.googlesource.com/c/1475638
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632671}

Following bot results are included.
15191 15193 15196 15207 15220 15231 15251 15257 15260 15262
15266 15276

99 lines were removed and 14 lines were deflaked by consecutive
results since 15191.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Ic9a6c959c78e95e9c27164209ca00e658bb6995f
Reviewed-on: https://chromium-review.googlesource.com/c/1464679Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632670}

If the media session is paused then we should not
apply transient focus types (ducking, pausing). If
the session is resumed then we should reapply those
types.

BUG=931898

Change-Id: Iabcaae24f42e6b3012c8e5098830d1115aecfdca
Reviewed-on: https://chromium-review.googlesource.com/c/1473832Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632669}

Per discussions with chromeos-system-services.

Bug: None
Change-Id: Iaf001625d37578bbf3a39d1bd64ea012e1bdb525
Reviewed-on: https://chromium-review.googlesource.com/c/1473613Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632668}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 714018
Change-Id: I508a403ccfef05e21920db6b84b3ae06655d8a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1475734
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632667}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d70d87c663f3..33bba657449d


git log d70d87c663f3..33bba657449d --date=short --no-merges --format='%ad %ae %s'
2019-02-15 evanhernandez@chromium.org cros branch: Add descriptor to branch name.


Created with:
  gclient setdep -r src/third_party/chromite@33bba657449d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifed88c56ebedf9fba32ed1a6bb32eee41ebbe56f
Reviewed-on: https://chromium-review.googlesource.com/c/1475583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632666}

This is in preparation of the contactsJson param being removed from the interface.

Bug: 860467
Change-Id: I296392446a3a40e1990ed9fb946b66d6fc685f80
Reviewed-on: https://chromium-review.googlesource.com/c/1475183
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632665}

Currently some shelf buttons (launcher button, overflow button) do not
have any outline when focused (only app buttons do).

This change moves the single line creating a focusing painter up the
class hierarchy so that all shelf buttons have at least a visual cue
indicating focus.

I might refine this in the future so that the focus ring is circular
for circular buttons (currently it's a rounded corner square), but this
at least fixes the core issue.

Bug: 753409, 884799
Change-Id: I28bb2e77e5d35bc08a1374d75fea6dbf4ee816ca
Reviewed-on: https://chromium-review.googlesource.com/c/1474885
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632664}

Bug: 932350
Change-Id: Idf2dbca27379389212277cfc20543b9b387440b9
Reviewed-on: https://chromium-review.googlesource.com/c/1475196Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632663}

Bug: 893460
Change-Id: I5618e7da43eb99e59839549c9669deeb61ee65f6
Reviewed-on: https://chromium-review.googlesource.com/c/1474438Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#632662}

This is a precursor CL to the CL that will change GCMS::AddAccountToCookie
to take a completion callback rather than calling the
GCMS::Observer::OnAddAccountToCookieCompleted.

With this CL GCMS::SignalComplete now is called solely in the context
of a GCMS::AddAccountToCookie calls. Previously it could be
called in the context of a GCMS::ListAccount call too (see stack below).

  #1 0x55d9e66a8018 AccountReconcilor::OnAddAccountToCookieCompleted()
  #2 0x55d9e5d0df79 identity::IdentityManager::OnAddAccountToCookieCompleted()
  #3 0x55d9e66c0ad8 GaiaCookieManagerService::SignalComplete()
  #4 0x55d9e66a77d9 AccountReconcilor::FinishReconcile()
  #5 0x55d9e66a6568 AccountReconcilor::OnAccountsInCookieUpdated()
  #6 0x55d9e5d0dd8d identity::IdentityManager::OnGaiaAccountsInCookieUpdated()
  #7 0x55d9e66c59de GaiaCookieManagerService::OnListAccountsSuccess()
  #8 0x55d9e5cf9316 GaiaAuthFetcher::OnListAccountsFetched()
  (...)
  #xx GaiaCookieManagerService::TriggerListAccounts
  #yy GaiaCookieManagerService::ListAccounts

Additionally, the CL removes the only caller of GCMS::SignalComplette
(AccountsCookieMutator::ForceTriggerOnAddAccountToCookieCompleted and its respective
unittests).

No behavior change is expected, since GCMS::SignalComplete calls out to
AccountReconcilor::OnAddAccountToCookieCompleted

BUG=932180

Change-Id: Ib64e96ae4761fa2976c6f07a457ad756084cf029
Reviewed-on: https://chromium-review.googlesource.com/c/1474111Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#632661}

|active_source_nodes_| tracked the active source nodes.  But we really
want to track the handlers for the nodes because that's what is really
running.  The nodes themselves may go away, but the handlers can still
be alive.

Thus, rename active_source_nodes_ to active_source_handlers_ and move it
to the DeferredTaskHandler class.

Bug: 752333
Change-Id: I1d7b39863f66782b6945fd5b7f02ab169c39584f
Reviewed-on: https://chromium-review.googlesource.com/c/1459791Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632660}

This test makes a request to Litepages integration test site, and then checks whether an expected report has been sent to the reporting endpoint by looking at netlogs (the endpoint will only return 200 on receiving expected report).

Design doc: https://docs.google.com/document/d/1sqfM65y0D31GGKB9vUCT8QqWFafQPGH-pYR1tzX7nos/edit#heading=h.8l9t303augmm

add new test

Bug: 929774
Change-Id: If894450e87bdf6b8baa7d9d767fe44e4f4345192
Reviewed-on: https://chromium-review.googlesource.com/c/1474381Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Xing Xu <xingx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632659}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=danakj@chromium.org, rmcilroy@chromium.org

Bug: 714018
Change-Id: I864f484c23ef23b0ced770ef1e0e768a013c3156
Reviewed-on: https://chromium-review.googlesource.com/c/1475649Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632658}

Follows https://github.com/WICG/kv-storage/pull/51.

Bug: 931263
Change-Id: Ia3b1482093bfaca443b8809c6e284397fdb6fec1
Reviewed-on: https://chromium-review.googlesource.com/c/1466863Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632657}

Change-Id: I014c9f549e8ef65782590056ad3dbe5722bb7d24
Reviewed-on: https://chromium-review.googlesource.com/c/1471954Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632656}

You should not access a unique_ptr in the same expression you are moving it.
This currently only crashes with MSVC 2017, but being undefined and could also
crash in the future with clang.

Bug: 887865
Change-Id: I9c242896e91d4c250e474667ed2132ba8587117c
Reviewed-on: https://chromium-review.googlesource.com/c/1238217
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632655}