- 02 Oct, 2019 40 commits
-
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in tools/android to the recommended methods/types. Bug: 1007843 Change-Id: Ia955cfe01bc7e23c73e7deda469d9408aa3c90ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832213 Commit-Queue: David Turner <digit@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702133}
-
Garrett Beaty authored
Bug: 878706 Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#702132}
-
Ben Pastene authored
To reflect go/request-chrome-resources. Change-Id: Iecd7438482cc62ac7570e4b4b11d67a8af449cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834827Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#702131}
-
Ian Barkley-Yeung authored
Added some VLOG messages to ChromeCrashReporterClient::GetCollectStatsConsent to explain why it is returning false. Crash-related tests on ChromeOS have been flaky; this is part of understanding why. BUG=chromium:994987,chromium:984807 TEST=Ran Chrome with and without consent, and Chromium with and without consent. Ensured crash dumps produced only for Chrome with consent, and that (with --vmodule=chrome_crash_reporter_client=1), expected messages were generated. Change-Id: Iecf77fd78a7aee0c5eb2ba852ad576d84cac6b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833929Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#702130}
-
Shakti Sahu authored
Bug: 856383 Change-Id: I5d4f4f5667c27c518dedb50304ab94246e0960de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834424Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702129}
-
Joshua Peraza authored
Also, Crashpad for Android can't yet monitor itself in the various configurations that Chrome packages it, so remove references to the flag from crashpad_android.cc to avoid accidentally turning it on. Bug: 942279 Change-Id: I1afae5fd433f9e2b1475e8fa3e883547542eb6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834401Reviewed-by:
-
Dana Fried authored
This CL fixes an error where the preview captured from a loading webpage (used in hover cards and tablet tabstrip) could appear blurry or stretched when the aspect ratio of the window did not match the thumbnail. It solves the problem by providing a max capture size based on the ratio between the desired and current window size, then clipping the image down later, just as we do with single-frame capture of active windows on tab switch. Still to do: - Trim scroll bars out of the final captured image. Change-Id: I8cbeee5c9c5959163d2e7f0b6251802f40455f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818641 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#702127}
-
Martin Robinson authored
The computed name is more useful to the user and a bit friendlier than values like "-webkit-sans-serif." Bug: 1005109 Change-Id: I8b0c3293072a456dd024c835431b724215072988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818483 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#702126}
-
Junyi Xiao authored
Issue: In the network tool, there is a pop up for stack traces that appears when you hover over the initiator column. This info is not available anywhere else, and is not keyboard accessible. This changes: add a new tab to the network item view, similar to the Timings tab and Waterfall column (which is available when hovering over the waterfall, but also accessible when selecting a network request to view). Bug: 963183, 842488 workflow gif: https://imgur.com/a/wmdNYXE Change-Id: Ib2f23b924a06e687acd362ccf4d6764f8a996559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742990 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702125}
-
Xianzhu Wang authored
This is a follow-up of crrev.com/c/1818717 which removed cc's dependency on most of the viewport layers, so we no longer need to create some of these layers. Bug: 909750 Change-Id: I93326b3c8b4a7cb0996af196afc08c3f39fa9d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818599 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702124}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e849e6783d9f..4167aa75260f git log e849e6783d9f..4167aa75260f --date=short --no-merges --format='%ad %ae %s' 2019-10-02 rharrison@google.com Rolling 4 dependencies (#817) Created with: gclient setdep -r src/third_party/shaderc/src@4167aa75260f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ia979a091f928272a5b9fe83a66abf89ca529e34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702123}
-
Xiaohui Chen authored
If |LogoViewImpl::StartTimer()| is called multiple times, it will potentially leave a dangling observer in compositor. Bug: 994451 Test: locally build and run Change-Id: Ie972ebc40f67d8580e546a1f6a79354bcd3ff1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834572Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deac9a0ff801..bb5d5accb146 Created with: gclient setdep -r src-internal@bb5d5accb146 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idf7522ef5c86e40df5b2427b1b03743508b908e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836081Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702121}
-
Xida Chen authored
There are 3 layout tests that crashes with off-thread paint worklet. The reason is that these tests are checking paint invalidation and have a special code path that never goes to the compositor thread. So for these tests, we should just fall to the main thread. Bug: 990382 Change-Id: I389b991da4469e4ba965e1390f4bcc2d3800e2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789828Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702120}
-
Fredrik Söderquist authored
Rename it to HandleIntervalRestart(...), and fold the check for an unresolved interval into it while sinking the actual interval resolution out into the caller (UpdateInterval). This allows merging the two ResolveInterval() calls. Bug: 998526 Change-Id: I23e3caab69a09aa701f16c0bda6a8751676149b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834089Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f45ddb9b..4c982147 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic48a52f2211fba7035122ae626fef74a9985c4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836051Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702118}
-
Kevin Bailey authored
It doesn't look like we'll use this (reversing the logic of the tab switch button behavior) so remove the feature and the no-longer necessary logic. Bug: 920628 Change-Id: Icfba78999d3b535dcbe5da2d0025b9519f746619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834877Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702117}
-
Tarun Bansal authored
Fetch hints from remote service at the time of navigation. Hints are fetched only if connection is slow. Change-Id: I37e13072b17e1adfe9b3365e2dca04ae9bdfc246 Bug: 933898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829474 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702116}
-
Donn Denman authored
BUG=1008973 Change-Id: I796131daaa611a14647a5ea2d480dacfc43b2bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836012 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#702115}
-
Avi Drissman authored
BUG=1010510 Change-Id: Id17f02751175fc1fefdbd7834f78302d2e04ff23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835156 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#702114}
-
Jeffrey Yasskin authored
This reverts commit ef7a869a. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/59576: [ RUN ] SSLClientSocketTest.EarlyDataReasonReadServerHello [4260:5836:1002/055310.421:661881:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: / [4260:5836:1002/055310.437:661896:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: / ../../net/socket/ssl_client_socket_unittest.cc(5922): error: Value of: MakeHTTPRequest(sock_.get()) Expected: net::OK Actual: -103, net::ERR_CONNECTION_ABORTED ../../base/test/metrics/histogram_tester.cc(202): error: Expected equality of these values: expected_count Which is: 1 actual_count Which is: 0 Histogram "Net.SSLHandshakeEarlyDataReason" does not have the right number of samples (1) in the expected bucket (2). It has (0). ../../base/test/metrics/histogram_tester.cc(217): error: Expected equality of these values: expected_count Which is: 1 actual_count Which is: 0 Histogram "Net.SSLHandshakeEarlyDataReason" does not have the right total number of samples (1). It has (0). Original change's description: > Expand TLS 1.3 handshake 0-RTT UMA detail > > This commit extends metrics coverage to provide more descriptive > logging of TLS 1.3 handshakes' 0-RTT state, by logging the > ssl_early_data_reason computed in BoringSSL. This records whether > TLS 1.3 early data handshake attempts succeed and, if they fail, > why. > > R=csharrison@chromium.org,davidben@chromium.org > > Bug: 1000659 > Test: expanded prior metrics unittests to cover new cases > Change-Id: Iaeba249c2be3ddb23900a51f9d223580481421f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784159 > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701978} TBR=davidben@chromium.org,csharrison@chromium.org,davidvc@chromium.org Change-Id: If78bf1c72917bea3a2453e3831515fa65982625f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834948Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702113}
-
Ahmed Fakhry authored
When initializing a new widget such that its native window is added as a transient child of a window tracked by a WindowPreviewView, WindowPreviewView gets notified with this addition *before* the window is parented to a container. If we try to get its WindowState at this point we would crash at this line: https://cs.chromium.org/chromium/src/ash/wm/window_state.cc?rcl=110515d4d38fd48cb9c6a1d0d3e4f9abf7c415f4&l=820 This CL fixes this issue and adds a test that fails without the fix. BUG=1003544 TEST=Added a new test Change-Id: I794d312601eb5b80f1928e86ba0fa42911b8c327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826031 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#702112}
-
Tim van der Lippe authored
- Change Multimap to Platform.Multimap - Importscripts in workers. This means that the file does not export any utilities, but we will need to clean that up later. Bug: 1006759 Change-Id: I91d45febebfc597f0d0b5c6a017c26f6b12b84b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832218 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Niels Möller authored
The latter is being deprecated in https://webrtc-review.googlesource.com/c/src/+/155163 Bug: webrtc:9378 Change-Id: I5356a62fa4f7b7790ff24aab814b647f2a21117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833466 Auto-Submit: Niels Möller <nisse@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#702110}
-
Ken Rockot authored
This reverts commit 301064ba. Reason for revert: There haven't been any flakes since https://crrev.com/25a48a5b landed, and that CL was fixing other flakes within the same test fixture. Very likely the same underlying cause, and very likely fixed already. Original change's description: > Disable flaky CorruptionOnDisk. > > See bug. > > TBR=dmurph@chromium.org, mpearson@chromium.org, rockot@chromium.org, mek@chromium.org, jam@chromium.org > > Bug: 1010414 > Change-Id: I4a87b8873a878cedeaf5d87bc62474a2adaa1444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834088 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701993} TBR=mpearson@chromium.org,dmurph@chromium.org,jam@chromium.org,rockot@google.com,mek@chromium.org,hbos@chromium.org Change-Id: I3817ca06b75a15f6fc2d4e993887430c16649a8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835067Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#702109}
-
Morten Stenshorne authored
This adds layout engine support for break avoidance between block children, if the LayoutNGBlockFragmentation feature is enabled. This feature is still not shipping, and it is also worth noting that fragment painting needs some work before we can paint and hit-test this properly (which is a general issue for LayoutNGBlockFragmentation, not break avoidance in particular). The solution is built on top of NGEarlyBreak, which can set up possible breakpoints before and inside blocks. Another important change is the introduction of "break appeal", i.e. how attractive a possible breakpoint is. Previously this was a binary thing; the break was either considered good or last-resort. Now we set appeal, which will decrease by rule violation severity. Bug: 223068, 829028 Change-Id: I7bb19028821eaf380c70c7bd92b3338f47124dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831804 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702108}
-
Etienne Bergeron authored
This CL is changing the file path from type SkString to base::FilePath. It's also using a size_t for iterating through a vector space. Change-Id: Ic345514557365e1e7a0115eddfae365c1b97b3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829791Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702107}
-
Rakib M. Hasan authored
The test_results_writer.write_test_result function has a large if else statement which decides which artifacts to write. The if else statement looks at which failure type instance is in the failures list. We can use a more objected oriented approach for creating artifacts by making each failure type handle the creation of its artifacts. This will lead to deduplication of logic for writing artifacts. Bug: chromium:982208 Change-Id: I260b26d44765bcbf9ae6d72451fa6b7590c80056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829752Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#702106}
-
Brian White authored
Adds expires_after attribute for 213 histograms that do not show any access in the past 30 days. Change-Id: I253f523a231690a6fb04cbb31411cee0da6b457f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835675 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#702105}
-
Kevin Ellis authored
This patch updates the implementation of Animation::setCurrentTime to be spec compliant. Explicitly setting the current time resets any pending tasks as reflected in the changed test expectations. One of the three test failures in finished is also addressed. The introduction of microtasks does not fully address the problem of early resolution of the finished promise, which requires fully phasing out PlayStateUpdatScope. Presently, the effect of duration shortening is not caught until the next animation frame. Addressing this failure may require notifying the animation of a timing change in order to trigger a state change check as a microtask. Bug: 960944 Change-Id: Iccd18b49ff2aa930e4fd72122d8ceddc052300d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832765 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
zhaoyangli authored
Initialize base::CommandLine arguments from NSProcessInfo in EG2 test bundle so that command line arguments can be accessed in EG2 test cases through base::CommandLine::ForCurrentProcess(). Bug: 922813, 1000474 Change-Id: Ie214ca281fedd5f24b489e2f1605c28ce3abd669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833044Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702103}
-
Lily Chen authored
Bug: 1005217 Change-Id: I16715129269802acfd3c25413545bec02711316a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835152 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702102}
-
Ethan Nicholas authored
The Skia shading language has changed slightly, necessitating the removal of 'in' from the uniforms in this code. See the comment at GrSkSLFP.h:41 for an explanation of how 'in' and 'uniform' work in runtime shaders now. Change-Id: I9cfef99f51cfb2c7cd37b284b2506dd261d8e87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827998 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702101}
-
Manas Verma authored
Making sure only user-verifying platform authenticators are registered when WebAuthn prompt is shown. Bug: 949269 Change-Id: I2ceeb3a38ec9e7e6529d11af02794a61bc244f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832662 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#702100}
-
Brian Sheedy authored
Removes the golden revision property from PixelTestPage, as it has not been used since switching the GPU pixel tests over to Skia Gold. Bug: 1008524 Change-Id: I5a88285b147fbc14b794a2a35434bf00e4300a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834831 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#702099}
-
Kush Sinha authored
It is launched and enabled on ToT. Bug: 1009960 Change-Id: Ibf21cdd01c6858c3d6959b2dd2740843445bde86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832814Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#702098}
-
Lei Zhang authored
Hopefully this can replace base::SHA1HashBytes() in the long run. Change-Id: Ie9138b569d59c8b252fa14262a56ced56f74a397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827647 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#702097}
-
Manu Cornet authored
There are still issues in the app list visibility observer patterns, but this is a step towards smoother animations by letting the shelf config be aware of the new "desired" state sooner. Bug: 1006013 Change-Id: Id90e2355f8120fcb51319189288a1956506dc8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832634 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702096}
-
Yue Li authored
This is a reland of 5072afda Original change's description: > Remove AssistantState::VISIBLE > > Remove the VISIBLE state and use AssistantVisibility instead. > Also remove obsolete handling for AGSA animations. > > Bug: b/140823590 > Test: Run existing tests > Change-Id: Id64c5e536dfe6d3e10c9b003c135e76c96a9fee1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802819 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696936} Bug: b/140823590 Change-Id: Ia161398488e6d920548ade8a1eb37a0a99cc3403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832704 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f03259ad7205..514d5e281c03 git log f03259ad7205..514d5e281c03 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 jmadill@chromium.org Vulkan: Remove global finish in ContextVk::onDestroy. 2019-10-02 geofflang@chromium.org Don't expose CHROMIUM_color_buffer_float_rgb[a] in ES3.0+ Created with: gclient setdep -r src/third_party/angle@514d5e281c03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I764d3e5a3752c21ef0d486b22010253d51335dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836071Reviewed-by:
-
