1. 28 Sep, 2017 40 commits
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · c6083866
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=xiyuan@chromium.org
      
      Bug: 666525
      Change-Id: I10358379bca0403dc8a3d27fbfd02a632cce65d3
      Reviewed-on: https://chromium-review.googlesource.com/689104Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505049}
      c6083866
    • Mostyn Bramley-Moore's avatar
      Update AUTHORS file for Vewd Software · e0ce83e8
      Mostyn Bramley-Moore authored
      Formerly known as Opera TV.
      
      TBR=jochen@chromium.org
      
      Change-Id: I22ffe796c455e75cba9e0624727ea6499097ac83
      Reviewed-on: https://chromium-review.googlesource.com/689514Reviewed-by: default avatarMostyn Bramley-Moore <mostynb@opera.com>
      Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
      Cr-Commit-Position: refs/heads/master@{#505048}
      e0ce83e8
    • Ella Ge's avatar
      Do not add touchpoint when reach kTouchesLengthCap · f69b51b1
      Ella Ge authored
      In this cl, we throw error in EventSender::AddTouchPoint
      to prevent touch_point_.size() exceed kTouchesLengthCap.
      
      Bug: 764921
      Change-Id: Ifbb8db421f1a523e91a845284656b17d6269bb40
      Reviewed-on: https://chromium-review.googlesource.com/687809Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
      Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
      Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505047}
      f69b51b1
    • Xianzhu Wang's avatar
      Update SPv2 test expectations about video · 0988f9b7
      Xianzhu Wang authored
      1. Skip virtual/new-remote-playback-pipeline/ which is under
         development.
      2. Remove baselines for paint/invalidation/video-[un]mute-repaint.html
         and expect failures. The video implementation is being changed and
         we can't catch up with it.
      
      TBR=pdr@chromium.org
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      Change-Id: I3f5cf22ddb879d77bfc78c86227b4ae06fa5d25d
      Reviewed-on: https://chromium-review.googlesource.com/690323Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505046}
      0988f9b7
    • John Chen's avatar
      Add media trace events for perf benchmark · 6e481570
      John Chen authored
      Add media trace events needed to calculate buffering time, dropped
      frame count, and seek time in media perf benchmarks.
      
      Bug: 700160
      Change-Id: I340fe3763a73fe3a77e6a04d0d8761811ae6838e
      Reviewed-on: https://chromium-review.googlesource.com/674166
      Commit-Queue: John Chen <johnchen@chromium.org>
      Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505045}
      6e481570
    • Xida Chen's avatar
      Mark fast/events/mouse-cursor-change-after-image-load.html crash · 57a3a0ca
      Xida Chen authored
      TBR=chongz@chromium.org
      NOTRY=true
      
      Bug: 652536
      Change-Id: Ib64364b32cbaeafa9423f87d4a6ed776f4fdbe44
      Reviewed-on: https://chromium-review.googlesource.com/690439Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
      Commit-Queue: Xida Chen <xidachen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505044}
      57a3a0ca
    • Chromium WPT Sync's avatar
      Import wpt@0f1ee41f0a201f836a5d4983bab14884c499b6b9 · d249361a
      Chromium WPT Sync authored
      Using wpt-import in Chromium 5738043d.
      
      Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2515
      
      Note to sheriffs: This CL imports external tests and adds
      expectations for those tests; if this CL is large and causes
      a few new failures, please fix the failures by adding new
      lines to TestExpectations rather than reverting. See:
      https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
      
      TBR=qyearsley@chromium.org
      
      No-Export: true
      Change-Id: I5fe3217aabe3bc3d3804d4253d142c16cc3b03c7
      Reviewed-on: https://chromium-review.googlesource.com/690218
      Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
      Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505043}
      d249361a
    • Xida Chen's avatar
      Disable TileGridLayoutTest#testModernTileGridAppearance_Two · 29a51ce7
      Xida Chen authored
      It has been flaky. I will let this CL go through CQ to make sure there is
      no build failure
      
      TBR=dgn@chromium.org
      
      Bug: 769738
      Change-Id: I495c98457d6139d6c46577d30d101b1ca4c4aa29
      Reviewed-on: https://chromium-review.googlesource.com/690320Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
      Commit-Queue: Xida Chen <xidachen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505042}
      29a51ce7
    • Gauthier Ambard's avatar
      Respect safe area for NTP view · d909eb87
      Gauthier Ambard authored
      The NTP view cannot use the safeAreaInsets property directly as it is
      snapshotted before being inserted in the view hierarchy, and the safe
      area is only available for views in the view hierarchy.
      This CL introduces a property mirroring the safe area once the view is
      in the view hierarchy. But it is also set up with the value used in the
      first frame, allowing the snapshot to be done as if the view was in the
      view hierarchy.
      
      Bug: 767869
      Change-Id: I605566105862e9f4c557736ec65df5f8ab1fc76b
      Reviewed-on: https://chromium-review.googlesource.com/681942
      Commit-Queue: Gauthier Ambard <gambard@chromium.org>
      Reviewed-by: default avatarRohit Rao (ping after 24h) <rohitrao@chromium.org>
      Reviewed-by: default avatarJean-François Geyelin <jif@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505041}
      d909eb87
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · 2ff2d156
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=msw@chromium.org
      
      Bug: 666525
      Change-Id: I310eea6b9f3dba136c2d46df235d9ce51b47b7a6
      Reviewed-on: https://chromium-review.googlesource.com/689100Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505040}
      2ff2d156
    • Marc-Antoine Courteau's avatar
      [Payment Request] Fixes a11y traits in the Picker View Controller. · 06f1401e
      Marc-Antoine Courteau authored
      These were not being updated when a different row was tapped.
      
      Bug: 
      Change-Id: Ib87d09ed55a4997c83a806146729861da6e64809
      Reviewed-on: https://chromium-review.googlesource.com/687823Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
      Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505039}
      06f1401e
    • Xiyuan Xia's avatar
      cros: Remove EasyBootstrap · 55a0cb65
      Xiyuan Xia authored
      Bug: 753543
      Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
      Change-Id: I4894763b0fb9817a879fcc8150522abd452a9910
      Reviewed-on: https://chromium-review.googlesource.com/688655Reviewed-by: default avatarTim Song <tengs@chromium.org>
      Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505038}
      55a0cb65
    • Mathieu Perreault's avatar
      [Autofill] Move AddressNormalizer and phone utils to Autofill · eea046d1
      Mathieu Perreault authored
      Functionality neutral refactor for an upcoming change. I started 
      pulling on AddressNormalizer and a lot of stuff came with it :|
      
      * AddressNormalizer and friends move to Autofill code.
      * GetCountryCodeWithFallback moves to autofill_data_util
      * Phone number utils move from Payment Request code to Autofill
      
      Bug: 767931
      Test: components_unittests
      Change-Id: I57b4b7863bc2f12408ab388694b349029607fe5e
      Reviewed-on: https://chromium-review.googlesource.com/688581Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
      Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
      Commit-Queue: Mathieu Perreault <mathp@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505037}
      eea046d1
    • Alexandr Ilin's avatar
      predictors: Add a shortcut for a history lookup · 3b950aea
      Alexandr Ilin authored
      This CL simplifies the learning part of the LoadingPredictor when 
      URL-based learning is disabled by skipping a history DB lookup as well 
      as skipping the update of ResourcePrefetchPredictor.DatabaseReadiness, 
      which also would entail a history DB lookup.
      
      Bug: 699080
      Change-Id: I46c2bf4482c291fa2ed5c64546b45118cb7b233b
      Reviewed-on: https://chromium-review.googlesource.com/686761
      Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
      Reviewed-by: default avatarMatthew Cary <mattcary@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505036}
      3b950aea
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · 7c06a6c3
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=rsesek@chromium.org
      
      Bug: 666525
      Change-Id: Iad735e1eddf2b56ec42f58a7c700628f7ef31df1
      Reviewed-on: https://chromium-review.googlesource.com/689141Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505035}
      7c06a6c3
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ 072c7102f..36dcd7f25 (1 commit) · 00462de4
      skia-deps-roller@chromium.org authored
      https://skia.googlesource.com/skia.git/+log/072c7102f4c9..36dcd7f25d1f
      
      $ git log 072c7102f..36dcd7f25 --date=short --no-merges --format='%ad %ae %s'
      2017-09-27 brianosman Enable caching of path mask textures by default
      
      Created with:
        roll-dep src/third_party/skia
      
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
      TBR=jvanverth@chromium.org
      
      Change-Id: Id909d28731130a3fb0c602c412b5e8e74db156f0
      Reviewed-on: https://chromium-review.googlesource.com/690316Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
      Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505034}
      00462de4
    • Mohammad Refaat's avatar
      Convert SystemCookieStore to Async. · 8505818b
      Mohammad Refaat authored
      * Converts SystemCookieStore to Async
      * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous
      functions.
      * Move creation time management to systemCookieStore.
      * Update cookie_store_ios_presistent_unittest & 
      cookie_store_ios_unittests to account for SystemCookieStore changes 
      * (As CookieStoreIOS is using systemCookieStore internally).
      
      Another CL is in progress to add WKSystemCookieStore & unit_tests for 
      systemCookieStore (to handle async methods) with template for both 
      NSHTTP & WK systemCookieStore.
      
      Bug: 759229, 759227, 767948
      Change-Id: I1c24c82540f4781a0bec77ebfa4a861ca7433391
      Reviewed-on: https://chromium-review.googlesource.com/675804
      Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
      Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505033}
      8505818b
    • Jorge Lucangeli Obes's avatar
      Update worker tests to avoid hitting memory limits. · b460a40f
      Jorge Lucangeli Obes authored
      https://chromium-review.googlesource.com/c/chromium/src/+/641992,
      the fix for crbug.com/752185, causes the following layout tests:
      
      * fast/workers/worker-exception-during-navigation.html
      * fast/workers/worker-multi-startup.html
      * http/tests/workers/terminate-during-sync-operation-file.html
      * http/tests/workers/terminate-during-sync-operation-filesystem.html
      * virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html
      * virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-filesystem.html
      
      to hit per-process memory limits on Linux. Fix by reducing the number
      of workers created in the tests from 30 to 20.
      
      See https://bugs.chromium.org/p/chromium/issues/detail?id=752185#c61
      for an explanation.
      
      BUG=752185
      TEST=Layout tests pass with related change.
      
      Change-Id: Ic0ebaaaad01ce05be5ca88214172d6141f57c2f0
      Reviewed-on: https://chromium-review.googlesource.com/685718
      Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
      Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
      Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
      Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505032}
      b460a40f
    • Luna Lu's avatar
      Browser-side UseCounter track kPageVisits in PageLoadMetricsObserver::OnCommit · 309089e7
      Luna Lu authored
      Bug: 760110
      Change-Id: I7c8e70af3cb5b58939a762d577b5374c54638aed
      Reviewed-on: https://chromium-review.googlesource.com/687574Reviewed-by: default avatarBryan McQuade <bmcquade@chromium.org>
      Commit-Queue: Luna Lu <loonybear@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505031}
      309089e7
    • Miriam Gershenson's avatar
      DNS histogram cleanup, part 1 · 40c4389f
      Miriam Gershenson authored
      Some of the DNS histograms are not useful anymore. A lot of them
      have no data but were never marked as obsolete. This CL deletes the ones
      I don't intend to replace with anything. Rearranging of the remaining
      metrics to be more useful will come in a future CL.
      
      Bug: 769320
      Change-Id: Ia45aaa5034371aa7780145ea991f624b52dd3b1a
      Reviewed-on: https://chromium-review.googlesource.com/673264Reviewed-by: default avatarJulia Tuttle <juliatuttle@chromium.org>
      Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
      Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505030}
      40c4389f
    • Adithya Srinivasan's avatar
      Remove StringImpl allocation in AtomicHTMLToken::InitializeAttributes · de41eb43
      Adithya Srinivasan authored
      Uses the AtomicString(Vector<UChar>) constructor for Attribute values.
      This is to remove an unnecessary memory allocation and conversion of
      attribute values to String (using Value8BitIfNecessary). The allocation
      is unnecessary for cases where the value is already present in
      AtomicStringTable.
      
      This CL also changes lookupHTMLTag to directly return an AtomicString,
      instead of converting it to a StringImpl and then back to an
      AtomicString.
      
      Bug: 
      Change-Id: I756f99cd57ebc20828d4a0430ba34f1018c730a4
      Reviewed-on: https://chromium-review.googlesource.com/685512Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
      Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505029}
      de41eb43
    • tzik's avatar
      Replace RefPtr<>::Get() with get() in platform/ · 3cf20755
      tzik authored
      RefPtr<>::Get() is being renamed to get() for a preparation of the
      unification of RefPtr and scoped_refptr.
      This CL updates calles of Get() in platform/ to use get().
      
      Bug: 763844
      Change-Id: I6884ea0a5bee8c1500c8a6de037c917a719ffc98
      Reviewed-on: https://chromium-review.googlesource.com/690355Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505028}
      3cf20755
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · 0aeaef80
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=miu@chromium.org
      
      Bug: 666525
      Change-Id: I518a4c7af8783cde82ca6b98796367e4530d94e0
      Reviewed-on: https://chromium-review.googlesource.com/689016Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
      Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505027}
      0aeaef80
    • Ran Ji's avatar
      Add WebAPK notification permission status UMA · 3e297acb
      Ran Ji authored
      Add a UMA to track whether user has WebAPK display notification permission
      enabled when a WebAPK receives a notification
      
      Bug: 685806
      Change-Id: I237947c44b8539e84384312b591be39d3759c4ed
      Reviewed-on: https://chromium-review.googlesource.com/667002Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
      Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
      Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
      Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
      Commit-Queue: Ran Ji <ranj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505026}
      3e297acb
    • Sigurdur Asgeirsson's avatar
      Reland "Make SECURITY_DCHECK play with Albatross." · e9d46063
      Sigurdur Asgeirsson authored
      This is a reland of 06d64c00
      Original change's description:
      > Make SECURITY_DCHECK play with Albatross.
      > 
      > In Albatross builds, DCHECKs can be compiled in, but non-fatal. See
      > https://docs.google.com/a/chromium.org/document/d/1QY4IbbJ8X6G-6-cMheEkP_mT7ZNPCuUJIW2sr_mEiH4
      > 
      > Bug: 596231
      > Change-Id: I84198f1d3f4122ac7a5bd8a90ed5ea96286b9022
      > Reviewed-on: https://chromium-review.googlesource.com/685498
      > Reviewed-by: Wez <wez@chromium.org>
      > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
      > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#504638}
      
      Bug: 596231
      Change-Id: I2c1223ba264dbdb06e814b92b84adfe9c3c619b7
      Reviewed-on: https://chromium-review.googlesource.com/687874Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
      Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
      Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505025}
      e9d46063
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · bb75a7d4
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=wjmaclean@chromium.org
      
      Bug: 666525
      Change-Id: I703d25575a1fbd487c5703633e652afea83cee4d
      Reviewed-on: https://chromium-review.googlesource.com/688897Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505024}
      bb75a7d4
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · fb359a64
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=cmumford@chromium.org
      
      Bug: 666525
      Change-Id: I74f82c441f22fa1809d8d8262fe5c71881843729
      Reviewed-on: https://chromium-review.googlesource.com/689137Reviewed-by: default avatarChris Mumford <cmumford@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505023}
      fb359a64
    • Jared Saul's avatar
      Minor autofill_manager_unittest.cc cleanup · 00332357
      Jared Saul authored
      Bug: 
      Change-Id: I72f6e575a30a9d3a9fef4d52cb0ca988270e5f70
      Reviewed-on: https://chromium-review.googlesource.com/688820Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
      Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505022}
      00332357
    • Miriam Gershenson's avatar
      Set up AsyncDns for experiments · 23cfe346
      Miriam Gershenson authored
      To prepare for running a new experiment on Android, the AsyncDns field
      trial needs a command line flag and a chrome://flags entry. Migrating it
      to the new FeatureList API was the easiest way to do that. Also
      deprecate the old pref source histograms.
      
      Bug: 768874
      Change-Id: I7858ffdc1b18a01701c75c3fca7d0269f8ed4455
      Reviewed-on: https://chromium-review.googlesource.com/685036
      Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
      Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
      Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505021}
      23cfe346
    • Xida Chen's avatar
      Revert "Disable TileGridLayoutTest#testModernTileGridAppearance_Two" · df10c399
      Xida Chen authored
      This reverts commit b6a0794d.
      
      Reason for revert: <INSERT REASONING HERE>
      Causing build error:
      https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/103347
      
      Original change's description:
      > Disable TileGridLayoutTest#testModernTileGridAppearance_Two
      > 
      > TBR=dgn@chromium.org
      > NOTRY=true
      > 
      > Bug: 769738
      > Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea
      > Reviewed-on: https://chromium-review.googlesource.com/690238
      > Reviewed-by: Xida Chen <xidachen@chromium.org>
      > Commit-Queue: Xida Chen <xidachen@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#505016}
      
      TBR=dgn@chromium.org,xidachen@chromium.org
      
      Change-Id: I546039abb34116b5897a9ffaf1f9134229d5659b
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 769738
      Reviewed-on: https://chromium-review.googlesource.com/690674Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
      Commit-Queue: Xida Chen <xidachen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505020}
      df10c399
    • Elodie Banel's avatar
      Keep omnibox visible on startup depending on startup params. · aa5ab43f
      Elodie Banel authored
      The omnibox is hidden when launching the app, but shown again if the
      startup params are set to focus omnibox. This causes a visual flicker.
      Passing around this argument makes it possible to not hide the omnibox
      in the first place if it will be focused.
      
      Bug: 754119
      Change-Id: I4a4e4f759c2be2bbdaa028ec7c34e49745848189
      Reviewed-on: https://chromium-review.googlesource.com/687774
      Commit-Queue: Elodie Banel <lod@chromium.org>
      Reviewed-by: default avatarRohit Rao (ping after 24h) <rohitrao@chromium.org>
      Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505019}
      aa5ab43f
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · dbcc8f95
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=lazyboy@chromium.org
      
      Bug: 666525
      Change-Id: Idbab88621758712b7d3d6cdf3decdb023e5e65f2
      Reviewed-on: https://chromium-review.googlesource.com/688899Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505018}
      dbcc8f95
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · a814f335
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=avi@chromium.org
      
      Bug: 666525
      Change-Id: I041a49290baec644180bd3f40c658dd0458d4cbe
      Reviewed-on: https://chromium-review.googlesource.com/689118
      Commit-Queue: Avi Drissman <avi@chromium.org>
      Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505017}
      a814f335
    • Xida Chen's avatar
      Disable TileGridLayoutTest#testModernTileGridAppearance_Two · b6a0794d
      Xida Chen authored
      TBR=dgn@chromium.org
      NOTRY=true
      
      Bug: 769738
      Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea
      Reviewed-on: https://chromium-review.googlesource.com/690238Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
      Commit-Queue: Xida Chen <xidachen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505016}
      b6a0794d
    • tzik's avatar
      Replace RefPtr<>::Get() with get() in modules/ · 2107e9db
      tzik authored
      RefPtr<>::Get() is being renamed to get() for a preparation of the
      unification of RefPtr and scoped_refptr.
      This CL updates calles of Get() in modules/ to use get().
      
      Bug: 763844
      Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I62a7652bbfca4cb9bdfe30b58a261c420047836e
      Reviewed-on: https://chromium-review.googlesource.com/690354Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505015}
      2107e9db
    • Xida Chen's avatar
      paint/invalidation/video-paint-invalidation.html crash on MSAN · 254e2084
      Xida Chen authored
      TBR=schenney@chromium.org
      NOTRY=true
      
      Bug: 769729
      Change-Id: I51b2f08827a09602ced344f9d3413a198d333b4a
      Reviewed-on: https://chromium-review.googlesource.com/690534Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
      Commit-Queue: Xida Chen <xidachen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505014}
      254e2084
    • Lukasz Anforowicz's avatar
      Removing callers of the WebContents::GetRenderProcessHost() method. · dddf6ec1
      Lukasz Anforowicz authored
      WebContents::GetRenderProcessHost is an API that doesn't behave as
      expected with out-of-process iframes, as multiple processes can be
      associated with a single WebContents.  This CL replaces callers of this
      API, so that they go through an equivalent API that explicitly selects
      which frame's process is needed.
      
      This CL was started by using an ad-hoc clang-plugin that replaced
      existing callsites of WebContents::GetRenderProcessHost() with a call to
      something like wc->GetMainFrame()->GetProcess().  This was followed-up
      by manually adding an include of render_frame_host.h and git cl format
      and git cl lint and then a self-review with small tweaks (e.g. sometimes
      using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
      
      This CL was uploaded by git cl split.
      
      R=lazyboy@chromium.org
      
      Bug: 666525
      Change-Id: Iea1d1570be5b3f35e6811c2faa1d0f0411f8a379
      Reviewed-on: https://chromium-review.googlesource.com/688895Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
      Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505013}
      dddf6ec1
    • Henrik Grunell's avatar
      Roll WebRTC 19922:20011 (89 commits) · 957ddbe6
      Henrik Grunell authored
      Changes: https://webrtc.googlesource.com/src.git/+log/433b11e..7e9c614
      
      $ git log 433b11e..7e9c614 --date=short --no-merges --format=%ad %ae %s
      2017-09-28 ivoc@webrtc.org Added configurable offsets to the per-packet overhead in the ANA frame length and bitrate controllers.
      2017-09-27 danilchap@webrtc.org Remove unused mocks of process thread
      2017-09-27 buildbot@webrtc.org Roll chromium_revision ff8cef57..888713f6 (504574:504840)
      2017-09-27 solenberg@webrtc.org Revert of Remove various IDs (patchset #7 id:120001 of https://codereview.webrtc.org/3019543002/ )
      2017-09-27 deadbeef@webrtc.org Try creating sockets again if network change occurs after bind failed.
      2017-09-27 solenberg@webrtc.org Prepare to remove ADM APIs that are to be deprecated.
      2017-09-27 solenberg@webrtc.org Remove various IDs:
      2017-09-26 steveanton@webrtc.org Add base fixture and PeerConnection wrapper for unit tests
      2017-09-26 philipel@webrtc.org Move PacketQueue out of paced_sender.cc to its own packet_queue.{cc,h}.
      2017-09-23 magjed@webrtc.org Remove unnecessary video factory references in PeerConnectionFactory
      2017-09-27 kjellander@webrtc.org Update build_aar.py after webrtc/ dir was removed.
      2017-09-27 ehmaldonado@webrtc.org Rename test output to test artifacts.
      2017-09-27 brandtr@webrtc.org Add support for SW fallback decoder in VideoProcessor.
      2017-09-27 nisse@webrtc.org Add lock annotations and const declarations to RtpReceiverImpl.
      2017-09-27 magjed@webrtc.org Revert "Android: Generate JNI code for VideoSink and VideoEncoder"
      2017-09-27 ehmaldonado@webrtc.org MB: Make it possible to specify timeout.
      2017-09-27 aleloi@webrtc.org Disabling CallPerfTest.{CaptureNtpTimeWithNetworkDelay,CaptureNtpTimeWithNetworkJitter}.
      2017-09-26 magjed@webrtc.org Android: Generate JNI code for VideoSink and VideoEncoder
      2017-09-27 sakal@webrtc.org Update documentation for getData methods in VideoFrame.I420Buffer.
      2017-09-27 alessiob@webrtc.org audioproc_f with simulated mic analog gain
      2017-09-27 aleloi@webrtc.org Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss on Mac.
      2017-09-26 alessiob@webrtc.org Export script bug fixed.
      2017-09-26 magjed@webrtc.org Android: Suppress lint warnings in JNI generator header
      2017-09-27 aleloi@webrtc.org Disable flaky test OrtcFactoryIntegrationTest.BasicTwoWayAudioVideoRtpSendersAndReceivers.
      2017-09-25 kthelgason@webrtc.org Reland "Remove precompiled header for AppRTCMobile."
      2017-09-26 peah@webrtc.org Reland of Added logging inside AEC3 for render API buffer
      2017-09-26 nisse@webrtc.org Delete redundant logic for setting is_first_packet_in_frame
      2017-09-26 ehmaldonado@webrtc.org Fix isac_fix_test on swarming perf bot.
      2017-09-26 buildbot@webrtc.org Roll chromium_revision 69fe0e1a..ff8cef57 (504538:504574)
      2017-09-26 buildbot@webrtc.org Roll chromium_revision a5e331cc..69fe0e1a (504494:504538)
      2017-09-26 solenberg@webrtc.org Remove unnecessary send codec initialization from voe::Channel.
      2017-09-26 buildbot@webrtc.org Roll chromium_revision 524a99e5..a5e331cc (504439:504494)
      2017-09-26 buildbot@webrtc.org Roll chromium_revision 2f37bb9a..524a99e5 (504378:504439)
      2017-09-26 lliuu@webrtc.org Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss on Linux due to flakiness.
      2017-09-22 zhihuang@webrtc.org Reland: Completed the functionalities of SrtpTransport.
      2017-09-26 solenberg@webrtc.org Remove the VoiceEngineObserver callback interface.
      2017-09-26 buildbot@webrtc.org Roll chromium_revision 99e3e3dd..2f37bb9a (504346:504378)
      2017-09-26 magjed@webrtc.org Android: Add header for generated JNI code
      2017-09-25 saza@webrtc.org Add PostProcessing interface to audio processing module.
      2017-09-25 charujain@google.com Presubmit: Add check to support b/xxx entry in bug reference.
      2017-09-26 buildbot@webrtc.org Roll chromium_revision 83821ae6..99e3e3dd (504327:504346)
      2017-09-26 alessiob@webrtc.org Total Harmonic Distorsion plus noise (THD+n) score in APM-QA.
      2017-09-26 philipel@webrtc.org Push back on the video encoder to avoid building queues in the pacer.
      2017-09-26 asapersson@webrtc.org Modify some rate control and quality thresholds due to flakiness.
      2017-09-26 buildbot@webrtc.org Roll chromium_revision f1b84062..83821ae6 (504296:504327)
      2017-09-26 philipel@webrtc.org Continuously request keyframes if decoding does not recover.
      2017-09-26 nisse@webrtc.org Delete member VideoReceiveStream::Config::Rtp::ulpfec.
      2017-09-26 sakal@webrtc.org Revert "Improve unit testing for HardwareVideoEncoder and fix bugs."
      2017-09-25 sakal@webrtc.org Improve unit testing for HardwareVideoEncoder and fix bugs.
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 81f3a6b9..f1b84062 (504277:504296)
      2017-09-25 buildbot@webrtc.org Roll chromium_revision b4889436..81f3a6b9 (504239:504277)
      2017-09-25 zijiehe@google.com Add more logs in DX capturer
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 548147b1..b4889436 (504172:504239)
      2017-09-25 buildbot@webrtc.org Roll chromium_revision d6e517c1..548147b1 (504112:504172)
      2017-09-25 henrik.lundin@webrtc.org NetEq: Simplify the dependencies of GetNetworkStatistics
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 5cea913a..d6e517c1 (504068:504112)
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 29ce025c..5cea913a (504034:504068)
      2017-09-25 aleloi@webrtc.org Disable flaky test VideoProcessorIntegrationTestMediaCodec.ForemanCif500kbpsVp8.
      2017-09-25 sakal@webrtc.org Return EGL_NO_CONTEXT instead of throwing an exception.
      2017-09-25 charujain@webrtc.org Revert "Remove precompiled header for AppRTCMobile."
      2017-09-25 magjed@webrtc.org Android: Add CalledByNative annotation interface
      2017-09-25 oprypin@webrtc.org Remove remaining mentions of gflags
      2017-09-25 henrika@webrtc.org Fixes issue in ADM on Mac OSX when audio is renegotiated
      2017-09-25 kthelgason@webrtc.org Remove precompiled header for AppRTCMobile.
      2017-09-25 danilchap@webrtc.org Resolve cyclic dependency in remote bitrate estimator
      2017-09-25 henrika@webrtc.org Adding time profiling support to AudioFrame
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 533744aa..29ce025c (504014:504034)
      2017-09-25 philipel@webrtc.org Reland of Fix the video buffer size should take rtt into consideration (patchset #2 id:160001 of https://codereview.chromium.org/3002033002/ )
      2017-09-25 nisse@webrtc.org Reorganize config of RTP header extensions for video receive streams.
      2017-09-25 kthelgason@webrtc.org Remove internal methods from global namespace.
      2017-09-25 henrik.lundin@webrtc.org NetEq/Stats: Don't let concealed_samples decrease
      2017-09-25 buildbot@webrtc.org Roll chromium_revision 300d540f..533744aa (503992:504014)
      2017-09-25 oprypin@webrtc.org Revert "Remove remaining mentions of gflags"
      2017-09-25 oprypin@webrtc.org Remove remaining mentions of gflags
      2017-09-24 buildbot@webrtc.org Roll chromium_revision 7877db28..300d540f (503976:503992)
      2017-09-24 buildbot@webrtc.org Roll chromium_revision c91bb424..7877db28 (503967:503976)
      2017-09-24 buildbot@webrtc.org Roll chromium_revision 569732c0..c91bb424 (503964:503967)
      2017-09-24 buildbot@webrtc.org Roll chromium_revision fe71bbc1..569732c0 (503807:503964)
      2017-09-24 oprypin@webrtc.org Roll chromium_revision 008fb813..fe71bbc1 (503673:503807) + Android fix
      2017-09-22 peah@webrtc.org Revert "Added logging inside AEC3 for render API buffer under/overruns"
      2017-09-23 magjed@webrtc.org Remove unnecessary audio references in PeerConnectionFactory
      2017-09-22 ehmaldonado@webrtc.org Fix autoroller script.
      2017-09-22 solenberg@webrtc.org Remove voe::OutputMixer and AudioConferenceMixer.
      2017-09-22 solenberg@webrtc.org Disable flaky AudioStats.NoLoss test.
      2017-09-22 henrika@webrtc.org Avoids crash in AudioTrack when audio starts in background mode
      2017-09-22 brandtr@webrtc.org Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ )
      2017-09-22 asapersson@webrtc.org VideoProcessorIntegrationTest: Group member variables into two structs containing target/actual rates.
      2017-09-22 nisse@webrtc.org Delete unused Atomic32 overloads of binary +/- operators.
      2017-09-22 brandtr@webrtc.org Add full stack tests for MediaCodec encoder.
      
      TBR=grunell@chromium.org
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
      
      Bug: 
      Change-Id: Ic58c012d1fb17bc7e2f941fbabc21861c06d0026
      Reviewed-on: https://chromium-review.googlesource.com/689375Reviewed-by: default avatarHenrik Grunell <grunell@chromium.org>
      Commit-Queue: Henrik Grunell <grunell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505012}
      957ddbe6
    • Anton Urusov's avatar
      Improved default session choice · d5c26599
      Anton Urusov authored
      Bug: 
      Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
      Change-Id: If6e6df5bc0bc5c086ed2d41ec2ff31bd88cf82ac
      Reviewed-on: https://chromium-review.googlesource.com/672724
      Commit-Queue: Anton Urusov <urusant@google.com>
      Reviewed-by: default avatarDave Schuyler <dschuyler@chromium.org>
      Reviewed-by: default avatarOwen Min <zmin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505011}
      d5c26599
    • Stephen Chenney's avatar
      Fix list-based hit testing of before/after elements · 3d55d4c0
      Stephen Chenney authored
      The list-based hit test result uses NodeForHitTest,
      but the node used for the point-based report in LayoutObject
      does not define this method, and uses custom logic for
      walking up from generated content to the parent before or
      after psuedo element.
      
      This patch moves NodeForHitTest from LayoutBox to LayoutObject
      and removes unnecessary overrides. LayoutObject::UpdateHitTestResult
      now uses NodeForHitTest and that includes the before/after content
      handling.
      
      R=pdr@chromium.org
      BUG=751405
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      Change-Id: Id64ae264fde3cb3525628d2dae4e4a1d1481c649
      Reviewed-on: https://chromium-review.googlesource.com/668697Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Commit-Queue: Stephen Chenney <schenney@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#505010}
      3d55d4c0