- 09 Aug, 2020 5 commits
-
-
Chris Harrelson authored
Instead of calling into BoundingBoxForCompositingInternal when filters are present, just account for them directly. The code was previously also wrong because it would recurse into children and stop the recursion at composited children, which means it depended on the previous compositing state. The code was added in 2013 (*) (*) https://source.chromium.org/chromium/chromium/src/+/ae7c13ecb7f34a7e31cab0ce9167d9c9744fabfa Change-Id: Id90d62adb7c0626135976110334805f76650f292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343507 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796249}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6e572f35b8bfe3eead5eff3b95b5bcc52c239202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796248}
-
Xianzhu Wang authored
This reverts commit dab549a6. Reason for revert: Fixed crbug.com/1114414 by adding a missing null check. Original change's description: > Revert "Unify graphics layer traversal functions" > > This reverts commit 84afbfbd. > > Reason for revert: crbug.com/1114414 > > Original change's description: > > Unify graphics layer traversal functions > > > > This makes them consistent to use the same skipping conditions as > > what we do during PrePaint, to avoid access of null or stale layer > > states. > > > > Bug: 1110232 > > Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796152} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ia49d32ab65cb69a98dcb2a1c2374cea0f0cb0c6a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110232, 1114414 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344645 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796235} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1110232 Bug: 1114414 Change-Id: If9ef06657208a69c948a6558adfbf79913a651c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344646 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596884690-8c8737b7a1025f9118074613364b21f1ff90ef1f.profdata to chrome-mac-master-1596906920-d9c268cee334ba8e96e8c161b05d8af21fcc527d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I12f93739a48d8c19740719210097b1a296ee7dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344650Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b2ed7f21ff9..defa9bc55594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: Change-Id: I858c9546d2f2b1219293556ceaeaffb9a2edf2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796245}
-
- 08 Aug, 2020 35 commits
-
-
Stephen Chenney authored
The paths for wavy, dashed and dotted paths are quite expensive to compute and are used in both bounds and painting. Cache them, recomputing when needed and resetting when any line data changes. No change in net behavior. Bug: 896295 Change-Id: If0e58f49e6ecc9246b95d4b883eec1ac7d006ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342641 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796244}
-
Kang Minchul authored
Remove use of base/macro.h and use explicit deletion instead Bug: 1010217 Change-Id: I74180731b700bdff4f2735111d8dede3ae4733b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342332 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796243}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596834937-d362a0fc8a27d2c9c7a6f73e739d7f96eafd2751.profdata to chrome-mac-master-1596884690-8c8737b7a1025f9118074613364b21f1ff90ef1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iba3a18ccb7b1b35050fa54d3bf601d41d9ce0efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344384Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I72ac91dd22cd7da2df6a2f4cb3de045e1e723e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344246Reviewed-by:
-
Matthias Körber authored
In the current implementation the structured address information retrieved from Sync is not available for voting because the profile passes through the SQL data base that does not handle the tokens. This CL fixes this bug by reading and writing the structured tokens to SQL. It implements eventual deletion consistency for legacy clients. The CL also renames the ADDRESS_HOME_FLOOR type to ADDRESS_HOME_SUBPREMISE because the type can also contain the apartment number and the staircase. Change-Id: I4e50341caafe7d5b0ca87ce6b394e582daa600e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344464 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#796240}
-
Hyunjune authored
This patch fixes up a crash relied on 'keySplines' of <animate*>. All values of 'keySplines' must all be in the range 0 to 1.[1] So this patch checks this ranges of the values. [1] https://svgwg.org/specs/animations/#KeySplinesAttribute Bug: 1114169 Change-Id: I1878842a5b07702743e5d59ada4a8c11a1cfed36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344426 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796239}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9044c9405838..2b2ed7f21ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia1294afc9be5828980261a34e41738525f0412f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344224Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f1b0dfbf1d4..19423f490a2c 2020-08-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66397c3f09c172b0c5046fe8a9d469771353b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344344Reviewed-by:
-
Mugdha Lakhani authored
A simple browser test has been added to verify creation logic. Bug: 1096088 Change-Id: I02ce454b16560d9bb5ee682d33a0c67cbbd3ee8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341127 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#796236}
-
Xianzhu Wang authored
This reverts commit 84afbfbd. Reason for revert: crbug.com/1114414 Original change's description: > Unify graphics layer traversal functions > > This makes them consistent to use the same skipping conditions as > what we do during PrePaint, to avoid access of null or stale layer > states. > > Bug: 1110232 > Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796152} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ia49d32ab65cb69a98dcb2a1c2374cea0f0cb0c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110232, 1114414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344645Reviewed-by:
-
Varun Khaneja authored
Adding logs to the constructor and destructor of the object to understand when/from where the object is being created/destroyed. Bug: 1104919 Change-Id: Id42320a1cafe45c700c159ec0a5969705e83e5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343550 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796234}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/237cbc3dc692..9044c9405838 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie3e274a892a9a90d6c22540f4e5cdfa05ae34e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344145Reviewed-by:
-
Victor Vasiliev authored
Bug: 1114027 Change-Id: I3a4137d443becc7f822073163ee2d15bf836934e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340318Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#796232}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9e10b457d87e34750ff37af376c60cccbc41b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344144Reviewed-by:
-
Sergey Poromov authored
"tabs.captureVisibleTab" extensions API should respect the current Data Leak Prevention content restrictions on Chrome OS. Bug: 1109723 Change-Id: I7d4fc2f3bcac466db3fbc0fc0f7fb35be25e8188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323357 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796230}
-
Sergey Poromov authored
Full- and partial-screenshots are restricted if any restricted for screenshots data is visible. Window-screenshots are restricted if the window contains any restricted for screenshots WebContents. Bug: 1109723 Test: Manual, new unit/browser tests being added. Change-Id: I62bd96f39706b13ef4468d78b0ce9258699c985f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317961Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83917be34ca2..237cbc3dc692 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icc0bc522cbb86c2be739edb5f26fe99625e25ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343680Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc6824d4ef44..4f1b0dfbf1d4 2020-08-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7abb8fb5d4656fbb522b5a974b8759451e754ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343511Reviewed-by:
-
Maria Kazinova authored
JS return types. Previously only strings could be returned which led to double conversions. Bug: 1075444 Change-Id: Ibf9cee2e03143654c21c8c48d9219b20e52a7cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340969 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#796226}
-
Mugdha Lakhani authored
This adds PrerenderContentsDelegateImpl, PrerenderManagerDelegateImpl and PrerenderManagerFactory. A simple browsertest has been added to verify functionality. Bug: 1096088 Change-Id: I8682eecc2deb10ac5da77d0892a7abf544aa839d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339463Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9892e6a22610..48ba75ac6845 2020-08-08 timvp@google.com Remove TextureCommand 2020-08-08 timvp@google.com Pass the Command when sync'ing dirty objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: CQ Change-Id: I74f87f8b38f080ccc2467eff6692878ca87e77bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343781Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df77912f3fda..83917be34ca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112941 Tbr: Change-Id: Iff6a9fa15ddc7a7e3a481ba5d1752a9840a9046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343780Reviewed-by:
-
Chris Harrelson authored
This is now possible because PrePaint is before CompositingAssignments. Change-Id: Id6ba9873834ceb2d96f55f15dc50f4a34b430a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343772Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I8293c3c96da974bb889c348f05d1e14c7a00bba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343854Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796221}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/06994a23acac..cc6824d4ef44 2020-08-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iff5483960d02127dfa135aa42e8c8c88ed89c16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343510Reviewed-by:
-
Gayane Petrosyan authored
Bug: 1112717 Change-Id: I5a3a74157a41ffb8dcb4b158240cab06c839a5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342581 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#796219}
-
Daniel Hosseinian authored
Note: "Learn more" links are TBD and will be added later. TBR=dpapad@chromium.org Bug: 1112581 Change-Id: Ic63aae5e2251f7882a4584c7fc3f0cd97af42a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343232 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796218}
-
Peter Kasting authored
BrowserContextDependencyManager:: RegisterWillCreateBrowserContextServicesCallbackForTesting() ...is long, redundant, and hard to read. More importantly, directly using the callback signature makes maintenance harder and makes it unclear where it actually comes from. (Also fixes a couple presubmit warnings that appeared during upload) Bug: none Change-Id: I57ec76aa425fa2d44a8a3f778d360af608df84cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340504 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#796217}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df7c08830093..df77912f3fda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1105799,chromium:1112002 Tbr: Change-Id: I2212852fa20676624ff5ba88c15006e79dc2d15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343990Reviewed-by:
-
Xiaocheng Hu authored
SimRequest is for navigation, while other resource requests should use SimSubresourceRequest. This patch revises a few font-related SimTests to follow the design. Change-Id: I5939d5499539f253012b4cae55ac9edc78b94608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343848Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#796215}
-
Alex Gough authored
No functional changes. Also updates build.gn and deps to reflect move. Linux hooks serve a different purpose and occur in utility so have not been moved. Bug: 1111421 Change-Id: I081d31afb421bbe0b906085c8c14e1f9558bab28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340158 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#796214}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1dcb3eb267e9..9892e6a22610 2020-08-07 cnorthrop@google.com Capture/Replay: Reduce SetupContext size further 2020-08-07 cnorthrop@google.com Samples: Fix Capture/Replay release build 2020-08-07 cnorthrop@google.com Capture/Replay: Dedup shaders to reduce capture size 2020-08-07 cnorthrop@google.com Tests: Update NBA2K20 trace 2020-08-07 cnorthrop@google.com Tests: Update Angry Birds 2 trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Compile and link NBA2K20 trace for AndroidTest: Test: Release build of Capture/Replay sampleTest: Test: angle_perftests --gtest_filter="*Trace*"Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Iec53ed01e22746592b746fd95d1afcfb4a9e0a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344004Reviewed-by:
-
Aleks Totic authored
When table has fixed height, row collapse should cause table to shrink Passing: IE 17, FF Failing: Chrome 84, Safari 13.1 Change-Id: I9b749cae2863a14094c484589b5c98a0e73cae11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343457 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796212}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ic02b7e66f3e1c58cc4d7ab0ee9b2474145c7fa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343851Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796211}
-
Evan Stade authored
This re-uses Chrome's WebOTP infobar for WebLayer. To test, run run_weblayer_shell https://web-otp-demo.glitch.me/ \ --args="--web-otp-backend=\"web-otp-backend-sms-verification\"" And send an SMS appended with ^zlUfAL9a4nJ Bug: 1035836 Change-Id: Ib68bcfc71a05bf60a2619a0ef8f503ce4fb7796c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340112Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#796210}
-
